* [PATCH v3 26/38] pnp: add HAS_IOPORT dependencies
[not found] <20230314121216.413434-1-schnelle@linux.ibm.com>
@ 2023-03-14 12:12 ` Niklas Schnelle
2023-03-20 17:37 ` Rafael J. Wysocki
0 siblings, 1 reply; 5+ messages in thread
From: Niklas Schnelle @ 2023-03-14 12:12 UTC (permalink / raw)
To: Arnd Bergmann, Jaroslav Kysela, Rafael J. Wysocki
Cc: Greg Kroah-Hartman, Bjorn Helgaas, Uwe Kleine-König,
Mauro Carvalho Chehab, Alan Stern, Rafael J. Wysocki,
Geert Uytterhoeven, Paul Walmsley, Palmer Dabbelt, Albert Ou,
linux-kernel, linux-arch, linux-pci, Arnd Bergmann, linux-acpi
In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
not being declared. We thus need to depend on HAS_IOPORT even when
compile testing only.
Co-developed-by: Arnd Bergmann <arnd@kernel.org>
Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
---
drivers/pnp/isapnp/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pnp/isapnp/Kconfig b/drivers/pnp/isapnp/Kconfig
index d0479a563123..79bd48f1dd94 100644
--- a/drivers/pnp/isapnp/Kconfig
+++ b/drivers/pnp/isapnp/Kconfig
@@ -4,7 +4,7 @@
#
config ISAPNP
bool "ISA Plug and Play support"
- depends on ISA || COMPILE_TEST
+ depends on ISA || (HAS_IOPORT && COMPILE_TEST)
help
Say Y here if you would like support for ISA Plug and Play devices.
Some information is in <file:Documentation/driver-api/isapnp.rst>.
--
2.37.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3 26/38] pnp: add HAS_IOPORT dependencies
2023-03-14 12:12 ` [PATCH v3 26/38] pnp: add HAS_IOPORT dependencies Niklas Schnelle
@ 2023-03-20 17:37 ` Rafael J. Wysocki
2023-03-21 13:56 ` Rafael J. Wysocki
0 siblings, 1 reply; 5+ messages in thread
From: Rafael J. Wysocki @ 2023-03-20 17:37 UTC (permalink / raw)
To: Niklas Schnelle
Cc: Arnd Bergmann, Jaroslav Kysela, Rafael J. Wysocki,
Greg Kroah-Hartman, Bjorn Helgaas, Uwe Kleine-König,
Mauro Carvalho Chehab, Alan Stern, Rafael J. Wysocki,
Geert Uytterhoeven, Paul Walmsley, Palmer Dabbelt, Albert Ou,
linux-kernel, linux-arch, linux-pci, Arnd Bergmann, linux-acpi
On Tue, Mar 14, 2023 at 1:13 PM Niklas Schnelle <schnelle@linux.ibm.com> wrote:
>
> In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
> not being declared. We thus need to depend on HAS_IOPORT even when
> compile testing only.
>
> Co-developed-by: Arnd Bergmann <arnd@kernel.org>
> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
> ---
> drivers/pnp/isapnp/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pnp/isapnp/Kconfig b/drivers/pnp/isapnp/Kconfig
> index d0479a563123..79bd48f1dd94 100644
> --- a/drivers/pnp/isapnp/Kconfig
> +++ b/drivers/pnp/isapnp/Kconfig
> @@ -4,7 +4,7 @@
> #
> config ISAPNP
> bool "ISA Plug and Play support"
> - depends on ISA || COMPILE_TEST
> + depends on ISA || (HAS_IOPORT && COMPILE_TEST)
> help
> Say Y here if you would like support for ISA Plug and Play devices.
> Some information is in <file:Documentation/driver-api/isapnp.rst>.
> --
Applied as 6.4 material, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 26/38] pnp: add HAS_IOPORT dependencies
2023-03-20 17:37 ` Rafael J. Wysocki
@ 2023-03-21 13:56 ` Rafael J. Wysocki
2023-03-23 12:55 ` Niklas Schnelle
0 siblings, 1 reply; 5+ messages in thread
From: Rafael J. Wysocki @ 2023-03-21 13:56 UTC (permalink / raw)
To: Niklas Schnelle
Cc: Arnd Bergmann, Jaroslav Kysela, Rafael J. Wysocki,
Greg Kroah-Hartman, Bjorn Helgaas, Uwe Kleine-König,
Mauro Carvalho Chehab, Alan Stern, Rafael J. Wysocki,
Geert Uytterhoeven, Paul Walmsley, Palmer Dabbelt, Albert Ou,
linux-kernel, linux-arch, linux-pci, Arnd Bergmann, linux-acpi
On Mon, Mar 20, 2023 at 6:37 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Tue, Mar 14, 2023 at 1:13 PM Niklas Schnelle <schnelle@linux.ibm.com> wrote:
> >
> > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
> > not being declared. We thus need to depend on HAS_IOPORT even when
> > compile testing only.
> >
> > Co-developed-by: Arnd Bergmann <arnd@kernel.org>
> > Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
> > ---
> > drivers/pnp/isapnp/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pnp/isapnp/Kconfig b/drivers/pnp/isapnp/Kconfig
> > index d0479a563123..79bd48f1dd94 100644
> > --- a/drivers/pnp/isapnp/Kconfig
> > +++ b/drivers/pnp/isapnp/Kconfig
> > @@ -4,7 +4,7 @@
> > #
> > config ISAPNP
> > bool "ISA Plug and Play support"
> > - depends on ISA || COMPILE_TEST
> > + depends on ISA || (HAS_IOPORT && COMPILE_TEST)
This breaks code selecting ISAPNP and not depending on it. See
https://lore.kernel.org/linux-acpi/202303211932.5gtCVHCz-lkp@intel.com/T/#u
for example.
I'm dropping the patch now, please fix and resend.
> > help
> > Say Y here if you would like support for ISA Plug and Play devices.
> > Some information is in <file:Documentation/driver-api/isapnp.rst>.
> > --
>
> Applied as 6.4 material, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 26/38] pnp: add HAS_IOPORT dependencies
2023-03-21 13:56 ` Rafael J. Wysocki
@ 2023-03-23 12:55 ` Niklas Schnelle
2023-03-24 18:45 ` Wysocki, Rafael J
0 siblings, 1 reply; 5+ messages in thread
From: Niklas Schnelle @ 2023-03-23 12:55 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Arnd Bergmann, Jaroslav Kysela, Rafael J. Wysocki,
Greg Kroah-Hartman, Bjorn Helgaas, Uwe Kleine-König,
Mauro Carvalho Chehab, Alan Stern, Geert Uytterhoeven,
Paul Walmsley, Palmer Dabbelt, Albert Ou, linux-kernel,
linux-arch, linux-pci, Arnd Bergmann, linux-acpi
On Tue, 2023-03-21 at 14:56 +0100, Rafael J. Wysocki wrote:
> On Mon, Mar 20, 2023 at 6:37 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
> >
> > On Tue, Mar 14, 2023 at 1:13 PM Niklas Schnelle <schnelle@linux.ibm.com> wrote:
> > >
> > > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
> > > not being declared. We thus need to depend on HAS_IOPORT even when
> > > compile testing only.
> > >
> > > Co-developed-by: Arnd Bergmann <arnd@kernel.org>
> > > Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
> > > ---
> > > drivers/pnp/isapnp/Kconfig | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/pnp/isapnp/Kconfig b/drivers/pnp/isapnp/Kconfig
> > > index d0479a563123..79bd48f1dd94 100644
> > > --- a/drivers/pnp/isapnp/Kconfig
> > > +++ b/drivers/pnp/isapnp/Kconfig
> > > @@ -4,7 +4,7 @@
> > > #
> > > config ISAPNP
> > > bool "ISA Plug and Play support"
> > > - depends on ISA || COMPILE_TEST
> > > + depends on ISA || (HAS_IOPORT && COMPILE_TEST)
>
> This breaks code selecting ISAPNP and not depending on it. See
> https://lore.kernel.org/linux-acpi/202303211932.5gtCVHCz-lkp@intel.com/T/#u
> for example.
>
> I'm dropping the patch now, please fix and resend.
>
> >
Sorry if this wasn't super clear but all patches in this series depend
on patch 1 which introduces the HAS_IOPORT Kconfig option. There's
really two options, either the whole series goes via e.g. Arnd's tree
at once or we first only merge patch 1 and then add the rest per
subsystem until finally the last patch can remove inb()/outb() when
HAS_IOPORT is unset.
That said I'm a little unsure about the linked error if that is just
due to missing HAS_IOPORT or something else. I'll still have to try
with the instructions in that mail and will report back if it is
something else.
Thanks,
Niklas
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 26/38] pnp: add HAS_IOPORT dependencies
2023-03-23 12:55 ` Niklas Schnelle
@ 2023-03-24 18:45 ` Wysocki, Rafael J
0 siblings, 0 replies; 5+ messages in thread
From: Wysocki, Rafael J @ 2023-03-24 18:45 UTC (permalink / raw)
To: Niklas Schnelle, Rafael J. Wysocki
Cc: Arnd Bergmann, Jaroslav Kysela, Greg Kroah-Hartman,
Bjorn Helgaas, Uwe Kleine-König, Mauro Carvalho Chehab,
Alan Stern, Geert Uytterhoeven, Paul Walmsley, Palmer Dabbelt,
Albert Ou, linux-kernel, linux-arch, linux-pci, Arnd Bergmann,
linux-acpi
On 3/23/2023 1:55 PM, Niklas Schnelle wrote:
> On Tue, 2023-03-21 at 14:56 +0100, Rafael J. Wysocki wrote:
>> On Mon, Mar 20, 2023 at 6:37 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>>> On Tue, Mar 14, 2023 at 1:13 PM Niklas Schnelle <schnelle@linux.ibm.com> wrote:
>>>> In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
>>>> not being declared. We thus need to depend on HAS_IOPORT even when
>>>> compile testing only.
>>>>
>>>> Co-developed-by: Arnd Bergmann <arnd@kernel.org>
>>>> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
>>>> ---
>>>> drivers/pnp/isapnp/Kconfig | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/pnp/isapnp/Kconfig b/drivers/pnp/isapnp/Kconfig
>>>> index d0479a563123..79bd48f1dd94 100644
>>>> --- a/drivers/pnp/isapnp/Kconfig
>>>> +++ b/drivers/pnp/isapnp/Kconfig
>>>> @@ -4,7 +4,7 @@
>>>> #
>>>> config ISAPNP
>>>> bool "ISA Plug and Play support"
>>>> - depends on ISA || COMPILE_TEST
>>>> + depends on ISA || (HAS_IOPORT && COMPILE_TEST)
>> This breaks code selecting ISAPNP and not depending on it. See
>> https://lore.kernel.org/linux-acpi/202303211932.5gtCVHCz-lkp@intel.com/T/#u
>> for example.
>>
>> I'm dropping the patch now, please fix and resend.
>>
> Sorry if this wasn't super clear but all patches in this series depend
> on patch 1 which introduces the HAS_IOPORT Kconfig option. There's
> really two options, either the whole series goes via e.g. Arnd's tree
> at once or we first only merge patch 1 and then add the rest per
> subsystem until finally the last patch can remove inb()/outb() when
> HAS_IOPORT is unset.
Well, it looks like you need to decide on the approach then and tell
people what it is.
If I see an individual patch without context, this is quite hard to
figure out.
> That said I'm a little unsure about the linked error if that is just
> due to missing HAS_IOPORT or something else. I'll still have to try
> with the instructions in that mail and will report back if it is
> something else.
>
> Thanks,
> Niklas
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-03-24 18:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230314121216.413434-1-schnelle@linux.ibm.com>
2023-03-14 12:12 ` [PATCH v3 26/38] pnp: add HAS_IOPORT dependencies Niklas Schnelle
2023-03-20 17:37 ` Rafael J. Wysocki
2023-03-21 13:56 ` Rafael J. Wysocki
2023-03-23 12:55 ` Niklas Schnelle
2023-03-24 18:45 ` Wysocki, Rafael J
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).