From: Hanjun Guo <guohanjun@huawei.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
<linux-arm-kernel@lists.infradead.org>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>, <linux-acpi@vger.kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
<linuxarm@huawei.com>
Subject: Re: [PATCH] acpi/arm64: Drop extra (struct resource)
Date: Thu, 2 Mar 2023 09:54:15 +0800 [thread overview]
Message-ID: <35c719be-e224-e3d5-3735-75df2d44f4aa@huawei.com> (raw)
In-Reply-To: <20230301170938.9278-1-Jonathan.Cameron@huawei.com>
On 2023/3/2 1:09, Jonathan Cameron wrote:
> DEFINE_RES_IRQ() is a wrapper around the DEFINE_RES_NAMED()
> macro which already has the (struct resource) for the compound
> literal.
>
> Fixes warnings:
> CC drivers/acpi/arm64/gtdt.o
> CHECK drivers/acpi/arm64/gtdt.c
> drivers/acpi/arm64/gtdt.c:355:19: warning: cast to non-scalar
> drivers/acpi/arm64/gtdt.c:355:19: warning: cast from non-scalar
>
> Fixes: 52c4d11f1dce ("resource: Convert DEFINE_RES_NAMED() to be compound literal")
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> drivers/acpi/arm64/gtdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c
> index c0e77c1c8e09..24bd479de91f 100644
> --- a/drivers/acpi/arm64/gtdt.c
> +++ b/drivers/acpi/arm64/gtdt.c
> @@ -352,7 +352,7 @@ static int __init gtdt_import_sbsa_gwdt(struct acpi_gtdt_watchdog *wd,
> }
>
> irq = map_gt_gsi(wd->timer_interrupt, wd->timer_flags);
> - res[2] = (struct resource)DEFINE_RES_IRQ(irq);
> + res[2] = DEFINE_RES_IRQ(irq);
> if (irq <= 0) {
> pr_warn("failed to map the Watchdog interrupt.\n");
> nr_res--;
>
Looks good to me,
Reviewed-by: Hanjun Guo <guohanjun@huawei.com>
next prev parent reply other threads:[~2023-03-02 1:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 17:09 [PATCH] acpi/arm64: Drop extra (struct resource) Jonathan Cameron
2023-03-01 17:18 ` Andy Shevchenko
2023-03-02 1:54 ` Hanjun Guo [this message]
2023-03-11 2:36 ` Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35c719be-e224-e3d5-3735-75df2d44f4aa@huawei.com \
--to=guohanjun@huawei.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linuxarm@huawei.com \
--cc=lpieralisi@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).