* [PATCH] ACPI: Fix LAPIC_ADDR_OVR address print
@ 2022-02-21 4:43 Vasant Hegde
2022-03-01 19:24 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Vasant Hegde @ 2022-02-21 4:43 UTC (permalink / raw)
To: linux-acpi; +Cc: rafael, lenb, Vasant Hegde, Suravee Suthikulpanit
Without fix:
[ 0.005429] ACPI: LAPIC_ADDR_OVR (address[(____ptrval____)])
With fix:
[ 0.005429] ACPI: LAPIC_ADDR_OVR (address[0x800fee00000])
Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Signed-off-by: Vasant Hegde <vasant.hegde@amd.com>
---
drivers/acpi/tables.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
index 0741a4933f62..550e9512534c 100644
--- a/drivers/acpi/tables.c
+++ b/drivers/acpi/tables.c
@@ -151,8 +151,8 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header)
{
struct acpi_madt_local_apic_override *p =
(struct acpi_madt_local_apic_override *)header;
- pr_info("LAPIC_ADDR_OVR (address[%p])\n",
- (void *)(unsigned long)p->address);
+ pr_info("LAPIC_ADDR_OVR (address[0x%llx])\n",
+ p->address);
}
break;
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ACPI: Fix LAPIC_ADDR_OVR address print
2022-02-21 4:43 [PATCH] ACPI: Fix LAPIC_ADDR_OVR address print Vasant Hegde
@ 2022-03-01 19:24 ` Rafael J. Wysocki
2022-03-02 4:51 ` Vasant Hegde
0 siblings, 1 reply; 4+ messages in thread
From: Rafael J. Wysocki @ 2022-03-01 19:24 UTC (permalink / raw)
To: Vasant Hegde
Cc: ACPI Devel Maling List, Rafael J. Wysocki, Len Brown,
Suravee Suthikulpanit
On Mon, Feb 21, 2022 at 5:44 AM Vasant Hegde <vasant.hegde@amd.com> wrote:
>
> Without fix:
> [ 0.005429] ACPI: LAPIC_ADDR_OVR (address[(____ptrval____)])
>
> With fix:
> [ 0.005429] ACPI: LAPIC_ADDR_OVR (address[0x800fee00000])
>
> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
The meaning of this sign-off is unclear.
If this a co-developer sign-off, please use a Co-developed-by tag to
clarify that.
> Signed-off-by: Vasant Hegde <vasant.hegde@amd.com>
> ---
> drivers/acpi/tables.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
> index 0741a4933f62..550e9512534c 100644
> --- a/drivers/acpi/tables.c
> +++ b/drivers/acpi/tables.c
> @@ -151,8 +151,8 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header)
> {
> struct acpi_madt_local_apic_override *p =
> (struct acpi_madt_local_apic_override *)header;
> - pr_info("LAPIC_ADDR_OVR (address[%p])\n",
> - (void *)(unsigned long)p->address);
> + pr_info("LAPIC_ADDR_OVR (address[0x%llx])\n",
> + p->address);
> }
> break;
>
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ACPI: Fix LAPIC_ADDR_OVR address print
2022-03-01 19:24 ` Rafael J. Wysocki
@ 2022-03-02 4:51 ` Vasant Hegde
2022-03-17 6:43 ` Vasant Hegde
0 siblings, 1 reply; 4+ messages in thread
From: Vasant Hegde @ 2022-03-02 4:51 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: ACPI Devel Maling List, Len Brown, Suravee Suthikulpanit
Rafael,
On 3/2/2022 12:54 AM, Rafael J. Wysocki wrote:
> On Mon, Feb 21, 2022 at 5:44 AM Vasant Hegde <vasant.hegde@amd.com> wrote:
>>
>> Without fix:
>> [ 0.005429] ACPI: LAPIC_ADDR_OVR (address[(____ptrval____)])
>>
>> With fix:
>> [ 0.005429] ACPI: LAPIC_ADDR_OVR (address[0x800fee00000])
>>
>> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
>
> The meaning of this sign-off is unclear.
>
> If this a co-developer sign-off, please use a Co-developed-by tag to
> clarify that.
Sorry for that. I missed to add Co-Developed-by tag. Can you please add below
line before merging -OR- do you want me to resend the patch?
Co-developed-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
-Vasant
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ACPI: Fix LAPIC_ADDR_OVR address print
2022-03-02 4:51 ` Vasant Hegde
@ 2022-03-17 6:43 ` Vasant Hegde
0 siblings, 0 replies; 4+ messages in thread
From: Vasant Hegde @ 2022-03-17 6:43 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: ACPI Devel Maling List, Len Brown, Suravee Suthikulpanit
Rafael,
On 3/2/2022 10:21 AM, Vasant Hegde wrote:
> Rafael,
>
>
> On 3/2/2022 12:54 AM, Rafael J. Wysocki wrote:
>> On Mon, Feb 21, 2022 at 5:44 AM Vasant Hegde <vasant.hegde@amd.com> wrote:
>>>
>>> Without fix:
>>> [ 0.005429] ACPI: LAPIC_ADDR_OVR (address[(____ptrval____)])
>>>
>>> With fix:
>>> [ 0.005429] ACPI: LAPIC_ADDR_OVR (address[0x800fee00000])
>>>
>>> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
>>
>> The meaning of this sign-off is unclear.
>>
>> If this a co-developer sign-off, please use a Co-developed-by tag to
>> clarify that.
>
> Sorry for that. I missed to add Co-Developed-by tag. Can you please add below
> line before merging -OR- do you want me to resend the patch?
I have sent v2 with updated co-developer tag.
Thanks
-Vasant
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-17 6:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-21 4:43 [PATCH] ACPI: Fix LAPIC_ADDR_OVR address print Vasant Hegde
2022-03-01 19:24 ` Rafael J. Wysocki
2022-03-02 4:51 ` Vasant Hegde
2022-03-17 6:43 ` Vasant Hegde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).