From: "Bjørn Mork" <bjorn@mork.no>
To: <Charles.Hyde@dellteam.com>
Cc: <stern@rowland.harvard.edu>, <oliver@neukum.org>,
<rjw@rjwysocki.net>, <lenb@kernel.org>,
<Mario.Limonciello@dell.com>, <chip.programmer@gmail.com>,
<nic_swsd@realtek.com>, <linux-usb@vger.kernel.org>,
<linux-acpi@vger.kernel.org>
Subject: Re: [PATCH 1/3] net: cdc_ncm: add get/set ethernet address functions
Date: Fri, 06 Sep 2019 22:07:12 +0200 [thread overview]
Message-ID: <87mufhqjdb.fsf@miraculix.mork.no> (raw)
In-Reply-To: <a9999ed336ba4f2a8cb93c57f0b3d2f4@AUSX13MPS307.AMER.DELL.COM> (Charles Hyde's message of "Fri, 6 Sep 2019 18:19:37 +0000")
<Charles.Hyde@dellteam.com> writes:
> What better suggestion do folks have, instead of using USB_REQ_SET_ADDRESS?
The spec is clear: wIndex is supposed to be 'NCM Communications
Interface'. That's how you address a specific NCM function (a USB
device can have more than one...), and that's what you'll see in all the
other interface specific class requests in this driver. You don't have
to look hard to find examples.
Bjørn
next prev parent reply other threads:[~2019-09-06 20:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 21:01 [PATCH 1/3] net: cdc_ncm: add get/set ethernet address functions Charles.Hyde
2019-09-06 9:02 ` Bjørn Mork
2019-09-06 18:00 ` Charles.Hyde
2019-09-06 18:15 ` Alan Stern
2019-09-06 18:19 ` Charles.Hyde
2019-09-06 20:07 ` Bjørn Mork [this message]
2019-09-06 20:20 ` Charles.Hyde
2019-09-06 20:39 ` Bjørn Mork
2019-09-06 21:00 ` Charles.Hyde
-- strict thread matches above, loose matches on Subject: below --
2019-08-30 19:37 Charles.Hyde
2019-09-02 9:43 ` Oliver Neukum
2019-09-03 16:45 ` Charles.Hyde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mufhqjdb.fsf@miraculix.mork.no \
--to=bjorn@mork.no \
--cc=Charles.Hyde@dellteam.com \
--cc=Mario.Limonciello@dell.com \
--cc=chip.programmer@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=oliver@neukum.org \
--cc=rjw@rjwysocki.net \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).