Linux-ACPI Archive on lore.kernel.org
 help / color / Atom feed
From: "Moore, Robert" <robert.moore@intel.com>
To: Nikolaus Voss <nv@vosn.de>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <lenb@kernel.org>,
	"Schmauss, Erik" <erik.schmauss@intel.com>,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	"open list:ACPI COMPONENT ARCHITECTURE (ACPICA)"
	<devel@acpica.org>,
	"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
	Linux PWM List <linux-pwm@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 1/3] ACPI: Resolve objects on host-directed table loads
Date: Tue, 18 Jun 2019 20:24:37 +0000
Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E3B95FB097@ORSMSX110.amr.corp.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1906181030240.24846@fox.voss.local>

If it is in fact the AcpiLoadTable interface that is incorrect, that of course is different. I'll check that out next.


> -----Original Message-----
> From: Moore, Robert
> Sent: Tuesday, June 18, 2019 1:23 PM
> To: 'Nikolaus Voss' <nv@vosn.de>
> Cc: 'Rafael J. Wysocki' <rafael@kernel.org>; 'Rafael J. Wysocki'
> <rjw@rjwysocki.net>; 'Len Brown' <lenb@kernel.org>; Schmauss, Erik
> <erik.schmauss@intel.com>; 'Jacek Anaszewski'
> <jacek.anaszewski@gmail.com>; 'Pavel Machek' <pavel@ucw.cz>; 'Dan
> Murphy' <dmurphy@ti.com>; 'Thierry Reding' <thierry.reding@gmail.com>;
> 'ACPI Devel Maling List' <linux-acpi@vger.kernel.org>; 'open list:ACPI
> COMPONENT ARCHITECTURE (ACPICA)' <devel@acpica.org>; 'linux-
> leds@vger.kernel.org' <linux-leds@vger.kernel.org>; 'Linux PWM List'
> <linux-pwm@vger.kernel.org>; 'Linux Kernel Mailing List' <linux-
> kernel@vger.kernel.org>
> Subject: RE: [PATCH v2 1/3] ACPI: Resolve objects on host-directed table
> loads
> 
> It looks to me that the package objects are being initialized properly
> already, unless I'm missing something. Please check the examples below
> and in the attached files.
> 
> Attached is a small test case that dynamically loads an SSDT which
> contains a package object which in turn contains references to other
> objects.
> 
> 
> Main DSDT:
>     Method (LD1)
>     {
>         Load (BUF1, HNDL)      // SSDT is in BUF1
>         Store (HNDL, Debug)
>         Return
>     }
> 
> Loaded table:
>     External (DEV1, DeviceObj)
>     Name (PKG1, Package() {
>         1,2, DEV2, DEV1, 4})
>     Device (DEV2) {}
> 
> 
> AcpiExec Output:
> - ev ld1
> Evaluating \LD1
> ACPI: Dynamic OEM Table Load:
> ACPI: SSDT 0x00000000006DEEB8 000051 (v02 Intel  Load     00000001 INTL
> 20190509)
> ACPI Exec: Table Event INSTALL, [SSDT] 006DEEB8
> Table [SSDT: Load    ] (id 06) -    5 Objects with   1 Devices,   0
> Regions,    1 Methods
> ACPI Exec: Table Event LOAD, [SSDT] 006DEEB8 ACPI Debug:  Reference
> [DdbHandle] Table Index 0x3
> 0x7 Outstanding allocations after evaluation of \LD1 Evaluation of \LD1
> returned object 006D2FE8, external buffer length 18
>   [Integer] = 0000000000000000
> 
> - ev pkg1
> Evaluating \PKG1
> Evaluation of \PKG1 returned object 006D2FE8, external buffer length 90
>   [Package] Contains 5 Elements:
>     [Integer] = 0000000000000001
>     [Integer] = 0000000000000002
>     [Object Reference] = 006DDF88 <Node>            Name DEV2 Device
>     [Object Reference] = 006DD608 <Node>            Name DEV1 Device
>     [Integer] = 0000000000000004


  parent reply index

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-12  8:36 [PATCH v2 0/3] PWM framework: add support referencing PWMs from ACPI Nikolaus Voss
2019-06-12  8:36 ` [PATCH v2 1/3] ACPI: Resolve objects on host-directed table loads Nikolaus Voss
2019-06-14  9:12   ` Rafael J. Wysocki
2019-06-14  9:25     ` Nikolaus Voss
2019-06-14 15:35       ` Moore, Robert
2019-06-17  6:24         ` Nikolaus Voss
2019-06-17 21:18           ` Moore, Robert
2019-06-18  9:21             ` Nikolaus Voss
2019-06-18 19:35               ` Moore, Robert
2019-06-18 20:22               ` Moore, Robert
2019-06-18 20:24               ` Moore, Robert [this message]
2019-06-18 20:31               ` Moore, Robert
2019-06-19  9:31                 ` Nikolaus Voss
2019-06-19 15:59                   ` Moore, Robert
2019-06-20  6:49                     ` Nikolaus Voss
2019-06-22  9:04                       ` Rafael J. Wysocki
2019-06-12  8:36 ` [PATCH v2 2/3] PWM framework: add support referencing PWMs from ACPI Nikolaus Voss
2019-06-12  8:36 ` [PATCH v2 3/3] leds-pwm.c: support ACPI via firmware-node framework Nikolaus Voss
2019-06-21 11:01   ` Pavel Machek

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=94F2FBAB4432B54E8AACC7DFDE6C92E3B95FB097@ORSMSX110.amr.corp.intel.com \
    --to=robert.moore@intel.com \
    --cc=devel@acpica.org \
    --cc=dmurphy@ti.com \
    --cc=erik.schmauss@intel.com \
    --cc=jacek.anaszewski@gmail.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=nv@vosn.de \
    --cc=pavel@ucw.cz \
    --cc=rafael@kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ACPI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-acpi/0 linux-acpi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-acpi linux-acpi/ https://lore.kernel.org/linux-acpi \
		linux-acpi@vger.kernel.org linux-acpi@archiver.kernel.org
	public-inbox-index linux-acpi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-acpi


AGPL code for this site: git clone https://public-inbox.org/ public-inbox