From: "Calvin Johnson (OSS)" <calvin.johnson@oss.nxp.com>
To: Jeremy Linton <jeremy.linton@arm.com>,
"linux.cj@gmail.com" <linux.cj@gmail.com>,
Jon Nettleton <jon@solid-run.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
Makarand Pawagi <makarand.pawagi@nxp.com>,
Cristi Sovaiala <cristian.sovaiala@nxp.com>,
Laurentiu Tudor <laurentiu.tudor@nxp.com>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Varun Sethi <V.Sethi@nxp.com>,
Pankaj Bansal <pankaj.bansal@nxp.com>,
"Rajesh V. Bikkina" <rajesh.bikkina@nxp.com>,
Leo Li <leoyang.li@nxp.com>
Cc: Marcin Wojtas <mw@semihalf.com>,
"Calvin Johnson (OSS)" <calvin.johnson@oss.nxp.com>,
Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH v1 1/7] mdio_bus: Introduce fwnode MDIO helpers
Date: Fri, 7 Feb 2020 09:42:56 +0000 [thread overview]
Message-ID: <AM0PR04MB56366808BA5C841E4E7BC86E931C0@AM0PR04MB5636.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <371ff9b4-4de6-7a03-90f8-a1eae4d5402d@arm.com>
Hi Jeremy,
> -----Original Message-----
> From: Jeremy Linton <jeremy.linton@arm.com>
> Sent: Wednesday, February 5, 2020 7:48 PM
<snip>
> > +static int fwnode_mdio_parse_addr(struct device *dev,
> > + const struct fwnode_handle *fwnode) {
> > + u32 addr;
> > + int ret;
> > +
> > + ret = fwnode_property_read_u32(fwnode, "reg", &addr);
> > + if (ret < 0) {
> > + dev_err(dev, "PHY node has no 'reg' property\n");
> > + return ret;
> > + }
> > +
> > + /* A PHY must have a reg property in the range [0-31] */
> > + if (addr < 0 || addr >= PHY_MAX_ADDR) {
> > + dev_err(dev, "PHY address %i is invalid\n", addr);
> > + return -EINVAL;
> > + }
> > +
> > + return addr;
> > +}
>
> Almost assuredly this is wrong, the _ADR method exists to identify a device
> on its parent bus. The DT reg property shouldn't be used like this in an ACPI
> enviroment.
>
> Further, there are a number of other dt bindings in this set that seem
> inappropriate in common/shared ACPI code paths. That is because AFAIK the
> _DSD methods are there to provide device implementation specific
> behaviors, not as standardized methods for a generic classes of devices.
> Its vaguly the equivlant of the "vendor,xxxx" properties in DT.
>
> This has been a discussion point on/off for a while with any attempt to
> publicly specify/standardize for all OS vendors what they might find encoded
> in a DSD property. The few year old "WORK_IN_PROGRESS" link on the uefi
> page has a few suggested ones
>
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuefi.
> org%2Fsites%2Fdefault%2Ffiles%2Fresources%2Fnic-request-
> v2.pdf&data=02%7C01%7Ccalvin.johnson%40nxp.com%7Cf16350b8314
> b4992063008d7ab4f6486%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1
> %7C637166229795374486&sdata=zcXu%2Fu%2Fxw5%2Ff7eJd%2FledR%
> 2FgnabvFcCUtOfwTXtMoDBI%3D&reserved=0
>
> Anyway, the use of phy-handle with a reference to the phy device on a
> shared MDIO is a techically workable solution to the problem brought up in
> the RPI/ACPI thread as well. OTOH, it suffers from the use of DSD and at a
> minimum should probably be added to the document linked above if its
> found to be the best way to handle this. Although, in the common case of a
> mdio bus, matching acpi described devices with their discovered
> counterparts (note the device() defintion in the spec
> 19.6.30) only to define DSD refrences is a bit overkill.
>
> Put another way, while seemingly not nessiary if a bus can be probed, a
> nic/device->mdio->phy can be described in the normal ACPI heirarchy with
> only appropriatly nested CRS and ADR resources. Its the shared nature of the
> MDIO bus that causes problems.
Thanks! I'll definitely consider your suggestions along with the others received earlier.
While I do more study on this, thought of forwarding DSTD tables used by this patch-set.
https://source.codeaurora.org/external/qoriq/qoriq-components/edk2-platforms/tree/Platform/NXP/LX2160aRdbPkg/AcpiTables/Dsdt/Mdio.asl?h=LX2160_UEFI_ACPI_EAR1
https://source.codeaurora.org/external/qoriq/qoriq-components/edk2-platforms/tree/Platform/NXP/LX2160aRdbPkg/AcpiTables/Dsdt/Mc.asl?h=LX2160_UEFI_ACPI_EAR1
Regards
Calvin
next prev parent reply other threads:[~2020-02-07 9:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200131153440.20870-1-calvin.johnson@nxp.com>
[not found] ` <fcda49b6-7a45-cd86-e33e-f8dea07c0684@gmail.com>
2020-02-05 8:31 ` [EXT] Re: [PATCH v1 0/7] ACPI support for xgmac_mdio and dpaa2-mac drivers Calvin Johnson (OSS)
[not found] ` <20200131153440.20870-7-calvin.johnson@nxp.com>
[not found] ` <20200203184121.GR25745@shell.armlinux.org.uk>
2020-02-05 11:33 ` [EXT] Re: [PATCH v1 6/7] net: phylink: Introduce phylink_fwnode_phy_connect() Calvin Johnson (OSS)
[not found] ` <20200131153440.20870-2-calvin.johnson@nxp.com>
[not found] ` <20200131162814.GB17185@lunn.ch>
2020-02-05 7:11 ` [EXT] Re: [PATCH v1 1/7] mdio_bus: Introduce fwnode MDIO helpers Calvin Johnson (OSS)
[not found] ` <371ff9b4-4de6-7a03-90f8-a1eae4d5402d@arm.com>
2020-02-07 9:42 ` Calvin Johnson (OSS) [this message]
2020-02-25 10:12 ` Calvin Johnson
2020-02-25 20:42 ` Jeremy Linton
2020-03-17 11:36 ` Calvin Johnson
2020-03-17 14:04 ` Andrew Lunn
2020-03-18 6:03 ` Calvin Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR04MB56366808BA5C841E4E7BC86E931C0@AM0PR04MB5636.eurprd04.prod.outlook.com \
--to=calvin.johnson@oss.nxp.com \
--cc=V.Sethi@nxp.com \
--cc=andrew@lunn.ch \
--cc=cristian.sovaiala@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=jeremy.linton@arm.com \
--cc=jon@solid-run.com \
--cc=laurentiu.tudor@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.cj@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=makarand.pawagi@nxp.com \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=pankaj.bansal@nxp.com \
--cc=rajesh.bikkina@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).