From: "Calvin Johnson (OSS)" <calvin.johnson@oss.nxp.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "linux.cj@gmail.com" <linux.cj@gmail.com>,
Jon Nettleton <jon@solid-run.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
Makarand Pawagi <makarand.pawagi@nxp.com>,
Cristi Sovaiala <cristian.sovaiala@nxp.com>,
Laurentiu Tudor <laurentiu.tudor@nxp.com>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Varun Sethi <V.Sethi@nxp.com>,
Pankaj Bansal <pankaj.bansal@nxp.com>,
"Rajesh V. Bikkina" <rajesh.bikkina@nxp.com>,
Marcin Wojtas <mw@semihalf.com>,
"Calvin Johnson (OSS)" <calvin.johnson@oss.nxp.com>,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH v1 1/7] mdio_bus: Introduce fwnode MDIO helpers
Date: Wed, 5 Feb 2020 07:11:37 +0000 [thread overview]
Message-ID: <AM0PR04MB5636F2F01AC234F2F613E5B293020@AM0PR04MB5636.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20200131162814.GB17185@lunn.ch>
Hi Andrew,
> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Friday, January 31, 2020 9:58 PM
<snip>
> On Fri, Jan 31, 2020 at 09:04:34PM +0530, Calvin Johnson wrote:
> > From: Marcin Wojtas <mw@semihalf.com>
> >
> > This patch introduces fwnode helper for registering MDIO bus, as well
> > as one for finding the PHY, basing on its firmware node pointer.
> > Comparing to existing OF equivalent,
> > fwnode_mdiobus_register() does not support:
> > * deprecated bindings (device whitelist, nor the PHY ID embedded
> > in the compatible string)
> > * MDIO bus auto scanning
> >
> > Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> > Signed-off-by: Calvin Johnson <calvin.johnson@oss.nxp.com>
>
> Hi Calvin
> no
> This appears to but a cut and paste, follow by an intelligent s/of/fwnode/g.
In this patchset, I tried to reuse Marcin's patch which was posted on 2017/12/18.
https://lkml.org/lkml/2017/12/18/211
With my patch([v1,2/7] mdio_bus: modify fwnode phy related functions), I've made
modifications to this(v1,1/7) patch to adapt to the changes in the kernel.
> Did you make any attempt to consolidate the two implementations? It
> seems like there should be some level of abstraction that hides away the
> difference between DT properties, and DT properties stuffed into ACPI
> tables?
Yes attempt is to consolidate DT and ACPI into fwnode. Sure, I'll revisit the patch
and try to work on your recommendation.
Thanks
Calvin
next prev parent reply other threads:[~2020-02-05 7:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200131153440.20870-1-calvin.johnson@nxp.com>
[not found] ` <fcda49b6-7a45-cd86-e33e-f8dea07c0684@gmail.com>
2020-02-05 8:31 ` [EXT] Re: [PATCH v1 0/7] ACPI support for xgmac_mdio and dpaa2-mac drivers Calvin Johnson (OSS)
[not found] ` <20200131153440.20870-7-calvin.johnson@nxp.com>
[not found] ` <20200203184121.GR25745@shell.armlinux.org.uk>
2020-02-05 11:33 ` [EXT] Re: [PATCH v1 6/7] net: phylink: Introduce phylink_fwnode_phy_connect() Calvin Johnson (OSS)
[not found] ` <20200131153440.20870-2-calvin.johnson@nxp.com>
[not found] ` <20200131162814.GB17185@lunn.ch>
2020-02-05 7:11 ` Calvin Johnson (OSS) [this message]
[not found] ` <371ff9b4-4de6-7a03-90f8-a1eae4d5402d@arm.com>
2020-02-07 9:42 ` [EXT] Re: [PATCH v1 1/7] mdio_bus: Introduce fwnode MDIO helpers Calvin Johnson (OSS)
2020-02-25 10:12 ` Calvin Johnson
2020-02-25 20:42 ` Jeremy Linton
2020-03-17 11:36 ` Calvin Johnson
2020-03-17 14:04 ` Andrew Lunn
2020-03-18 6:03 ` Calvin Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR04MB5636F2F01AC234F2F613E5B293020@AM0PR04MB5636.eurprd04.prod.outlook.com \
--to=calvin.johnson@oss.nxp.com \
--cc=V.Sethi@nxp.com \
--cc=andrew@lunn.ch \
--cc=cristian.sovaiala@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=jon@solid-run.com \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.cj@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=makarand.pawagi@nxp.com \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=pankaj.bansal@nxp.com \
--cc=rajesh.bikkina@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).