Linux-ACPI Archive on lore.kernel.org
 help / color / Atom feed
* [pm:bleeding-edge 175/181] drivers/cpuidle/driver.c:270:4: error: 'cpuidle_prev_governor' undeclared; did you mean 'cpuidle_find_governor'?
@ 2019-09-06 16:44 kbuild test robot
  2019-09-06 17:38 ` Joao Martins
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2019-09-06 16:44 UTC (permalink / raw)
  To: Joao Martins; +Cc: kbuild-all, linux-acpi, devel, linux-pm, Rafael J. Wysocki

[-- Attachment #1: Type: text/plain, Size: 2977 bytes --]

tree:   https://kernel.googlesource.com/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge
head:   79f0d67a241f0583b994c73437caa54a4e942737
commit: 73d2bcced00671c2b724a31c3a4b3401c3e278d0 [175/181] cpuidle: allow governor switch on cpuidle_register_driver()
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 73d2bcced00671c2b724a31c3a4b3401c3e278d0
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/cpuidle/driver.c: In function 'cpuidle_register_driver':
>> drivers/cpuidle/driver.c:270:4: error: 'cpuidle_prev_governor' undeclared (first use in this function); did you mean 'cpuidle_find_governor'?
       cpuidle_prev_governor = cpuidle_curr_governor;
       ^~~~~~~~~~~~~~~~~~~~~
       cpuidle_find_governor
   drivers/cpuidle/driver.c:270:4: note: each undeclared identifier is reported only once for each function it appears in
   drivers/cpuidle/driver.c: In function 'cpuidle_unregister_driver':
   drivers/cpuidle/driver.c:301:6: error: 'cpuidle_prev_governor' undeclared (first use in this function); did you mean 'cpuidle_find_governor'?
     if (cpuidle_prev_governor) {
         ^~~~~~~~~~~~~~~~~~~~~
         cpuidle_find_governor

vim +270 drivers/cpuidle/driver.c

   245	
   246	/**
   247	 * cpuidle_register_driver - registers a driver
   248	 * @drv: a pointer to a valid struct cpuidle_driver
   249	 *
   250	 * Register the driver under a lock to prevent concurrent attempts to
   251	 * [un]register the driver from occuring at the same time.
   252	 *
   253	 * Returns 0 on success, a negative error code (returned by
   254	 * __cpuidle_register_driver()) otherwise.
   255	 */
   256	int cpuidle_register_driver(struct cpuidle_driver *drv)
   257	{
   258		struct cpuidle_governor *gov;
   259		int ret;
   260	
   261		spin_lock(&cpuidle_driver_lock);
   262		ret = __cpuidle_register_driver(drv);
   263		spin_unlock(&cpuidle_driver_lock);
   264	
   265		if (!ret && !strlen(param_governor) && drv->governor &&
   266		    (cpuidle_get_driver() == drv)) {
   267			mutex_lock(&cpuidle_lock);
   268			gov = cpuidle_find_governor(drv->governor);
   269			if (gov) {
 > 270				cpuidle_prev_governor = cpuidle_curr_governor;
   271				if (cpuidle_switch_governor(gov) < 0)
   272					cpuidle_prev_governor = NULL;
   273			}
   274			mutex_unlock(&cpuidle_lock);
   275		}
   276	
   277		return ret;
   278	}
   279	EXPORT_SYMBOL_GPL(cpuidle_register_driver);
   280	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 48009 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [pm:bleeding-edge 175/181] drivers/cpuidle/driver.c:270:4: error: 'cpuidle_prev_governor' undeclared; did you mean 'cpuidle_find_governor'?
  2019-09-06 16:44 [pm:bleeding-edge 175/181] drivers/cpuidle/driver.c:270:4: error: 'cpuidle_prev_governor' undeclared; did you mean 'cpuidle_find_governor'? kbuild test robot
@ 2019-09-06 17:38 ` Joao Martins
  2019-09-07 21:07   ` Rafael J. Wysocki
  0 siblings, 1 reply; 3+ messages in thread
From: Joao Martins @ 2019-09-06 17:38 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: kbuild test robot, kbuild-all, linux-acpi, devel, linux-pm

On 9/6/19 5:44 PM, kbuild test robot wrote:
> tree:   https://kernel.googlesource.com/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge
> head:   79f0d67a241f0583b994c73437caa54a4e942737
> commit: 73d2bcced00671c2b724a31c3a4b3401c3e278d0 [175/181] cpuidle: allow governor switch on cpuidle_register_driver()
> config: arm-defconfig (attached as .config)
> compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 73d2bcced00671c2b724a31c3a4b3401c3e278d0
>         # save the attached .config to linux build tree
>         GCC_VERSION=7.4.0 make.cross ARCH=arm 
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/cpuidle/driver.c: In function 'cpuidle_register_driver':
>>> drivers/cpuidle/driver.c:270:4: error: 'cpuidle_prev_governor' undeclared (first use in this function); did you mean 'cpuidle_find_governor'?
>        cpuidle_prev_governor = cpuidle_curr_governor;
>        ^~~~~~~~~~~~~~~~~~~~~
>        cpuidle_find_governor
>    drivers/cpuidle/driver.c:270:4: note: each undeclared identifier is reported only once for each function it appears in
>    drivers/cpuidle/driver.c: In function 'cpuidle_unregister_driver':
>    drivers/cpuidle/driver.c:301:6: error: 'cpuidle_prev_governor' undeclared (first use in this function); did you mean 'cpuidle_find_governor'?
>      if (cpuidle_prev_governor) {
>          ^~~~~~~~~~~~~~~~~~~~~
>          cpuidle_find_governor
> 
Sorry, didn't build-test with CONFIG_CPU_IDLE_MULTIPLE_DRIVERS=y

Rafael, should I take this message that you queued the series (and thus I submit
a follow up fixing this), or I can just submit a v3 of this particular series?
You didn't answer on the cover letter, so I take it that it's the latter?

	Joao

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [pm:bleeding-edge 175/181] drivers/cpuidle/driver.c:270:4: error: 'cpuidle_prev_governor' undeclared; did you mean 'cpuidle_find_governor'?
  2019-09-06 17:38 ` Joao Martins
@ 2019-09-07 21:07   ` Rafael J. Wysocki
  0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2019-09-07 21:07 UTC (permalink / raw)
  To: Joao Martins
  Cc: Rafael J. Wysocki, kbuild test robot, kbuild-all,
	ACPI Devel Maling List,
	open list:ACPI COMPONENT ARCHITECTURE (ACPICA),
	Linux PM

On Fri, Sep 6, 2019 at 7:39 PM Joao Martins <joao.m.martins@oracle.com> wrote:
>
> On 9/6/19 5:44 PM, kbuild test robot wrote:
> > tree:   https://kernel.googlesource.com/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge
> > head:   79f0d67a241f0583b994c73437caa54a4e942737
> > commit: 73d2bcced00671c2b724a31c3a4b3401c3e278d0 [175/181] cpuidle: allow governor switch on cpuidle_register_driver()
> > config: arm-defconfig (attached as .config)
> > compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0
> > reproduce:
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         git checkout 73d2bcced00671c2b724a31c3a4b3401c3e278d0
> >         # save the attached .config to linux build tree
> >         GCC_VERSION=7.4.0 make.cross ARCH=arm
> >
> > If you fix the issue, kindly add following tag
> > Reported-by: kbuild test robot <lkp@intel.com>
> >
> > All errors (new ones prefixed by >>):
> >
> >    drivers/cpuidle/driver.c: In function 'cpuidle_register_driver':
> >>> drivers/cpuidle/driver.c:270:4: error: 'cpuidle_prev_governor' undeclared (first use in this function); did you mean 'cpuidle_find_governor'?
> >        cpuidle_prev_governor = cpuidle_curr_governor;
> >        ^~~~~~~~~~~~~~~~~~~~~
> >        cpuidle_find_governor
> >    drivers/cpuidle/driver.c:270:4: note: each undeclared identifier is reported only once for each function it appears in
> >    drivers/cpuidle/driver.c: In function 'cpuidle_unregister_driver':
> >    drivers/cpuidle/driver.c:301:6: error: 'cpuidle_prev_governor' undeclared (first use in this function); did you mean 'cpuidle_find_governor'?
> >      if (cpuidle_prev_governor) {
> >          ^~~~~~~~~~~~~~~~~~~~~
> >          cpuidle_find_governor
> >
> Sorry, didn't build-test with CONFIG_CPU_IDLE_MULTIPLE_DRIVERS=y
>
> Rafael, should I take this message that you queued the series (and thus I submit
> a follow up fixing this), or I can just submit a v3 of this particular series?

Please submit a v3.  Thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-06 16:44 [pm:bleeding-edge 175/181] drivers/cpuidle/driver.c:270:4: error: 'cpuidle_prev_governor' undeclared; did you mean 'cpuidle_find_governor'? kbuild test robot
2019-09-06 17:38 ` Joao Martins
2019-09-07 21:07   ` Rafael J. Wysocki

Linux-ACPI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-acpi/0 linux-acpi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-acpi linux-acpi/ https://lore.kernel.org/linux-acpi \
		linux-acpi@vger.kernel.org linux-acpi@archiver.kernel.org
	public-inbox-index linux-acpi


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-acpi


AGPL code for this site: git clone https://public-inbox.org/ public-inbox