* [PATCH] ACPI: resource: Skip IRQ override on Asus Expertbook B2402CBA
@ 2022-12-30 5:58 Tamim Khan
2023-01-11 20:14 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Tamim Khan @ 2022-12-30 5:58 UTC (permalink / raw)
To: linux-acpi; +Cc: rafael, lenb, linux-kernel, Tamim Khan, zelenat
Like the Asus Expertbook B2502CBA and various Asus Vivobook laptops,
the Asus Expertbook B2402CBA has an ACPI DSDT table that describes IRQ 1
as ActiveLow while the kernel overrides it to Edge_High. This prevents the
keyboard from working. To fix this issue, add this laptop to the
skip_override_table so that the kernel does not override IRQ 1.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=216864
Tested-by: zelenat <zelenat@gmail.com>
Signed-off-by: Tamim Khan <tamim@fusetak.com>
---
This patch is very similar to 7203481fd12b1257938519efb2460ea02b9236ee
(ACPI: resource: Add Asus ExpertBook B2502 to Asus quirks) and just adds
another ExpertBook that has the same IRQ override problem to the quirks list.
drivers/acpi/resource.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index 16dcd31d124f..153e3f8b446f 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -432,6 +432,13 @@ static const struct dmi_system_id asus_laptop[] = {
DMI_MATCH(DMI_BOARD_NAME, "S5602ZA"),
},
},
+ {
+ .ident = "Asus ExpertBook B2402CBA",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_BOARD_NAME, "B2402CBA"),
+ },
+ },
{
.ident = "Asus ExpertBook B2502",
.matches = {
--
2.38.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ACPI: resource: Skip IRQ override on Asus Expertbook B2402CBA
2022-12-30 5:58 [PATCH] ACPI: resource: Skip IRQ override on Asus Expertbook B2402CBA Tamim Khan
@ 2023-01-11 20:14 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2023-01-11 20:14 UTC (permalink / raw)
To: Tamim Khan; +Cc: linux-acpi, rafael, lenb, linux-kernel, zelenat
On Fri, Dec 30, 2022 at 6:59 AM Tamim Khan <tamim@fusetak.com> wrote:
>
> Like the Asus Expertbook B2502CBA and various Asus Vivobook laptops,
> the Asus Expertbook B2402CBA has an ACPI DSDT table that describes IRQ 1
> as ActiveLow while the kernel overrides it to Edge_High. This prevents the
> keyboard from working. To fix this issue, add this laptop to the
> skip_override_table so that the kernel does not override IRQ 1.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216864
> Tested-by: zelenat <zelenat@gmail.com>
> Signed-off-by: Tamim Khan <tamim@fusetak.com>
> ---
> This patch is very similar to 7203481fd12b1257938519efb2460ea02b9236ee
> (ACPI: resource: Add Asus ExpertBook B2502 to Asus quirks) and just adds
> another ExpertBook that has the same IRQ override problem to the quirks list.
>
> drivers/acpi/resource.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> index 16dcd31d124f..153e3f8b446f 100644
> --- a/drivers/acpi/resource.c
> +++ b/drivers/acpi/resource.c
> @@ -432,6 +432,13 @@ static const struct dmi_system_id asus_laptop[] = {
> DMI_MATCH(DMI_BOARD_NAME, "S5602ZA"),
> },
> },
> + {
> + .ident = "Asus ExpertBook B2402CBA",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_BOARD_NAME, "B2402CBA"),
> + },
> + },
> {
> .ident = "Asus ExpertBook B2502",
> .matches = {
> --
Applied as 6.2-rc material, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-11 20:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-30 5:58 [PATCH] ACPI: resource: Skip IRQ override on Asus Expertbook B2402CBA Tamim Khan
2023-01-11 20:14 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).