linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [rafael-pm:bleeding-edge 113/118] arch/x86/kernel/acpi/boot.c:1394 (null)() error: buffer overflow '(acpi_dmi_table[6])->matches' 4 <= 4
@ 2022-03-03 11:51 Dan Carpenter
  2022-03-03 12:02 ` Rafael J. Wysocki
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2022-03-03 11:51 UTC (permalink / raw)
  To: kbuild, Mark Cilissen
  Cc: lkp, kbuild-all, linux-acpi, devel, linux-pm, Rafael J. Wysocki,
	Hans de Goede

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge
head:   f7307721a01f4f14d21c699b270a870370cf34b9
commit: ed00b2b8d737f87a2437d7bd7c7f90124b50da05 [113/118] x86 / ACPI: Work around broken XSDT on SEGA AALE board
config: x86_64-randconfig-m001 (https://download.01.org/0day-ci/archive/20220302/202203021037.WWnG44C5-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
arch/x86/kernel/acpi/boot.c:1394 (null)() error: buffer overflow '(acpi_dmi_table[6])->matches' 4 <= 4
arch/x86/kernel/acpi/boot.c:1394 (null)() error: buffer overflow '(acpi_dmi_table[6])->matches' 4 <= 4

vim +1394 arch/x86/kernel/acpi/boot.c

6faadbbb7f9da7 arch/x86/kernel/acpi/boot.c  Christoph Hellwig 2017-09-14 @1394  static const struct dmi_system_id acpi_dmi_table[] __initconst = {
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1395  	/*
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1396  	 * Boxes that need ACPI disabled
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1397  	 */
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1398  	{
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1399  	 .callback = dmi_disable_acpi,
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1400  	 .ident = "IBM Thinkpad",
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1401  	 .matches = {
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1402  		     DMI_MATCH(DMI_BOARD_VENDOR, "IBM"),
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1403  		     DMI_MATCH(DMI_BOARD_NAME, "2629H1G"),
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1404  		     },
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1405  	 },
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1406  
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1407  	/*
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1408  	 * Boxes that need ACPI PCI IRQ routing disabled
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1409  	 */
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1410  	{
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1411  	 .callback = disable_acpi_irq,
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1412  	 .ident = "ASUS A7V",
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1413  	 .matches = {
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1414  		     DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC"),
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1415  		     DMI_MATCH(DMI_BOARD_NAME, "<A7V>"),
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1416  		     /* newer BIOS, Revision 1011, does work */
4be44fcd3bf648 arch/i386/kernel/acpi/boot.c Len Brown         2005-08-05  1417  		     DMI_MATCH(DMI_BIOS_VERSION,
4be44fcd3bf648 arch/i386/kernel/acpi/boot.c Len Brown         2005-08-05  1418  			       "ASUS A7V ACPI BIOS Revision 1007"),
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1419  		     },
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1420  	 },
74586fca38109d arch/i386/kernel/acpi/boot.c Len Brown         2007-03-08  1421  	{
74586fca38109d arch/i386/kernel/acpi/boot.c Len Brown         2007-03-08  1422  		/*
74586fca38109d arch/i386/kernel/acpi/boot.c Len Brown         2007-03-08  1423  		 * Latest BIOS for IBM 600E (1.16) has bad pcinum
74586fca38109d arch/i386/kernel/acpi/boot.c Len Brown         2007-03-08  1424  		 * for LPC bridge, which is needed for the PCI
74586fca38109d arch/i386/kernel/acpi/boot.c Len Brown         2007-03-08  1425  		 * interrupt links to work. DSDT fix is in bug 5966.
74586fca38109d arch/i386/kernel/acpi/boot.c Len Brown         2007-03-08  1426  		 * 2645, 2646 model numbers are shared with 600/600E/600X
74586fca38109d arch/i386/kernel/acpi/boot.c Len Brown         2007-03-08  1427  		 */
74586fca38109d arch/i386/kernel/acpi/boot.c Len Brown         2007-03-08  1428  	 .callback = disable_acpi_irq,
74586fca38109d arch/i386/kernel/acpi/boot.c Len Brown         2007-03-08  1429  	 .ident = "IBM Thinkpad 600 Series 2645",
74586fca38109d arch/i386/kernel/acpi/boot.c Len Brown         2007-03-08  1430  	 .matches = {
74586fca38109d arch/i386/kernel/acpi/boot.c Len Brown         2007-03-08  1431  		     DMI_MATCH(DMI_BOARD_VENDOR, "IBM"),
74586fca38109d arch/i386/kernel/acpi/boot.c Len Brown         2007-03-08  1432  		     DMI_MATCH(DMI_BOARD_NAME, "2645"),
74586fca38109d arch/i386/kernel/acpi/boot.c Len Brown         2007-03-08  1433  		     },
74586fca38109d arch/i386/kernel/acpi/boot.c Len Brown         2007-03-08  1434  	 },
74586fca38109d arch/i386/kernel/acpi/boot.c Len Brown         2007-03-08  1435  	{
74586fca38109d arch/i386/kernel/acpi/boot.c Len Brown         2007-03-08  1436  	 .callback = disable_acpi_irq,
74586fca38109d arch/i386/kernel/acpi/boot.c Len Brown         2007-03-08  1437  	 .ident = "IBM Thinkpad 600 Series 2646",
74586fca38109d arch/i386/kernel/acpi/boot.c Len Brown         2007-03-08  1438  	 .matches = {
74586fca38109d arch/i386/kernel/acpi/boot.c Len Brown         2007-03-08  1439  		     DMI_MATCH(DMI_BOARD_VENDOR, "IBM"),
74586fca38109d arch/i386/kernel/acpi/boot.c Len Brown         2007-03-08  1440  		     DMI_MATCH(DMI_BOARD_NAME, "2646"),
74586fca38109d arch/i386/kernel/acpi/boot.c Len Brown         2007-03-08  1441  		     },
74586fca38109d arch/i386/kernel/acpi/boot.c Len Brown         2007-03-08  1442  	 },
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1443  	/*
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1444  	 * Boxes that need ACPI PCI IRQ routing and PCI scan disabled
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1445  	 */
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1446  	{			/* _BBN 0 bug */
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1447  	 .callback = disable_acpi_pci,
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1448  	 .ident = "ASUS PR-DLS",
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1449  	 .matches = {
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1450  		     DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1451  		     DMI_MATCH(DMI_BOARD_NAME, "PR-DLS"),
4be44fcd3bf648 arch/i386/kernel/acpi/boot.c Len Brown         2005-08-05  1452  		     DMI_MATCH(DMI_BIOS_VERSION,
4be44fcd3bf648 arch/i386/kernel/acpi/boot.c Len Brown         2005-08-05  1453  			       "ASUS PR-DLS ACPI BIOS Revision 1010"),
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1454  		     DMI_MATCH(DMI_BIOS_DATE, "03/21/2003")
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1455  		     },
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1456  	 },
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1457  	{
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1458  	 .callback = disable_acpi_pci,
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1459  	 .ident = "Acer TravelMate 36x Laptop",
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1460  	 .matches = {
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1461  		     DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1462  		     DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 360"),
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1463  		     },
aea00143a8db8c arch/i386/kernel/acpi/boot.c Andrey Panin      2005-06-25  1464  	 },
ed00b2b8d737f8 arch/x86/kernel/acpi/boot.c  Mark Cilissen     2022-02-23  1465  	/*
ed00b2b8d737f8 arch/x86/kernel/acpi/boot.c  Mark Cilissen     2022-02-23  1466  	 * Boxes that need ACPI XSDT use disabled due to corrupted tables
ed00b2b8d737f8 arch/x86/kernel/acpi/boot.c  Mark Cilissen     2022-02-23  1467  	 */
ed00b2b8d737f8 arch/x86/kernel/acpi/boot.c  Mark Cilissen     2022-02-23  1468  	{
ed00b2b8d737f8 arch/x86/kernel/acpi/boot.c  Mark Cilissen     2022-02-23  1469  	 .callback = disable_acpi_xsdt,
ed00b2b8d737f8 arch/x86/kernel/acpi/boot.c  Mark Cilissen     2022-02-23  1470  	 .ident = "SEGA AALE",
ed00b2b8d737f8 arch/x86/kernel/acpi/boot.c  Mark Cilissen     2022-02-23  1471  	 .matches = {
ed00b2b8d737f8 arch/x86/kernel/acpi/boot.c  Mark Cilissen     2022-02-23  1472  		     DMI_MATCH(DMI_SYS_VENDOR, "NEC"),
ed00b2b8d737f8 arch/x86/kernel/acpi/boot.c  Mark Cilissen     2022-02-23  1473  		     DMI_MATCH(DMI_PRODUCT_NAME, "Bearlake CRB Board"),
ed00b2b8d737f8 arch/x86/kernel/acpi/boot.c  Mark Cilissen     2022-02-23  1474  		     DMI_MATCH(DMI_BIOS_VENDOR, "Phoenix Technologies LTD"),
ed00b2b8d737f8 arch/x86/kernel/acpi/boot.c  Mark Cilissen     2022-02-23  1475  		     DMI_MATCH(DMI_BIOS_VERSION, "V1.12"),
ed00b2b8d737f8 arch/x86/kernel/acpi/boot.c  Mark Cilissen     2022-02-23  1476  		     DMI_MATCH(DMI_BIOS_DATE, "02/01/2011"),

There are only 4 elements in the .matches[] array.

ed00b2b8d737f8 arch/x86/kernel/acpi/boot.c  Mark Cilissen     2022-02-23  1477  		     },
ed00b2b8d737f8 arch/x86/kernel/acpi/boot.c  Mark Cilissen     2022-02-23  1478  	},
35af28219e684a arch/x86/kernel/acpi/boot.c  Andreas Herrmann  2008-10-22  1479  	{}
35af28219e684a arch/x86/kernel/acpi/boot.c  Andreas Herrmann  2008-10-22  1480  };

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [rafael-pm:bleeding-edge 113/118] arch/x86/kernel/acpi/boot.c:1394 (null)() error: buffer overflow '(acpi_dmi_table[6])->matches' 4 <= 4
  2022-03-03 11:51 [rafael-pm:bleeding-edge 113/118] arch/x86/kernel/acpi/boot.c:1394 (null)() error: buffer overflow '(acpi_dmi_table[6])->matches' 4 <= 4 Dan Carpenter
@ 2022-03-03 12:02 ` Rafael J. Wysocki
  0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2022-03-03 12:02 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: kbuild, Mark Cilissen, kbuild test robot, kbuild-all,
	ACPI Devel Maling List,
	open list:ACPI COMPONENT ARCHITECTURE (ACPICA),
	Linux PM, Rafael J. Wysocki, Hans de Goede

On Thu, Mar 3, 2022 at 12:52 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge
> head:   f7307721a01f4f14d21c699b270a870370cf34b9
> commit: ed00b2b8d737f87a2437d7bd7c7f90124b50da05 [113/118] x86 / ACPI: Work around broken XSDT on SEGA AALE board

Yes, this commit has been dropped already.

> config: x86_64-randconfig-m001 (https://download.01.org/0day-ci/archive/20220302/202203021037.WWnG44C5-lkp@intel.com/config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

Thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-03-03 12:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-03 11:51 [rafael-pm:bleeding-edge 113/118] arch/x86/kernel/acpi/boot.c:1394 (null)() error: buffer overflow '(acpi_dmi_table[6])->matches' 4 <= 4 Dan Carpenter
2022-03-03 12:02 ` Rafael J. Wysocki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).