Linux-ACPI Archive on lore.kernel.org
 help / color / Atom feed
From: "Kaneda, Erik" <erik.kaneda@intel.com>
To: Hans de Goede <hdegoede@redhat.com>,
	"Moore, Robert" <robert.moore@intel.com>,
	"Rafael J . Wysocki" <rjw@rjwysocki.net>,
	Len Brown <lenb@kernel.org>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"devel@acpica.org" <devel@acpica.org>
Subject: RE: [PATCH] ACPICA: Also handle "orphan" _REG methods for GPIO OpRegions
Date: Fri, 30 Oct 2020 18:57:33 +0000
Message-ID: <MWHPR11MB15992234045948BBAD62716EF0150@MWHPR11MB1599.namprd11.prod.outlook.com> (raw)
In-Reply-To: <6e04d729-421e-c663-6d06-d69ec4c96556@redhat.com>



> -----Original Message-----
> From: Hans de Goede <hdegoede@redhat.com>
> Sent: Thursday, October 29, 2020 2:49 AM
> To: Kaneda, Erik <erik.kaneda@intel.com>; Moore, Robert
> <robert.moore@intel.com>; Rafael J . Wysocki <rjw@rjwysocki.net>; Len
> Brown <lenb@kernel.org>
> Cc: linux-acpi@vger.kernel.org; devel@acpica.org
> Subject: Re: [PATCH] ACPICA: Also handle "orphan" _REG methods for GPIO
> OpRegions
> 
> Hi,
> 
> On 10/28/20 11:33 PM, Kaneda, Erik wrote:
> >
> >
> >> -----Original Message-----
> >> From: Hans de Goede <hdegoede@redhat.com>
> >> Sent: Tuesday, October 27, 2020 12:00 PM
> >> To: Kaneda, Erik <erik.kaneda@intel.com>; Moore, Robert
> >> <robert.moore@intel.com>; Rafael J . Wysocki <rjw@rjwysocki.net>; Len
> >> Brown <lenb@kernel.org>
> >> Cc: linux-acpi@vger.kernel.org; devel@acpica.org
> >> Subject: Re: [PATCH] ACPICA: Also handle "orphan" _REG methods for
> GPIO
> >> OpRegions
> >>
> >> Hi,
> >>
> >> On 10/27/20 6:43 PM, Kaneda, Erik wrote:
> >>>
> >>>
> >>>> -----Original Message-----
> >>>> From: Moore, Robert <robert.moore@intel.com>
> >>>> Sent: Tuesday, October 27, 2020 7:17 AM
> >>>> To: Kaneda, Erik <erik.kaneda@intel.com>; Hans de Goede
> >>>> <hdegoede@redhat.com>; Rafael J . Wysocki <rjw@rjwysocki.net>;
> Len
> >>>> Brown <lenb@kernel.org>
> >>>> Cc: linux-acpi@vger.kernel.org; devel@acpica.org
> >>>> Subject: RE: [PATCH] ACPICA: Also handle "orphan" _REG methods for
> >> GPIO
> >>>> OpRegions
> >>>>
> >>>> Looks OK to me.
> >>>
> >>> Ok, I'll make a pull request of this to ACPICA on behalf of Hans and it will
> be
> >> in the next ACPICA release.
> >>
> >> Great, thank you.
> >
> > Pull request is available here: https://github.com/acpica/acpica/pull/644
> >
> > Once it's merged, it'll be a part of the next ACPICA release.
> 
> Thank you for porting this to the ACPICA upstream code,
> unfortunately you missed one change when porting this. I've added
> a review pointing the missing bit out on github.
> 
> Specifically you missed this bit:
> 
>  		if ((next_node->type == ACPI_TYPE_REGION) &&
>  		    (next_node->object) &&
> -		    (next_node->object->region.space_id ==
> ACPI_ADR_SPACE_EC)) {
> +		    (next_node->object->region.space_id == space_id)) {
>  			goto exit;	/* Do not execute the _REG */
>  		}
> 
Updated the PR.

Thanks for catching this,
Erik
> 
> Regards,
> 
> Hans


  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-25  9:45 Hans de Goede
2020-10-26 20:55 ` Kaneda, Erik
2020-10-27 14:17   ` Moore, Robert
2020-10-27 17:43     ` Kaneda, Erik
2020-10-27 18:59       ` Hans de Goede
2020-10-28 22:33         ` Kaneda, Erik
2020-10-29  9:48           ` Hans de Goede
2020-10-30 18:57             ` Kaneda, Erik [this message]
2020-11-04 22:08           ` Moore, Robert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR11MB15992234045948BBAD62716EF0150@MWHPR11MB1599.namprd11.prod.outlook.com \
    --to=erik.kaneda@intel.com \
    --cc=devel@acpica.org \
    --cc=hdegoede@redhat.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=robert.moore@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ACPI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-acpi/0 linux-acpi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-acpi linux-acpi/ https://lore.kernel.org/linux-acpi \
		linux-acpi@vger.kernel.org
	public-inbox-index linux-acpi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-acpi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git