From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: chengwei <foxfly.lai.tw@gmail.com>
Cc: lee@kernel.org, broonie@kernel.org, rafael@kernel.org,
mika.westerberg@linux.intel.com, linus.walleij@linaro.org,
brgl@bgdev.pl, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org, lenb@kernel.org,
linux-acpi@vger.kernel.org, linux-gpio@vger.kernel.org,
GaryWang@aaeon.com.tw, musa.lin@yunjingtech.com,
jack.chang@yunjingtech.com, chengwei <larry.lai@yunjingtech.com>
Subject: Re: [PATCH 4/5] GPIO ACPI: Add support to map GPIO resources to ranges
Date: Wed, 19 Oct 2022 16:36:14 +0300 [thread overview]
Message-ID: <Y0/9Tq71JLr+Le4N@smile.fi.intel.com> (raw)
In-Reply-To: <20221019022450.16851-5-larry.lai@yunjingtech.com>
On Wed, Oct 19, 2022 at 10:24:49AM +0800, chengwei wrote:
> Add a function to gpiolib to facilitate registering a pin controller for
> a range of GPIO pins, but using ACPI resource references and without
> claiming the GPIO resource.
This is quite under explained.
First of all, why do you need all these?
Second, where is the link to ACPI DSDT excerpt of the device node
which needs that?
Third, is the BIOS for these platforms is already in wild or
can be amended?
...
> + count = acpi_gpio_count_from_property(adev, propname);
> if (count > 0)
> break;
This part can be split to a separate change as a prerequisite.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-10-19 13:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 2:24 [PATCH 0/5] Add support control UP board CPLD/FPGA pin control chengwei
2022-10-19 2:24 ` [PATCH 1/5] mfd: Add support for UP board CPLD/FPGA chengwei
2022-10-31 14:58 ` Lee Jones
[not found] ` <SG2PR06MB37422173908A6584B3D6D349F93F9@SG2PR06MB3742.apcprd06.prod.outlook.com>
2022-11-08 15:53 ` 回覆: " gregkh
[not found] ` <SG2PR06MB3742D3714B6A255914DC73E4F93F9@SG2PR06MB3742.apcprd06.prod.outlook.com>
2022-11-08 17:24 ` gregkh
2022-11-14 10:09 ` Lee Jones
2022-10-19 2:24 ` [PATCH 2/5] regmap: Expose regmap_writeable function to check if a register is writable chengwei
2022-10-19 11:57 ` Mark Brown
2022-10-19 2:24 ` [PATCH 3/5] ACPI: acpi_node_add_pin_mapping added to header file chengwei
2022-10-19 13:32 ` Andy Shevchenko
2022-10-19 2:24 ` [PATCH 4/5] GPIO ACPI: Add support to map GPIO resources to ranges chengwei
2022-10-19 13:36 ` Andy Shevchenko [this message]
2022-10-19 2:24 ` [PATCH 5/5] pinctrl: Add support pin control for UP board CPLD/FPGA chengwei
2022-10-20 16:58 ` Andy Shevchenko
2022-10-21 9:09 ` Linus Walleij
2022-10-21 10:55 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0/9Tq71JLr+Le4N@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=GaryWang@aaeon.com.tw \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=foxfly.lai.tw@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jack.chang@yunjingtech.com \
--cc=larry.lai@yunjingtech.com \
--cc=lee@kernel.org \
--cc=lenb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=musa.lin@yunjingtech.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).