From: Hanjun Guo <hanjun.guo@linaro.org>
To: fu.wei@linaro.org, rjw@rjwysocki.net, lenb@kernel.org,
daniel.lezcano@linaro.org, tglx@linutronix.de,
marc.zyngier@arm.com
Cc: linux-arm-kernel@lists.infradead.org,
linaro-acpi@lists.linaro.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, rruigrok@codeaurora.org,
harba@codeaurora.org, cov@codeaurora.org, timur@codeaurora.org,
graeme.gregory@linaro.org, al.stone@linaro.org, jcm@redhat.com,
wei@redhat.com, arnd@arndb.de, wim@iguana.be,
catalin.marinas@arm.com, will.deacon@arm.com,
Suravee.Suthikulpanit@amd.com, leo.duran@amd.com
Subject: Re: [PATCH v6 03/10] clocksource/drivers/arm_arch_timer: Improve printk relevant code
Date: Thu, 30 Jun 2016 10:54:32 +0800 [thread overview]
Message-ID: <c347a9d9-82b4-b469-4e64-6446e6282a19@linaro.org> (raw)
In-Reply-To: <1467224153-22873-4-git-send-email-fu.wei@linaro.org>
On 2016/6/30 2:15, fu.wei@linaro.org wrote:
> From: Fu Wei <fu.wei@linaro.org>
>
> This patch defines pr_fmt(fmt) for all pr_* functions,
> then the pr_* don't need to add "arch_timer:" everytime.
>
> Also delete some Blank Spaces in arch_timer_banner,
> according to the suggestion from checkpatch.pl.
>
> No functional change.
>
> Signed-off-by: Fu Wei <fu.wei@linaro.org>
> ---
> drivers/clocksource/arm_arch_timer.c | 52 +++++++++++++++++++-----------------
> 1 file changed, 27 insertions(+), 25 deletions(-)
>
> diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
> index 966c574..9540e9d 100644
> --- a/drivers/clocksource/arm_arch_timer.c
> +++ b/drivers/clocksource/arm_arch_timer.c
> @@ -29,6 +29,9 @@
>
> #include <clocksource/arm_arch_timer.h>
>
> +#undef pr_fmt
> +#define pr_fmt(fmt) "arch_timer: " fmt
> +
> #define CNTTIDR 0x08
> #define CNTTIDR_VIRT(n) (BIT(1) << ((n) * 4))
>
> @@ -388,24 +391,24 @@ arch_timer_detect_rate(void __iomem *cntbase, struct device_node *np)
>
> /* Check the timer frequency. */
> if (arch_timer_rate == 0)
> - pr_warn("Architected timer frequency not available\n");
> + pr_warn("frequency not available\n");
> }
>
> static void arch_timer_banner(unsigned type)
> {
> - pr_info("Architected %s%s%s timer(s) running at %lu.%02luMHz (%s%s%s).\n",
> - type & ARCH_CP15_TIMER ? "cp15" : "",
> - type == (ARCH_CP15_TIMER | ARCH_MEM_TIMER) ? " and " : "",
> - type & ARCH_MEM_TIMER ? "mmio" : "",
> - (unsigned long)arch_timer_rate / 1000000,
> - (unsigned long)(arch_timer_rate / 10000) % 100,
> - type & ARCH_CP15_TIMER ?
> - (arch_timer_uses_ppi == VIRT_PPI) ? "virt" : "phys" :
> - "",
> - type == (ARCH_CP15_TIMER | ARCH_MEM_TIMER) ? "/" : "",
> - type & ARCH_MEM_TIMER ?
> - arch_timer_mem_use_virtual ? "virt" : "phys" :
> - "");
> + pr_info("%s%s%s timer(s) running at %lu.%02luMHz (%s%s%s).\n",
> + type & ARCH_CP15_TIMER ? "cp15" : "",
> + type == (ARCH_CP15_TIMER | ARCH_MEM_TIMER) ? " and " : "",
> + type & ARCH_MEM_TIMER ? "mmio" : "",
> + (unsigned long)arch_timer_rate / 1000000,
> + (unsigned long)(arch_timer_rate / 10000) % 100,
> + type & ARCH_CP15_TIMER ?
> + (arch_timer_uses_ppi == VIRT_PPI) ? "virt" : "phys" :
> + "",
> + type == (ARCH_CP15_TIMER | ARCH_MEM_TIMER) ? "/" : "",
> + type & ARCH_MEM_TIMER ?
> + arch_timer_mem_use_virtual ? "virt" : "phys" :
> + "");
> }
>
> u32 arch_timer_get_rate(void)
> @@ -498,7 +501,7 @@ static void __init arch_counter_register(unsigned type)
>
> static void arch_timer_stop(struct clock_event_device *clk)
> {
> - pr_debug("arch_timer_teardown disable IRQ%d cpu #%d\n",
> + pr_debug("teardown, disable IRQ%d cpu #%d\n",
Not a problem of this patch, but arch_timer_teardown is a function
name? I can't find where it's defined...
I think we can leave arch_timer as it but update it to:
pr_debug("arch_timer_stop disable IRQ%d cpu #%d\n",
Others are look good to me.
Thanks
Hanjun
next prev parent reply other threads:[~2016-06-30 2:54 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 18:15 [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer fu.wei
2016-06-29 18:15 ` [PATCH v6 01/10] clocksource/drivers/arm_arch_timer: Move enums and defines to header file fu.wei
2016-06-29 18:15 ` [PATCH v6 02/10] clocksource/drivers/arm_arch_timer: Add a new enum for spi type fu.wei
2016-06-29 18:15 ` [PATCH v6 03/10] clocksource/drivers/arm_arch_timer: Improve printk relevant code fu.wei
2016-06-30 2:54 ` Hanjun Guo [this message]
2016-07-07 16:12 ` Fu Wei
2016-06-29 18:15 ` [PATCH v6 04/10] acpi: Add some basic struct and functions in GTDT driver fu.wei
2016-06-29 21:24 ` Rafael J. Wysocki
2016-06-30 1:17 ` Fu Wei
2016-06-30 1:26 ` Rafael J. Wysocki
2016-06-30 1:32 ` Fu Wei
2016-06-30 4:13 ` Timur Tabi
2016-06-29 18:15 ` [PATCH v6 05/10] acpi: Add arch_timer support in GTDT table parse driver fu.wei
2016-06-29 18:15 ` [PATCH v6 06/10] acpi: Add GTDT driver to kernel build system fu.wei
2016-06-29 18:15 ` [PATCH v6 07/10] clocksource/drivers/arm_arch_timer: Simplify ACPI support code fu.wei
2016-06-29 18:15 ` [PATCH v6 08/10] acpi: Add memory-mapped timer support in GTDT driver fu.wei
2016-06-29 18:15 ` [PATCH v6 09/10] clocksource/drivers/arm_arch_timer: Add GTDT support for memory-mapped timer fu.wei
2016-06-29 18:15 ` [PATCH v6 10/10] acpi: Add SBSA Generic Watchdog support in GTDT driver fu.wei
2016-06-29 21:32 ` [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer Rafael J. Wysocki
2016-06-30 1:29 ` Fu Wei
2016-06-30 1:37 ` Rafael J. Wysocki
2016-06-30 2:10 ` Hanjun Guo
2016-06-30 13:27 ` Rafael J. Wysocki
2016-06-30 13:48 ` Hanjun Guo
2016-07-01 15:23 ` Will Deacon
2016-07-01 21:04 ` Rafael J. Wysocki
2016-07-04 12:53 ` Rafael J. Wysocki
2016-07-05 14:18 ` Graeme Gregory
2016-07-06 0:00 ` Rafael J. Wysocki
2016-07-07 11:12 ` Hanjun Guo
2016-07-07 12:03 ` Rafael J. Wysocki
2016-07-07 13:40 ` Lorenzo Pieralisi
2016-07-07 13:58 ` Rafael J. Wysocki
2016-07-07 15:21 ` Fu Wei
2016-07-08 13:22 ` Lorenzo Pieralisi
2016-07-08 13:50 ` Sudeep Holla
2016-07-09 3:44 ` Hanjun Guo
2016-07-10 1:26 ` Rafael J. Wysocki
2016-07-09 3:00 ` Hanjun Guo
2016-07-01 14:00 ` Daniel Lezcano
2016-07-01 21:01 ` Rafael J. Wysocki
2016-07-04 13:43 ` Daniel Lezcano
2016-07-04 14:19 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c347a9d9-82b4-b469-4e64-6446e6282a19@linaro.org \
--to=hanjun.guo@linaro.org \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=al.stone@linaro.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=cov@codeaurora.org \
--cc=daniel.lezcano@linaro.org \
--cc=fu.wei@linaro.org \
--cc=graeme.gregory@linaro.org \
--cc=harba@codeaurora.org \
--cc=jcm@redhat.com \
--cc=lenb@kernel.org \
--cc=leo.duran@amd.com \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=rjw@rjwysocki.net \
--cc=rruigrok@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=timur@codeaurora.org \
--cc=wei@redhat.com \
--cc=will.deacon@arm.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).