From: "David E. Box" <david.e.box@linux.intel.com>
To: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org,
iommu@lists.linux-foundation.org, devel@acpica.org
Cc: linuxarm@huawei.com, lorenzo.pieralisi@arm.com, joro@8bytes.org,
robin.murphy@arm.com, wanghuiqiang@huawei.com,
jonathan.cameron@huawei.com
Subject: Re: [Devel] [RFC PATCH 2/4] ACPI/IORT: Add support for RMR node parsing
Date: Wed, 28 Oct 2020 11:43:48 -0700 [thread overview]
Message-ID: <d414a22fbae9575e6c04f4a557ae49a2cd8eac57.camel@linux.intel.com> (raw)
In-Reply-To: <20201027112646.44680-3-shameerali.kolothum.thodi@huawei.com>
Hi,
On Tue, 2020-10-27 at 11:26 +0000, Shameer Kolothum wrote:
...
> @@ -1647,6 +1667,100 @@ static void __init iort_enable_acs(struct
> acpi_iort_node *iort_node)
> #else
> static inline void iort_enable_acs(struct acpi_iort_node *iort_node)
> { }
> #endif
> +static int iort_rmr_desc_valid(struct acpi_iort_rmr_desc *desc)
> +{
> + struct iort_rmr_entry *e;
> + u64 end, start = desc->base_address, length = desc->length;
> +
> + if ((!IS_ALIGNED(start, SZ_64K)) || (length % SZ_64K != 0))
You could just do:
if ((!IS_ALIGNED(start, SZ_64K)) || (length % SZ_64K))
David
next prev parent reply other threads:[~2020-10-28 21:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 11:26 [RFC PATCH 0/4] ACPI/IORT: Support for IORT RMR node Shameer Kolothum
2020-10-27 11:26 ` [RFC PATCH 1/4] ACPICA: IORT: Update for revision E Shameer Kolothum
[not found] ` <BYAPR11MB3256AFF743B4FCC400F4181C87160@BYAPR11MB3256.namprd11.prod.outlook.com>
[not found] ` <610c14ef56d64fe087ca52aede07d811@huawei.com>
[not found] ` <MWHPR11MB1599988D7C857E3AFFA4A48AF0170@MWHPR11MB1599.namprd11.prod.outlook.com>
2020-10-28 18:40 ` [Devel] " Shameerali Kolothum Thodi
2020-10-27 11:26 ` [RFC PATCH 2/4] ACPI/IORT: Add support for RMR node parsing Shameer Kolothum
2020-10-28 18:43 ` David E. Box [this message]
2020-11-09 12:29 ` [Devel] " Sami Mujawar
2020-11-19 12:07 ` Shameerali Kolothum Thodi
2020-10-27 11:26 ` [RFC PATCH 3/4] ACPI/IORT: Add RMR memory regions reservation helper Shameer Kolothum
2020-11-05 18:03 ` Robin Murphy
2020-11-06 8:30 ` Shameerali Kolothum Thodi
2020-11-06 13:06 ` Robin Murphy
2020-11-06 16:00 ` Shameerali Kolothum Thodi
2020-10-27 11:26 ` [RFC PATCH 4/4] iommu/dma: Reserve any RMR regions associated with a dev Shameer Kolothum
2020-10-28 16:43 ` [RFC PATCH 0/4] ACPI/IORT: Support for IORT RMR node Steven Price
2020-10-28 18:24 ` Shameerali Kolothum Thodi
2020-11-06 15:22 ` Steven Price
2020-11-06 16:17 ` Shameerali Kolothum Thodi
2020-11-06 16:26 ` Steven Price
2020-11-06 17:09 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d414a22fbae9575e6c04f4a557ae49a2cd8eac57.camel@linux.intel.com \
--to=david.e.box@linux.intel.com \
--cc=devel@acpica.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jonathan.cameron@huawei.com \
--cc=joro@8bytes.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linuxarm@huawei.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=wanghuiqiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).