* [PATCH -next] arm64: gtdt: Fix section mismatch in next_platform_timer()
@ 2020-05-08 15:26 Kefeng Wang
2020-05-09 1:18 ` Hanjun Guo
0 siblings, 1 reply; 2+ messages in thread
From: Kefeng Wang @ 2020-05-08 15:26 UTC (permalink / raw)
To: Lorenzo Pieralisi, Hanjun Guo, Sudeep Holla, linux-acpi,
linux-arm-kernel
Cc: Kefeng Wang, Hulk Robot
Drop the __initdata for acpi_gtdt_desc variable to fix the section mismatch,
WARNING: modpost: vmlinux.o(.text.unlikely+0x95ac): Section mismatch in reference from the function next_platform_timer() to the variable .init.data:acpi_gtdt_desc
The function next_platform_timer() references
the variable __initdata acpi_gtdt_desc.
This is often because next_platform_timer lacks a __initdata
annotation or the annotation of acpi_gtdt_desc is wrong.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
drivers/acpi/arm64/gtdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c
index 01962c63a711..6a327616a299 100644
--- a/drivers/acpi/arm64/gtdt.c
+++ b/drivers/acpi/arm64/gtdt.c
@@ -34,7 +34,7 @@ struct acpi_gtdt_descriptor {
void *platform_timer;
};
-static struct acpi_gtdt_descriptor acpi_gtdt_desc __initdata;
+static struct acpi_gtdt_descriptor acpi_gtdt_desc;
static inline void *next_platform_timer(void *platform_timer)
{
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] arm64: gtdt: Fix section mismatch in next_platform_timer()
2020-05-08 15:26 [PATCH -next] arm64: gtdt: Fix section mismatch in next_platform_timer() Kefeng Wang
@ 2020-05-09 1:18 ` Hanjun Guo
0 siblings, 0 replies; 2+ messages in thread
From: Hanjun Guo @ 2020-05-09 1:18 UTC (permalink / raw)
To: Kefeng Wang, Lorenzo Pieralisi, Sudeep Holla, linux-acpi,
linux-arm-kernel
Cc: Hulk Robot
On 2020/5/8 23:26, Kefeng Wang wrote:
> Drop the __initdata for acpi_gtdt_desc variable to fix the section mismatch,
>
> WARNING: modpost: vmlinux.o(.text.unlikely+0x95ac): Section mismatch in reference from the function next_platform_timer() to the variable .init.data:acpi_gtdt_desc
> The function next_platform_timer() references
> the variable __initdata acpi_gtdt_desc.
> This is often because next_platform_timer lacks a __initdata
> annotation or the annotation of acpi_gtdt_desc is wrong.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> drivers/acpi/arm64/gtdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c
> index 01962c63a711..6a327616a299 100644
> --- a/drivers/acpi/arm64/gtdt.c
> +++ b/drivers/acpi/arm64/gtdt.c
> @@ -34,7 +34,7 @@ struct acpi_gtdt_descriptor {
> void *platform_timer;
> };
>
> -static struct acpi_gtdt_descriptor acpi_gtdt_desc __initdata;
> +static struct acpi_gtdt_descriptor acpi_gtdt_desc;
>
> static inline void *next_platform_timer(void *platform_timer)
I prefer to make this function as no inline, and make it
as __init function, becasue acpi_gtdt_desc is not used after
gtdt_sbsa_gwdt_init().
Thanks
Hanjun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-09 1:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-08 15:26 [PATCH -next] arm64: gtdt: Fix section mismatch in next_platform_timer() Kefeng Wang
2020-05-09 1:18 ` Hanjun Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).