* [PATCH 00/12] add missing of_node_put after of_device_is_available
@ 2019-02-23 13:20 Julia Lawall
2019-02-23 13:20 ` [PATCH 09/12] meson-gx-socinfo: " Julia Lawall
0 siblings, 1 reply; 4+ messages in thread
From: Julia Lawall @ 2019-02-23 13:20 UTC (permalink / raw)
To: linux-amlogic
Cc: linux-fbdev, linux-pm, kernel-janitors, linux-kernel, dri-devel,
linux-crypto, linux-tegra, linux-omap, linuxppc-dev,
linux-arm-kernel
Failure of of_device_is_available implies that the device node
should be put, if it is not used otherwise.
---
arch/arm/mach-omap2/display.c | 4 +++-
arch/powerpc/platforms/83xx/usb.c | 4 +++-
drivers/bus/arm-cci.c | 4 +++-
drivers/cpufreq/armada-8k-cpufreq.c | 4 +++-
drivers/crypto/amcc/crypto4xx_trng.c | 4 +++-
drivers/firmware/psci.c | 4 +++-
drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c | 4 +++-
drivers/gpu/drm/tegra/rgb.c | 4 +++-
drivers/phy/tegra/xusb.c | 4 +++-
drivers/soc/amlogic/meson-gx-socinfo.c | 4 +++-
drivers/tee/optee/core.c | 4 +++-
drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c | 4 +++-
12 files changed, 36 insertions(+), 12 deletions(-)
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 09/12] meson-gx-socinfo: add missing of_node_put after of_device_is_available
2019-02-23 13:20 [PATCH 00/12] add missing of_node_put after of_device_is_available Julia Lawall
@ 2019-02-23 13:20 ` Julia Lawall
2019-03-12 20:28 ` Kevin Hilman
2019-04-14 16:12 ` Markus Elfring
0 siblings, 2 replies; 4+ messages in thread
From: Julia Lawall @ 2019-02-23 13:20 UTC (permalink / raw)
To: Kevin Hilman
Cc: linux-amlogic, kernel-janitors, linux-kernel, linux-arm-kernel
Add an of_node_put when a tested device node is not available.
The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr):
// <smpl>
@@
identifier f;
local idexpression e;
expression x;
@@
e = f(...);
... when != of_node_put(e)
when != x = e
when != e = x
when any
if (<+...of_device_is_available(e)...+>) {
... when != of_node_put(e)
(
return e;
|
+ of_node_put(e);
return ...;
)
}
// </smpl>
Fixes: a9daaba2965e8 ("soc: Add Amlogic SoC Information driver")
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/soc/amlogic/meson-gx-socinfo.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff -u -p a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic/meson-gx-socinfo.c
--- a/drivers/soc/amlogic/meson-gx-socinfo.c
+++ b/drivers/soc/amlogic/meson-gx-socinfo.c
@@ -123,8 +123,10 @@ static int __init meson_gx_socinfo_init(
return -ENODEV;
/* check if interface is enabled */
- if (!of_device_is_available(np))
+ if (!of_device_is_available(np)) {
+ of_node_put(np);
return -ENODEV;
+ }
/* check if chip-id is available */
if (!of_property_read_bool(np, "amlogic,has-chip-id"))
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 09/12] meson-gx-socinfo: add missing of_node_put after of_device_is_available
2019-02-23 13:20 ` [PATCH 09/12] meson-gx-socinfo: " Julia Lawall
@ 2019-03-12 20:28 ` Kevin Hilman
2019-04-14 16:12 ` Markus Elfring
1 sibling, 0 replies; 4+ messages in thread
From: Kevin Hilman @ 2019-03-12 20:28 UTC (permalink / raw)
To: Julia Lawall
Cc: linux-amlogic, kernel-janitors, linux-kernel, linux-arm-kernel
Julia Lawall <Julia.Lawall@lip6.fr> writes:
> Add an of_node_put when a tested device node is not available.
[...]
]
> Fixes: a9daaba2965e8 ("soc: Add Amlogic SoC Information driver")
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Patch applied,
Thanks,
Kevin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 09/12] meson-gx-socinfo: add missing of_node_put after of_device_is_available
2019-02-23 13:20 ` [PATCH 09/12] meson-gx-socinfo: " Julia Lawall
2019-03-12 20:28 ` Kevin Hilman
@ 2019-04-14 16:12 ` Markus Elfring
1 sibling, 0 replies; 4+ messages in thread
From: Markus Elfring @ 2019-04-14 16:12 UTC (permalink / raw)
To: Julia Lawall, Kevin Hilman, linux-amlogic, linux-arm-kernel
Cc: kernel-janitors, linux-kernel
> @@ -123,8 +123,10 @@ static int __init meson_gx_socinfo_init(
> return -ENODEV;
>
> /* check if interface is enabled */
> - if (!of_device_is_available(np))
> + if (!of_device_is_available(np)) {
> + of_node_put(np);
> return -ENODEV;
> + }
>
> /* check if chip-id is available */
> if (!of_property_read_bool(np, "amlogic,has-chip-id"))
How do you think about to adjust the exception handling in this function
implementation a bit more according to the Linux coding style?
Regards,
Markus
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-14 16:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-23 13:20 [PATCH 00/12] add missing of_node_put after of_device_is_available Julia Lawall
2019-02-23 13:20 ` [PATCH 09/12] meson-gx-socinfo: " Julia Lawall
2019-03-12 20:28 ` Kevin Hilman
2019-04-14 16:12 ` Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).