linux-amlogic.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Otto Meier <gf435@gmx.net>
To: linux-amlogic@lists.infradead.org
Cc: martin.blumenstingl@googlemail.com, linux-gpio@vger.kernel.org,
	linus.walleij@linaro.org, khilman@baylibre.com
Subject: Re: [BUG] wrong pinning definition or uart_c in pinctrl-meson-gxbb.c
Date: Tue, 10 Sep 2019 18:01:41 +0200	[thread overview]
Message-ID: <1cc32a18-464d-5531-7a1c-084390e2ecb1@gmx.net> (raw)

Hi i tried to use the uart_C of the the odroid-c2.

I enabled it in the dts file. During boot it crashed when the
the sdcard slot is addressed.

After long search in the net i found this:

https://forum.odroid.com/viewtopic.php?f=139&t=25371&p=194370&hilit=uart_C#p177856

After changing the pin definitions accordingly erverything works.
Uart_c is functioning and sdcard ist working.


Fixes: 6db0f3a8a04e46 ("pinctrl: amlogic: gxbb: add more UART pins")
Signed-off-by: Otto Meiergf435@gmx.net
---


--- a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c 2019-08-26 
18:24:45.450089334 +0200
+++ b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c 2019-09-05 
13:07:38.518637214 +0200
@@ -192,8 +192,8 @@  static const unsigned int uart_rts_b_pin
  
  static const unsigned int uart_tx_c_pins[]     = { GPIOY_13 };
  static const unsigned int uart_rx_c_pins[]     = { GPIOY_14 };
-static const unsigned int uart_cts_c_pins[] = { GPIOX_11 };
-static const unsigned int uart_rts_c_pins[] = { GPIOX_12 };
+static const unsigned int uart_cts_c_pins[] = { GPIOY_11 };
+static const unsigned int uart_rts_c_pins[] = { GPIOY_12 };
  
  static const unsigned int i2c_sck_a_pins[]     = { GPIODV_25 };
  static const unsigned int i2c_sda_a_pins[]     = { GPIODV_24 };
@@ -439,10 +439,10 @@  static struct meson_pmx_group meson_gxbb
         GROUP(pwm_f_x,          3,      18),
  
         /* Bank Y */
- GROUP(uart_cts_c, 1, 19),
- GROUP(uart_rts_c, 1, 18),
- GROUP(uart_tx_c, 1, 17),
- GROUP(uart_rx_c, 1, 16),
+ GROUP(uart_cts_c, 1, 17),
+ GROUP(uart_rts_c, 1, 16),
+ GROUP(uart_tx_c, 1, 19),
+ GROUP(uart_rx_c, 1, 18),
         GROUP(pwm_a_y,          1,      21),
         GROUP(pwm_f_y,          1,      20),
         GROUP(i2s_out_ch23_y,   1,      5),






_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

             reply	other threads:[~2019-09-13 11:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-10 16:01 Otto Meier [this message]
2019-09-12  9:21 ` [BUG] wrong pinning definition or uart_c in pinctrl-meson-gxbb.c Linus Walleij
2019-09-12 10:02   ` Neil Armstrong
2019-09-14 17:25   ` Martin Blumenstingl
  -- strict thread matches above, loose matches on Subject: below --
2019-09-05 11:48 Otto Meier
2019-09-07 14:57 ` Martin Blumenstingl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1cc32a18-464d-5531-7a1c-084390e2ecb1@gmx.net \
    --to=gf435@gmx.net \
    --cc=khilman@baylibre.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).