archive mirror
 help / color / mirror / Atom feed
From: Martin Blumenstingl <>
To: Otto Meier <>
Subject: Re: [BUG] wrong pinning definition or uart_c in pinctrl-meson-gxbb.c
Date: Sat, 7 Sep 2019 16:57:45 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Otto,

On Thu, Sep 5, 2019 at 1:49 PM Otto Meier <> wrote:
> Hi i tried to use uart_C of the the odroid-c2.
> I enabled it int the dts file. During boot it crashed when the
> the sdcard slot is addressd.
> After long search in the net i found this:
thank you for doing research on this...

> After changing the pin definitios accordingly erverything works.
> Uart_c is functioning and sdcard ist working.
> Patch attached well as going the extra mile (writing a patch and submitting it)

your patch is looking good to me apart from some small formal issues:
- some typos in the commit message (int -> in, addressd -> addressed,
definitios -> definitions, ist -> is)
- please add the following line above your Signed-off-by line (to get
your fix also into -stable kernels): Fixes: 6db0f3a8a04e46 ("pinctrl:
amlogic: gxbb: add more UART pins")
- your "Signed-off-by" has to be in a specific format
- patches must be sent inline (not as attachment)
- the pinctrl maintainers are not Cc'ed (so they won't notice this patch)

here's a simplified version of the patch submission flow that I use:
- (change the code)
- git commit --signoff (give a good description why you are changing
things, include a Fixes line if appropriate)
- git format-patch HEAD~1
- run ./scripts/ 0001-*.patch (fix all checkpatch errors,
"git commit --amend" the changes, then run git format-patch again)
- find the email recipients with: ./scripts/ 0001-*.patch
- run: git send-email 0001-*.patch --to=<maintainer or mailing list
email> --to=<another maintainer mailing list or email> --cc=<more
mailing lists...>

feel free to ask if you have any questions

I'm looking forward to an updated  patch!

linux-amlogic mailing list

  reply	other threads:[~2019-09-07 14:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-05 11:48 [BUG] wrong pinning definition or uart_c in pinctrl-meson-gxbb.c Otto Meier
2019-09-07 14:57 ` Martin Blumenstingl [this message]
2019-09-10 16:01 Otto Meier
2019-09-12  9:21 ` Linus Walleij
2019-09-12 10:02   ` Neil Armstrong
2019-09-14 17:25   ` Martin Blumenstingl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).