Linux-Amlogic Archive on lore.kernel.org
 help / color / Atom feed
From: Jerome Brunet <jbrunet@baylibre.com>
To: Anand Moon <linux.amoon@gmail.com>
Cc: devicetree <devicetree@vger.kernel.org>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-amlogic@lists.infradead.org,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v1 0/3] Add missing ethernet reset ID for Amlogic SoC
Date: Thu, 30 Jul 2020 15:55:14 +0200
Message-ID: <1jbljx85vh.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <CANAwSgSnqHL=gxsEmTxrDitmowtwuM8cwPG9SD7cbpoShEd1EA@mail.gmail.com>


On Thu 30 Jul 2020 at 15:46, Anand Moon <linux.amoon@gmail.com> wrote:

> Hi Jerome
>
> On Thu, 30 Jul 2020 at 17:44, Jerome Brunet <jbrunet@baylibre.com> wrote:
>>
>>
>> On Thu 30 Jul 2020 at 13:57, Jerome Brunet <jbrunet@baylibre.com> wrote:
>>
>> > On Thu 30 Jul 2020 at 12:02, Anand Moon <linux.amoon@gmail.com> wrote:
>> >
>> >> These patch fix the Ethernet issue on Odroid C2 & Odroid N2
>> >> Some time Ethernet interface come up but no DHCP request
>> >> is forwaded to the Router, this happens quite offern on
>> >> my side. Adding Reset controller to ethernet node FIx the
>> >> inilization issue.
>> >>
>> >
>> > I'm seeing this on other device as well. Strange that it pops up only
>> > now. Change tested on S905x, seems to help.
>>
>> Strike that one - still seeing random DHCP issue on boot with this
>> applied
>>
>> >
>> >> -Anand
>> >>
>> >> Anand Moon (3):
>> >>   arm64: dts: amlogic: meson-gx: add missing ethernet reset ID
>> >>   arm64: dts: amlogic: meson-axg: add missing ethernet reset ID
>> >>   arm64: dts: amlogic: meson-g12: add missing ethernet reset ID
>> >
>> > None of the patches apply, please rebase on kevin's dt64 branch.
>> >
>> > With that, you can add
>> >
>> > Tested-by: Jerome Brunet <jbrunet@baylibre.com>
>>
> So I have to drop the Tested-by  ?

Yes

>
>> So still worth rebasing and applying on I suppose but I don't think it
>> solves the problem as described in this cover letter.
>>
>
> I have a mac address mapped to the ip address on my router,
> So I am just testing with the latest u-boot-2000.07 on my boards.
> Usually the ethernet comes up with no packet getting forwarded,
> Even ping to the device is not working, which is what I observed at
> my end many times.

This is not the use case descibed in the cover letter. Please clarify if
you resubmit.

>
> I will try to rebase on top of Kevin's v5.9/dt64 if needed.

If you intend on submitting the series again, rebasing is necessary.

> Please let me know.
>
> -Anand


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-30 10:02 Anand Moon
2020-07-30 10:02 ` [PATCH v1 1/3] arm64: dts: amlogic: meson-gx: add missing ethernet reset ID Anand Moon
2020-07-30 10:02 ` [PATCH v1 2/3] arm64: dts: amlogic: meson-axg: " Anand Moon
2020-07-30 10:02 ` [PATCH v1 3/3] arm64: dts: amlogic: meson-g12: " Anand Moon
2020-07-30 11:57 ` [PATCH v1 0/3] Add missing ethernet reset ID for Amlogic SoC Jerome Brunet
2020-07-30 12:14   ` Jerome Brunet
2020-07-30 13:46     ` Anand Moon
2020-07-30 13:55       ` Jerome Brunet [this message]
2020-07-30 18:04         ` Anand Moon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1jbljx85vh.fsf@starbuckisacylon.baylibre.com \
    --to=jbrunet@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux.amoon@gmail.com \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=narmstrong@baylibre.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Amlogic Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-amlogic/0 linux-amlogic/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-amlogic linux-amlogic/ https://lore.kernel.org/linux-amlogic \
		linux-amlogic@lists.infradead.org
	public-inbox-index linux-amlogic

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-amlogic


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git