* [PATCH v2 05/14] spi: spi-meson-spifc: Fix misdocumenting of 'dev' in 'struct meson_spifc' [not found] <20200717135424.2442271-1-lee.jones@linaro.org> @ 2020-07-17 13:54 ` Lee Jones 2020-07-21 8:00 ` Neil Armstrong 2020-07-17 13:54 ` [PATCH v2 06/14] spi: spi-meson-spicc: Remove set but never used variable 'data' from meson_spicc_reset_fifo() Lee Jones 1 sibling, 1 reply; 4+ messages in thread From: Lee Jones @ 2020-07-17 13:54 UTC (permalink / raw) To: broonie Cc: Kevin Hilman, linux-kernel, linux-spi, Beniamino Galvani, linux-amlogic, Lee Jones, linux-arm-kernel Fixes the following W=1 kernel build warning(s): drivers/spi/spi-meson-spifc.c:80: warning: Function parameter or member 'dev' not described in 'meson_spifc' Cc: Kevin Hilman <khilman@baylibre.com> Cc: Beniamino Galvani <b.galvani@gmail.com> Cc: linux-amlogic@lists.infradead.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/spi/spi-meson-spifc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-meson-spifc.c b/drivers/spi/spi-meson-spifc.c index c7b0399802913..8eca6f24cb799 100644 --- a/drivers/spi/spi-meson-spifc.c +++ b/drivers/spi/spi-meson-spifc.c @@ -70,7 +70,7 @@ * @master: the SPI master * @regmap: regmap for device registers * @clk: input clock of the built-in baud rate generator - * @device: the device structure + * @dev: the device structure */ struct meson_spifc { struct spi_master *master; -- 2.25.1 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 05/14] spi: spi-meson-spifc: Fix misdocumenting of 'dev' in 'struct meson_spifc' 2020-07-17 13:54 ` [PATCH v2 05/14] spi: spi-meson-spifc: Fix misdocumenting of 'dev' in 'struct meson_spifc' Lee Jones @ 2020-07-21 8:00 ` Neil Armstrong 0 siblings, 0 replies; 4+ messages in thread From: Neil Armstrong @ 2020-07-21 8:00 UTC (permalink / raw) To: Lee Jones, broonie Cc: Kevin Hilman, linux-kernel, linux-spi, Beniamino Galvani, linux-amlogic, linux-arm-kernel On 17/07/2020 15:54, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/spi/spi-meson-spifc.c:80: warning: Function parameter or member 'dev' not described in 'meson_spifc' > > Cc: Kevin Hilman <khilman@baylibre.com> > Cc: Beniamino Galvani <b.galvani@gmail.com> > Cc: linux-amlogic@lists.infradead.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/spi/spi-meson-spifc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-meson-spifc.c b/drivers/spi/spi-meson-spifc.c > index c7b0399802913..8eca6f24cb799 100644 > --- a/drivers/spi/spi-meson-spifc.c > +++ b/drivers/spi/spi-meson-spifc.c > @@ -70,7 +70,7 @@ > * @master: the SPI master > * @regmap: regmap for device registers > * @clk: input clock of the built-in baud rate generator > - * @device: the device structure > + * @dev: the device structure > */ > struct meson_spifc { > struct spi_master *master; > Acked-by: Neil Armstrong <narmstrong@baylibre.com> _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 06/14] spi: spi-meson-spicc: Remove set but never used variable 'data' from meson_spicc_reset_fifo() [not found] <20200717135424.2442271-1-lee.jones@linaro.org> 2020-07-17 13:54 ` [PATCH v2 05/14] spi: spi-meson-spifc: Fix misdocumenting of 'dev' in 'struct meson_spifc' Lee Jones @ 2020-07-17 13:54 ` Lee Jones 2020-07-21 8:01 ` Neil Armstrong 1 sibling, 1 reply; 4+ messages in thread From: Lee Jones @ 2020-07-17 13:54 UTC (permalink / raw) To: broonie Cc: Neil Armstrong, Kevin Hilman, linux-kernel, linux-spi, linux-amlogic, Lee Jones, linux-arm-kernel Looks like it hasn't ever been checked. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-meson-spicc.c: In function ‘meson_spicc_reset_fifo’: drivers/spi/spi-meson-spicc.c:365:6: warning: variable ‘data’ set but not used [-Wunused-but-set-variable] 365 | u32 data; | ^~~~ Cc: Kevin Hilman <khilman@baylibre.com> Cc: Neil Armstrong <narmstrong@baylibre.com> Cc: linux-amlogic@lists.infradead.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/spi/spi-meson-spicc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/spi/spi-meson-spicc.c b/drivers/spi/spi-meson-spicc.c index 77f7d0e0e46ad..ecba6b4a5d85d 100644 --- a/drivers/spi/spi-meson-spicc.c +++ b/drivers/spi/spi-meson-spicc.c @@ -362,8 +362,6 @@ static void meson_spicc_setup_xfer(struct meson_spicc_device *spicc, static void meson_spicc_reset_fifo(struct meson_spicc_device *spicc) { - u32 data; - if (spicc->data->has_oen) writel_bits_relaxed(SPICC_ENH_MAIN_CLK_AO, SPICC_ENH_MAIN_CLK_AO, @@ -373,7 +371,7 @@ static void meson_spicc_reset_fifo(struct meson_spicc_device *spicc) spicc->base + SPICC_TESTREG); while (meson_spicc_rxready(spicc)) - data = readl_relaxed(spicc->base + SPICC_RXDATA); + readl_relaxed(spicc->base + SPICC_RXDATA); if (spicc->data->has_oen) writel_bits_relaxed(SPICC_ENH_MAIN_CLK_AO, 0, -- 2.25.1 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 06/14] spi: spi-meson-spicc: Remove set but never used variable 'data' from meson_spicc_reset_fifo() 2020-07-17 13:54 ` [PATCH v2 06/14] spi: spi-meson-spicc: Remove set but never used variable 'data' from meson_spicc_reset_fifo() Lee Jones @ 2020-07-21 8:01 ` Neil Armstrong 0 siblings, 0 replies; 4+ messages in thread From: Neil Armstrong @ 2020-07-21 8:01 UTC (permalink / raw) To: Lee Jones, broonie Cc: Kevin Hilman, linux-amlogic, linux-kernel, linux-arm-kernel, linux-spi On 17/07/2020 15:54, Lee Jones wrote: > Looks like it hasn't ever been checked. > > Fixes the following W=1 kernel build warning(s): > > drivers/spi/spi-meson-spicc.c: In function ‘meson_spicc_reset_fifo’: > drivers/spi/spi-meson-spicc.c:365:6: warning: variable ‘data’ set but not used [-Wunused-but-set-variable] > 365 | u32 data; > | ^~~~ > > Cc: Kevin Hilman <khilman@baylibre.com> > Cc: Neil Armstrong <narmstrong@baylibre.com> > Cc: linux-amlogic@lists.infradead.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/spi/spi-meson-spicc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/spi/spi-meson-spicc.c b/drivers/spi/spi-meson-spicc.c > index 77f7d0e0e46ad..ecba6b4a5d85d 100644 > --- a/drivers/spi/spi-meson-spicc.c > +++ b/drivers/spi/spi-meson-spicc.c > @@ -362,8 +362,6 @@ static void meson_spicc_setup_xfer(struct meson_spicc_device *spicc, > > static void meson_spicc_reset_fifo(struct meson_spicc_device *spicc) > { > - u32 data; > - > if (spicc->data->has_oen) > writel_bits_relaxed(SPICC_ENH_MAIN_CLK_AO, > SPICC_ENH_MAIN_CLK_AO, > @@ -373,7 +371,7 @@ static void meson_spicc_reset_fifo(struct meson_spicc_device *spicc) > spicc->base + SPICC_TESTREG); > > while (meson_spicc_rxready(spicc)) > - data = readl_relaxed(spicc->base + SPICC_RXDATA); > + readl_relaxed(spicc->base + SPICC_RXDATA); > > if (spicc->data->has_oen) > writel_bits_relaxed(SPICC_ENH_MAIN_CLK_AO, 0, > Acked-by: Neil Armstrong <narmstrong@baylibre.com> _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-21 8:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200717135424.2442271-1-lee.jones@linaro.org>
2020-07-17 13:54 ` [PATCH v2 05/14] spi: spi-meson-spifc: Fix misdocumenting of 'dev' in 'struct meson_spifc' Lee Jones
2020-07-21 8:00 ` Neil Armstrong
2020-07-17 13:54 ` [PATCH v2 06/14] spi: spi-meson-spicc: Remove set but never used variable 'data' from meson_spicc_reset_fifo() Lee Jones
2020-07-21 8:01 ` Neil Armstrong
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).