Linux-Amlogic Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 00/10] Remove surplus dev_err() when handing an error from platform_get_irq()
@ 2020-08-02 14:25 Krzysztof Wilczyński
  2020-08-02 14:25 ` [PATCH 01/10] PCI: dwc: Remove " Krzysztof Wilczyński
                   ` (10 more replies)
  0 siblings, 11 replies; 16+ messages in thread
From: Krzysztof Wilczyński @ 2020-08-02 14:25 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: Heiko Stuebner, linux-pci, Shawn Lin, Binghui Wang,
	linux-arm-kernel, Ley Foon Tan, Thomas Petazzoni, Toan Le,
	Jesper Nilsson, linux-samsung-soc, Kevin Hilman, Pratyush Anand,
	Krzysztof Kozlowski, linux-rockchip, Kukjin Kim, Xiaowei Song,
	Hou Zhiqiang, Linus Walleij, Richard Zhu, Sascha Hauer, Yue Wang,
	Murali Karicheri, linux-tegra, linux-amlogic, linux-omap,
	linux-arm-kernel, Jingoo Han, rfi, Shawn Guo, Lucas Stach

At the moment a lot of error handling code would print a duplicated
error message should either the platform_get_irq() or
platform_get_irq_byname() function fails to obtain an IRQ for a device.

There is no need to call the dev_err() function directly to print
a custom message when handling an error from either of these functions
as both are going to display an appropriate error message in case of
a failure.

This series aims to remove surplus call to dev_err() when handing an
error originating from either platform_get_irq() or
platform_get_irq_byname() function as per suggestion from Coccinelle.

Related commits are commit 7723f4c5ecdb ("driver core: platform: Add an
error message to platform_get_irq*()") and commit 98051ba2b28b
("coccinelle: Add script to check for platform_get_irq() excessive
prints").

Krzysztof Wilczyński (10):
  PCI: dwc: Remove dev_err() when handing an error from
    platform_get_irq()
  PCI: mobiveil: Remove dev_err() when handing an error from
    platform_get_irq()
  PCI: tegra: Remove dev_err() when handing an error from
    platform_get_irq()
  PCI: altera: Remove dev_err() when handing an error from
    platform_get_irq()
  PCI: host-generic: Remove dev_err() when handing an error from
    platform_get_irq()
  PCI: v3-semi: Remove dev_err() when handing an error from
    platform_get_irq()
  PCI: altera-msi: Remove dev_err() when handing an error from
    platform_get_irq()
  PCI: xgene-msi: Remove dev_err() when handing an error from
    platform_get_irq()
  PCI: rockchip: Remove dev_err() when handing an error from
    platform_get_irq()
  PCI: xilinx-nwl: Remove dev_err() when handing an error from
    platform_get_irq()

 drivers/pci/controller/dwc/pci-dra7xx.c              |  8 ++------
 drivers/pci/controller/dwc/pci-exynos.c              |  9 +++------
 drivers/pci/controller/dwc/pci-imx6.c                |  4 +---
 drivers/pci/controller/dwc/pci-keystone.c            |  4 +---
 drivers/pci/controller/dwc/pci-meson.c               |  4 +---
 drivers/pci/controller/dwc/pcie-armada8k.c           |  4 +---
 drivers/pci/controller/dwc/pcie-artpec6.c            |  4 +---
 drivers/pci/controller/dwc/pcie-histb.c              |  4 +---
 drivers/pci/controller/dwc/pcie-kirin.c              |  5 +----
 drivers/pci/controller/dwc/pcie-spear13xx.c          |  5 ++---
 drivers/pci/controller/dwc/pcie-tegra194.c           |  4 +---
 .../pci/controller/mobiveil/pcie-layerscape-gen4.c   |  5 ++---
 drivers/pci/controller/mobiveil/pcie-mobiveil-host.c |  4 +---
 drivers/pci/controller/pci-tegra.c                   |  8 ++------
 drivers/pci/controller/pci-v3-semi.c                 |  5 ++---
 drivers/pci/controller/pci-xgene-msi.c               |  2 --
 drivers/pci/controller/pcie-altera-msi.c             |  1 -
 drivers/pci/controller/pcie-altera.c                 |  4 +---
 drivers/pci/controller/pcie-rockchip-host.c          | 12 +++---------
 drivers/pci/controller/pcie-tango.c                  |  4 +---
 drivers/pci/controller/pcie-xilinx-nwl.c             | 11 ++---------
 21 files changed, 29 insertions(+), 82 deletions(-)

-- 
2.27.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH 01/10] PCI: dwc: Remove dev_err() when handing an error from platform_get_irq()
  2020-08-02 14:25 [PATCH 00/10] Remove surplus dev_err() when handing an error from platform_get_irq() Krzysztof Wilczyński
@ 2020-08-02 14:25 ` Krzysztof Wilczyński
  2020-08-03  7:16   ` Jesper Nilsson
  2020-08-02 14:25 ` [PATCH 02/10] PCI: mobiveil: " Krzysztof Wilczyński
                   ` (9 subsequent siblings)
  10 siblings, 1 reply; 16+ messages in thread
From: Krzysztof Wilczyński @ 2020-08-02 14:25 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: Heiko Stuebner, linux-pci, Shawn Lin, Binghui Wang,
	linux-arm-kernel, Ley Foon Tan, Thomas Petazzoni, Toan Le,
	Jesper Nilsson, linux-samsung-soc, Kevin Hilman, Pratyush Anand,
	Krzysztof Kozlowski, linux-rockchip, Kukjin Kim, Xiaowei Song,
	Hou Zhiqiang, Linus Walleij, Richard Zhu, Sascha Hauer, Yue Wang,
	Murali Karicheri, linux-tegra, linux-amlogic, linux-omap,
	linux-arm-kernel, Jingoo Han, rfi, Shawn Guo, Lucas Stach

There is no need to call the dev_err() function directly to print a
custom message when handling an error from either the platform_get_irq()
or platform_get_irq_byname() functions as both are going to display an
appropriate error message in case of a failure.

This change is as per suggestion from Coccinelle:

  drivers/pci/controller/dwc/pcie-armada8k.c:252:2-9: line 252 is
  redundant because platform_get_irq() already prints an error

  drivers/pci/controller/dwc/pcie-kirin.c:459:3-10: line 459 is
  redundant because platform_get_irq() already prints an error

  drivers/pci/controller/dwc/pci-imx6.c:872:3-10: line 872 is redundant
  because platform_get_irq() already prints an error

  drivers/pci/controller/dwc/pcie-artpec6.c:391:3-10: line 391 is
  redundant because platform_get_irq() already prints an error

  drivers/pci/controller/dwc/pcie-spear13xx.c:202:2-9: line 202 is
  redundant because platform_get_irq() already prints an error

  drivers/pci/controller/dwc/pci-keystone.c:1254:2-9: line 1254 is
  redundant because platform_get_irq() already prints an error

  drivers/pci/controller/dwc/pci-exynos.c:406:2-9: line 406 is redundant
  because platform_get_irq() already prints an error

  drivers/pci/controller/dwc/pci-exynos.c:419:3-10: line 419 is
  redundant because platform_get_irq() already prints an error

  drivers/pci/controller/dwc/pcie-tegra194.c:2193:2-9: line 2193 is
  redundant because platform_get_irq() already prints an error

  drivers/pci/controller/dwc/pcie-histb.c:406:3-10: line 406 is
  redundant because platform_get_irq() already prints an error

  drivers/pci/controller/dwc/pci-meson.c:492:3-10: line 492 is redundant
  because platform_get_irq() already prints an error

  drivers/pci/controller/dwc/pci-dra7xx.c:633:2-9: line 633 is redundant
  because platform_get_irq() already prints an error

  drivers/pci/controller/dwc/pci-dra7xx.c:875:2-9: line 875 is redundant
  because platform_get_irq() already prints an error

Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
---
 drivers/pci/controller/dwc/pci-dra7xx.c     | 8 ++------
 drivers/pci/controller/dwc/pci-exynos.c     | 9 +++------
 drivers/pci/controller/dwc/pci-imx6.c       | 4 +---
 drivers/pci/controller/dwc/pci-keystone.c   | 4 +---
 drivers/pci/controller/dwc/pci-meson.c      | 4 +---
 drivers/pci/controller/dwc/pcie-armada8k.c  | 4 +---
 drivers/pci/controller/dwc/pcie-artpec6.c   | 4 +---
 drivers/pci/controller/dwc/pcie-histb.c     | 4 +---
 drivers/pci/controller/dwc/pcie-kirin.c     | 5 +----
 drivers/pci/controller/dwc/pcie-spear13xx.c | 5 ++---
 drivers/pci/controller/dwc/pcie-tegra194.c  | 4 +---
 11 files changed, 15 insertions(+), 40 deletions(-)

diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c
index 6184ebc9392d..66465dd69858 100644
--- a/drivers/pci/controller/dwc/pci-dra7xx.c
+++ b/drivers/pci/controller/dwc/pci-dra7xx.c
@@ -629,10 +629,8 @@ static int __init dra7xx_add_pcie_port(struct dra7xx_pcie *dra7xx,
 	struct resource *res;
 
 	pp->irq = platform_get_irq(pdev, 1);
-	if (pp->irq < 0) {
-		dev_err(dev, "missing IRQ resource\n");
+	if (pp->irq < 0)
 		return pp->irq;
-	}
 
 	ret = dra7xx_pcie_init_irq_domain(pp);
 	if (ret < 0)
@@ -871,10 +869,8 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev)
 	pci->ops = &dw_pcie_ops;
 
 	irq = platform_get_irq(pdev, 0);
-	if (irq < 0) {
-		dev_err(dev, "missing IRQ resource: %d\n", irq);
+	if (irq < 0)
 		return irq;
-	}
 
 	base = devm_platform_ioremap_resource_byname(pdev, "ti_conf");
 	if (IS_ERR(base))
diff --git a/drivers/pci/controller/dwc/pci-exynos.c b/drivers/pci/controller/dwc/pci-exynos.c
index c5043d951e80..f721fddc521e 100644
--- a/drivers/pci/controller/dwc/pci-exynos.c
+++ b/drivers/pci/controller/dwc/pci-exynos.c
@@ -402,10 +402,9 @@ static int __init exynos_add_pcie_port(struct exynos_pcie *ep,
 	int ret;
 
 	pp->irq = platform_get_irq(pdev, 1);
-	if (pp->irq < 0) {
-		dev_err(dev, "failed to get irq\n");
+	if (pp->irq < 0)
 		return pp->irq;
-	}
+
 	ret = devm_request_irq(dev, pp->irq, exynos_pcie_irq_handler,
 				IRQF_SHARED, "exynos-pcie", ep);
 	if (ret) {
@@ -415,10 +414,8 @@ static int __init exynos_add_pcie_port(struct exynos_pcie *ep,
 
 	if (IS_ENABLED(CONFIG_PCI_MSI)) {
 		pp->msi_irq = platform_get_irq(pdev, 0);
-		if (pp->msi_irq < 0) {
-			dev_err(dev, "failed to get msi irq\n");
+		if (pp->msi_irq < 0)
 			return pp->msi_irq;
-		}
 	}
 
 	pp->ops = &exynos_pcie_host_ops;
diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
index 8f08ae53f53e..aba0a1514a86 100644
--- a/drivers/pci/controller/dwc/pci-imx6.c
+++ b/drivers/pci/controller/dwc/pci-imx6.c
@@ -868,10 +868,8 @@ static int imx6_add_pcie_port(struct imx6_pcie *imx6_pcie,
 
 	if (IS_ENABLED(CONFIG_PCI_MSI)) {
 		pp->msi_irq = platform_get_irq_byname(pdev, "msi");
-		if (pp->msi_irq < 0) {
-			dev_err(dev, "failed to get MSI irq\n");
+		if (pp->msi_irq < 0)
 			return pp->msi_irq;
-		}
 	}
 
 	pp->ops = &imx6_pcie_host_ops;
diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c
index 790679fdfa48..99df9aeece1f 100644
--- a/drivers/pci/controller/dwc/pci-keystone.c
+++ b/drivers/pci/controller/dwc/pci-keystone.c
@@ -1250,10 +1250,8 @@ static int __init ks_pcie_probe(struct platform_device *pdev)
 	pci->version = version;
 
 	irq = platform_get_irq(pdev, 0);
-	if (irq < 0) {
-		dev_err(dev, "missing IRQ resource: %d\n", irq);
+	if (irq < 0)
 		return irq;
-	}
 
 	ret = request_irq(irq, ks_pcie_err_irq_handler, IRQF_SHARED,
 			  "ks-pcie-error-irq", ks_pcie);
diff --git a/drivers/pci/controller/dwc/pci-meson.c b/drivers/pci/controller/dwc/pci-meson.c
index ca59ba9e0ecd..4f183b96afbb 100644
--- a/drivers/pci/controller/dwc/pci-meson.c
+++ b/drivers/pci/controller/dwc/pci-meson.c
@@ -488,10 +488,8 @@ static int meson_add_pcie_port(struct meson_pcie *mp,
 
 	if (IS_ENABLED(CONFIG_PCI_MSI)) {
 		pp->msi_irq = platform_get_irq(pdev, 0);
-		if (pp->msi_irq < 0) {
-			dev_err(dev, "failed to get MSI IRQ\n");
+		if (pp->msi_irq < 0)
 			return pp->msi_irq;
-		}
 	}
 
 	pp->ops = &meson_pcie_host_ops;
diff --git a/drivers/pci/controller/dwc/pcie-armada8k.c b/drivers/pci/controller/dwc/pcie-armada8k.c
index 49596547e8c2..66ec21cd9487 100644
--- a/drivers/pci/controller/dwc/pcie-armada8k.c
+++ b/drivers/pci/controller/dwc/pcie-armada8k.c
@@ -248,10 +248,8 @@ static int armada8k_add_pcie_port(struct armada8k_pcie *pcie,
 	pp->ops = &armada8k_pcie_host_ops;
 
 	pp->irq = platform_get_irq(pdev, 0);
-	if (pp->irq < 0) {
-		dev_err(dev, "failed to get irq for port\n");
+	if (pp->irq < 0)
 		return pp->irq;
-	}
 
 	ret = devm_request_irq(dev, pp->irq, armada8k_pcie_irq_handler,
 			       IRQF_SHARED, "armada8k-pcie", pcie);
diff --git a/drivers/pci/controller/dwc/pcie-artpec6.c b/drivers/pci/controller/dwc/pcie-artpec6.c
index 28d5a1095200..d429bd2b2406 100644
--- a/drivers/pci/controller/dwc/pcie-artpec6.c
+++ b/drivers/pci/controller/dwc/pcie-artpec6.c
@@ -387,10 +387,8 @@ static int artpec6_add_pcie_port(struct artpec6_pcie *artpec6_pcie,
 
 	if (IS_ENABLED(CONFIG_PCI_MSI)) {
 		pp->msi_irq = platform_get_irq_byname(pdev, "msi");
-		if (pp->msi_irq < 0) {
-			dev_err(dev, "failed to get MSI irq\n");
+		if (pp->msi_irq < 0)
 			return pp->msi_irq;
-		}
 	}
 
 	pp->ops = &artpec6_pcie_host_ops;
diff --git a/drivers/pci/controller/dwc/pcie-histb.c b/drivers/pci/controller/dwc/pcie-histb.c
index 811b5c6d62ea..006437eadc31 100644
--- a/drivers/pci/controller/dwc/pcie-histb.c
+++ b/drivers/pci/controller/dwc/pcie-histb.c
@@ -402,10 +402,8 @@ static int histb_pcie_probe(struct platform_device *pdev)
 
 	if (IS_ENABLED(CONFIG_PCI_MSI)) {
 		pp->msi_irq = platform_get_irq_byname(pdev, "msi");
-		if (pp->msi_irq < 0) {
-			dev_err(dev, "Failed to get MSI IRQ\n");
+		if (pp->msi_irq < 0)
 			return pp->msi_irq;
-		}
 	}
 
 	hipcie->phy = devm_phy_get(dev, "phy");
diff --git a/drivers/pci/controller/dwc/pcie-kirin.c b/drivers/pci/controller/dwc/pcie-kirin.c
index c19617a912bd..2e0181ce6895 100644
--- a/drivers/pci/controller/dwc/pcie-kirin.c
+++ b/drivers/pci/controller/dwc/pcie-kirin.c
@@ -455,11 +455,8 @@ static int kirin_pcie_add_msi(struct dw_pcie *pci,
 
 	if (IS_ENABLED(CONFIG_PCI_MSI)) {
 		irq = platform_get_irq(pdev, 0);
-		if (irq < 0) {
-			dev_err(&pdev->dev,
-				"failed to get MSI IRQ (%d)\n", irq);
+		if (irq < 0)
 			return irq;
-		}
 
 		pci->pp.msi_irq = irq;
 	}
diff --git a/drivers/pci/controller/dwc/pcie-spear13xx.c b/drivers/pci/controller/dwc/pcie-spear13xx.c
index 7d0cdfd8138b..ad5d08d19926 100644
--- a/drivers/pci/controller/dwc/pcie-spear13xx.c
+++ b/drivers/pci/controller/dwc/pcie-spear13xx.c
@@ -198,10 +198,9 @@ static int spear13xx_add_pcie_port(struct spear13xx_pcie *spear13xx_pcie,
 	int ret;
 
 	pp->irq = platform_get_irq(pdev, 0);
-	if (pp->irq < 0) {
-		dev_err(dev, "failed to get irq\n");
+	if (pp->irq < 0)
 		return pp->irq;
-	}
+
 	ret = devm_request_irq(dev, pp->irq, spear13xx_pcie_irq_handler,
 			       IRQF_SHARED | IRQF_NO_THREAD,
 			       "spear1340-pcie", spear13xx_pcie);
diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
index 92b77f7d8354..70498689d0c0 100644
--- a/drivers/pci/controller/dwc/pcie-tegra194.c
+++ b/drivers/pci/controller/dwc/pcie-tegra194.c
@@ -2189,10 +2189,8 @@ static int tegra_pcie_dw_probe(struct platform_device *pdev)
 	}
 
 	pp->irq = platform_get_irq_byname(pdev, "intr");
-	if (pp->irq < 0) {
-		dev_err(dev, "Failed to get \"intr\" interrupt\n");
+	if (pp->irq < 0)
 		return pp->irq;
-	}
 
 	pcie->bpmp = tegra_bpmp_get(dev);
 	if (IS_ERR(pcie->bpmp))
-- 
2.27.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH 02/10] PCI: mobiveil: Remove dev_err() when handing an error from platform_get_irq()
  2020-08-02 14:25 [PATCH 00/10] Remove surplus dev_err() when handing an error from platform_get_irq() Krzysztof Wilczyński
  2020-08-02 14:25 ` [PATCH 01/10] PCI: dwc: Remove " Krzysztof Wilczyński
@ 2020-08-02 14:25 ` Krzysztof Wilczyński
  2020-08-02 14:25 ` [PATCH 03/10] PCI: tegra: " Krzysztof Wilczyński
                   ` (8 subsequent siblings)
  10 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Wilczyński @ 2020-08-02 14:25 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: Heiko Stuebner, linux-pci, Shawn Lin, Binghui Wang,
	linux-arm-kernel, Ley Foon Tan, Thomas Petazzoni, Toan Le,
	Jesper Nilsson, linux-samsung-soc, Kevin Hilman, Pratyush Anand,
	Krzysztof Kozlowski, linux-rockchip, Kukjin Kim, Xiaowei Song,
	Hou Zhiqiang, Linus Walleij, Richard Zhu, Sascha Hauer, Yue Wang,
	Murali Karicheri, linux-tegra, linux-amlogic, linux-omap,
	linux-arm-kernel, Jingoo Han, rfi, Shawn Guo, Lucas Stach

There is no need to call the dev_err() function directly to print a
custom message when handling an error from either the platform_get_irq()
or platform_get_irq_byname() functions as both are going to display an
appropriate error message in case of a failure.

This change is as per suggestion from Coccinelle:

  drivers/pci/controller/mobiveil/pcie-layerscape-gen4.c:174:2-9: line
  174 is redundant because platform_get_irq() already prints an error

  drivers/pci/controller/mobiveil/pcie-mobiveil-host.c:526:2-9: line 526
  is redundant because platform_get_irq() already prints an error

Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
---
 drivers/pci/controller/mobiveil/pcie-layerscape-gen4.c | 5 ++---
 drivers/pci/controller/mobiveil/pcie-mobiveil-host.c   | 4 +---
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/pci/controller/mobiveil/pcie-layerscape-gen4.c b/drivers/pci/controller/mobiveil/pcie-layerscape-gen4.c
index a6d2190a6753..ee0156921ebc 100644
--- a/drivers/pci/controller/mobiveil/pcie-layerscape-gen4.c
+++ b/drivers/pci/controller/mobiveil/pcie-layerscape-gen4.c
@@ -170,10 +170,9 @@ static int ls_pcie_g4_interrupt_init(struct mobiveil_pcie *mv_pci)
 	int ret;
 
 	pcie->irq = platform_get_irq_byname(pdev, "intr");
-	if (pcie->irq < 0) {
-		dev_err(dev, "Can't get 'intr' IRQ, errno = %d\n", pcie->irq);
+	if (pcie->irq < 0)
 		return pcie->irq;
-	}
+
 	ret = devm_request_irq(dev, pcie->irq, ls_pcie_g4_isr,
 			       IRQF_SHARED, pdev->name, pcie);
 	if (ret) {
diff --git a/drivers/pci/controller/mobiveil/pcie-mobiveil-host.c b/drivers/pci/controller/mobiveil/pcie-mobiveil-host.c
index 5907baa9b1f2..fa321fcdd4bc 100644
--- a/drivers/pci/controller/mobiveil/pcie-mobiveil-host.c
+++ b/drivers/pci/controller/mobiveil/pcie-mobiveil-host.c
@@ -522,10 +522,8 @@ static int mobiveil_pcie_integrated_interrupt_init(struct mobiveil_pcie *pcie)
 	mobiveil_pcie_enable_msi(pcie);
 
 	rp->irq = platform_get_irq(pdev, 0);
-	if (rp->irq < 0) {
-		dev_err(dev, "failed to map IRQ: %d\n", rp->irq);
+	if (rp->irq < 0)
 		return rp->irq;
-	}
 
 	/* initialize the IRQ domains */
 	ret = mobiveil_pcie_init_irq_domain(pcie);
-- 
2.27.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH 03/10] PCI: tegra: Remove dev_err() when handing an error from platform_get_irq()
  2020-08-02 14:25 [PATCH 00/10] Remove surplus dev_err() when handing an error from platform_get_irq() Krzysztof Wilczyński
  2020-08-02 14:25 ` [PATCH 01/10] PCI: dwc: Remove " Krzysztof Wilczyński
  2020-08-02 14:25 ` [PATCH 02/10] PCI: mobiveil: " Krzysztof Wilczyński
@ 2020-08-02 14:25 ` Krzysztof Wilczyński
  2020-08-02 14:25 ` [PATCH 04/10] PCI: altera: " Krzysztof Wilczyński
                   ` (7 subsequent siblings)
  10 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Wilczyński @ 2020-08-02 14:25 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: Heiko Stuebner, linux-pci, Shawn Lin, Binghui Wang,
	linux-arm-kernel, Ley Foon Tan, Thomas Petazzoni, Toan Le,
	Jesper Nilsson, linux-samsung-soc, Kevin Hilman, Pratyush Anand,
	Krzysztof Kozlowski, linux-rockchip, Kukjin Kim, Xiaowei Song,
	Hou Zhiqiang, Linus Walleij, Richard Zhu, Sascha Hauer, Yue Wang,
	Murali Karicheri, linux-tegra, linux-amlogic, linux-omap,
	linux-arm-kernel, Jingoo Han, rfi, Shawn Guo, Lucas Stach

There is no need to call the dev_err() function directly to print a
custom message when handling an error from either the platform_get_irq()
or platform_get_irq_byname() functions as both are going to display an
appropriate error message in case of a failure.

This change is as per suggestion from Coccinelle:

  drivers/pci/controller/pci-tegra.c:1524:2-9: line 1524 is redundant
  because platform_get_irq() already prints an error

  drivers/pci/controller/pci-tegra.c:1742:2-9: line 1742 is redundant
  because platform_get_irq() already prints an error

Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
---
 drivers/pci/controller/pci-tegra.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c
index 235b456698fc..b11397475a4d 100644
--- a/drivers/pci/controller/pci-tegra.c
+++ b/drivers/pci/controller/pci-tegra.c
@@ -1520,10 +1520,8 @@ static int tegra_pcie_get_resources(struct tegra_pcie *pcie)
 
 	/* request interrupt */
 	err = platform_get_irq_byname(pdev, "intr");
-	if (err < 0) {
-		dev_err(dev, "failed to get IRQ: %d\n", err);
+	if (err < 0)
 		goto phys_put;
-	}
 
 	pcie->irq = err;
 
@@ -1738,10 +1736,8 @@ static int tegra_pcie_msi_setup(struct tegra_pcie *pcie)
 	}
 
 	err = platform_get_irq_byname(pdev, "msi");
-	if (err < 0) {
-		dev_err(dev, "failed to get IRQ: %d\n", err);
+	if (err < 0)
 		goto free_irq_domain;
-	}
 
 	msi->irq = err;
 
-- 
2.27.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH 04/10] PCI: altera: Remove dev_err() when handing an error from platform_get_irq()
  2020-08-02 14:25 [PATCH 00/10] Remove surplus dev_err() when handing an error from platform_get_irq() Krzysztof Wilczyński
                   ` (2 preceding siblings ...)
  2020-08-02 14:25 ` [PATCH 03/10] PCI: tegra: " Krzysztof Wilczyński
@ 2020-08-02 14:25 ` Krzysztof Wilczyński
  2020-08-03  6:19   ` Tan, Ley Foon
  2020-08-02 14:25 ` [PATCH 05/10] PCI: host-generic: " Krzysztof Wilczyński
                   ` (6 subsequent siblings)
  10 siblings, 1 reply; 16+ messages in thread
From: Krzysztof Wilczyński @ 2020-08-02 14:25 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: Heiko Stuebner, linux-pci, Shawn Lin, Binghui Wang,
	linux-arm-kernel, Ley Foon Tan, Thomas Petazzoni, Toan Le,
	Jesper Nilsson, linux-samsung-soc, Kevin Hilman, Pratyush Anand,
	Krzysztof Kozlowski, linux-rockchip, Kukjin Kim, Xiaowei Song,
	Hou Zhiqiang, Linus Walleij, Richard Zhu, Sascha Hauer, Yue Wang,
	Murali Karicheri, linux-tegra, linux-amlogic, linux-omap,
	linux-arm-kernel, Jingoo Han, rfi, Shawn Guo, Lucas Stach

There is no need to call the dev_err() function directly to print a
custom message when handling an error from either the platform_get_irq()
or platform_get_irq_byname() functions as both are going to display an
appropriate error message in case of a failure.

This change is as per suggestion from Coccinelle:

  drivers/pci/controller/pcie-altera.c:717:2-9: line 717 is redundant
  because platform_get_irq() already prints an error

Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
---
 drivers/pci/controller/pcie-altera.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pci/controller/pcie-altera.c b/drivers/pci/controller/pcie-altera.c
index 24cb1c331058..f6d73d282230 100644
--- a/drivers/pci/controller/pcie-altera.c
+++ b/drivers/pci/controller/pcie-altera.c
@@ -713,10 +713,8 @@ static int altera_pcie_parse_dt(struct altera_pcie *pcie)
 
 	/* setup IRQ */
 	pcie->irq = platform_get_irq(pdev, 0);
-	if (pcie->irq < 0) {
-		dev_err(dev, "failed to get IRQ: %d\n", pcie->irq);
+	if (pcie->irq < 0)
 		return pcie->irq;
-	}
 
 	irq_set_chained_handler_and_data(pcie->irq, altera_pcie_isr, pcie);
 	return 0;
-- 
2.27.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH 05/10] PCI: host-generic: Remove dev_err() when handing an error from platform_get_irq()
  2020-08-02 14:25 [PATCH 00/10] Remove surplus dev_err() when handing an error from platform_get_irq() Krzysztof Wilczyński
                   ` (3 preceding siblings ...)
  2020-08-02 14:25 ` [PATCH 04/10] PCI: altera: " Krzysztof Wilczyński
@ 2020-08-02 14:25 ` Krzysztof Wilczyński
  2020-08-02 14:25 ` [PATCH 06/10] PCI: v3-semi: " Krzysztof Wilczyński
                   ` (5 subsequent siblings)
  10 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Wilczyński @ 2020-08-02 14:25 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: Heiko Stuebner, linux-pci, Shawn Lin, Binghui Wang,
	linux-arm-kernel, Ley Foon Tan, Thomas Petazzoni, Toan Le,
	Jesper Nilsson, linux-samsung-soc, Kevin Hilman, Pratyush Anand,
	Krzysztof Kozlowski, linux-rockchip, Kukjin Kim, Xiaowei Song,
	Hou Zhiqiang, Linus Walleij, Richard Zhu, Sascha Hauer, Yue Wang,
	Murali Karicheri, linux-tegra, linux-amlogic, linux-omap,
	linux-arm-kernel, Jingoo Han, rfi, Shawn Guo, Lucas Stach

There is no need to call the dev_err() function directly to print a
custom message when handling an error from either the platform_get_irq()
or platform_get_irq_byname() functions as both are going to display an
appropriate error message in case of a failure.

This change is as per suggestion from Coccinelle:

  drivers/pci/controller/pcie-tango.c:277:2-9: line 277 is redundant
  because platform_get_irq() already prints an error

Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
---
 drivers/pci/controller/pcie-tango.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pci/controller/pcie-tango.c b/drivers/pci/controller/pcie-tango.c
index 8f640c70f936..d093a8ce4bb1 100644
--- a/drivers/pci/controller/pcie-tango.c
+++ b/drivers/pci/controller/pcie-tango.c
@@ -273,10 +273,8 @@ static int tango_pcie_probe(struct platform_device *pdev)
 		writel_relaxed(0, pcie->base + SMP8759_ENABLE + offset);
 
 	virq = platform_get_irq(pdev, 1);
-	if (virq < 0) {
-		dev_err(dev, "Failed to map IRQ\n");
+	if (virq < 0)
 		return virq;
-	}
 
 	irq_dom = irq_domain_create_linear(fwnode, MSI_MAX, &dom_ops, pcie);
 	if (!irq_dom) {
-- 
2.27.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH 06/10] PCI: v3-semi: Remove dev_err() when handing an error from platform_get_irq()
  2020-08-02 14:25 [PATCH 00/10] Remove surplus dev_err() when handing an error from platform_get_irq() Krzysztof Wilczyński
                   ` (4 preceding siblings ...)
  2020-08-02 14:25 ` [PATCH 05/10] PCI: host-generic: " Krzysztof Wilczyński
@ 2020-08-02 14:25 ` Krzysztof Wilczyński
  2020-08-02 14:25 ` [PATCH 07/10] PCI: altera-msi: " Krzysztof Wilczyński
                   ` (4 subsequent siblings)
  10 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Wilczyński @ 2020-08-02 14:25 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: Heiko Stuebner, linux-pci, Shawn Lin, Binghui Wang,
	linux-arm-kernel, Ley Foon Tan, Thomas Petazzoni, Toan Le,
	Jesper Nilsson, linux-samsung-soc, Kevin Hilman, Pratyush Anand,
	Krzysztof Kozlowski, linux-rockchip, Kukjin Kim, Xiaowei Song,
	Hou Zhiqiang, Linus Walleij, Richard Zhu, Sascha Hauer, Yue Wang,
	Murali Karicheri, linux-tegra, linux-amlogic, linux-omap,
	linux-arm-kernel, Jingoo Han, rfi, Shawn Guo, Lucas Stach

There is no need to call the dev_err() function directly to print a
custom message when handling an error from either the platform_get_irq()
or platform_get_irq_byname() functions as both are going to display an
appropriate error message in case of a failure.

This change is as per suggestion from Coccinelle:

  drivers/pci/controller/pci-v3-semi.c:781:2-9: line 781 is redundant
  because platform_get_irq() already prints an error

Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
---
 drivers/pci/controller/pci-v3-semi.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/pci/controller/pci-v3-semi.c b/drivers/pci/controller/pci-v3-semi.c
index 3681e5af3878..2a19f2a98945 100644
--- a/drivers/pci/controller/pci-v3-semi.c
+++ b/drivers/pci/controller/pci-v3-semi.c
@@ -777,10 +777,9 @@ static int v3_pci_probe(struct platform_device *pdev)
 
 	/* Get and request error IRQ resource */
 	irq = platform_get_irq(pdev, 0);
-	if (irq < 0) {
-		dev_err(dev, "unable to obtain PCIv3 error IRQ\n");
+	if (irq < 0)
 		return irq;
-	}
+
 	ret = devm_request_irq(dev, irq, v3_irq, 0,
 			"PCIv3 error", v3);
 	if (ret < 0) {
-- 
2.27.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH 07/10] PCI: altera-msi: Remove dev_err() when handing an error from platform_get_irq()
  2020-08-02 14:25 [PATCH 00/10] Remove surplus dev_err() when handing an error from platform_get_irq() Krzysztof Wilczyński
                   ` (5 preceding siblings ...)
  2020-08-02 14:25 ` [PATCH 06/10] PCI: v3-semi: " Krzysztof Wilczyński
@ 2020-08-02 14:25 ` Krzysztof Wilczyński
  2020-08-02 14:26 ` [PATCH 08/10] PCI: xgene-msi: " Krzysztof Wilczyński
                   ` (3 subsequent siblings)
  10 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Wilczyński @ 2020-08-02 14:25 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: Heiko Stuebner, linux-pci, Shawn Lin, Binghui Wang,
	linux-arm-kernel, Ley Foon Tan, Thomas Petazzoni, Toan Le,
	Jesper Nilsson, linux-samsung-soc, Kevin Hilman, Pratyush Anand,
	Krzysztof Kozlowski, linux-rockchip, Kukjin Kim, Xiaowei Song,
	Hou Zhiqiang, Linus Walleij, Richard Zhu, Sascha Hauer, Yue Wang,
	Murali Karicheri, linux-tegra, linux-amlogic, linux-omap,
	linux-arm-kernel, Jingoo Han, rfi, Shawn Guo, Lucas Stach

There is no need to call the dev_err() function directly to print a
custom message when handling an error from either the platform_get_irq()
or platform_get_irq_byname() functions as both are going to display an
appropriate error message in case of a failure.

This change is as per suggestion from Coccinelle:

  drivers/pci/controller/pcie-altera-msi.c:259:2-9: line 259 is
  redundant because platform_get_irq() already prints an error

Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
---
 drivers/pci/controller/pcie-altera-msi.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/controller/pcie-altera-msi.c b/drivers/pci/controller/pcie-altera-msi.c
index 16d938920ca5..bec666eda1eb 100644
--- a/drivers/pci/controller/pcie-altera-msi.c
+++ b/drivers/pci/controller/pcie-altera-msi.c
@@ -256,7 +256,6 @@ static int altera_msi_probe(struct platform_device *pdev)
 
 	msi->irq = platform_get_irq(pdev, 0);
 	if (msi->irq < 0) {
-		dev_err(&pdev->dev, "failed to map IRQ: %d\n", msi->irq);
 		ret = msi->irq;
 		goto err;
 	}
-- 
2.27.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH 08/10] PCI: xgene-msi: Remove dev_err() when handing an error from platform_get_irq()
  2020-08-02 14:25 [PATCH 00/10] Remove surplus dev_err() when handing an error from platform_get_irq() Krzysztof Wilczyński
                   ` (6 preceding siblings ...)
  2020-08-02 14:25 ` [PATCH 07/10] PCI: altera-msi: " Krzysztof Wilczyński
@ 2020-08-02 14:26 ` Krzysztof Wilczyński
  2020-08-02 14:26 ` [PATCH 09/10] PCI: rockchip: " Krzysztof Wilczyński
                   ` (2 subsequent siblings)
  10 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Wilczyński @ 2020-08-02 14:26 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: Heiko Stuebner, linux-pci, Shawn Lin, Binghui Wang,
	linux-arm-kernel, Ley Foon Tan, Thomas Petazzoni, Toan Le,
	Jesper Nilsson, linux-samsung-soc, Kevin Hilman, Pratyush Anand,
	Krzysztof Kozlowski, linux-rockchip, Kukjin Kim, Xiaowei Song,
	Hou Zhiqiang, Linus Walleij, Richard Zhu, Sascha Hauer, Yue Wang,
	Murali Karicheri, linux-tegra, linux-amlogic, linux-omap,
	linux-arm-kernel, Jingoo Han, rfi, Shawn Guo, Lucas Stach

There is no need to call the dev_err() function directly to print a
custom message when handling an error from either the platform_get_irq()
or platform_get_irq_byname() functions as both are going to display an
appropriate error message in case of a failure.

This change is as per suggestion from Coccinelle:

  drivers/pci/controller/pci-xgene-msi.c:481:3-10: line 481 is redundant
  because platform_get_irq() already prints an error

Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
---
 drivers/pci/controller/pci-xgene-msi.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/pci/controller/pci-xgene-msi.c b/drivers/pci/controller/pci-xgene-msi.c
index f4c02da84e59..02271c6d17a1 100644
--- a/drivers/pci/controller/pci-xgene-msi.c
+++ b/drivers/pci/controller/pci-xgene-msi.c
@@ -478,8 +478,6 @@ static int xgene_msi_probe(struct platform_device *pdev)
 	for (irq_index = 0; irq_index < NR_HW_IRQS; irq_index++) {
 		virt_msir = platform_get_irq(pdev, irq_index);
 		if (virt_msir < 0) {
-			dev_err(&pdev->dev, "Cannot translate IRQ index %d\n",
-				irq_index);
 			rc = virt_msir;
 			goto error;
 		}
-- 
2.27.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH 09/10] PCI: rockchip: Remove dev_err() when handing an error from platform_get_irq()
  2020-08-02 14:25 [PATCH 00/10] Remove surplus dev_err() when handing an error from platform_get_irq() Krzysztof Wilczyński
                   ` (7 preceding siblings ...)
  2020-08-02 14:26 ` [PATCH 08/10] PCI: xgene-msi: " Krzysztof Wilczyński
@ 2020-08-02 14:26 ` Krzysztof Wilczyński
  2020-08-03  2:01 ` [PATCH 00/10] Remove surplus " Bjorn Helgaas
  2020-08-03  7:10 ` [PATCH 10/10] PCI: xilinx-nwl: Remove " Krzysztof Wilczyński
  10 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Wilczyński @ 2020-08-02 14:26 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: Heiko Stuebner, linux-pci, Shawn Lin, Binghui Wang,
	linux-arm-kernel, Ley Foon Tan, Thomas Petazzoni, Toan Le,
	Jesper Nilsson, linux-samsung-soc, Kevin Hilman, Pratyush Anand,
	Krzysztof Kozlowski, linux-rockchip, Kukjin Kim, Xiaowei Song,
	Hou Zhiqiang, Linus Walleij, Richard Zhu, Sascha Hauer, Yue Wang,
	Murali Karicheri, linux-tegra, linux-amlogic, linux-omap,
	linux-arm-kernel, Jingoo Han, rfi, Shawn Guo, Lucas Stach

There is no need to call the dev_err() function directly to print a
custom message when handling an error from either the platform_get_irq()
or platform_get_irq_byname() functions as both are going to display an
appropriate error message in case of a failure.

This change is as per suggestion from Coccinelle:

  drivers/pci/controller/pcie-rockchip-host.c:553:2-9: line 553 is
  redundant because platform_get_irq() already prints an error

  drivers/pci/controller/pcie-rockchip-host.c:566:2-9: line 566 is
  redundant because platform_get_irq() already prints an error

  drivers/pci/controller/pcie-rockchip-host.c:576:2-9: line 576 is
  redundant because platform_get_irq() already prints an error

Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
---
 drivers/pci/controller/pcie-rockchip-host.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/controller/pcie-rockchip-host.c
index 94af6f5828a3..eebe05ab354f 100644
--- a/drivers/pci/controller/pcie-rockchip-host.c
+++ b/drivers/pci/controller/pcie-rockchip-host.c
@@ -549,10 +549,8 @@ static int rockchip_pcie_setup_irq(struct rockchip_pcie *rockchip)
 	struct platform_device *pdev = to_platform_device(dev);
 
 	irq = platform_get_irq_byname(pdev, "sys");
-	if (irq < 0) {
-		dev_err(dev, "missing sys IRQ resource\n");
+	if (irq < 0)
 		return irq;
-	}
 
 	err = devm_request_irq(dev, irq, rockchip_pcie_subsys_irq_handler,
 			       IRQF_SHARED, "pcie-sys", rockchip);
@@ -562,20 +560,16 @@ static int rockchip_pcie_setup_irq(struct rockchip_pcie *rockchip)
 	}
 
 	irq = platform_get_irq_byname(pdev, "legacy");
-	if (irq < 0) {
-		dev_err(dev, "missing legacy IRQ resource\n");
+	if (irq < 0)
 		return irq;
-	}
 
 	irq_set_chained_handler_and_data(irq,
 					 rockchip_pcie_legacy_int_handler,
 					 rockchip);
 
 	irq = platform_get_irq_byname(pdev, "client");
-	if (irq < 0) {
-		dev_err(dev, "missing client IRQ resource\n");
+	if (irq < 0)
 		return irq;
-	}
 
 	err = devm_request_irq(dev, irq, rockchip_pcie_client_irq_handler,
 			       IRQF_SHARED, "pcie-client", rockchip);
-- 
2.27.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 00/10] Remove surplus dev_err() when handing an error from platform_get_irq()
  2020-08-02 14:25 [PATCH 00/10] Remove surplus dev_err() when handing an error from platform_get_irq() Krzysztof Wilczyński
                   ` (8 preceding siblings ...)
  2020-08-02 14:26 ` [PATCH 09/10] PCI: rockchip: " Krzysztof Wilczyński
@ 2020-08-03  2:01 ` Bjorn Helgaas
  2020-08-03 11:10   ` Krzysztof Wilczyński
  2020-08-03 14:55   ` Bjorn Helgaas
  2020-08-03  7:10 ` [PATCH 10/10] PCI: xilinx-nwl: Remove " Krzysztof Wilczyński
  10 siblings, 2 replies; 16+ messages in thread
From: Bjorn Helgaas @ 2020-08-03  2:01 UTC (permalink / raw)
  To: Krzysztof Wilczyński
  Cc: Heiko Stuebner, linux-pci, Shawn Lin, Binghui Wang,
	linux-arm-kernel, linux-tegra, Ley Foon Tan, Thomas Petazzoni,
	Toan Le, Jesper Nilsson, linux-samsung-soc, Kevin Hilman,
	Pratyush Anand, Krzysztof Kozlowski, linux-rockchip, Kukjin Kim,
	Xiaowei Song, Hou Zhiqiang, Linus Walleij, Richard Zhu,
	Sascha Hauer, Yue Wang, Murali Karicheri, Bjorn Helgaas,
	linux-amlogic, linux-omap, linux-arm-kernel, Jingoo Han, rfi,
	Shawn Guo, Lucas Stach

On Sun, Aug 02, 2020 at 02:25:52PM +0000, Krzysztof Wilczyński wrote:
> At the moment a lot of error handling code would print a duplicated
> error message should either the platform_get_irq() or
> platform_get_irq_byname() function fails to obtain an IRQ for a device.
> 
> There is no need to call the dev_err() function directly to print
> a custom message when handling an error from either of these functions
> as both are going to display an appropriate error message in case of
> a failure.
> 
> This series aims to remove surplus call to dev_err() when handing an
> error originating from either platform_get_irq() or
> platform_get_irq_byname() function as per suggestion from Coccinelle.
> 
> Related commits are commit 7723f4c5ecdb ("driver core: platform: Add an
> error message to platform_get_irq*()") and commit 98051ba2b28b
> ("coccinelle: Add script to check for platform_get_irq() excessive
> prints").
> 
> Krzysztof Wilczyński (10):
>   PCI: dwc: Remove dev_err() when handing an error from
>     platform_get_irq()
>   PCI: mobiveil: Remove dev_err() when handing an error from
>     platform_get_irq()
>   PCI: tegra: Remove dev_err() when handing an error from
>     platform_get_irq()
>   PCI: altera: Remove dev_err() when handing an error from
>     platform_get_irq()
>   PCI: host-generic: Remove dev_err() when handing an error from
>     platform_get_irq()
>   PCI: v3-semi: Remove dev_err() when handing an error from
>     platform_get_irq()
>   PCI: altera-msi: Remove dev_err() when handing an error from
>     platform_get_irq()
>   PCI: xgene-msi: Remove dev_err() when handing an error from
>     platform_get_irq()
>   PCI: rockchip: Remove dev_err() when handing an error from
>     platform_get_irq()
>   PCI: xilinx-nwl: Remove dev_err() when handing an error from
>     platform_get_irq()
> 
>  drivers/pci/controller/dwc/pci-dra7xx.c              |  8 ++------
>  drivers/pci/controller/dwc/pci-exynos.c              |  9 +++------
>  drivers/pci/controller/dwc/pci-imx6.c                |  4 +---
>  drivers/pci/controller/dwc/pci-keystone.c            |  4 +---
>  drivers/pci/controller/dwc/pci-meson.c               |  4 +---
>  drivers/pci/controller/dwc/pcie-armada8k.c           |  4 +---
>  drivers/pci/controller/dwc/pcie-artpec6.c            |  4 +---
>  drivers/pci/controller/dwc/pcie-histb.c              |  4 +---
>  drivers/pci/controller/dwc/pcie-kirin.c              |  5 +----
>  drivers/pci/controller/dwc/pcie-spear13xx.c          |  5 ++---
>  drivers/pci/controller/dwc/pcie-tegra194.c           |  4 +---
>  .../pci/controller/mobiveil/pcie-layerscape-gen4.c   |  5 ++---
>  drivers/pci/controller/mobiveil/pcie-mobiveil-host.c |  4 +---
>  drivers/pci/controller/pci-tegra.c                   |  8 ++------
>  drivers/pci/controller/pci-v3-semi.c                 |  5 ++---
>  drivers/pci/controller/pci-xgene-msi.c               |  2 --
>  drivers/pci/controller/pcie-altera-msi.c             |  1 -
>  drivers/pci/controller/pcie-altera.c                 |  4 +---
>  drivers/pci/controller/pcie-rockchip-host.c          | 12 +++---------
>  drivers/pci/controller/pcie-tango.c                  |  4 +---
>  drivers/pci/controller/pcie-xilinx-nwl.c             | 11 ++---------
>  21 files changed, 29 insertions(+), 82 deletions(-)

I squashed these together and applied them to pci/irq-error for v5.9,
thanks!

The cover letter claims there should be 10 patches, but I only got 9.
Just FYI.

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 16+ messages in thread

* RE: [PATCH 04/10] PCI: altera: Remove dev_err() when handing an error from platform_get_irq()
  2020-08-02 14:25 ` [PATCH 04/10] PCI: altera: " Krzysztof Wilczyński
@ 2020-08-03  6:19   ` Tan, Ley Foon
  0 siblings, 0 replies; 16+ messages in thread
From: Tan, Ley Foon @ 2020-08-03  6:19 UTC (permalink / raw)
  To: Krzysztof Wilczyński, Bjorn Helgaas
  Cc: Heiko Stuebner, linux-pci, Shawn Lin, Binghui Wang,
	linux-arm-kernel, Thomas Petazzoni, Toan Le, Jesper Nilsson,
	linux-samsung-soc, Kevin Hilman, Pratyush Anand,
	Krzysztof Kozlowski, linux-rockchip, Kukjin Kim, Xiaowei Song,
	Hou Zhiqiang, Linus Walleij, Richard Zhu, Sascha Hauer, Yue Wang,
	Murali Karicheri, linux-tegra, linux-amlogic, linux-omap,
	linux-arm-kernel, Jingoo Han, rfi, Shawn Guo, Lucas Stach



> -----Original Message-----
> From: Krzysztof Wilczyński <kw@linux.com>
> Sent: Sunday, August 2, 2020 10:26 PM
> To: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Jingoo Han <jingoohan1@gmail.com>; Kukjin Kim <kgene@kernel.org>;
> Krzysztof Kozlowski <krzk@kernel.org>; Richard Zhu
> <hongxing.zhu@nxp.com>; Lucas Stach <l.stach@pengutronix.de>; Shawn
> Guo <shawnguo@kernel.org>; Sascha Hauer <s.hauer@pengutronix.de>;
> Murali Karicheri <m-karicheri2@ti.com>; Yue Wang
> <yue.wang@Amlogic.com>; Kevin Hilman <khilman@baylibre.com>; Thomas
> Petazzoni <thomas.petazzoni@bootlin.com>; Jesper Nilsson
> <jesper.nilsson@axis.com>; Xiaowei Song <songxiaowei@hisilicon.com>;
> Binghui Wang <wangbinghui@hisilicon.com>; Pratyush Anand
> <pratyush.anand@gmail.com>; Hou Zhiqiang <Zhiqiang.Hou@nxp.com>;
> Linus Walleij <linus.walleij@linaro.org>; Toan Le
> <toan@os.amperecomputing.com>; Tan, Ley Foon
> <ley.foon.tan@intel.com>; Shawn Lin <shawn.lin@rock-chips.com>; Heiko
> Stuebner <heiko@sntech.de>; linux-amlogic@lists.infradead.org; linux-arm-
> kernel@axis.com; linux-arm-kernel@lists.infradead.org; linux-
> omap@vger.kernel.org; linux-pci@vger.kernel.org; linux-
> rockchip@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-
> tegra@vger.kernel.org; rfi@lists.rocketboards.org
> Subject: [PATCH 04/10] PCI: altera: Remove dev_err() when handing an error
> from platform_get_irq()
> 
> There is no need to call the dev_err() function directly to print a custom
> message when handling an error from either the platform_get_irq() or
> platform_get_irq_byname() functions as both are going to display an
> appropriate error message in case of a failure.
> 
> This change is as per suggestion from Coccinelle:
> 
>   drivers/pci/controller/pcie-altera.c:717:2-9: line 717 is redundant
>   because platform_get_irq() already prints an error
> 
> Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
> Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
> ---

Reviewed-by: Ley Foon Tan <ley.foon.tan@intel.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH 10/10] PCI: xilinx-nwl: Remove dev_err() when handing an error from platform_get_irq()
  2020-08-02 14:25 [PATCH 00/10] Remove surplus dev_err() when handing an error from platform_get_irq() Krzysztof Wilczyński
                   ` (9 preceding siblings ...)
  2020-08-03  2:01 ` [PATCH 00/10] Remove surplus " Bjorn Helgaas
@ 2020-08-03  7:10 ` Krzysztof Wilczyński
  10 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Wilczyński @ 2020-08-03  7:10 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: Heiko Stuebner, linux-pci, Shawn Lin, Binghui Wang,
	linux-arm-kernel, Ley Foon Tan, Thomas Petazzoni, Toan Le,
	Jesper Nilsson, linux-samsung-soc, Kevin Hilman, Pratyush Anand,
	Krzysztof Kozlowski, linux-rockchip, Kukjin Kim, Xiaowei Song,
	Hou Zhiqiang, Linus Walleij, Richard Zhu, Sascha Hauer, Yue Wang,
	Murali Karicheri, linux-tegra, linux-amlogic, linux-omap,
	linux-arm-kernel, Jingoo Han, rfi, Shawn Guo, Lucas Stach

There is no need to call the dev_err() function directly to print a
custom message when handling an error from either the platform_get_irq()
or platform_get_irq_byname() functions as both are going to display an
appropriate error message in case of a failure.

This change is as per suggestion from Coccinelle:

  drivers/pci/controller/pcie-xilinx-nwl.c:732:2-9: line 732 is
  redundant because platform_get_irq() already prints an error

  drivers/pci/controller/pcie-xilinx-nwl.c:589:2-9: line 589 is
  redundant because platform_get_irq() already prints an error

  drivers/pci/controller/pcie-xilinx-nwl.c:600:2-9: line 600 is
  redundant because platform_get_irq() already prints an error

  drivers/pci/controller/pcie-xilinx-nwl.c:801:2-9: line 801 is
  redundant because platform_get_irq() already prints an error

Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
---
 drivers/pci/controller/pcie-xilinx-nwl.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/drivers/pci/controller/pcie-xilinx-nwl.c b/drivers/pci/controller/pcie-xilinx-nwl.c
index 9bd1427f2fd6..55489b728484 100644
--- a/drivers/pci/controller/pcie-xilinx-nwl.c
+++ b/drivers/pci/controller/pcie-xilinx-nwl.c
@@ -586,7 +586,6 @@ static int nwl_pcie_enable_msi(struct nwl_pcie *pcie)
 	/* Get msi_1 IRQ number */
 	msi->irq_msi1 = platform_get_irq_byname(pdev, "msi1");
 	if (msi->irq_msi1 < 0) {
-		dev_err(dev, "failed to get IRQ#%d\n", msi->irq_msi1);
 		ret = -EINVAL;
 		goto err;
 	}
@@ -597,7 +596,6 @@ static int nwl_pcie_enable_msi(struct nwl_pcie *pcie)
 	/* Get msi_0 IRQ number */
 	msi->irq_msi0 = platform_get_irq_byname(pdev, "msi0");
 	if (msi->irq_msi0 < 0) {
-		dev_err(dev, "failed to get IRQ#%d\n", msi->irq_msi0);
 		ret = -EINVAL;
 		goto err;
 	}
@@ -728,11 +726,8 @@ static int nwl_pcie_bridge_init(struct nwl_pcie *pcie)
 
 	/* Get misc IRQ number */
 	pcie->irq_misc = platform_get_irq_byname(pdev, "misc");
-	if (pcie->irq_misc < 0) {
-		dev_err(dev, "failed to get misc IRQ %d\n",
-			pcie->irq_misc);
+	if (pcie->irq_misc < 0)
 		return -EINVAL;
-	}
 
 	err = devm_request_irq(dev, pcie->irq_misc,
 			       nwl_pcie_misc_handler, IRQF_SHARED,
@@ -797,10 +792,8 @@ static int nwl_pcie_parse_dt(struct nwl_pcie *pcie,
 
 	/* Get intx IRQ number */
 	pcie->irq_intx = platform_get_irq_byname(pdev, "intx");
-	if (pcie->irq_intx < 0) {
-		dev_err(dev, "failed to get intx IRQ %d\n", pcie->irq_intx);
+	if (pcie->irq_intx < 0)
 		return pcie->irq_intx;
-	}
 
 	irq_set_chained_handler_and_data(pcie->irq_intx,
 					 nwl_pcie_leg_handler, pcie);
-- 
2.27.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 01/10] PCI: dwc: Remove dev_err() when handing an error from platform_get_irq()
  2020-08-02 14:25 ` [PATCH 01/10] PCI: dwc: Remove " Krzysztof Wilczyński
@ 2020-08-03  7:16   ` Jesper Nilsson
  0 siblings, 0 replies; 16+ messages in thread
From: Jesper Nilsson @ 2020-08-03  7:16 UTC (permalink / raw)
  To: Krzysztof Wilczyński
  Cc: Heiko Stuebner, linux-pci, Shawn Lin, Binghui Wang,
	linux-arm-kernel, linux-tegra, Ley Foon Tan, Thomas Petazzoni,
	Toan Le, Jesper Nilsson, linux-samsung-soc, Kevin Hilman,
	Pratyush Anand, Krzysztof Kozlowski, linux-rockchip, Kukjin Kim,
	Xiaowei Song, Hou Zhiqiang, Linus Walleij, Richard Zhu,
	Sascha Hauer, Yue Wang, Murali Karicheri, Bjorn Helgaas,
	linux-amlogic, linux-omap, linux-arm-kernel, Jingoo Han, rfi,
	Shawn Guo, Lucas Stach

On Sun, Aug 02, 2020 at 04:25:53PM +0200, Krzysztof Wilczyński wrote:
> There is no need to call the dev_err() function directly to print a
> custom message when handling an error from either the platform_get_irq()
> or platform_get_irq_byname() functions as both are going to display an
> appropriate error message in case of a failure.
> 
> This change is as per suggestion from Coccinelle:
> 
>   drivers/pci/controller/dwc/pcie-armada8k.c:252:2-9: line 252 is
>   redundant because platform_get_irq() already prints an error
> 
>   drivers/pci/controller/dwc/pcie-kirin.c:459:3-10: line 459 is
>   redundant because platform_get_irq() already prints an error
> 
>   drivers/pci/controller/dwc/pci-imx6.c:872:3-10: line 872 is redundant
>   because platform_get_irq() already prints an error
> 
>   drivers/pci/controller/dwc/pcie-artpec6.c:391:3-10: line 391 is
>   redundant because platform_get_irq() already prints an error
> 
>   drivers/pci/controller/dwc/pcie-spear13xx.c:202:2-9: line 202 is
>   redundant because platform_get_irq() already prints an error
> 
>   drivers/pci/controller/dwc/pci-keystone.c:1254:2-9: line 1254 is
>   redundant because platform_get_irq() already prints an error
> 
>   drivers/pci/controller/dwc/pci-exynos.c:406:2-9: line 406 is redundant
>   because platform_get_irq() already prints an error
> 
>   drivers/pci/controller/dwc/pci-exynos.c:419:3-10: line 419 is
>   redundant because platform_get_irq() already prints an error
> 
>   drivers/pci/controller/dwc/pcie-tegra194.c:2193:2-9: line 2193 is
>   redundant because platform_get_irq() already prints an error
> 
>   drivers/pci/controller/dwc/pcie-histb.c:406:3-10: line 406 is
>   redundant because platform_get_irq() already prints an error
> 
>   drivers/pci/controller/dwc/pci-meson.c:492:3-10: line 492 is redundant
>   because platform_get_irq() already prints an error
> 
>   drivers/pci/controller/dwc/pci-dra7xx.c:633:2-9: line 633 is redundant
>   because platform_get_irq() already prints an error
> 
>   drivers/pci/controller/dwc/pci-dra7xx.c:875:2-9: line 875 is redundant
>   because platform_get_irq() already prints an error
> 
> Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
> Signed-off-by: Krzysztof Wilczyński <kw@linux.com>

Looks good,

Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@axis.com

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 00/10] Remove surplus dev_err() when handing an error from platform_get_irq()
  2020-08-03  2:01 ` [PATCH 00/10] Remove surplus " Bjorn Helgaas
@ 2020-08-03 11:10   ` Krzysztof Wilczyński
  2020-08-03 14:55   ` Bjorn Helgaas
  1 sibling, 0 replies; 16+ messages in thread
From: Krzysztof Wilczyński @ 2020-08-03 11:10 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: Heiko Stuebner, linux-pci, Shawn Lin, Binghui Wang,
	linux-arm-kernel, linux-tegra, Ley Foon Tan, Thomas Petazzoni,
	Toan Le, Jesper Nilsson, linux-samsung-soc, Kevin Hilman,
	Pratyush Anand, Krzysztof Kozlowski, linux-rockchip, Kukjin Kim,
	Xiaowei Song, Hou Zhiqiang, Linus Walleij, Richard Zhu,
	Sascha Hauer, Yue Wang, Murali Karicheri, Bjorn Helgaas,
	linux-amlogic, linux-omap, linux-arm-kernel, Jingoo Han, rfi,
	Shawn Guo, Lucas Stach

On 20-08-02 21:01:51, Bjorn Helgaas wrote:

Hi Bjorn,

[...]
>
> I squashed these together and applied them to pci/irq-error for v5.9,
> thanks!

Thank you!

> The cover letter claims there should be 10 patches, but I only got 9.
> Just FYI.

There indeed should be 10 patches.  I sent the missing one (not should
why it didn't go through) this morning making sure it falls under the
thread with the cover letter.

Sorry about that!

The missing patch can be seen here:
  https://patchwork.kernel.org/patch/11697463/

Krzysztof

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 00/10] Remove surplus dev_err() when handing an error from platform_get_irq()
  2020-08-03  2:01 ` [PATCH 00/10] Remove surplus " Bjorn Helgaas
  2020-08-03 11:10   ` Krzysztof Wilczyński
@ 2020-08-03 14:55   ` Bjorn Helgaas
  1 sibling, 0 replies; 16+ messages in thread
From: Bjorn Helgaas @ 2020-08-03 14:55 UTC (permalink / raw)
  To: Krzysztof Wilczyński
  Cc: Heiko Stuebner, linux-pci, Shawn Lin, Binghui Wang,
	linux-arm-kernel, linux-tegra, Ley Foon Tan, Thomas Petazzoni,
	Toan Le, Jesper Nilsson, linux-samsung-soc, Kevin Hilman,
	Pratyush Anand, Krzysztof Kozlowski, linux-rockchip, Kukjin Kim,
	Xiaowei Song, Hou Zhiqiang, Linus Walleij, Richard Zhu,
	Sascha Hauer, Yue Wang, Murali Karicheri, Bjorn Helgaas,
	linux-amlogic, linux-omap, linux-arm-kernel, Jingoo Han, rfi,
	Shawn Guo, Lucas Stach

On Sun, Aug 02, 2020 at 09:01:51PM -0500, Bjorn Helgaas wrote:
> On Sun, Aug 02, 2020 at 02:25:52PM +0000, Krzysztof Wilczyński wrote:
> > At the moment a lot of error handling code would print a duplicated
> > error message should either the platform_get_irq() or
> > platform_get_irq_byname() function fails to obtain an IRQ for a device.
> > 
> > There is no need to call the dev_err() function directly to print
> > a custom message when handling an error from either of these functions
> > as both are going to display an appropriate error message in case of
> > a failure.
> > 
> > This series aims to remove surplus call to dev_err() when handing an
> > error originating from either platform_get_irq() or
> > platform_get_irq_byname() function as per suggestion from Coccinelle.
> > 
> > Related commits are commit 7723f4c5ecdb ("driver core: platform: Add an
> > error message to platform_get_irq*()") and commit 98051ba2b28b
> > ("coccinelle: Add script to check for platform_get_irq() excessive
> > prints").
> > 
> > Krzysztof Wilczyński (10):
> >   PCI: dwc: Remove dev_err() when handing an error from
> >     platform_get_irq()
> >   PCI: mobiveil: Remove dev_err() when handing an error from
> >     platform_get_irq()
> >   PCI: tegra: Remove dev_err() when handing an error from
> >     platform_get_irq()
> >   PCI: altera: Remove dev_err() when handing an error from
> >     platform_get_irq()
> >   PCI: host-generic: Remove dev_err() when handing an error from
> >     platform_get_irq()
> >   PCI: v3-semi: Remove dev_err() when handing an error from
> >     platform_get_irq()
> >   PCI: altera-msi: Remove dev_err() when handing an error from
> >     platform_get_irq()
> >   PCI: xgene-msi: Remove dev_err() when handing an error from
> >     platform_get_irq()
> >   PCI: rockchip: Remove dev_err() when handing an error from
> >     platform_get_irq()
> >   PCI: xilinx-nwl: Remove dev_err() when handing an error from
> >     platform_get_irq()
> > 
> >  drivers/pci/controller/dwc/pci-dra7xx.c              |  8 ++------
> >  drivers/pci/controller/dwc/pci-exynos.c              |  9 +++------
> >  drivers/pci/controller/dwc/pci-imx6.c                |  4 +---
> >  drivers/pci/controller/dwc/pci-keystone.c            |  4 +---
> >  drivers/pci/controller/dwc/pci-meson.c               |  4 +---
> >  drivers/pci/controller/dwc/pcie-armada8k.c           |  4 +---
> >  drivers/pci/controller/dwc/pcie-artpec6.c            |  4 +---
> >  drivers/pci/controller/dwc/pcie-histb.c              |  4 +---
> >  drivers/pci/controller/dwc/pcie-kirin.c              |  5 +----
> >  drivers/pci/controller/dwc/pcie-spear13xx.c          |  5 ++---
> >  drivers/pci/controller/dwc/pcie-tegra194.c           |  4 +---
> >  .../pci/controller/mobiveil/pcie-layerscape-gen4.c   |  5 ++---
> >  drivers/pci/controller/mobiveil/pcie-mobiveil-host.c |  4 +---
> >  drivers/pci/controller/pci-tegra.c                   |  8 ++------
> >  drivers/pci/controller/pci-v3-semi.c                 |  5 ++---
> >  drivers/pci/controller/pci-xgene-msi.c               |  2 --
> >  drivers/pci/controller/pcie-altera-msi.c             |  1 -
> >  drivers/pci/controller/pcie-altera.c                 |  4 +---
> >  drivers/pci/controller/pcie-rockchip-host.c          | 12 +++---------
> >  drivers/pci/controller/pcie-tango.c                  |  4 +---
> >  drivers/pci/controller/pcie-xilinx-nwl.c             | 11 ++---------
> >  21 files changed, 29 insertions(+), 82 deletions(-)
> 
> I squashed these together and applied them to pci/irq-error for v5.9,
> thanks!
> 
> The cover letter claims there should be 10 patches, but I only got 9.
> Just FYI.

I picked up and applied 10/10 as well.  And added Jesper & Ley Foon's
reviewed-by and acked-by.  Thanks!

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, back to index

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-02 14:25 [PATCH 00/10] Remove surplus dev_err() when handing an error from platform_get_irq() Krzysztof Wilczyński
2020-08-02 14:25 ` [PATCH 01/10] PCI: dwc: Remove " Krzysztof Wilczyński
2020-08-03  7:16   ` Jesper Nilsson
2020-08-02 14:25 ` [PATCH 02/10] PCI: mobiveil: " Krzysztof Wilczyński
2020-08-02 14:25 ` [PATCH 03/10] PCI: tegra: " Krzysztof Wilczyński
2020-08-02 14:25 ` [PATCH 04/10] PCI: altera: " Krzysztof Wilczyński
2020-08-03  6:19   ` Tan, Ley Foon
2020-08-02 14:25 ` [PATCH 05/10] PCI: host-generic: " Krzysztof Wilczyński
2020-08-02 14:25 ` [PATCH 06/10] PCI: v3-semi: " Krzysztof Wilczyński
2020-08-02 14:25 ` [PATCH 07/10] PCI: altera-msi: " Krzysztof Wilczyński
2020-08-02 14:26 ` [PATCH 08/10] PCI: xgene-msi: " Krzysztof Wilczyński
2020-08-02 14:26 ` [PATCH 09/10] PCI: rockchip: " Krzysztof Wilczyński
2020-08-03  2:01 ` [PATCH 00/10] Remove surplus " Bjorn Helgaas
2020-08-03 11:10   ` Krzysztof Wilczyński
2020-08-03 14:55   ` Bjorn Helgaas
2020-08-03  7:10 ` [PATCH 10/10] PCI: xilinx-nwl: Remove " Krzysztof Wilczyński

Linux-Amlogic Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-amlogic/0 linux-amlogic/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-amlogic linux-amlogic/ https://lore.kernel.org/linux-amlogic \
		linux-amlogic@lists.infradead.org
	public-inbox-index linux-amlogic

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-amlogic


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git