* [PATCH 3/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in v4.14
2020-09-03 23:24 [PATCH 0/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for all host drivers Douglas Anderson
@ 2020-09-03 23:24 ` Douglas Anderson
2020-09-04 6:35 ` Wolfram Sang
2020-09-03 23:24 ` [PATCH 4/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in v4.19 Douglas Anderson
` (3 subsequent siblings)
4 siblings, 1 reply; 14+ messages in thread
From: Douglas Anderson @ 2020-09-03 23:24 UTC (permalink / raw)
To: Ulf Hansson
Cc: Neil Armstrong, Douglas Anderson, Peter Ujfalusi, Wolfram Sang,
Jerome Brunet, Florian Fainelli, Kevin Hilman,
Krzysztof Kozlowski, Jaehoon Chung, bcm-kernel-feedback-list,
Saiyam Doshi, Martin Blumenstingl, Ray Jui, swboyd,
linux-rpi-kernel, linux-amlogic, linux-arm-kernel, Scott Branden,
Hu Ziji, linux-mmc, Adrian Hunter, linux-kernel, Robert Richter,
Stefan Wahren, Jun Nie, Shawn Guo, Nicolas Saenz Julienne
This is like commit 3d3451124f3d ("mmc: sdhci-msm: Prefer asynchronous
probe") but applied to a whole pile of drivers. This batch converts
the drivers that appeared to be around in the v4.14 timeframe.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
drivers/mmc/host/bcm2835.c | 1 +
drivers/mmc/host/cavium-octeon.c | 1 +
drivers/mmc/host/dw_mmc-zx.c | 1 +
drivers/mmc/host/meson-gx-mmc.c | 1 +
drivers/mmc/host/renesas_sdhi_internal_dmac.c | 1 +
drivers/mmc/host/renesas_sdhi_sys_dmac.c | 1 +
drivers/mmc/host/sdhci-cadence.c | 1 +
drivers/mmc/host/sdhci-xenon.c | 1 +
8 files changed, 8 insertions(+)
diff --git a/drivers/mmc/host/bcm2835.c b/drivers/mmc/host/bcm2835.c
index 35320bc9dc02..8c2361e66277 100644
--- a/drivers/mmc/host/bcm2835.c
+++ b/drivers/mmc/host/bcm2835.c
@@ -1474,6 +1474,7 @@ static struct platform_driver bcm2835_driver = {
.remove = bcm2835_remove,
.driver = {
.name = "sdhost-bcm2835",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.of_match_table = bcm2835_match,
},
};
diff --git a/drivers/mmc/host/cavium-octeon.c b/drivers/mmc/host/cavium-octeon.c
index e299cdd1e619..2c4b2df52adb 100644
--- a/drivers/mmc/host/cavium-octeon.c
+++ b/drivers/mmc/host/cavium-octeon.c
@@ -327,6 +327,7 @@ static struct platform_driver octeon_mmc_driver = {
.remove = octeon_mmc_remove,
.driver = {
.name = KBUILD_MODNAME,
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.of_match_table = octeon_mmc_match,
},
};
diff --git a/drivers/mmc/host/dw_mmc-zx.c b/drivers/mmc/host/dw_mmc-zx.c
index d9e483432a61..51bcc6332f3a 100644
--- a/drivers/mmc/host/dw_mmc-zx.c
+++ b/drivers/mmc/host/dw_mmc-zx.c
@@ -222,6 +222,7 @@ static struct platform_driver dw_mci_zx_pltfm_driver = {
.remove = dw_mci_pltfm_remove,
.driver = {
.name = "dwmmc_zx",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.of_match_table = dw_mci_zx_match,
.pm = &dw_mci_zx_dev_pm_ops,
},
diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index a68b43082f61..4ec41579940a 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -1264,6 +1264,7 @@ static struct platform_driver meson_mmc_driver = {
.remove = meson_mmc_remove,
.driver = {
.name = DRIVER_NAME,
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.of_match_table = of_match_ptr(meson_mmc_of_match),
},
};
diff --git a/drivers/mmc/host/renesas_sdhi_internal_dmac.c b/drivers/mmc/host/renesas_sdhi_internal_dmac.c
index 32ab991544ef..90b395a187fa 100644
--- a/drivers/mmc/host/renesas_sdhi_internal_dmac.c
+++ b/drivers/mmc/host/renesas_sdhi_internal_dmac.c
@@ -357,6 +357,7 @@ static const struct dev_pm_ops renesas_sdhi_internal_dmac_dev_pm_ops = {
static struct platform_driver renesas_internal_dmac_sdhi_driver = {
.driver = {
.name = "renesas_sdhi_internal_dmac",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.pm = &renesas_sdhi_internal_dmac_dev_pm_ops,
.of_match_table = renesas_sdhi_internal_dmac_of_match,
},
diff --git a/drivers/mmc/host/renesas_sdhi_sys_dmac.c b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
index 13ff023fbee9..c5f789675302 100644
--- a/drivers/mmc/host/renesas_sdhi_sys_dmac.c
+++ b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
@@ -463,6 +463,7 @@ static const struct dev_pm_ops renesas_sdhi_sys_dmac_dev_pm_ops = {
static struct platform_driver renesas_sys_dmac_sdhi_driver = {
.driver = {
.name = "sh_mobile_sdhi",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.pm = &renesas_sdhi_sys_dmac_dev_pm_ops,
.of_match_table = renesas_sdhi_sys_dmac_of_match,
},
diff --git a/drivers/mmc/host/sdhci-cadence.c b/drivers/mmc/host/sdhci-cadence.c
index 4d9f7681817c..6f2de54a5987 100644
--- a/drivers/mmc/host/sdhci-cadence.c
+++ b/drivers/mmc/host/sdhci-cadence.c
@@ -463,6 +463,7 @@ MODULE_DEVICE_TABLE(of, sdhci_cdns_match);
static struct platform_driver sdhci_cdns_driver = {
.driver = {
.name = "sdhci-cdns",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.pm = &sdhci_cdns_pm_ops,
.of_match_table = sdhci_cdns_match,
},
diff --git a/drivers/mmc/host/sdhci-xenon.c b/drivers/mmc/host/sdhci-xenon.c
index 4703cd540c7f..24c978de2a3f 100644
--- a/drivers/mmc/host/sdhci-xenon.c
+++ b/drivers/mmc/host/sdhci-xenon.c
@@ -677,6 +677,7 @@ MODULE_DEVICE_TABLE(of, sdhci_xenon_dt_ids);
static struct platform_driver sdhci_xenon_driver = {
.driver = {
.name = "xenon-sdhci",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.of_match_table = sdhci_xenon_dt_ids,
.pm = &sdhci_xenon_dev_pm_ops,
},
--
2.28.0.526.ge36021eeef-goog
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 3/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in v4.14
2020-09-03 23:24 ` [PATCH 3/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in v4.14 Douglas Anderson
@ 2020-09-04 6:35 ` Wolfram Sang
0 siblings, 0 replies; 14+ messages in thread
From: Wolfram Sang @ 2020-09-04 6:35 UTC (permalink / raw)
To: Douglas Anderson
Cc: Ulf Hansson, Neil Armstrong, linux-kernel, Peter Ujfalusi,
Hu Ziji, Jerome Brunet, Florian Fainelli, Kevin Hilman,
Krzysztof Kozlowski, Jaehoon Chung, bcm-kernel-feedback-list,
Saiyam Doshi, Martin Blumenstingl, Ray Jui, swboyd,
linux-rpi-kernel, linux-amlogic, linux-arm-kernel, Scott Branden,
linux-mmc, Adrian Hunter, Robert Richter, Stefan Wahren, Jun Nie,
Shawn Guo, Nicolas Saenz Julienne
[-- Attachment #1.1: Type: text/plain, Size: 892 bytes --]
On Thu, Sep 03, 2020 at 04:24:38PM -0700, Douglas Anderson wrote:
> This is like commit 3d3451124f3d ("mmc: sdhci-msm: Prefer asynchronous
> probe") but applied to a whole pile of drivers. This batch converts
> the drivers that appeared to be around in the v4.14 timeframe.
The LTS granularity of patches is a nice idea! I will keep it in mind.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
In general, I like more coverage of async probing. It makes sense for
SD/MMC, I think.
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> drivers/mmc/host/renesas_sdhi_internal_dmac.c | 1 +
> drivers/mmc/host/renesas_sdhi_sys_dmac.c | 1 +
For these two also:
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com> # SDHI drivers
The speedups somewhat match the expected values and no regressions when
checksumming a large file.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 4/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in v4.19
2020-09-03 23:24 [PATCH 0/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for all host drivers Douglas Anderson
2020-09-03 23:24 ` [PATCH 3/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in v4.14 Douglas Anderson
@ 2020-09-03 23:24 ` Douglas Anderson
2020-09-03 23:24 ` [PATCH 6/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that are newer than 5.4 Douglas Anderson
` (2 subsequent siblings)
4 siblings, 0 replies; 14+ messages in thread
From: Douglas Anderson @ 2020-09-03 23:24 UTC (permalink / raw)
To: Ulf Hansson
Cc: Kishon Vijay Abraham I, linux-kernel, Neil Armstrong,
Martin Blumenstingl, Kevin Hilman, linux-mmc, Adrian Hunter,
Douglas Anderson, Jaehoon Chung, linux-amlogic, swboyd,
linux-arm-kernel, Jerome Brunet
This is like commit 3d3451124f3d ("mmc: sdhci-msm: Prefer asynchronous
probe") but applied to a whole pile of drivers. This batch converts
the drivers that appeared to be around in the v4.19 timeframe.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
drivers/mmc/host/dw_mmc-bluefield.c | 1 +
drivers/mmc/host/dw_mmc-hi3798cv200.c | 1 +
drivers/mmc/host/meson-mx-sdio.c | 1 +
drivers/mmc/host/sdhci-of-dwcmshc.c | 1 +
drivers/mmc/host/sdhci-omap.c | 1 +
5 files changed, 5 insertions(+)
diff --git a/drivers/mmc/host/dw_mmc-bluefield.c b/drivers/mmc/host/dw_mmc-bluefield.c
index aa38b1a8017e..10baf122bc15 100644
--- a/drivers/mmc/host/dw_mmc-bluefield.c
+++ b/drivers/mmc/host/dw_mmc-bluefield.c
@@ -55,6 +55,7 @@ static struct platform_driver dw_mci_bluefield_pltfm_driver = {
.remove = dw_mci_pltfm_remove,
.driver = {
.name = "dwmmc_bluefield",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.of_match_table = dw_mci_bluefield_match,
.pm = &dw_mci_pltfm_pmops,
},
diff --git a/drivers/mmc/host/dw_mmc-hi3798cv200.c b/drivers/mmc/host/dw_mmc-hi3798cv200.c
index 83e1bad0a008..39794f93826f 100644
--- a/drivers/mmc/host/dw_mmc-hi3798cv200.c
+++ b/drivers/mmc/host/dw_mmc-hi3798cv200.c
@@ -200,6 +200,7 @@ static struct platform_driver dw_mci_hi3798cv200_driver = {
.remove = dw_mci_hi3798cv200_remove,
.driver = {
.name = "dwmmc_hi3798cv200",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.of_match_table = dw_mci_hi3798cv200_match,
},
};
diff --git a/drivers/mmc/host/meson-mx-sdio.c b/drivers/mmc/host/meson-mx-sdio.c
index 9b2cf7afc246..a6ff8b4ad1a5 100644
--- a/drivers/mmc/host/meson-mx-sdio.c
+++ b/drivers/mmc/host/meson-mx-sdio.c
@@ -755,6 +755,7 @@ static struct platform_driver meson_mx_mmc_driver = {
.remove = meson_mx_mmc_remove,
.driver = {
.name = "meson-mx-sdio",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.of_match_table = of_match_ptr(meson_mx_mmc_of_match),
},
};
diff --git a/drivers/mmc/host/sdhci-of-dwcmshc.c b/drivers/mmc/host/sdhci-of-dwcmshc.c
index 64ac0dbee95c..4b673792b5a4 100644
--- a/drivers/mmc/host/sdhci-of-dwcmshc.c
+++ b/drivers/mmc/host/sdhci-of-dwcmshc.c
@@ -214,6 +214,7 @@ MODULE_DEVICE_TABLE(of, sdhci_dwcmshc_dt_ids);
static struct platform_driver sdhci_dwcmshc_driver = {
.driver = {
.name = "sdhci-dwcmshc",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.of_match_table = sdhci_dwcmshc_dt_ids,
.pm = &dwcmshc_pmops,
},
diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c
index 1ec74c2d5c17..7893fd3599b6 100644
--- a/drivers/mmc/host/sdhci-omap.c
+++ b/drivers/mmc/host/sdhci-omap.c
@@ -1297,6 +1297,7 @@ static struct platform_driver sdhci_omap_driver = {
.remove = sdhci_omap_remove,
.driver = {
.name = "sdhci-omap",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.pm = &sdhci_omap_dev_pm_ops,
.of_match_table = omap_sdhci_match,
},
--
2.28.0.526.ge36021eeef-goog
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 6/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that are newer than 5.4
2020-09-03 23:24 [PATCH 0/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for all host drivers Douglas Anderson
2020-09-03 23:24 ` [PATCH 3/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in v4.14 Douglas Anderson
2020-09-03 23:24 ` [PATCH 4/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in v4.19 Douglas Anderson
@ 2020-09-03 23:24 ` Douglas Anderson
2020-09-04 8:14 ` Lars Povlsen
` (2 more replies)
2020-09-04 21:53 ` [PATCH 0/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for all host drivers Martin Blumenstingl
2020-09-07 12:28 ` Ulf Hansson
4 siblings, 3 replies; 14+ messages in thread
From: Douglas Anderson @ 2020-09-03 23:24 UTC (permalink / raw)
To: Ulf Hansson
Cc: linux-kernel, Neil Armstrong, Martin Blumenstingl, Kevin Hilman,
Steen Hegelund, Manivannan Sadhasivam, linux-mmc, Adrian Hunter,
Douglas Anderson, Microchip Linux Driver Support,
linux-arm-kernel, Andreas Färber, linux-amlogic, swboyd,
Angelo Dureghello, Lars Povlsen, Jerome Brunet
This is like commit 3d3451124f3d ("mmc: sdhci-msm: Prefer asynchronous
probe") but applied to a whole pile of drivers. This batch converts
the drivers that appeared to have been added after kernel 5.4.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
drivers/mmc/host/meson-mx-sdhc-mmc.c | 1 +
drivers/mmc/host/owl-mmc.c | 1 +
drivers/mmc/host/sdhci-esdhc-mcf.c | 1 +
drivers/mmc/host/sdhci-milbeaut.c | 1 +
drivers/mmc/host/sdhci-of-sparx5.c | 1 +
5 files changed, 5 insertions(+)
diff --git a/drivers/mmc/host/meson-mx-sdhc-mmc.c b/drivers/mmc/host/meson-mx-sdhc-mmc.c
index 53e3f6a4245a..7cd9c0ec2fcf 100644
--- a/drivers/mmc/host/meson-mx-sdhc-mmc.c
+++ b/drivers/mmc/host/meson-mx-sdhc-mmc.c
@@ -903,6 +903,7 @@ static struct platform_driver meson_mx_sdhc_driver = {
.remove = meson_mx_sdhc_remove,
.driver = {
.name = "meson-mx-sdhc",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.of_match_table = of_match_ptr(meson_mx_sdhc_of_match),
},
};
diff --git a/drivers/mmc/host/owl-mmc.c b/drivers/mmc/host/owl-mmc.c
index df43f42855e2..ccf214a89eda 100644
--- a/drivers/mmc/host/owl-mmc.c
+++ b/drivers/mmc/host/owl-mmc.c
@@ -689,6 +689,7 @@ MODULE_DEVICE_TABLE(of, owl_mmc_of_match);
static struct platform_driver owl_mmc_driver = {
.driver = {
.name = "owl_mmc",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.of_match_table = owl_mmc_of_match,
},
.probe = owl_mmc_probe,
diff --git a/drivers/mmc/host/sdhci-esdhc-mcf.c b/drivers/mmc/host/sdhci-esdhc-mcf.c
index 71bf086a9812..ca7a1690b2a8 100644
--- a/drivers/mmc/host/sdhci-esdhc-mcf.c
+++ b/drivers/mmc/host/sdhci-esdhc-mcf.c
@@ -509,6 +509,7 @@ static int sdhci_esdhc_mcf_remove(struct platform_device *pdev)
static struct platform_driver sdhci_esdhc_mcf_driver = {
.driver = {
.name = "sdhci-esdhc-mcf",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
},
.probe = sdhci_esdhc_mcf_probe,
.remove = sdhci_esdhc_mcf_remove,
diff --git a/drivers/mmc/host/sdhci-milbeaut.c b/drivers/mmc/host/sdhci-milbeaut.c
index 4e7cc0680f94..148b37ac6564 100644
--- a/drivers/mmc/host/sdhci-milbeaut.c
+++ b/drivers/mmc/host/sdhci-milbeaut.c
@@ -333,6 +333,7 @@ static int sdhci_milbeaut_remove(struct platform_device *pdev)
static struct platform_driver sdhci_milbeaut_driver = {
.driver = {
.name = "sdhci-milbeaut",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.of_match_table = of_match_ptr(mlb_dt_ids),
},
.probe = sdhci_milbeaut_probe,
diff --git a/drivers/mmc/host/sdhci-of-sparx5.c b/drivers/mmc/host/sdhci-of-sparx5.c
index 747f108a0ace..28e4ee69e100 100644
--- a/drivers/mmc/host/sdhci-of-sparx5.c
+++ b/drivers/mmc/host/sdhci-of-sparx5.c
@@ -255,6 +255,7 @@ MODULE_DEVICE_TABLE(of, sdhci_sparx5_of_match);
static struct platform_driver sdhci_sparx5_driver = {
.driver = {
.name = "sdhci-sparx5",
+ .probe_type = PROBE_PREFER_ASYNCHRONOUS,
.of_match_table = sdhci_sparx5_of_match,
.pm = &sdhci_pltfm_pmops,
},
--
2.28.0.526.ge36021eeef-goog
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 6/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that are newer than 5.4
2020-09-03 23:24 ` [PATCH 6/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that are newer than 5.4 Douglas Anderson
@ 2020-09-04 8:14 ` Lars Povlsen
2020-09-04 9:33 ` Angelo Dureghello
2020-09-04 10:42 ` Manivannan Sadhasivam
2 siblings, 0 replies; 14+ messages in thread
From: Lars Povlsen @ 2020-09-04 8:14 UTC (permalink / raw)
To: Douglas Anderson
Cc: Ulf Hansson, linux-kernel, Neil Armstrong, Martin Blumenstingl,
Kevin Hilman, Steen Hegelund, linux-mmc, Adrian Hunter,
Andreas Färber, Microchip Linux Driver Support,
linux-arm-kernel, Manivannan Sadhasivam, linux-amlogic, swboyd,
Angelo Dureghello, Lars Povlsen, Jerome Brunet
Douglas Anderson writes:
> This is like commit 3d3451124f3d ("mmc: sdhci-msm: Prefer asynchronous
> probe") but applied to a whole pile of drivers. This batch converts
> the drivers that appeared to have been added after kernel 5.4.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> drivers/mmc/host/meson-mx-sdhc-mmc.c | 1 +
> drivers/mmc/host/owl-mmc.c | 1 +
> drivers/mmc/host/sdhci-esdhc-mcf.c | 1 +
> drivers/mmc/host/sdhci-milbeaut.c | 1 +
> drivers/mmc/host/sdhci-of-sparx5.c | 1 +
> 5 files changed, 5 insertions(+)
>
[snip]
> diff --git a/drivers/mmc/host/sdhci-of-sparx5.c b/drivers/mmc/host/sdhci-of-sparx5.c
> index 747f108a0ace..28e4ee69e100 100644
> --- a/drivers/mmc/host/sdhci-of-sparx5.c
> +++ b/drivers/mmc/host/sdhci-of-sparx5.c
> @@ -255,6 +255,7 @@ MODULE_DEVICE_TABLE(of, sdhci_sparx5_of_match);
> static struct platform_driver sdhci_sparx5_driver = {
> .driver = {
> .name = "sdhci-sparx5",
> + .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> .of_match_table = sdhci_sparx5_of_match,
> .pm = &sdhci_pltfm_pmops,
> },
Acked-by: Lars Povlsen <lars.povlsen@microchip.com>
--
Lars Povlsen,
Microchip
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 6/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that are newer than 5.4
2020-09-03 23:24 ` [PATCH 6/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that are newer than 5.4 Douglas Anderson
2020-09-04 8:14 ` Lars Povlsen
@ 2020-09-04 9:33 ` Angelo Dureghello
2020-09-04 10:42 ` Manivannan Sadhasivam
2 siblings, 0 replies; 14+ messages in thread
From: Angelo Dureghello @ 2020-09-04 9:33 UTC (permalink / raw)
To: Douglas Anderson
Cc: Ulf Hansson, linux-kernel, Neil Armstrong, Martin Blumenstingl,
Kevin Hilman, Steen Hegelund, linux-mmc, Adrian Hunter, swboyd,
linux-arm-kernel, Manivannan Sadhasivam, linux-amlogic,
Microchip Linux Driver Support, Andreas Färber,
Lars Povlsen, Jerome Brunet
On Fri, Sep 4, 2020 at 1:25 AM Douglas Anderson <dianders@chromium.org> wrote:
> This is like commit 3d3451124f3d ("mmc: sdhci-msm: Prefer asynchronous
> probe") but applied to a whole pile of drivers. This batch converts
> the drivers that appeared to have been added after kernel 5.4.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> drivers/mmc/host/meson-mx-sdhc-mmc.c | 1 +
> drivers/mmc/host/owl-mmc.c | 1 +
> drivers/mmc/host/sdhci-esdhc-mcf.c | 1 +
> drivers/mmc/host/sdhci-milbeaut.c | 1 +
> drivers/mmc/host/sdhci-of-sparx5.c | 1 +
> 5 files changed, 5 insertions(+)
[snip]
>
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-mcf.c b/drivers/mmc/host/sdhci-esdhc-mcf.c
> index 71bf086a9812..ca7a1690b2a8 100644
> --- a/drivers/mmc/host/sdhci-esdhc-mcf.c
> +++ b/drivers/mmc/host/sdhci-esdhc-mcf.c
> @@ -509,6 +509,7 @@ static int sdhci_esdhc_mcf_remove(struct platform_device *pdev)
> static struct platform_driver sdhci_esdhc_mcf_driver = {
> .driver = {
> .name = "sdhci-esdhc-mcf",
> + .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> },
> .probe = sdhci_esdhc_mcf_probe,
> .remove = sdhci_esdhc_mcf_remove,
>
Acked-by: Angelo Dureghello <angelo.dureghello@timesys.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 6/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that are newer than 5.4
2020-09-03 23:24 ` [PATCH 6/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that are newer than 5.4 Douglas Anderson
2020-09-04 8:14 ` Lars Povlsen
2020-09-04 9:33 ` Angelo Dureghello
@ 2020-09-04 10:42 ` Manivannan Sadhasivam
2 siblings, 0 replies; 14+ messages in thread
From: Manivannan Sadhasivam @ 2020-09-04 10:42 UTC (permalink / raw)
To: Douglas Anderson
Cc: Ulf Hansson, linux-kernel, Neil Armstrong, Martin Blumenstingl,
Kevin Hilman, Steen Hegelund, linux-mmc, Adrian Hunter,
Andreas Färber, Microchip Linux Driver Support,
linux-arm-kernel, linux-amlogic, swboyd, Angelo Dureghello,
Lars Povlsen, Jerome Brunet
On 0903, Douglas Anderson wrote:
> This is like commit 3d3451124f3d ("mmc: sdhci-msm: Prefer asynchronous
> probe") but applied to a whole pile of drivers. This batch converts
> the drivers that appeared to have been added after kernel 5.4.
>
Backporting made easy ;)
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
For owl-mmc,
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
>
> drivers/mmc/host/meson-mx-sdhc-mmc.c | 1 +
> drivers/mmc/host/owl-mmc.c | 1 +
> drivers/mmc/host/sdhci-esdhc-mcf.c | 1 +
> drivers/mmc/host/sdhci-milbeaut.c | 1 +
> drivers/mmc/host/sdhci-of-sparx5.c | 1 +
> 5 files changed, 5 insertions(+)
>
> diff --git a/drivers/mmc/host/meson-mx-sdhc-mmc.c b/drivers/mmc/host/meson-mx-sdhc-mmc.c
> index 53e3f6a4245a..7cd9c0ec2fcf 100644
> --- a/drivers/mmc/host/meson-mx-sdhc-mmc.c
> +++ b/drivers/mmc/host/meson-mx-sdhc-mmc.c
> @@ -903,6 +903,7 @@ static struct platform_driver meson_mx_sdhc_driver = {
> .remove = meson_mx_sdhc_remove,
> .driver = {
> .name = "meson-mx-sdhc",
> + .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> .of_match_table = of_match_ptr(meson_mx_sdhc_of_match),
> },
> };
> diff --git a/drivers/mmc/host/owl-mmc.c b/drivers/mmc/host/owl-mmc.c
> index df43f42855e2..ccf214a89eda 100644
> --- a/drivers/mmc/host/owl-mmc.c
> +++ b/drivers/mmc/host/owl-mmc.c
> @@ -689,6 +689,7 @@ MODULE_DEVICE_TABLE(of, owl_mmc_of_match);
> static struct platform_driver owl_mmc_driver = {
> .driver = {
> .name = "owl_mmc",
> + .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> .of_match_table = owl_mmc_of_match,
> },
> .probe = owl_mmc_probe,
> diff --git a/drivers/mmc/host/sdhci-esdhc-mcf.c b/drivers/mmc/host/sdhci-esdhc-mcf.c
> index 71bf086a9812..ca7a1690b2a8 100644
> --- a/drivers/mmc/host/sdhci-esdhc-mcf.c
> +++ b/drivers/mmc/host/sdhci-esdhc-mcf.c
> @@ -509,6 +509,7 @@ static int sdhci_esdhc_mcf_remove(struct platform_device *pdev)
> static struct platform_driver sdhci_esdhc_mcf_driver = {
> .driver = {
> .name = "sdhci-esdhc-mcf",
> + .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> },
> .probe = sdhci_esdhc_mcf_probe,
> .remove = sdhci_esdhc_mcf_remove,
> diff --git a/drivers/mmc/host/sdhci-milbeaut.c b/drivers/mmc/host/sdhci-milbeaut.c
> index 4e7cc0680f94..148b37ac6564 100644
> --- a/drivers/mmc/host/sdhci-milbeaut.c
> +++ b/drivers/mmc/host/sdhci-milbeaut.c
> @@ -333,6 +333,7 @@ static int sdhci_milbeaut_remove(struct platform_device *pdev)
> static struct platform_driver sdhci_milbeaut_driver = {
> .driver = {
> .name = "sdhci-milbeaut",
> + .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> .of_match_table = of_match_ptr(mlb_dt_ids),
> },
> .probe = sdhci_milbeaut_probe,
> diff --git a/drivers/mmc/host/sdhci-of-sparx5.c b/drivers/mmc/host/sdhci-of-sparx5.c
> index 747f108a0ace..28e4ee69e100 100644
> --- a/drivers/mmc/host/sdhci-of-sparx5.c
> +++ b/drivers/mmc/host/sdhci-of-sparx5.c
> @@ -255,6 +255,7 @@ MODULE_DEVICE_TABLE(of, sdhci_sparx5_of_match);
> static struct platform_driver sdhci_sparx5_driver = {
> .driver = {
> .name = "sdhci-sparx5",
> + .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> .of_match_table = sdhci_sparx5_of_match,
> .pm = &sdhci_pltfm_pmops,
> },
> --
> 2.28.0.526.ge36021eeef-goog
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for all host drivers
2020-09-03 23:24 [PATCH 0/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for all host drivers Douglas Anderson
` (2 preceding siblings ...)
2020-09-03 23:24 ` [PATCH 6/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that are newer than 5.4 Douglas Anderson
@ 2020-09-04 21:53 ` Martin Blumenstingl
2020-09-07 3:57 ` Anand Moon
2020-09-07 12:28 ` Ulf Hansson
4 siblings, 1 reply; 14+ messages in thread
From: Martin Blumenstingl @ 2020-09-04 21:53 UTC (permalink / raw)
To: Douglas Anderson
Cc: Heiko Stuebner, Geert Uytterhoeven, Linus Walleij,
Peter Ujfalusi, Jerome Brunet, linux-samsung-soc, Aaro Koskinen,
Kevin Hilman, Michal Simek, Ludovic Desroches, NXP Linux Team,
linux-tegra, Sascha Hauer, swboyd, Lars Persson, linux-omap,
Chaotian Jing, Scott Branden, Andrew Jeffery, Greg Kroah-Hartman,
Yoshihiro Shimoda, linux-kernel, Pengutronix Kernel Team,
Eugen Hristev, Alexandre Belloni, linux-aspeed, Yangtao Li,
Hu Ziji, Thierry Reding, Manivannan Sadhasivam, Jesper Nilsson,
Chunyan Zhang, linux-arm-kernel, Jonathan Hunter, linux-rockchip,
Kukjin Kim, Pierre Ossman, Saiyam Doshi, Maxime Ripard,
linux-rpi-kernel, linux-amlogic, linux-arm-kernel, Barry Song,
Nicolas Pitre, Patrice Chotard, Microchip Linux Driver Support,
Stefan Wahren, Christophe JAILLET, Ricky Wu,
Nicolas Saenz Julienne, Ulf Hansson, Neil Armstrong, Al Cooper,
Wolfram Sang, Fabio Estevam, Florian Fainelli, Steen Hegelund,
Krzysztof Kozlowski, Kishon Vijay Abraham I, Chen-Yu Tsai,
bcm-kernel-feedback-list, Joel Stanley, Orson Zhai, Ray Jui,
Ben Dooks, Masahiro Yamada, linux-mmc, Baolin Wang, Shawn Guo,
Andreas Färber, H. Nikolaus Schaller, Adrian Hunter,
Paul Cercueil, Lee Jones, Marek Vasut, Anson Huang,
Jaehoon Chung, Rui Miguel Silva, linux-mediatek, Manuel Lauss,
Matthias Brugger, Michał Mirosław, Angelo Dureghello,
Lars Povlsen, Nicolas Ferre, Tony Prisk, Vinod Koul,
Robert Richter, Viresh Kumar, Jun Nie
Hi Douglas,
On Fri, Sep 4, 2020 at 1:25 AM Douglas Anderson <dianders@chromium.org> wrote:
>
> As per discussion [1], it seems like it should be quite safe to turn
> on PROBE_PREFER_ASYNCHRONOUS for all sd/mmc host controllers. Let's
> give it a shot. For some discussion about this flag, see the commit
> message for commit 3d3451124f3d ("mmc: sdhci-msm: Prefer asynchronous
> probe").
can this somehow change the order in which the MMC drivers end up loading?
on Amlogic SoCs we have up to three MMC controllers, some SoCs even
use two different MMC controller IPs (and therefore two different
drivers).
so far the MMC controller naming (/dev/mmcblk* etc.) was consistent -
can that change with this patch?
apologies if this has been discussed and answered anywhere
Best regards,
Martin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 0/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for all host drivers
2020-09-04 21:53 ` [PATCH 0/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for all host drivers Martin Blumenstingl
@ 2020-09-07 3:57 ` Anand Moon
2020-09-07 4:04 ` Chen-Yu Tsai
2020-09-07 4:07 ` Chen-Yu Tsai
0 siblings, 2 replies; 14+ messages in thread
From: Anand Moon @ 2020-09-07 3:57 UTC (permalink / raw)
To: Martin Blumenstingl
Cc: Heiko Stuebner, Geert Uytterhoeven, Linus Walleij,
Peter Ujfalusi, Jerome Brunet, linux-samsung-soc, Aaro Koskinen,
Kevin Hilman, Michal Simek, Ludovic Desroches, NXP Linux Team,
linux-tegra, Sascha Hauer, Michał Mirosław,
Lars Persson, linux-omap, Chaotian Jing, Scott Branden,
Andrew Jeffery, Greg Kroah-Hartman, Yoshihiro Shimoda,
Linux Kernel, Pengutronix Kernel Team, Eugen Hristev,
Alexandre Belloni, linux-aspeed, Yangtao Li, Hu Ziji,
Thierry Reding, Manivannan Sadhasivam, Jesper Nilsson,
Chunyan Zhang, linux-arm-kernel, Jonathan Hunter, linux-rockchip,
Kukjin Kim, Pierre Ossman, Saiyam Doshi, Maxime Ripard,
linux-rpi-kernel, linux-amlogic, linux-arm-kernel, Barry Song,
Nicolas Pitre, Douglas Anderson, Microchip Linux Driver Support,
Stefan Wahren, Christophe JAILLET, Ricky Wu,
Nicolas Saenz Julienne, Ulf Hansson, Neil Armstrong, Al Cooper,
Wolfram Sang, Fabio Estevam, Florian Fainelli, Steen Hegelund,
Krzysztof Kozlowski, Kishon Vijay Abraham I, Chen-Yu Tsai,
bcm-kernel-feedback-list, Joel Stanley, Orson Zhai, Ray Jui,
Ben Dooks, Masahiro Yamada, linux-mmc, Baolin Wang, Shawn Guo,
Andreas Färber, H. Nikolaus Schaller, Nicolas Ferre,
Paul Cercueil, Lee Jones, Marek Vasut, Anson Huang,
Jaehoon Chung, Robert Richter, Rui Miguel Silva, linux-mediatek,
Manuel Lauss, Matthias Brugger, swboyd, Angelo Dureghello,
Lars Povlsen, Adrian Hunter, Tony Prisk, Vinod Koul,
Patrice Chotard, Viresh Kumar, Jun Nie
Hi Martin.
On Sat, 5 Sep 2020 at 03:24, Martin Blumenstingl
<martin.blumenstingl@googlemail.com> wrote:
>
> Hi Douglas,
>
> On Fri, Sep 4, 2020 at 1:25 AM Douglas Anderson <dianders@chromium.org> wrote:
> >
> > As per discussion [1], it seems like it should be quite safe to turn
> > on PROBE_PREFER_ASYNCHRONOUS for all sd/mmc host controllers. Let's
> > give it a shot. For some discussion about this flag, see the commit
> > message for commit 3d3451124f3d ("mmc: sdhci-msm: Prefer asynchronous
> > probe").
> can this somehow change the order in which the MMC drivers end up loading?
> on Amlogic SoCs we have up to three MMC controllers, some SoCs even
> use two different MMC controller IPs (and therefore two different
> drivers).
> so far the MMC controller naming (/dev/mmcblk* etc.) was consistent -
> can that change with this patch?
>
We could resolve this by setting up aliases for mmc nodes in the dts.
> apologies if this has been discussed and answered anywhere
>
>
> Best regards,
> Martin
Best regards
-Anand
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 0/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for all host drivers
2020-09-07 3:57 ` Anand Moon
@ 2020-09-07 4:04 ` Chen-Yu Tsai
2020-09-07 4:07 ` Chen-Yu Tsai
1 sibling, 0 replies; 14+ messages in thread
From: Chen-Yu Tsai @ 2020-09-07 4:04 UTC (permalink / raw)
To: Anand Moon
Cc: Heiko Stuebner, Geert Uytterhoeven, Linus Walleij,
Peter Ujfalusi, Jerome Brunet,
moderated list:ARM/SAMSUNG EXYNO...,
Aaro Koskinen, Kevin Hilman, Michal Simek, Ludovic Desroches,
NXP Linux Team, linux-tegra, Sascha Hauer,
Michał Mirosław, Lars Persson,
open list:OMAP2+ SUPPORT, Chaotian Jing, Scott Branden,
Andrew Jeffery, Greg Kroah-Hartman, Yoshihiro Shimoda,
Linux Kernel, Pengutronix Kernel Team, Eugen Hristev,
Alexandre Belloni, linux-aspeed, Yangtao Li, Hu Ziji,
Thierry Reding, Manivannan Sadhasivam, Jesper Nilsson,
Chunyan Zhang, linux-arm-kernel, Jonathan Hunter,
open list:ARM/Rockchip SoC...,
Kukjin Kim, Pierre Ossman, Saiyam Doshi, Martin Blumenstingl,
Maxime Ripard, moderated list:BROADCOM BCM2835...,
open list:ARM/Amlogic Meson...,
linux-arm-kernel, Barry Song, Nicolas Pitre, Douglas Anderson,
Microchip Linux Driver Support, Stefan Wahren,
Christophe JAILLET, Ricky Wu, Nicolas Saenz Julienne,
Ulf Hansson, Neil Armstrong, Al Cooper, Wolfram Sang,
Fabio Estevam, Florian Fainelli, Steen Hegelund,
Krzysztof Kozlowski, Kishon Vijay Abraham I,
open list:BROADCOM BCM281XX...,
Joel Stanley, Orson Zhai, Ray Jui, Ben Dooks, Masahiro Yamada,
linux-mmc, Baolin Wang, Shawn Guo, Andreas Färber,
H. Nikolaus Schaller, Nicolas Ferre, Paul Cercueil, Lee Jones,
Marek Vasut, Anson Huang, Jaehoon Chung, Robert Richter,
Rui Miguel Silva, moderated list:ARM/Mediatek SoC...,
Manuel Lauss, Matthias Brugger, Stephen Boyd, Angelo Dureghello,
Lars Povlsen, Adrian Hunter, Tony Prisk, Vinod Koul,
Patrice Chotard, Viresh Kumar, Jun Nie
On Mon, Sep 7, 2020 at 11:57 AM Anand Moon <linux.amoon@gmail.com> wrote:
>
> Hi Martin.
>
> On Sat, 5 Sep 2020 at 03:24, Martin Blumenstingl
> <martin.blumenstingl@googlemail.com> wrote:
> >
> > Hi Douglas,
> >
> > On Fri, Sep 4, 2020 at 1:25 AM Douglas Anderson <dianders@chromium.org> wrote:
> > >
> > > As per discussion [1], it seems like it should be quite safe to turn
> > > on PROBE_PREFER_ASYNCHRONOUS for all sd/mmc host controllers. Let's
> > > give it a shot. For some discussion about this flag, see the commit
> > > message for commit 3d3451124f3d ("mmc: sdhci-msm: Prefer asynchronous
> > > probe").
> > can this somehow change the order in which the MMC drivers end up loading?
> > on Amlogic SoCs we have up to three MMC controllers, some SoCs even
> > use two different MMC controller IPs (and therefore two different
> > drivers).
> > so far the MMC controller naming (/dev/mmcblk* etc.) was consistent -
> > can that change with this patch?
> >
>
> We could resolve this by setting up aliases for mmc nodes in the dts.
Right now, only the dw_mmc driver family supports aliases for mmc nodes.
> > apologies if this has been discussed and answered anywhere
> >
> >
> > Best regards,
> > Martin
>
> Best regards
> -Anand
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 0/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for all host drivers
2020-09-07 3:57 ` Anand Moon
2020-09-07 4:04 ` Chen-Yu Tsai
@ 2020-09-07 4:07 ` Chen-Yu Tsai
2020-09-07 10:25 ` Ulf Hansson
1 sibling, 1 reply; 14+ messages in thread
From: Chen-Yu Tsai @ 2020-09-07 4:07 UTC (permalink / raw)
To: Anand Moon
Cc: Heiko Stuebner, Geert Uytterhoeven, Linus Walleij,
Peter Ujfalusi, Jerome Brunet,
moderated list:ARM/SAMSUNG EXYNO...,
Aaro Koskinen, Kevin Hilman, Michal Simek, Ludovic Desroches,
NXP Linux Team, linux-tegra, Sascha Hauer,
Michał Mirosław, Lars Persson,
open list:OMAP2+ SUPPORT, Chaotian Jing, Scott Branden,
Andrew Jeffery, Greg Kroah-Hartman, Yoshihiro Shimoda,
Linux Kernel, Pengutronix Kernel Team, Eugen Hristev,
Alexandre Belloni, linux-aspeed, Yangtao Li, Hu Ziji,
Thierry Reding, Manivannan Sadhasivam, Jesper Nilsson,
Chunyan Zhang, linux-arm-kernel, Jonathan Hunter,
open list:ARM/Rockchip SoC...,
Kukjin Kim, Pierre Ossman, Saiyam Doshi, Martin Blumenstingl,
Maxime Ripard, moderated list:BROADCOM BCM2835...,
open list:ARM/Amlogic Meson...,
linux-arm-kernel, Barry Song, Nicolas Pitre, Douglas Anderson,
Microchip Linux Driver Support, Stefan Wahren,
Christophe JAILLET, Ricky Wu, Nicolas Saenz Julienne,
Ulf Hansson, Neil Armstrong, Al Cooper, Wolfram Sang,
Fabio Estevam, Florian Fainelli, Steen Hegelund,
Krzysztof Kozlowski, Kishon Vijay Abraham I,
open list:BROADCOM BCM281XX...,
Joel Stanley, Orson Zhai, Ray Jui, Ben Dooks, Masahiro Yamada,
linux-mmc, Baolin Wang, Shawn Guo, Andreas Färber,
H. Nikolaus Schaller, Nicolas Ferre, Paul Cercueil, Lee Jones,
Marek Vasut, Anson Huang, Jaehoon Chung, Robert Richter,
Rui Miguel Silva, moderated list:ARM/Mediatek SoC...,
Manuel Lauss, Matthias Brugger, Stephen Boyd, Angelo Dureghello,
Lars Povlsen, Adrian Hunter, Tony Prisk, Vinod Koul,
Patrice Chotard, Viresh Kumar, Jun Nie
(Resent from kernel.org)
On Mon, Sep 7, 2020 at 11:57 AM Anand Moon <linux.amoon@gmail.com> wrote:
>
> Hi Martin.
>
> On Sat, 5 Sep 2020 at 03:24, Martin Blumenstingl
> <martin.blumenstingl@googlemail.com> wrote:
> >
> > Hi Douglas,
> >
> > On Fri, Sep 4, 2020 at 1:25 AM Douglas Anderson <dianders@chromium.org> wrote:
> > >
> > > As per discussion [1], it seems like it should be quite safe to turn
> > > on PROBE_PREFER_ASYNCHRONOUS for all sd/mmc host controllers. Let's
> > > give it a shot. For some discussion about this flag, see the commit
> > > message for commit 3d3451124f3d ("mmc: sdhci-msm: Prefer asynchronous
> > > probe").
> > can this somehow change the order in which the MMC drivers end up loading?
> > on Amlogic SoCs we have up to three MMC controllers, some SoCs even
> > use two different MMC controller IPs (and therefore two different
> > drivers).
> > so far the MMC controller naming (/dev/mmcblk* etc.) was consistent -
> > can that change with this patch?
> >
>
> We could resolve this by setting up aliases for mmc nodes in the dts.
Right now, only the dw_mmc driver family supports aliases for mmc nodes.
> > apologies if this has been discussed and answered anywhere
> >
> >
> > Best regards,
> > Martin
>
> Best regards
> -Anand
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 0/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for all host drivers
2020-09-07 4:07 ` Chen-Yu Tsai
@ 2020-09-07 10:25 ` Ulf Hansson
0 siblings, 0 replies; 14+ messages in thread
From: Ulf Hansson @ 2020-09-07 10:25 UTC (permalink / raw)
To: Chen-Yu Tsai, Anand Moon, Martin Blumenstingl
Cc: Heiko Stuebner, Geert Uytterhoeven, Linus Walleij,
Peter Ujfalusi, Jerome Brunet,
moderated list:ARM/SAMSUNG EXYNO...,
Aaro Koskinen, Kevin Hilman, Michal Simek, Ludovic Desroches,
NXP Linux Team, linux-tegra, Sascha Hauer,
Michał Mirosław, Lars Persson,
open list:OMAP2+ SUPPORT, Chaotian Jing, Scott Branden,
Andrew Jeffery, Greg Kroah-Hartman, Yoshihiro Shimoda,
Linux Kernel, Pengutronix Kernel Team, Eugen Hristev,
Alexandre Belloni, linux-aspeed, Yangtao Li, Hu Ziji,
Thierry Reding, Manivannan Sadhasivam, Jesper Nilsson,
Chunyan Zhang, linux-arm-kernel, Jonathan Hunter,
open list:ARM/Rockchip SoC...,
Kukjin Kim, Pierre Ossman, Saiyam Doshi, Maxime Ripard,
moderated list:BROADCOM BCM2835...,
open list:ARM/Amlogic Meson...,
linux-arm-kernel, Barry Song, Nicolas Pitre, Douglas Anderson,
Microchip Linux Driver Support, Stefan Wahren,
Christophe JAILLET, Ricky Wu, Nicolas Saenz Julienne,
Neil Armstrong, Al Cooper, Wolfram Sang, Fabio Estevam,
Florian Fainelli, Steen Hegelund, Krzysztof Kozlowski,
Kishon Vijay Abraham I, open list:BROADCOM BCM281XX...,
Joel Stanley, Orson Zhai, Ray Jui, Ben Dooks, Masahiro Yamada,
linux-mmc, Baolin Wang, Shawn Guo, Andreas Färber,
H. Nikolaus Schaller, Nicolas Ferre, Paul Cercueil, Lee Jones,
Marek Vasut, Anson Huang, Jaehoon Chung, Robert Richter,
Rui Miguel Silva, moderated list:ARM/Mediatek SoC...,
Manuel Lauss, Matthias Brugger, Stephen Boyd, Angelo Dureghello,
Lars Povlsen, Adrian Hunter, Tony Prisk, Vinod Koul,
Patrice Chotard, Viresh Kumar, Jun Nie
On Mon, 7 Sep 2020 at 06:08, Chen-Yu Tsai <wens@kernel.org> wrote:
>
> (Resent from kernel.org)
>
> On Mon, Sep 7, 2020 at 11:57 AM Anand Moon <linux.amoon@gmail.com> wrote:
> >
> > Hi Martin.
> >
> > On Sat, 5 Sep 2020 at 03:24, Martin Blumenstingl
> > <martin.blumenstingl@googlemail.com> wrote:
> > >
> > > Hi Douglas,
> > >
> > > On Fri, Sep 4, 2020 at 1:25 AM Douglas Anderson <dianders@chromium.org> wrote:
> > > >
> > > > As per discussion [1], it seems like it should be quite safe to turn
> > > > on PROBE_PREFER_ASYNCHRONOUS for all sd/mmc host controllers. Let's
> > > > give it a shot. For some discussion about this flag, see the commit
> > > > message for commit 3d3451124f3d ("mmc: sdhci-msm: Prefer asynchronous
> > > > probe").
> > > can this somehow change the order in which the MMC drivers end up loading?
> > > on Amlogic SoCs we have up to three MMC controllers, some SoCs even
> > > use two different MMC controller IPs (and therefore two different
> > > drivers).
> > > so far the MMC controller naming (/dev/mmcblk* etc.) was consistent -
> > > can that change with this patch?
> > >
Consistency has never been guaranteed. Just imagine one of the mmc
host drivers ending up lacking some of its resources during ->probe()
and returning -EPROBE_DEFER.
UUID/PARTID has been the only way.
> >
> > We could resolve this by setting up aliases for mmc nodes in the dts.
Yes, this is now possible due to the recently [1] applied patches for
supporting mmc aliases.
>
> Right now, only the dw_mmc driver family supports aliases for mmc nodes.
That's "mshc" specific (related to the old multiple slot support I
think), but not affecting the mmc aliases, which the mmc core now is
supporting.
So the mmc aliases are common for all mmc hosts. Please have a look at
the new OF parsing in mmc_alloc_host().
[...]
Kind regards
Uffe
[1]
https://patchwork.kernel.org/patch/11747669/
https://patchwork.kernel.org/patch/11747671/
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for all host drivers
2020-09-03 23:24 [PATCH 0/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for all host drivers Douglas Anderson
` (3 preceding siblings ...)
2020-09-04 21:53 ` [PATCH 0/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for all host drivers Martin Blumenstingl
@ 2020-09-07 12:28 ` Ulf Hansson
4 siblings, 0 replies; 14+ messages in thread
From: Ulf Hansson @ 2020-09-07 12:28 UTC (permalink / raw)
To: Douglas Anderson
Cc: Heiko Stuebner, Geert Uytterhoeven, Linus Walleij,
Peter Ujfalusi, Jerome Brunet, linux-samsung-soc, Aaro Koskinen,
Kevin Hilman, Michal Simek, Ludovic Desroches, NXP Linux Team,
linux-tegra, Sascha Hauer, Stephen Boyd, Lars Persson,
linux-omap, Chaotian Jing, Scott Branden, Andrew Jeffery,
Greg Kroah-Hartman, Yoshihiro Shimoda, Linux Kernel Mailing List,
Pengutronix Kernel Team, Eugen Hristev, Alexandre Belloni,
linux-aspeed, Yangtao Li, Hu Ziji, Thierry Reding,
Manivannan Sadhasivam, Jesper Nilsson, Chunyan Zhang,
linux-arm-kernel, Jonathan Hunter, open list:ARM/Rockchip SoC...,
Kukjin Kim, Pierre Ossman, Saiyam Doshi, Martin Blumenstingl,
Maxime Ripard, moderated list:BROADCOM BCM2835...,
open list:ARM/Amlogic Meson...,
Linux ARM, Barry Song, Nicolas Pitre, Patrice Chotard,
Microchip Linux Driver Support, Stefan Wahren,
Christophe JAILLET, Ricky Wu, Nicolas Saenz Julienne,
Neil Armstrong, Al Cooper, Wolfram Sang, Fabio Estevam,
Florian Fainelli, Steen Hegelund, Krzysztof Kozlowski,
Kishon Vijay Abraham I, Chen-Yu Tsai, BCM Kernel Feedback,
Joel Stanley, Orson Zhai, Ray Jui, Ben Dooks, Masahiro Yamada,
linux-mmc, Baolin Wang, Shawn Guo, Andreas Färber,
H. Nikolaus Schaller, Adrian Hunter, Paul Cercueil, Lee Jones,
Marek Vasut, Anson Huang, Jaehoon Chung, Rui Miguel Silva,
moderated list:ARM/Mediatek SoC support, Manuel Lauss,
Matthias Brugger, Michał Mirosław, Angelo Dureghello,
Lars Povlsen, Nicolas Ferre, Tony Prisk, Vinod Koul,
Robert Richter, Viresh Kumar, Jun Nie
On Fri, 4 Sep 2020 at 01:25, Douglas Anderson <dianders@chromium.org> wrote:
>
> As per discussion [1], it seems like it should be quite safe to turn
> on PROBE_PREFER_ASYNCHRONOUS for all sd/mmc host controllers. Let's
> give it a shot. For some discussion about this flag, see the commit
> message for commit 3d3451124f3d ("mmc: sdhci-msm: Prefer asynchronous
> probe").
>
> I've broken this series into chunks based on LTS kernel releases to
> attempt to make it easier if someone wanted to cherry-pick it to an
> older kernel. While these cherry-picks won't be conflict free, there
> should only be trivial context conflicts and no problems with drivers
> that are totally missing. This is a bit of a compromise between a
> 1-big patch and a many-part patch series.
>
> I have only tested this on a rk3399-kevin (sdhci-of-arasan) and a
> rk3288-veyron (dw_mmc-rockchip) device and only lightly. If this
> patch causes anyone problems those drivers should be marked with
> PROBE_FORCE_SYNCHRONOUS, debugged, and then go back to prefer
> asynchronous. Any problems are likely just a hidden bug that has been
> exposed by this change.
>
> NOTE: in theory, it'd be nice if there was a KConfig option that we
> could flip that would turn on async probe everywhere (except for those
> that opt out by adding PROBE_FORCE_SYNCHRONOUS). My hope is that by
> adding this flag in more places it will become clear that this flag is
> working reliably and easier to move over when we're ready.
>
> While coccinelle is too difficult for my feeble brain, I managed to
> whip up a pretty terrible python script to help with this. For your
> edification:
>
> import os
> import sys
> import re
>
> for filename in os.listdir("."):
> found_plat = False
> found_driver = False
> output = []
> for line in open(filename, "r").readlines():
> output.append(line)
>
> if "struct platform_driver" in line:
> found_plat = True
> if found_plat and re.search(r"\t\.driver\s*=\s*{", line):
> found_driver = True
> found_plat = False
> mo = re.search(r"(\s*)\.name(\s*)=", line)
> if found_driver and mo:
> if mo.group(2) == " ":
> space = " "
> elif mo.group(2) == "\t":
> # Best we can do
> space = " "
> elif mo.group(2).startswith("\t"):
> # Guess that removing one tab is right
> space = mo.group(2)[1:]
> else:
> # Guess it's all spaces
> space = mo.group(2)[7:] + " "
>
> output.append("%s.probe_type%s= PROBE_PREFER_ASYNCHRONOUS,\n" % (mo.group(1), space))
> found_driver = False
>
> open(filename, "w").write("".join(output))
>
> [1] https://lore.kernel.org/r/CAPDyKFq31bucJhP9hp1HSqh-qM2uNGHgDoyQpmbJf00nEf_T4Q@mail.gmail.com/
>
>
> Douglas Anderson (6):
> mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in v4.4
> mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in v4.9
> mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in v4.14
> mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in v4.19
> mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in v5.4
> mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that are newer than 5.4
>
> drivers/mmc/host/alcor.c | 1 +
> drivers/mmc/host/android-goldfish.c | 1 +
> drivers/mmc/host/atmel-mci.c | 1 +
> drivers/mmc/host/au1xmmc.c | 1 +
> drivers/mmc/host/bcm2835.c | 1 +
> drivers/mmc/host/cavium-octeon.c | 1 +
> drivers/mmc/host/davinci_mmc.c | 1 +
> drivers/mmc/host/dw_mmc-bluefield.c | 1 +
> drivers/mmc/host/dw_mmc-exynos.c | 1 +
> drivers/mmc/host/dw_mmc-hi3798cv200.c | 1 +
> drivers/mmc/host/dw_mmc-k3.c | 1 +
> drivers/mmc/host/dw_mmc-pltfm.c | 1 +
> drivers/mmc/host/dw_mmc-rockchip.c | 1 +
> drivers/mmc/host/dw_mmc-zx.c | 1 +
> drivers/mmc/host/jz4740_mmc.c | 1 +
> drivers/mmc/host/meson-gx-mmc.c | 1 +
> drivers/mmc/host/meson-mx-sdhc-mmc.c | 1 +
> drivers/mmc/host/meson-mx-sdio.c | 1 +
> drivers/mmc/host/moxart-mmc.c | 1 +
> drivers/mmc/host/mtk-sd.c | 1 +
> drivers/mmc/host/mvsdio.c | 1 +
> drivers/mmc/host/mxcmmc.c | 1 +
> drivers/mmc/host/mxs-mmc.c | 1 +
> drivers/mmc/host/omap.c | 1 +
> drivers/mmc/host/omap_hsmmc.c | 1 +
> drivers/mmc/host/owl-mmc.c | 1 +
> drivers/mmc/host/pxamci.c | 1 +
> drivers/mmc/host/renesas_sdhi_internal_dmac.c | 1 +
> drivers/mmc/host/renesas_sdhi_sys_dmac.c | 1 +
> drivers/mmc/host/rtsx_pci_sdmmc.c | 1 +
> drivers/mmc/host/rtsx_usb_sdmmc.c | 1 +
> drivers/mmc/host/s3cmci.c | 1 +
> drivers/mmc/host/sdhci-acpi.c | 1 +
> drivers/mmc/host/sdhci-bcm-kona.c | 1 +
> drivers/mmc/host/sdhci-brcmstb.c | 1 +
> drivers/mmc/host/sdhci-cadence.c | 1 +
> drivers/mmc/host/sdhci-cns3xxx.c | 1 +
> drivers/mmc/host/sdhci-dove.c | 1 +
> drivers/mmc/host/sdhci-esdhc-imx.c | 1 +
> drivers/mmc/host/sdhci-esdhc-mcf.c | 1 +
> drivers/mmc/host/sdhci-iproc.c | 1 +
> drivers/mmc/host/sdhci-milbeaut.c | 1 +
> drivers/mmc/host/sdhci-of-arasan.c | 1 +
> drivers/mmc/host/sdhci-of-aspeed.c | 2 ++
> drivers/mmc/host/sdhci-of-at91.c | 1 +
> drivers/mmc/host/sdhci-of-dwcmshc.c | 1 +
> drivers/mmc/host/sdhci-of-esdhc.c | 1 +
> drivers/mmc/host/sdhci-of-hlwd.c | 1 +
> drivers/mmc/host/sdhci-of-sparx5.c | 1 +
> drivers/mmc/host/sdhci-omap.c | 1 +
> drivers/mmc/host/sdhci-pic32.c | 1 +
> drivers/mmc/host/sdhci-pxav2.c | 1 +
> drivers/mmc/host/sdhci-pxav3.c | 1 +
> drivers/mmc/host/sdhci-s3c.c | 1 +
> drivers/mmc/host/sdhci-sirf.c | 1 +
> drivers/mmc/host/sdhci-spear.c | 1 +
> drivers/mmc/host/sdhci-sprd.c | 1 +
> drivers/mmc/host/sdhci-st.c | 1 +
> drivers/mmc/host/sdhci-tegra.c | 1 +
> drivers/mmc/host/sdhci-xenon.c | 1 +
> drivers/mmc/host/sdhci_am654.c | 1 +
> drivers/mmc/host/sdhci_f_sdh30.c | 1 +
> drivers/mmc/host/sh_mmcif.c | 1 +
> drivers/mmc/host/sunxi-mmc.c | 1 +
> drivers/mmc/host/tmio_mmc.c | 1 +
> drivers/mmc/host/uniphier-sd.c | 1 +
> drivers/mmc/host/usdhi6rol0.c | 1 +
> drivers/mmc/host/wbsd.c | 1 +
> drivers/mmc/host/wmt-sdmmc.c | 1 +
> 69 files changed, 70 insertions(+)
>
> --
> 2.28.0.526.ge36021eeef-goog
>
An interesting idea about a patch per LTS release. I think it makes
perfect sense in this type of case.
Let's give this a shot in next and see how it goes. So, applied for
next, thanks!
Kind regards
Uffe
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 14+ messages in thread