* [PATCH 15/18] dt-bindings: usb: meson-g12a-usb: Discard FL-adj property [not found] <20201010224121.12672-1-Sergey.Semin@baikalelectronics.ru> @ 2020-10-10 22:41 ` Serge Semin 2020-10-12 7:54 ` Neil Armstrong 2020-10-10 22:41 ` [PATCH 16/18] dt-bindings: usb: meson-g12a-usb: Validate DWC2/DWC3 sub-nodes Serge Semin 1 sibling, 1 reply; 10+ messages in thread From: Serge Semin @ 2020-10-10 22:41 UTC (permalink / raw) To: Mathias Nyman, Felipe Balbi, Greg Kroah-Hartman, Rob Herring, Kevin Hilman, Neil Armstrong, Jerome Brunet, Martin Blumenstingl Cc: devicetree, linux-kernel, Yoshihiro Shimoda, linux-usb, Lad Prabhakar, Serge Semin, Bjorn Andersson, Serge Semin, Manu Gautam, Andy Gross, Pavel Parkhomenko, linux-amlogic, Alexey Malahov, linux-arm-kernel, Roger Quadros An empty snps,quirk-frame-length-adjustment won't cause any change performed by the driver. Moreover the DT schema validation will fail, since it expects the property being assigned with some value. So just discard the property declaration then from the example. Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> --- Note the same problem is in the DT source file arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi . --- .../devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml index 5b04a7dfa018..88184d7e26cc 100644 --- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml @@ -209,6 +209,5 @@ examples: interrupts = <30>; dr_mode = "host"; snps,dis_u2_susphy_quirk; - snps,quirk-frame-length-adjustment; }; }; -- 2.27.0 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 15/18] dt-bindings: usb: meson-g12a-usb: Discard FL-adj property 2020-10-10 22:41 ` [PATCH 15/18] dt-bindings: usb: meson-g12a-usb: Discard FL-adj property Serge Semin @ 2020-10-12 7:54 ` Neil Armstrong 2020-10-12 14:22 ` Serge Semin 0 siblings, 1 reply; 10+ messages in thread From: Neil Armstrong @ 2020-10-12 7:54 UTC (permalink / raw) To: Serge Semin, Mathias Nyman, Felipe Balbi, Greg Kroah-Hartman, Rob Herring, Kevin Hilman, Jerome Brunet, Martin Blumenstingl Cc: devicetree, linux-kernel, Yoshihiro Shimoda, linux-usb, Lad Prabhakar, Serge Semin, Bjorn Andersson, Manu Gautam, Andy Gross, Pavel Parkhomenko, linux-amlogic, Alexey Malahov, linux-arm-kernel, Roger Quadros Hi, On 11/10/2020 00:41, Serge Semin wrote: > An empty snps,quirk-frame-length-adjustment won't cause any change > performed by the driver. Moreover the DT schema validation will fail, > since it expects the property being assigned with some value. So just > discard the property declaration then from the example. > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > --- > > Note the same problem is in the DT source file > arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi . > --- > .../devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > index 5b04a7dfa018..88184d7e26cc 100644 > --- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > @@ -209,6 +209,5 @@ examples: > interrupts = <30>; > dr_mode = "host"; > snps,dis_u2_susphy_quirk; > - snps,quirk-frame-length-adjustment; > }; > }; > Thanks for reporting this, actually the fladj must be 0x20 on this hw, but we do set this on the PHY side, so we can let the dwc3 side 0 here. Acked-by: Neil Armstrong <narmstrong@baylibre.com> Neil _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 15/18] dt-bindings: usb: meson-g12a-usb: Discard FL-adj property 2020-10-12 7:54 ` Neil Armstrong @ 2020-10-12 14:22 ` Serge Semin 2020-10-12 15:01 ` Neil Armstrong 0 siblings, 1 reply; 10+ messages in thread From: Serge Semin @ 2020-10-12 14:22 UTC (permalink / raw) To: Neil Armstrong Cc: linux-arm-kernel, Felipe Balbi, Roger Quadros, Mathias Nyman, devicetree, Martin Blumenstingl, Kevin Hilman, Lad Prabhakar, linux-usb, Andy Gross, Serge Semin, Alexey Malahov, Manu Gautam, Rob Herring, Pavel Parkhomenko, Greg Kroah-Hartman, linux-amlogic, Bjorn Andersson, Yoshihiro Shimoda, linux-kernel, Jerome Brunet On Mon, Oct 12, 2020 at 09:54:25AM +0200, Neil Armstrong wrote: > Hi, > > On 11/10/2020 00:41, Serge Semin wrote: > > An empty snps,quirk-frame-length-adjustment won't cause any change > > performed by the driver. Moreover the DT schema validation will fail, > > since it expects the property being assigned with some value. So just > > discard the property declaration then from the example. > > > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > > > --- > > > > Note the same problem is in the DT source file > > arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi . > > --- > > .../devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > > index 5b04a7dfa018..88184d7e26cc 100644 > > --- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > > +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > > @@ -209,6 +209,5 @@ examples: > > interrupts = <30>; > > dr_mode = "host"; > > snps,dis_u2_susphy_quirk; > > - snps,quirk-frame-length-adjustment; > > }; > > }; > > > > Thanks for reporting this, actually the fladj must be 0x20 on this hw, > but we do set this on the PHY side, so we can let the dwc3 side 0 here. I can convert this patch to initializing the "snps,quirk-frame-length-adjustment" property with 0x20 value instead. Since most likely I'll have to send a v2/v3/etc of this patchset, that modification won't be too much work to do. What do you think? Anyway please note, that I've fixed the improper property usage in the DT schema example only. "snps,quirk-frame-length-adjustment" defined as boolean still persists in the DTS file: arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi . So if you ever try to validate that dts file with "make dtbs_check" scenario, it will fail. -Sergey > > Acked-by: Neil Armstrong <narmstrong@baylibre.com> > > Neil > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 15/18] dt-bindings: usb: meson-g12a-usb: Discard FL-adj property 2020-10-12 14:22 ` Serge Semin @ 2020-10-12 15:01 ` Neil Armstrong 2020-10-12 15:13 ` Serge Semin 0 siblings, 1 reply; 10+ messages in thread From: Neil Armstrong @ 2020-10-12 15:01 UTC (permalink / raw) To: Serge Semin Cc: linux-arm-kernel, Felipe Balbi, Roger Quadros, Mathias Nyman, devicetree, Martin Blumenstingl, Kevin Hilman, Lad Prabhakar, linux-usb, Andy Gross, Serge Semin, Alexey Malahov, Manu Gautam, Rob Herring, Pavel Parkhomenko, Greg Kroah-Hartman, linux-amlogic, Bjorn Andersson, Yoshihiro Shimoda, linux-kernel, Jerome Brunet Hi, On 12/10/2020 16:22, Serge Semin wrote: > On Mon, Oct 12, 2020 at 09:54:25AM +0200, Neil Armstrong wrote: >> Hi, >> >> On 11/10/2020 00:41, Serge Semin wrote: >>> An empty snps,quirk-frame-length-adjustment won't cause any change >>> performed by the driver. Moreover the DT schema validation will fail, >>> since it expects the property being assigned with some value. So just >>> discard the property declaration then from the example. >>> >>> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> >>> >>> --- >>> >>> Note the same problem is in the DT source file >>> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi . >>> --- >>> .../devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml >>> index 5b04a7dfa018..88184d7e26cc 100644 >>> --- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml >>> +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml >>> @@ -209,6 +209,5 @@ examples: >>> interrupts = <30>; >>> dr_mode = "host"; >>> snps,dis_u2_susphy_quirk; >>> - snps,quirk-frame-length-adjustment; >>> }; >>> }; >>> >> > >> Thanks for reporting this, actually the fladj must be 0x20 on this hw, >> but we do set this on the PHY side, so we can let the dwc3 side 0 here. > > I can convert this patch to initializing the "snps,quirk-frame-length-adjustment" > property with 0x20 value instead. Since most likely I'll have to send a v2/v3/etc > of this patchset, that modification won't be too much work to do. What do you think? Yes, do this please, anyway it's only an example so it's ok. > > Anyway please note, that I've fixed the improper property usage in the DT schema > example only. "snps,quirk-frame-length-adjustment" defined as boolean still > persists in the DTS file: arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi . > So if you ever try to validate that dts file with "make dtbs_check" scenario, it > will fail. Yes, I'll push a fix to pass the dtbs_check when this is merged. Thanks, Neil > > -Sergey > >> >> Acked-by: Neil Armstrong <narmstrong@baylibre.com> >> >> Neil >> _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 15/18] dt-bindings: usb: meson-g12a-usb: Discard FL-adj property 2020-10-12 15:01 ` Neil Armstrong @ 2020-10-12 15:13 ` Serge Semin 2020-10-12 15:29 ` Neil Armstrong 0 siblings, 1 reply; 10+ messages in thread From: Serge Semin @ 2020-10-12 15:13 UTC (permalink / raw) To: Neil Armstrong Cc: linux-arm-kernel, Felipe Balbi, Roger Quadros, Mathias Nyman, devicetree, Martin Blumenstingl, Kevin Hilman, Lad Prabhakar, linux-usb, Andy Gross, Serge Semin, Alexey Malahov, Manu Gautam, Rob Herring, Pavel Parkhomenko, Greg Kroah-Hartman, linux-amlogic, Bjorn Andersson, Yoshihiro Shimoda, linux-kernel, Jerome Brunet On Mon, Oct 12, 2020 at 05:01:43PM +0200, Neil Armstrong wrote: > Hi, > > On 12/10/2020 16:22, Serge Semin wrote: > > On Mon, Oct 12, 2020 at 09:54:25AM +0200, Neil Armstrong wrote: > >> Hi, > >> > >> On 11/10/2020 00:41, Serge Semin wrote: > >>> An empty snps,quirk-frame-length-adjustment won't cause any change > >>> performed by the driver. Moreover the DT schema validation will fail, > >>> since it expects the property being assigned with some value. So just > >>> discard the property declaration then from the example. > >>> > >>> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > >>> > >>> --- > >>> > >>> Note the same problem is in the DT source file > >>> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi . > >>> --- > >>> .../devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 1 - > >>> 1 file changed, 1 deletion(-) > >>> > >>> diff --git a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > >>> index 5b04a7dfa018..88184d7e26cc 100644 > >>> --- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > >>> +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > >>> @@ -209,6 +209,5 @@ examples: > >>> interrupts = <30>; > >>> dr_mode = "host"; > >>> snps,dis_u2_susphy_quirk; > >>> - snps,quirk-frame-length-adjustment; > >>> }; > >>> }; > >>> > >> > > > >> Thanks for reporting this, actually the fladj must be 0x20 on this hw, > >> but we do set this on the PHY side, so we can let the dwc3 side 0 here. > > > > I can convert this patch to initializing the "snps,quirk-frame-length-adjustment" > > property with 0x20 value instead. Since most likely I'll have to send a v2/v3/etc > > of this patchset, that modification won't be too much work to do. What do you think? > > Yes, do this please, Ok. Shall I preserve your Acked-by tag in the new patch or you'd prefer to review it first? > anyway it's only an example so it's ok. Actually examples are also validated by "make dt_binding_check". That's why I had to fix the amlogic,meson-g12a-usb-ctrl example for at least so the new snps,dwc3.yaml DT schema wouldn't break that full DT bindings validation procedure.) -Sergey > > > > > Anyway please note, that I've fixed the improper property usage in the DT schema > > example only. "snps,quirk-frame-length-adjustment" defined as boolean still > > persists in the DTS file: arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi . > > So if you ever try to validate that dts file with "make dtbs_check" scenario, it > > will fail. > > Yes, I'll push a fix to pass the dtbs_check when this is merged. > > Thanks, > Neil > > > > > -Sergey > > > >> > >> Acked-by: Neil Armstrong <narmstrong@baylibre.com> > >> > >> Neil > >> > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 15/18] dt-bindings: usb: meson-g12a-usb: Discard FL-adj property 2020-10-12 15:13 ` Serge Semin @ 2020-10-12 15:29 ` Neil Armstrong 0 siblings, 0 replies; 10+ messages in thread From: Neil Armstrong @ 2020-10-12 15:29 UTC (permalink / raw) To: Serge Semin Cc: linux-arm-kernel, Felipe Balbi, Roger Quadros, Mathias Nyman, devicetree, Martin Blumenstingl, Kevin Hilman, Lad Prabhakar, linux-usb, Andy Gross, Serge Semin, Alexey Malahov, Manu Gautam, Rob Herring, Pavel Parkhomenko, Greg Kroah-Hartman, linux-amlogic, Bjorn Andersson, Yoshihiro Shimoda, linux-kernel, Jerome Brunet On 12/10/2020 17:13, Serge Semin wrote: > On Mon, Oct 12, 2020 at 05:01:43PM +0200, Neil Armstrong wrote: >> Hi, >> >> On 12/10/2020 16:22, Serge Semin wrote: >>> On Mon, Oct 12, 2020 at 09:54:25AM +0200, Neil Armstrong wrote: >>>> Hi, >>>> >>>> On 11/10/2020 00:41, Serge Semin wrote: >>>>> An empty snps,quirk-frame-length-adjustment won't cause any change >>>>> performed by the driver. Moreover the DT schema validation will fail, >>>>> since it expects the property being assigned with some value. So just >>>>> discard the property declaration then from the example. >>>>> >>>>> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> >>>>> >>>>> --- >>>>> >>>>> Note the same problem is in the DT source file >>>>> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi . >>>>> --- >>>>> .../devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 1 - >>>>> 1 file changed, 1 deletion(-) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml >>>>> index 5b04a7dfa018..88184d7e26cc 100644 >>>>> --- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml >>>>> +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml >>>>> @@ -209,6 +209,5 @@ examples: >>>>> interrupts = <30>; >>>>> dr_mode = "host"; >>>>> snps,dis_u2_susphy_quirk; >>>>> - snps,quirk-frame-length-adjustment; >>>>> }; >>>>> }; >>>>> >>>> >>> >>>> Thanks for reporting this, actually the fladj must be 0x20 on this hw, >>>> but we do set this on the PHY side, so we can let the dwc3 side 0 here. >>> >>> I can convert this patch to initializing the "snps,quirk-frame-length-adjustment" >>> property with 0x20 value instead. Since most likely I'll have to send a v2/v3/etc >>> of this patchset, that modification won't be too much work to do. What do you think? >> > >> Yes, do this please, > > Ok. Shall I preserve your Acked-by tag in the new patch or you'd prefer to > review it first? Yes, preserve it, Thanks, Neil >> anyway it's only an example so it's ok. > > Actually examples are also validated by "make dt_binding_check". That's why I > had to fix the amlogic,meson-g12a-usb-ctrl example for at least so the new > snps,dwc3.yaml DT schema wouldn't break that full DT bindings > validation procedure.) > > -Sergey > >> >>> >>> Anyway please note, that I've fixed the improper property usage in the DT schema >>> example only. "snps,quirk-frame-length-adjustment" defined as boolean still >>> persists in the DTS file: arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi . >>> So if you ever try to validate that dts file with "make dtbs_check" scenario, it >>> will fail. >> >> Yes, I'll push a fix to pass the dtbs_check when this is merged. >> >> Thanks, >> Neil >> >>> >>> -Sergey >>> >>>> >>>> Acked-by: Neil Armstrong <narmstrong@baylibre.com> >>>> >>>> Neil >>>> >> _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 16/18] dt-bindings: usb: meson-g12a-usb: Validate DWC2/DWC3 sub-nodes [not found] <20201010224121.12672-1-Sergey.Semin@baikalelectronics.ru> 2020-10-10 22:41 ` [PATCH 15/18] dt-bindings: usb: meson-g12a-usb: Discard FL-adj property Serge Semin @ 2020-10-10 22:41 ` Serge Semin 2020-10-12 7:38 ` Neil Armstrong 2020-10-13 12:42 ` Rob Herring 1 sibling, 2 replies; 10+ messages in thread From: Serge Semin @ 2020-10-10 22:41 UTC (permalink / raw) To: Mathias Nyman, Felipe Balbi, Greg Kroah-Hartman, Rob Herring, Kevin Hilman, Neil Armstrong, Jerome Brunet, Martin Blumenstingl Cc: devicetree, linux-kernel, Yoshihiro Shimoda, linux-usb, Lad Prabhakar, Serge Semin, Bjorn Andersson, Serge Semin, Manu Gautam, Andy Gross, Pavel Parkhomenko, linux-amlogic, Alexey Malahov, linux-arm-kernel, Roger Quadros Amlogic G12A USB DT sub-nodes are supposed to be compatible with the generic DWC USB2 and USB3 devices. Since now we've got DT schemas for both of the later IP cores let's make sure that the Amlogic G12A USB DT nodes are fully evaluated including the DWC sub-nodes. Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> --- .../bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml index 88184d7e26cc..3e8ac0ff90de 100644 --- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml @@ -78,7 +78,20 @@ properties: patternProperties: "^usb@[0-9a-f]+$": - type: object + allOf: + - if: + properties: + compatible: + contains: + const: snps,dwc2 + then: + $ref: dwc2.yaml# + - if: + properties: + compatible: + const: snps,dwc3 + then: + $ref: snps,dwc3.yaml# additionalProperties: false -- 2.27.0 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 16/18] dt-bindings: usb: meson-g12a-usb: Validate DWC2/DWC3 sub-nodes 2020-10-10 22:41 ` [PATCH 16/18] dt-bindings: usb: meson-g12a-usb: Validate DWC2/DWC3 sub-nodes Serge Semin @ 2020-10-12 7:38 ` Neil Armstrong 2020-10-13 12:42 ` Rob Herring 1 sibling, 0 replies; 10+ messages in thread From: Neil Armstrong @ 2020-10-12 7:38 UTC (permalink / raw) To: Serge Semin, Mathias Nyman, Felipe Balbi, Greg Kroah-Hartman, Rob Herring, Kevin Hilman, Jerome Brunet, Martin Blumenstingl Cc: devicetree, linux-kernel, Yoshihiro Shimoda, linux-usb, Lad Prabhakar, Serge Semin, Bjorn Andersson, Manu Gautam, Andy Gross, Pavel Parkhomenko, linux-amlogic, Alexey Malahov, linux-arm-kernel, Roger Quadros On 11/10/2020 00:41, Serge Semin wrote: > Amlogic G12A USB DT sub-nodes are supposed to be compatible with the > generic DWC USB2 and USB3 devices. Since now we've got DT schemas for > both of the later IP cores let's make sure that the Amlogic G12A USB > DT nodes are fully evaluated including the DWC sub-nodes. > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > --- > .../bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > index 88184d7e26cc..3e8ac0ff90de 100644 > --- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > @@ -78,7 +78,20 @@ properties: > > patternProperties: > "^usb@[0-9a-f]+$": > - type: object > + allOf: > + - if: > + properties: > + compatible: > + contains: > + const: snps,dwc2 > + then: > + $ref: dwc2.yaml# > + - if: > + properties: > + compatible: > + const: snps,dwc3 > + then: > + $ref: snps,dwc3.yaml# > > additionalProperties: false > > Reviewed-by: Neil Armstrong <narmstrong@baylibre.com> _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 16/18] dt-bindings: usb: meson-g12a-usb: Validate DWC2/DWC3 sub-nodes 2020-10-10 22:41 ` [PATCH 16/18] dt-bindings: usb: meson-g12a-usb: Validate DWC2/DWC3 sub-nodes Serge Semin 2020-10-12 7:38 ` Neil Armstrong @ 2020-10-13 12:42 ` Rob Herring 2020-10-13 15:50 ` Serge Semin 1 sibling, 1 reply; 10+ messages in thread From: Rob Herring @ 2020-10-13 12:42 UTC (permalink / raw) To: Serge Semin Cc: linux-arm-kernel, Felipe Balbi, Roger Quadros, Mathias Nyman, Neil Armstrong, Martin Blumenstingl, Kevin Hilman, Yoshihiro Shimoda, linux-usb, Lad Prabhakar, Serge Semin, Alexey Malahov, Manu Gautam, devicetree, Andy Gross, Pavel Parkhomenko, Greg Kroah-Hartman, linux-amlogic, Bjorn Andersson, linux-kernel, Jerome Brunet On Sun, Oct 11, 2020 at 01:41:19AM +0300, Serge Semin wrote: > Amlogic G12A USB DT sub-nodes are supposed to be compatible with the > generic DWC USB2 and USB3 devices. Since now we've got DT schemas for > both of the later IP cores let's make sure that the Amlogic G12A USB > DT nodes are fully evaluated including the DWC sub-nodes. > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > --- > .../bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > index 88184d7e26cc..3e8ac0ff90de 100644 > --- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > @@ -78,7 +78,20 @@ properties: > > patternProperties: > "^usb@[0-9a-f]+$": > - type: object > + allOf: > + - if: > + properties: > + compatible: > + contains: > + const: snps,dwc2 > + then: > + $ref: dwc2.yaml# > + - if: > + properties: > + compatible: > + const: snps,dwc3 > + then: > + $ref: snps,dwc3.yaml# It should be enough to do just: oneOf: - $ref: dwc2.yaml# - $ref: snps,dwc3.yaml# _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 16/18] dt-bindings: usb: meson-g12a-usb: Validate DWC2/DWC3 sub-nodes 2020-10-13 12:42 ` Rob Herring @ 2020-10-13 15:50 ` Serge Semin 0 siblings, 0 replies; 10+ messages in thread From: Serge Semin @ 2020-10-13 15:50 UTC (permalink / raw) To: Rob Herring Cc: linux-arm-kernel, Felipe Balbi, Roger Quadros, Mathias Nyman, Neil Armstrong, Martin Blumenstingl, Kevin Hilman, Yoshihiro Shimoda, linux-usb, Lad Prabhakar, Serge Semin, Alexey Malahov, Manu Gautam, devicetree, Andy Gross, Pavel Parkhomenko, Greg Kroah-Hartman, linux-amlogic, Bjorn Andersson, linux-kernel, Jerome Brunet On Tue, Oct 13, 2020 at 07:42:03AM -0500, Rob Herring wrote: > On Sun, Oct 11, 2020 at 01:41:19AM +0300, Serge Semin wrote: > > Amlogic G12A USB DT sub-nodes are supposed to be compatible with the > > generic DWC USB2 and USB3 devices. Since now we've got DT schemas for > > both of the later IP cores let's make sure that the Amlogic G12A USB > > DT nodes are fully evaluated including the DWC sub-nodes. > > > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > --- > > .../bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 15 ++++++++++++++- > > 1 file changed, 14 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > > index 88184d7e26cc..3e8ac0ff90de 100644 > > --- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > > +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > > @@ -78,7 +78,20 @@ properties: > > > > patternProperties: > > "^usb@[0-9a-f]+$": > > - type: object > > + allOf: > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: snps,dwc2 > > + then: > > + $ref: dwc2.yaml# > > + - if: > > + properties: > > + compatible: > > + const: snps,dwc3 > > + then: > > + $ref: snps,dwc3.yaml# > > It should be enough to do just: > > oneOf: > - $ref: dwc2.yaml# > - $ref: snps,dwc3.yaml# Ah, good point! Thanks. -Sergey _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-10-13 15:50 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20201010224121.12672-1-Sergey.Semin@baikalelectronics.ru> 2020-10-10 22:41 ` [PATCH 15/18] dt-bindings: usb: meson-g12a-usb: Discard FL-adj property Serge Semin 2020-10-12 7:54 ` Neil Armstrong 2020-10-12 14:22 ` Serge Semin 2020-10-12 15:01 ` Neil Armstrong 2020-10-12 15:13 ` Serge Semin 2020-10-12 15:29 ` Neil Armstrong 2020-10-10 22:41 ` [PATCH 16/18] dt-bindings: usb: meson-g12a-usb: Validate DWC2/DWC3 sub-nodes Serge Semin 2020-10-12 7:38 ` Neil Armstrong 2020-10-13 12:42 ` Rob Herring 2020-10-13 15:50 ` Serge Semin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).