* [PATCH v9 1/4] dt-bindings: mfd: Fix schema warnings for pwm-leds
2020-12-28 16:32 [PATCH v9 0/4] leds: pwm: Make automatic labels work Alexander Dahl
@ 2020-12-28 16:32 ` Alexander Dahl
2020-12-30 18:54 ` Pavel Machek
2021-01-14 10:03 ` Lee Jones
2020-12-28 16:32 ` [PATCH v9 2/4] ARM: dts: berlin: " Alexander Dahl
` (2 subsequent siblings)
3 siblings, 2 replies; 16+ messages in thread
From: Alexander Dahl @ 2020-12-28 16:32 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, Rob Herring, Alexander Dahl, linux-kernel,
Alexander Dahl, linux-arm-kernel, linux-amlogic, Jeff LaBundy,
Lee Jones, linux-stm32, linux-leds
The node names for devices using the pwm-leds driver follow a certain
naming scheme (now). Parent node name is not enforced, but recommended
by DT project.
DTC Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
CHECK Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
/home/alex/build/linux/Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml: pwmleds: 'panel' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
Signed-off-by: Alexander Dahl <post@lespocky.de>
Acked-by: Jeff LaBundy <jeff@labundy.com>
Acked-by: Rob Herring <robh@kernel.org>
---
Notes:
v8 -> v9:
* added forgotten Acked-by (Jeff LaBundy)
* rebased on v5.11-rc1
v7 -> v8:
* rebased on recent pavel/for-next (post v5.10-rc1)
* added Acked-by (Rob Herring)
v6 -> v7:
* added warning message to commit message (Krzysztof Kozlowski)
v6:
* added this patch to series
Documentation/devicetree/bindings/mfd/iqs62x.yaml | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/iqs62x.yaml b/Documentation/devicetree/bindings/mfd/iqs62x.yaml
index 541b06d80e73..92dc48a8dfa7 100644
--- a/Documentation/devicetree/bindings/mfd/iqs62x.yaml
+++ b/Documentation/devicetree/bindings/mfd/iqs62x.yaml
@@ -90,10 +90,11 @@ examples:
};
};
- pwmleds {
+ led-controller {
compatible = "pwm-leds";
- panel {
+ led-1 {
+ label = "panel";
pwms = <&iqs620a_pwm 0 1000000>;
max-brightness = <255>;
};
--
2.20.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH v9 1/4] dt-bindings: mfd: Fix schema warnings for pwm-leds
2020-12-28 16:32 ` [PATCH v9 1/4] dt-bindings: mfd: Fix schema warnings for pwm-leds Alexander Dahl
@ 2020-12-30 18:54 ` Pavel Machek
2020-12-31 8:33 ` Lee Jones
2021-01-14 10:03 ` Lee Jones
1 sibling, 1 reply; 16+ messages in thread
From: Pavel Machek @ 2020-12-30 18:54 UTC (permalink / raw)
To: Alexander Dahl
Cc: devicetree, Rob Herring, Alexander Dahl, linux-kernel,
Rob Herring, linux-arm-kernel, linux-amlogic, Jeff LaBundy,
Lee Jones, linux-stm32, linux-leds
[-- Attachment #1.1: Type: text/plain, Size: 842 bytes --]
Hi!
> The node names for devices using the pwm-leds driver follow a certain
> naming scheme (now). Parent node name is not enforced, but recommended
> by DT project.
>
> DTC Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> CHECK Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> /home/alex/build/linux/Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml: pwmleds: 'panel' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
>
> Signed-off-by: Alexander Dahl <post@lespocky.de>
> Acked-by: Jeff LaBundy <jeff@labundy.com>
> Acked-by: Rob Herring <robh@kernel.org>
Thanks, applied.
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v9 1/4] dt-bindings: mfd: Fix schema warnings for pwm-leds
2020-12-30 18:54 ` Pavel Machek
@ 2020-12-31 8:33 ` Lee Jones
2020-12-31 9:39 ` Pavel Machek
0 siblings, 1 reply; 16+ messages in thread
From: Lee Jones @ 2020-12-31 8:33 UTC (permalink / raw)
To: Pavel Machek
Cc: devicetree, Rob Herring, Alexander Dahl, linux-kernel,
Rob Herring, Alexander Dahl, linux-arm-kernel, linux-amlogic,
Jeff LaBundy, linux-stm32, linux-leds
On Wed, 30 Dec 2020, Pavel Machek wrote:
> Hi!
>
> > The node names for devices using the pwm-leds driver follow a certain
> > naming scheme (now). Parent node name is not enforced, but recommended
> > by DT project.
> >
> > DTC Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> > CHECK Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> > /home/alex/build/linux/Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml: pwmleds: 'panel' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> > From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
> >
> > Signed-off-by: Alexander Dahl <post@lespocky.de>
> > Acked-by: Jeff LaBundy <jeff@labundy.com>
> > Acked-by: Rob Herring <robh@kernel.org>
>
> Thanks, applied.
Sorry, what?
Applied to what tree?
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v9 1/4] dt-bindings: mfd: Fix schema warnings for pwm-leds
2020-12-31 8:33 ` Lee Jones
@ 2020-12-31 9:39 ` Pavel Machek
2020-12-31 12:18 ` Lee Jones
0 siblings, 1 reply; 16+ messages in thread
From: Pavel Machek @ 2020-12-31 9:39 UTC (permalink / raw)
To: Lee Jones
Cc: devicetree, Rob Herring, Alexander Dahl, linux-kernel,
Rob Herring, Alexander Dahl, linux-arm-kernel, linux-amlogic,
Jeff LaBundy, linux-stm32, linux-leds
[-- Attachment #1.1: Type: text/plain, Size: 1161 bytes --]
Hi!
> > > The node names for devices using the pwm-leds driver follow a certain
> > > naming scheme (now). Parent node name is not enforced, but recommended
> > > by DT project.
> > >
> > > DTC Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> > > CHECK Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> > > /home/alex/build/linux/Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml: pwmleds: 'panel' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> > > From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
> > >
> > > Signed-off-by: Alexander Dahl <post@lespocky.de>
> > > Acked-by: Jeff LaBundy <jeff@labundy.com>
> > > Acked-by: Rob Herring <robh@kernel.org>
> >
> > Thanks, applied.
>
> Sorry, what?
>
> Applied to what tree?
I took it to (local copy) of leds-next tree on. But now I realised it
is mfd, not a LED patch, so I undone that. Sorry for the confusion.
Anyway, patch still looks good to me:
Acked-by: Pavel Machek <pavel@ucw.cz>
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v9 1/4] dt-bindings: mfd: Fix schema warnings for pwm-leds
2020-12-31 9:39 ` Pavel Machek
@ 2020-12-31 12:18 ` Lee Jones
0 siblings, 0 replies; 16+ messages in thread
From: Lee Jones @ 2020-12-31 12:18 UTC (permalink / raw)
To: Pavel Machek
Cc: devicetree, Rob Herring, Alexander Dahl, linux-kernel,
Rob Herring, Alexander Dahl, linux-arm-kernel, linux-amlogic,
Jeff LaBundy, linux-stm32, linux-leds
On Thu, 31 Dec 2020, Pavel Machek wrote:
> Hi!
>
> > > > The node names for devices using the pwm-leds driver follow a certain
> > > > naming scheme (now). Parent node name is not enforced, but recommended
> > > > by DT project.
> > > >
> > > > DTC Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> > > > CHECK Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> > > > /home/alex/build/linux/Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml: pwmleds: 'panel' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> > > > From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
> > > >
> > > > Signed-off-by: Alexander Dahl <post@lespocky.de>
> > > > Acked-by: Jeff LaBundy <jeff@labundy.com>
> > > > Acked-by: Rob Herring <robh@kernel.org>
> > >
> > > Thanks, applied.
> >
> > Sorry, what?
> >
> > Applied to what tree?
>
> I took it to (local copy) of leds-next tree on. But now I realised it
> is mfd, not a LED patch, so I undone that. Sorry for the confusion.
>
> Anyway, patch still looks good to me:
>
> Acked-by: Pavel Machek <pavel@ucw.cz>
Thanks Pavel.
I plan on taking this next week.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v9 1/4] dt-bindings: mfd: Fix schema warnings for pwm-leds
2020-12-28 16:32 ` [PATCH v9 1/4] dt-bindings: mfd: Fix schema warnings for pwm-leds Alexander Dahl
2020-12-30 18:54 ` Pavel Machek
@ 2021-01-14 10:03 ` Lee Jones
2021-01-15 3:50 ` Jeff LaBundy
1 sibling, 1 reply; 16+ messages in thread
From: Lee Jones @ 2021-01-14 10:03 UTC (permalink / raw)
To: Alexander Dahl
Cc: devicetree, Rob Herring, Alexander Dahl, linux-kernel,
Rob Herring, linux-arm-kernel, linux-amlogic, Jeff LaBundy,
linux-stm32, linux-leds
On Mon, 28 Dec 2020, Alexander Dahl wrote:
> The node names for devices using the pwm-leds driver follow a certain
> naming scheme (now). Parent node name is not enforced, but recommended
> by DT project.
>
> DTC Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> CHECK Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> /home/alex/build/linux/Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml: pwmleds: 'panel' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
>
> Signed-off-by: Alexander Dahl <post@lespocky.de>
> Acked-by: Jeff LaBundy <jeff@labundy.com>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
>
> Notes:
> v8 -> v9:
> * added forgotten Acked-by (Jeff LaBundy)
> * rebased on v5.11-rc1
>
> v7 -> v8:
> * rebased on recent pavel/for-next (post v5.10-rc1)
> * added Acked-by (Rob Herring)
>
> v6 -> v7:
> * added warning message to commit message (Krzysztof Kozlowski)
>
> v6:
> * added this patch to series
>
> Documentation/devicetree/bindings/mfd/iqs62x.yaml | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Failed to apply:
Applying: dt-bindings: mfd: Fix schema warnings for pwm-leds
Using index info to reconstruct a base tree...
M Documentation/devicetree/bindings/mfd/iqs62x.yaml
/home/lee/projects/linux/kernel/.git/worktrees/mfd/rebase-apply/patch:34: indent with spaces.
led-1 {
/home/lee/projects/linux/kernel/.git/worktrees/mfd/rebase-apply/patch:35: indent with spaces.
label = "panel";
warning: 2 lines add whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging Documentation/devicetree/bindings/mfd/iqs62x.yaml
CONFLICT (content): Merge conflict in Documentation/devicetree/bindings/mfd/iqs62x.yaml
Recorded preimage for 'Documentation/devicetree/bindings/mfd/iqs62x.yaml'
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v9 1/4] dt-bindings: mfd: Fix schema warnings for pwm-leds
2021-01-14 10:03 ` Lee Jones
@ 2021-01-15 3:50 ` Jeff LaBundy
2021-01-15 9:42 ` Alexander Dahl
0 siblings, 1 reply; 16+ messages in thread
From: Jeff LaBundy @ 2021-01-15 3:50 UTC (permalink / raw)
To: Lee Jones
Cc: devicetree, Rob Herring, Alexander Dahl, linux-kernel,
Rob Herring, Alexander Dahl, linux-arm-kernel, linux-amlogic,
linux-stm32, linux-leds
Hi Alexander,
On Thu, Jan 14, 2021 at 10:03:12AM +0000, Lee Jones wrote:
> On Mon, 28 Dec 2020, Alexander Dahl wrote:
>
> > The node names for devices using the pwm-leds driver follow a certain
> > naming scheme (now). Parent node name is not enforced, but recommended
> > by DT project.
> >
> > DTC Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> > CHECK Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> > /home/alex/build/linux/Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml: pwmleds: 'panel' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> > From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
> >
> > Signed-off-by: Alexander Dahl <post@lespocky.de>
> > Acked-by: Jeff LaBundy <jeff@labundy.com>
> > Acked-by: Rob Herring <robh@kernel.org>
> > ---
> >
> > Notes:
> > v8 -> v9:
> > * added forgotten Acked-by (Jeff LaBundy)
> > * rebased on v5.11-rc1
> >
> > v7 -> v8:
> > * rebased on recent pavel/for-next (post v5.10-rc1)
> > * added Acked-by (Rob Herring)
> >
> > v6 -> v7:
> > * added warning message to commit message (Krzysztof Kozlowski)
> >
> > v6:
> > * added this patch to series
> >
> > Documentation/devicetree/bindings/mfd/iqs62x.yaml | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
>
> Failed to apply:
>
> Applying: dt-bindings: mfd: Fix schema warnings for pwm-leds
> Using index info to reconstruct a base tree...
> M Documentation/devicetree/bindings/mfd/iqs62x.yaml
> /home/lee/projects/linux/kernel/.git/worktrees/mfd/rebase-apply/patch:34: indent with spaces.
> led-1 {
> /home/lee/projects/linux/kernel/.git/worktrees/mfd/rebase-apply/patch:35: indent with spaces.
> label = "panel";
> warning: 2 lines add whitespace errors.
> Falling back to patching base and 3-way merge...
> Auto-merging Documentation/devicetree/bindings/mfd/iqs62x.yaml
> CONFLICT (content): Merge conflict in Documentation/devicetree/bindings/mfd/iqs62x.yaml
> Recorded preimage for 'Documentation/devicetree/bindings/mfd/iqs62x.yaml'
It looks like the following patch already beat this to the punch:
8237e8382498 ("dt-bindings: mfd: Correct the node name of the panel LED")
That patch does not retain the LED's label or rename the parent node to
led-controller, however. The label hardly matters for this example, but
perhaps we still want the parent node change to follow leds-pwm.yaml.
>
> --
> Lee Jones [李琼斯]
> Senior Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog
Kind regards,
Jeff LaBundy
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v9 1/4] dt-bindings: mfd: Fix schema warnings for pwm-leds
2021-01-15 3:50 ` Jeff LaBundy
@ 2021-01-15 9:42 ` Alexander Dahl
2021-01-18 4:02 ` Jeff LaBundy
0 siblings, 1 reply; 16+ messages in thread
From: Alexander Dahl @ 2021-01-15 9:42 UTC (permalink / raw)
To: Jeff LaBundy
Cc: devicetree, Rob Herring, Alexander Dahl, linux-kernel,
Rob Herring, Alexander Dahl, linux-arm-kernel, linux-amlogic,
Lee Jones, linux-stm32, linux-leds
[-- Attachment #1.1: Type: text/plain, Size: 3244 bytes --]
Hello Jeff,
On Thu, Jan 14, 2021 at 09:50:50PM -0600, Jeff LaBundy wrote:
> On Thu, Jan 14, 2021 at 10:03:12AM +0000, Lee Jones wrote:
> > On Mon, 28 Dec 2020, Alexander Dahl wrote:
> >
> > > The node names for devices using the pwm-leds driver follow a certain
> > > naming scheme (now). Parent node name is not enforced, but recommended
> > > by DT project.
> > >
> > > DTC Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> > > CHECK Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> > > /home/alex/build/linux/Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml: pwmleds: 'panel' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> > > From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
> > >
> > > Signed-off-by: Alexander Dahl <post@lespocky.de>
> > > Acked-by: Jeff LaBundy <jeff@labundy.com>
> > > Acked-by: Rob Herring <robh@kernel.org>
> > > ---
> > >
> > > Notes:
> > > v8 -> v9:
> > > * added forgotten Acked-by (Jeff LaBundy)
> > > * rebased on v5.11-rc1
> > >
> > > v7 -> v8:
> > > * rebased on recent pavel/for-next (post v5.10-rc1)
> > > * added Acked-by (Rob Herring)
> > >
> > > v6 -> v7:
> > > * added warning message to commit message (Krzysztof Kozlowski)
> > >
> > > v6:
> > > * added this patch to series
> > >
> > > Documentation/devicetree/bindings/mfd/iqs62x.yaml | 5 +++--
> > > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > Failed to apply:
> >
> > Applying: dt-bindings: mfd: Fix schema warnings for pwm-leds
> > Using index info to reconstruct a base tree...
> > M Documentation/devicetree/bindings/mfd/iqs62x.yaml
> > /home/lee/projects/linux/kernel/.git/worktrees/mfd/rebase-apply/patch:34: indent with spaces.
> > led-1 {
> > /home/lee/projects/linux/kernel/.git/worktrees/mfd/rebase-apply/patch:35: indent with spaces.
> > label = "panel";
> > warning: 2 lines add whitespace errors.
> > Falling back to patching base and 3-way merge...
> > Auto-merging Documentation/devicetree/bindings/mfd/iqs62x.yaml
> > CONFLICT (content): Merge conflict in Documentation/devicetree/bindings/mfd/iqs62x.yaml
> > Recorded preimage for 'Documentation/devicetree/bindings/mfd/iqs62x.yaml'
>
> It looks like the following patch already beat this to the punch:
>
> 8237e8382498 ("dt-bindings: mfd: Correct the node name of the panel LED")
Which tree is that commit on? This one?
https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/
> That patch does not retain the LED's label or rename the parent node to
> led-controller, however. The label hardly matters for this example, but
> perhaps we still want the parent node change to follow leds-pwm.yaml.
Should I rework the patch then to have that change only?
Greets
Alex
--
/"\ ASCII RIBBON | »With the first link, the chain is forged. The first
\ / CAMPAIGN | speech censured, the first thought forbidden, the
X AGAINST | first freedom denied, chains us all irrevocably.«
/ \ HTML MAIL | (Jean-Luc Picard, quoting Judge Aaron Satie)
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v9 1/4] dt-bindings: mfd: Fix schema warnings for pwm-leds
2021-01-15 9:42 ` Alexander Dahl
@ 2021-01-18 4:02 ` Jeff LaBundy
0 siblings, 0 replies; 16+ messages in thread
From: Jeff LaBundy @ 2021-01-18 4:02 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Alexander Dahl, linux-leds, devicetree,
linux-kernel, linux-arm-kernel, linux-stm32, linux-amlogic,
Rob Herring
Hi Alexander,
Thanks again for your work on this.
On Fri, Jan 15, 2021 at 10:42:39AM +0100, Alexander Dahl wrote:
> Hello Jeff,
>
> On Thu, Jan 14, 2021 at 09:50:50PM -0600, Jeff LaBundy wrote:
> > On Thu, Jan 14, 2021 at 10:03:12AM +0000, Lee Jones wrote:
> > > On Mon, 28 Dec 2020, Alexander Dahl wrote:
> > >
> > > > The node names for devices using the pwm-leds driver follow a certain
> > > > naming scheme (now). Parent node name is not enforced, but recommended
> > > > by DT project.
> > > >
> > > > DTC Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> > > > CHECK Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
> > > > /home/alex/build/linux/Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml: pwmleds: 'panel' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> > > > From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
> > > >
> > > > Signed-off-by: Alexander Dahl <post@lespocky.de>
> > > > Acked-by: Jeff LaBundy <jeff@labundy.com>
> > > > Acked-by: Rob Herring <robh@kernel.org>
> > > > ---
> > > >
> > > > Notes:
> > > > v8 -> v9:
> > > > * added forgotten Acked-by (Jeff LaBundy)
> > > > * rebased on v5.11-rc1
> > > >
> > > > v7 -> v8:
> > > > * rebased on recent pavel/for-next (post v5.10-rc1)
> > > > * added Acked-by (Rob Herring)
> > > >
> > > > v6 -> v7:
> > > > * added warning message to commit message (Krzysztof Kozlowski)
> > > >
> > > > v6:
> > > > * added this patch to series
> > > >
> > > > Documentation/devicetree/bindings/mfd/iqs62x.yaml | 5 +++--
> > > > 1 file changed, 3 insertions(+), 2 deletions(-)
> > >
> > > Failed to apply:
> > >
> > > Applying: dt-bindings: mfd: Fix schema warnings for pwm-leds
> > > Using index info to reconstruct a base tree...
> > > M Documentation/devicetree/bindings/mfd/iqs62x.yaml
> > > /home/lee/projects/linux/kernel/.git/worktrees/mfd/rebase-apply/patch:34: indent with spaces.
> > > led-1 {
> > > /home/lee/projects/linux/kernel/.git/worktrees/mfd/rebase-apply/patch:35: indent with spaces.
> > > label = "panel";
> > > warning: 2 lines add whitespace errors.
> > > Falling back to patching base and 3-way merge...
> > > Auto-merging Documentation/devicetree/bindings/mfd/iqs62x.yaml
> > > CONFLICT (content): Merge conflict in Documentation/devicetree/bindings/mfd/iqs62x.yaml
> > > Recorded preimage for 'Documentation/devicetree/bindings/mfd/iqs62x.yaml'
> >
> > It looks like the following patch already beat this to the punch:
> >
> > 8237e8382498 ("dt-bindings: mfd: Correct the node name of the panel LED")
>
> Which tree is that commit on? This one?
>
> https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/
That's correct.
>
> > That patch does not retain the LED's label or rename the parent node to
> > led-controller, however. The label hardly matters for this example, but
> > perhaps we still want the parent node change to follow leds-pwm.yaml.
>
> Should I rework the patch then to have that change only?
That seems like a reasonable compromise.
>
> Greets
> Alex
>
> --
> /"\ ASCII RIBBON | »With the first link, the chain is forged. The first
> \ / CAMPAIGN | speech censured, the first thought forbidden, the
> X AGAINST | first freedom denied, chains us all irrevocably.«
> / \ HTML MAIL | (Jean-Luc Picard, quoting Judge Aaron Satie)
Kind regards,
Jeff LaBundy
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v9 2/4] ARM: dts: berlin: Fix schema warnings for pwm-leds
2020-12-28 16:32 [PATCH v9 0/4] leds: pwm: Make automatic labels work Alexander Dahl
2020-12-28 16:32 ` [PATCH v9 1/4] dt-bindings: mfd: Fix schema warnings for pwm-leds Alexander Dahl
@ 2020-12-28 16:32 ` Alexander Dahl
2020-12-29 2:24 ` Jisheng Zhang
2020-12-28 16:32 ` [PATCH v9 3/4] ARM: dts: stm32: " Alexander Dahl
2020-12-28 16:32 ` [PATCH v9 4/4] arm64: dts: meson: " Alexander Dahl
3 siblings, 1 reply; 16+ messages in thread
From: Alexander Dahl @ 2020-12-28 16:32 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, Alexander Dahl, linux-kernel, Jisheng Zhang,
Alexander Dahl, linux-arm-kernel, linux-amlogic, linux-stm32,
linux-leds, Sebastian Hesselbarth
The node names for devices using the pwm-leds driver follow a certain
naming scheme (now). Parent node name is not enforced, but recommended
by DT project.
DTC arch/arm/boot/dts/berlin2cd-google-chromecast.dt.yaml
CHECK arch/arm/boot/dts/berlin2cd-google-chromecast.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/berlin2cd-google-chromecast.dt.yaml: leds: 'red', 'white' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
Signed-off-by: Alexander Dahl <post@lespocky.de>
---
Notes:
v8 -> v9:
* rebased on v5.11-rc1
v7 -> v8:
* rebased on recent pavel/for-next (post v5.10-rc1)
v6 -> v7:
* split up patch (one per sub arch)
* added actual warnings to commit message
arch/arm/boot/dts/berlin2cd-google-chromecast.dts | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/berlin2cd-google-chromecast.dts b/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
index 56fa951bc86f..c1d91424e658 100644
--- a/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
+++ b/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
@@ -34,19 +34,19 @@
linux,usable-memory = <0x00000000 0x20000000>; /* 512 MB */
};
- leds {
+ led-controller {
compatible = "pwm-leds";
pinctrl-0 = <&ledpwm_pmux>;
pinctrl-names = "default";
- white {
+ led-1 {
label = "white";
pwms = <&pwm 0 600000 0>;
max-brightness = <255>;
linux,default-trigger = "default-on";
};
- red {
+ led-2 {
label = "red";
pwms = <&pwm 1 600000 0>;
max-brightness = <255>;
--
2.20.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH v9 2/4] ARM: dts: berlin: Fix schema warnings for pwm-leds
2020-12-28 16:32 ` [PATCH v9 2/4] ARM: dts: berlin: " Alexander Dahl
@ 2020-12-29 2:24 ` Jisheng Zhang
0 siblings, 0 replies; 16+ messages in thread
From: Jisheng Zhang @ 2020-12-29 2:24 UTC (permalink / raw)
To: Alexander Dahl
Cc: devicetree, Alexander Dahl, linux-kernel, Rob Herring,
linux-arm-kernel, linux-amlogic, linux-stm32, linux-leds,
Sebastian Hesselbarth
On Mon, 28 Dec 2020 17:32:15 +0100
Alexander Dahl <post@lespocky.de> wrote:
>
> The node names for devices using the pwm-leds driver follow a certain
> naming scheme (now). Parent node name is not enforced, but recommended
> by DT project.
>
> DTC arch/arm/boot/dts/berlin2cd-google-chromecast.dt.yaml
> CHECK arch/arm/boot/dts/berlin2cd-google-chromecast.dt.yaml
> /home/alex/build/linux/arch/arm/boot/dts/berlin2cd-google-chromecast.dt.yaml: leds: 'red', 'white' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
>
> Signed-off-by: Alexander Dahl <post@lespocky.de>
Thanks for the patch.
I took this patch but sent out the PR late: https://www.spinics.net/lists/arm-kernel/msg862567.html
I will send out PR earlier for 5.12
> ---
>
> Notes:
> v8 -> v9:
> * rebased on v5.11-rc1
>
> v7 -> v8:
> * rebased on recent pavel/for-next (post v5.10-rc1)
>
> v6 -> v7:
> * split up patch (one per sub arch)
> * added actual warnings to commit message
>
> arch/arm/boot/dts/berlin2cd-google-chromecast.dts | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/berlin2cd-google-chromecast.dts b/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
> index 56fa951bc86f..c1d91424e658 100644
> --- a/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
> +++ b/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
> @@ -34,19 +34,19 @@
> linux,usable-memory = <0x00000000 0x20000000>; /* 512 MB */
> };
>
> - leds {
> + led-controller {
> compatible = "pwm-leds";
> pinctrl-0 = <&ledpwm_pmux>;
> pinctrl-names = "default";
>
> - white {
> + led-1 {
> label = "white";
> pwms = <&pwm 0 600000 0>;
> max-brightness = <255>;
> linux,default-trigger = "default-on";
> };
>
> - red {
> + led-2 {
> label = "red";
> pwms = <&pwm 1 600000 0>;
> max-brightness = <255>;
> --
> 2.20.1
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v9 3/4] ARM: dts: stm32: Fix schema warnings for pwm-leds
2020-12-28 16:32 [PATCH v9 0/4] leds: pwm: Make automatic labels work Alexander Dahl
2020-12-28 16:32 ` [PATCH v9 1/4] dt-bindings: mfd: Fix schema warnings for pwm-leds Alexander Dahl
2020-12-28 16:32 ` [PATCH v9 2/4] ARM: dts: berlin: " Alexander Dahl
@ 2020-12-28 16:32 ` Alexander Dahl
2021-01-14 16:07 ` Alexandre TORGUE
2020-12-28 16:32 ` [PATCH v9 4/4] arm64: dts: meson: " Alexander Dahl
3 siblings, 1 reply; 16+ messages in thread
From: Alexander Dahl @ 2020-12-28 16:32 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, Ahmad Fatoum, Alexandre Torgue, Alexander Dahl,
linux-kernel, Alexander Dahl, linux-arm-kernel, Maxime Coquelin,
linux-amlogic, linux-stm32, linux-leds
The node names for devices using the pwm-leds driver follow a certain
naming scheme (now). Parent node name is not enforced, but recommended
by DT project.
DTC arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml
CHECK arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml: led-rgb: 'led-blue', 'led-green', 'led-red' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
Signed-off-by: Alexander Dahl <post@lespocky.de>
Acked-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
Notes:
v8 -> v9:
* added Acked-by (Ahmad Fatoum)
* rebased on v5.11-rc1
v7 -> v8:
* rebased on recent pavel/for-next (post v5.10-rc1)
* updated indexes and added comment (Ahmad Fatoum)
v6 -> v7:
* split up patch (one per sub arch)
* added actual warnings to commit message
arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
index cda8e871f999..1e9bf7eea0f1 100644
--- a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
+++ b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
@@ -36,34 +36,35 @@
stdout-path = &uart4;
};
- led-act {
+ led-controller-0 {
compatible = "gpio-leds";
- led-green {
+ led-0 {
label = "mc1:green:act";
gpios = <&gpioa 13 GPIO_ACTIVE_LOW>;
linux,default-trigger = "heartbeat";
};
};
- led-rgb {
+ led-controller-1 {
compatible = "pwm-leds";
- led-red {
+ /* led-1 to led-3 are part of a single RGB led */
+ led-1 {
label = "mc1:red:rgb";
pwms = <&leds_pwm 1 1000000 0>;
max-brightness = <255>;
active-low;
};
- led-green {
+ led-2 {
label = "mc1:green:rgb";
pwms = <&leds_pwm 2 1000000 0>;
max-brightness = <255>;
active-low;
};
- led-blue {
+ led-3 {
label = "mc1:blue:rgb";
pwms = <&leds_pwm 3 1000000 0>;
max-brightness = <255>;
--
2.20.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH v9 3/4] ARM: dts: stm32: Fix schema warnings for pwm-leds
2020-12-28 16:32 ` [PATCH v9 3/4] ARM: dts: stm32: " Alexander Dahl
@ 2021-01-14 16:07 ` Alexandre TORGUE
0 siblings, 0 replies; 16+ messages in thread
From: Alexandre TORGUE @ 2021-01-14 16:07 UTC (permalink / raw)
To: Alexander Dahl, Rob Herring
Cc: devicetree, Ahmad Fatoum, Alexandre Torgue, Alexander Dahl,
linux-kernel, linux-leds, Maxime Coquelin, linux-amlogic,
linux-stm32, linux-arm-kernel
Hi Alexander
On 12/28/20 5:32 PM, Alexander Dahl wrote:
> The node names for devices using the pwm-leds driver follow a certain
> naming scheme (now). Parent node name is not enforced, but recommended
> by DT project.
>
> DTC arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml
> CHECK arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml
> /home/alex/build/linux/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml: led-rgb: 'led-blue', 'led-green', 'led-red' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
>
> Signed-off-by: Alexander Dahl <post@lespocky.de>
> Acked-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Applied on stm32-next.
Thanks.
Alex
> ---
>
> Notes:
> v8 -> v9:
> * added Acked-by (Ahmad Fatoum)
> * rebased on v5.11-rc1
>
> v7 -> v8:
> * rebased on recent pavel/for-next (post v5.10-rc1)
> * updated indexes and added comment (Ahmad Fatoum)
>
> v6 -> v7:
> * split up patch (one per sub arch)
> * added actual warnings to commit message
>
> arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> index cda8e871f999..1e9bf7eea0f1 100644
> --- a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> +++ b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> @@ -36,34 +36,35 @@
> stdout-path = &uart4;
> };
>
> - led-act {
> + led-controller-0 {
> compatible = "gpio-leds";
>
> - led-green {
> + led-0 {
> label = "mc1:green:act";
> gpios = <&gpioa 13 GPIO_ACTIVE_LOW>;
> linux,default-trigger = "heartbeat";
> };
> };
>
> - led-rgb {
> + led-controller-1 {
> compatible = "pwm-leds";
>
> - led-red {
> + /* led-1 to led-3 are part of a single RGB led */
> + led-1 {
> label = "mc1:red:rgb";
> pwms = <&leds_pwm 1 1000000 0>;
> max-brightness = <255>;
> active-low;
> };
>
> - led-green {
> + led-2 {
> label = "mc1:green:rgb";
> pwms = <&leds_pwm 2 1000000 0>;
> max-brightness = <255>;
> active-low;
> };
>
> - led-blue {
> + led-3 {
> label = "mc1:blue:rgb";
> pwms = <&leds_pwm 3 1000000 0>;
> max-brightness = <255>;
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v9 4/4] arm64: dts: meson: Fix schema warnings for pwm-leds
2020-12-28 16:32 [PATCH v9 0/4] leds: pwm: Make automatic labels work Alexander Dahl
` (2 preceding siblings ...)
2020-12-28 16:32 ` [PATCH v9 3/4] ARM: dts: stm32: " Alexander Dahl
@ 2020-12-28 16:32 ` Alexander Dahl
2021-01-04 16:13 ` Kevin Hilman
3 siblings, 1 reply; 16+ messages in thread
From: Alexander Dahl @ 2020-12-28 16:32 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, Neil Armstrong, Alexander Dahl, Kevin Hilman,
linux-kernel, Martin Blumenstingl, Alexander Dahl,
linux-arm-kernel, linux-amlogic, linux-stm32, linux-leds,
Jerome Brunet
The node names for devices using the pwm-leds driver follow a certain
naming scheme (now). Parent node name is not enforced, but recommended
by DT project.
Signed-off-by: Alexander Dahl <post@lespocky.de>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
---
Notes:
v8 -> v9:
* rebased on v5.11-rc1
v7 -> v8:
* rebased on pavel/for-next (post v5.10-rc1)
v6 -> v7:
* added Reviewed-by
* added another explaining sentence to commit message
v6:
* added this patch to series
.../arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts | 4 ++--
arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 4 ++--
arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts | 8 ++++----
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts
index 6fe589cd2ba2..45adae480a3d 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts
@@ -42,10 +42,10 @@
};
};
- pwmleds {
+ led-controller {
compatible = "pwm-leds";
- power {
+ led-1 {
label = "vim:red:power";
pwms = <&pwm_AO_ab 1 7812500 0>;
max-brightness = <255>;
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
index bf9877d33427..25857e0c0831 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
@@ -81,10 +81,10 @@
};
};
- pwmleds {
+ led-controller {
compatible = "pwm-leds";
- power {
+ led-1 {
label = "vim:red:power";
pwms = <&pwm_AO_ab 1 7812500 0>;
max-brightness = <255>;
diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
index 5ab139a34c01..039a8d0d1e9b 100644
--- a/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
@@ -101,20 +101,20 @@
};
};
- leds {
+ led-controller-1 {
compatible = "gpio-leds";
- led-bluetooth {
+ led-1 {
label = "sei610:blue:bt";
gpios = <&gpio GPIOC_7 (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN)>;
default-state = "off";
};
};
- pwmleds {
+ led-controller-2 {
compatible = "pwm-leds";
- power {
+ led-2 {
label = "sei610:red:power";
pwms = <&pwm_AO_ab 0 30518 0>;
max-brightness = <255>;
--
2.20.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH v9 4/4] arm64: dts: meson: Fix schema warnings for pwm-leds
2020-12-28 16:32 ` [PATCH v9 4/4] arm64: dts: meson: " Alexander Dahl
@ 2021-01-04 16:13 ` Kevin Hilman
0 siblings, 0 replies; 16+ messages in thread
From: Kevin Hilman @ 2021-01-04 16:13 UTC (permalink / raw)
To: Alexander Dahl, Rob Herring
Cc: devicetree, Neil Armstrong, Alexander Dahl, linux-kernel,
Martin Blumenstingl, Alexander Dahl, linux-arm-kernel,
linux-amlogic, linux-stm32, linux-leds, Jerome Brunet
Alexander Dahl <post@lespocky.de> writes:
> The node names for devices using the pwm-leds driver follow a certain
> naming scheme (now). Parent node name is not enforced, but recommended
> by DT project.
>
> Signed-off-by: Alexander Dahl <post@lespocky.de>
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Queued for 5.12,
Thanks,
Kevin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 16+ messages in thread