* Re: [PATCH v6] crypto: amlogic - Delete duplicate dev_err() in meson_crypto_probe()
@ 2020-04-04 12:00 Markus Elfring
0 siblings, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2020-04-04 12:00 UTC (permalink / raw)
To: Tang Bin, linux-amlogic, linux-crypto
Cc: Herbert Xu, Neil Armstrong, kernel-janitors, linux-kernel,
Corentin Labbe, David S. Miller
> When something goes wrong, platform_get_irq() will print an error message,
This information is reasonable.
> so in order to avoid the situation of repeat output,
Possible adjustments:
* Separate sentences
* Avoid another typo: “repeated output”
> we should remove dev_err here.
Thus remove a redundant function call.
(An imperative wording is usually preferred for Linux commit messages.)
Regards,
Markus
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v6]crypto: amlogic - Delete duplicate dev_err in meson_crypto_probe()
2020-04-03 22:07 [PATCH v6]crypto: amlogic - Delete duplicate dev_err " Tang Bin
@ 2020-04-16 6:51 ` Herbert Xu
0 siblings, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2020-04-16 6:51 UTC (permalink / raw)
To: Tang Bin
Cc: narmstrong, linux-kernel, linux-crypto, linux-amlogic, davem, clabbe
On Sat, Apr 04, 2020 at 06:07:54AM +0800, Tang Bin wrote:
> When something goes wrong, platform_get_irq() will print an error message,
> so in order to avoid the situation of repeat output,we should remove
> dev_err here.
>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---
> Changes from v5
> - modify the commit message.
>
> Changes from v4:
> - rewrite the code, because the code in v4 is wrong, sorry.
>
> Changes form v3:
> - fix the theme writing error.
>
> Changes from v2:
> - modify the theme format and content description.
> - reformat the patch, it's the wrong way to resubmit a new patch that
> should be modified on top of the original. The original piece is:
> https://lore.kernel.org/patchwork/patch/1219611/
>
> Changes from v1:
> - the title has changed, because the description is not very detailed.
> - the code has been modified, because it needs to match the theme.
>
> drivers/crypto/amlogic/amlogic-gxl-core.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v6]crypto: amlogic - Delete duplicate dev_err in meson_crypto_probe()
@ 2020-04-03 22:07 Tang Bin
2020-04-16 6:51 ` Herbert Xu
0 siblings, 1 reply; 3+ messages in thread
From: Tang Bin @ 2020-04-03 22:07 UTC (permalink / raw)
To: narmstrong, clabbe, herbert, davem
Cc: linux-amlogic, Tang Bin, linux-crypto, linux-kernel
When something goes wrong, platform_get_irq() will print an error message,
so in order to avoid the situation of repeat output,we should remove
dev_err here.
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
Changes from v5
- modify the commit message.
Changes from v4:
- rewrite the code, because the code in v4 is wrong, sorry.
Changes form v3:
- fix the theme writing error.
Changes from v2:
- modify the theme format and content description.
- reformat the patch, it's the wrong way to resubmit a new patch that
should be modified on top of the original. The original piece is:
https://lore.kernel.org/patchwork/patch/1219611/
Changes from v1:
- the title has changed, because the description is not very detailed.
- the code has been modified, because it needs to match the theme.
drivers/crypto/amlogic/amlogic-gxl-core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/crypto/amlogic/amlogic-gxl-core.c b/drivers/crypto/amlogic/amlogic-gxl-core.c
index 9d4ead2f7..411857fad 100644
--- a/drivers/crypto/amlogic/amlogic-gxl-core.c
+++ b/drivers/crypto/amlogic/amlogic-gxl-core.c
@@ -253,10 +253,8 @@ static int meson_crypto_probe(struct platform_device *pdev)
mc->irqs = devm_kcalloc(mc->dev, MAXFLOW, sizeof(int), GFP_KERNEL);
for (i = 0; i < MAXFLOW; i++) {
mc->irqs[i] = platform_get_irq(pdev, i);
- if (mc->irqs[i] < 0) {
- dev_err(mc->dev, "Cannot get IRQ for flow %d\n", i);
+ if (mc->irqs[i] < 0)
return mc->irqs[i];
- }
err = devm_request_irq(&pdev->dev, mc->irqs[i], meson_irq_handler, 0,
"gxl-crypto", mc);
--
2.20.1.windows.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-16 6:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-04 12:00 [PATCH v6] crypto: amlogic - Delete duplicate dev_err() in meson_crypto_probe() Markus Elfring
-- strict thread matches above, loose matches on Subject: below --
2020-04-03 22:07 [PATCH v6]crypto: amlogic - Delete duplicate dev_err " Tang Bin
2020-04-16 6:51 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).