* [PATCH] staging: media/meson: remove redundant dev_err call
@ 2021-04-07 16:09 Muhammad Usama Anjum
2021-04-26 18:03 ` Neil Armstrong
0 siblings, 1 reply; 2+ messages in thread
From: Muhammad Usama Anjum @ 2021-04-07 16:09 UTC (permalink / raw)
To: hverkuil, Neil Armstrong, Mauro Carvalho Chehab,
Greg Kroah-Hartman, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl,
open list:MESON VIDEO DECODER DRIVER FOR AMLOGIC SOCS,
open list:MESON VIDEO DECODER DRIVER FOR AMLOGIC SOCS,
open list:STAGING SUBSYSTEM,
moderated list:ARM/Amlogic Meson SoC support, open list
Cc: musamaanjum, kernel-janitors, dan.carpenter
devm_ioremap_resource() prints error message in itself. Remove the
dev_err call to avoid redundant error message.
Signed-off-by: Muhammad Usama Anjum <musamaanjum@gmail.com>
---
drivers/staging/media/meson/vdec/vdec.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/media/meson/vdec/vdec.c
index 5d4db7a5b4b5..e51d69c4729d 100644
--- a/drivers/staging/media/meson/vdec/vdec.c
+++ b/drivers/staging/media/meson/vdec/vdec.c
@@ -1008,17 +1008,13 @@ static int vdec_probe(struct platform_device *pdev)
r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dos");
core->dos_base = devm_ioremap_resource(dev, r);
- if (IS_ERR(core->dos_base)) {
- dev_err(dev, "Couldn't remap DOS memory\n");
+ if (IS_ERR(core->dos_base))
return PTR_ERR(core->dos_base);
- }
r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "esparser");
core->esparser_base = devm_ioremap_resource(dev, r);
- if (IS_ERR(core->esparser_base)) {
- dev_err(dev, "Couldn't remap ESPARSER memory\n");
+ if (IS_ERR(core->esparser_base))
return PTR_ERR(core->esparser_base);
- }
core->regmap_ao =
syscon_regmap_lookup_by_phandle(dev->of_node,
--
2.25.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: media/meson: remove redundant dev_err call
2021-04-07 16:09 [PATCH] staging: media/meson: remove redundant dev_err call Muhammad Usama Anjum
@ 2021-04-26 18:03 ` Neil Armstrong
0 siblings, 0 replies; 2+ messages in thread
From: Neil Armstrong @ 2021-04-26 18:03 UTC (permalink / raw)
To: Muhammad Usama Anjum, hverkuil, Mauro Carvalho Chehab,
Greg Kroah-Hartman, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl,
open list:MESON VIDEO DECODER DRIVER FOR AMLOGIC SOCS,
open list:MESON VIDEO DECODER DRIVER FOR AMLOGIC SOCS,
open list:STAGING SUBSYSTEM,
moderated list:ARM/Amlogic Meson SoC support, open list
Cc: kernel-janitors, dan.carpenter
On 07/04/2021 18:09, Muhammad Usama Anjum wrote:
> devm_ioremap_resource() prints error message in itself. Remove the
> dev_err call to avoid redundant error message.
>
> Signed-off-by: Muhammad Usama Anjum <musamaanjum@gmail.com>
> ---
> drivers/staging/media/meson/vdec/vdec.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/media/meson/vdec/vdec.c
> index 5d4db7a5b4b5..e51d69c4729d 100644
> --- a/drivers/staging/media/meson/vdec/vdec.c
> +++ b/drivers/staging/media/meson/vdec/vdec.c
> @@ -1008,17 +1008,13 @@ static int vdec_probe(struct platform_device *pdev)
>
> r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dos");
> core->dos_base = devm_ioremap_resource(dev, r);
> - if (IS_ERR(core->dos_base)) {
> - dev_err(dev, "Couldn't remap DOS memory\n");
> + if (IS_ERR(core->dos_base))
> return PTR_ERR(core->dos_base);
> - }
>
> r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "esparser");
> core->esparser_base = devm_ioremap_resource(dev, r);
> - if (IS_ERR(core->esparser_base)) {
> - dev_err(dev, "Couldn't remap ESPARSER memory\n");
> + if (IS_ERR(core->esparser_base))
> return PTR_ERR(core->esparser_base);
> - }
>
> core->regmap_ao =
> syscon_regmap_lookup_by_phandle(dev->of_node,
>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-26 18:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-07 16:09 [PATCH] staging: media/meson: remove redundant dev_err call Muhammad Usama Anjum
2021-04-26 18:03 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).