From: Heiner Kallweit <hkallweit1@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Linus Walleij <linus.walleij@linaro.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v7] dt-bindings: pinctrl: Convert Amlogic Meson pinctrl binding
Date: Sat, 25 Mar 2023 13:17:46 +0100 [thread overview]
Message-ID: <73faa10f-c94a-759f-8407-49d64bd0f824@gmail.com> (raw)
In-Reply-To: <29530f96-2633-a9ae-0ab6-811b68a74e9d@linaro.org>
On 25.03.2023 12:50, Krzysztof Kozlowski wrote:
> On 25/03/2023 12:41, Heiner Kallweit wrote:
>> On 25.03.2023 12:18, Krzysztof Kozlowski wrote:
>>> On 24/03/2023 23:51, Heiner Kallweit wrote:
>>>> Convert Amlogic Meson pin controller binding to yaml.
>>>>
>
>
>>>> +patternProperties:
>>>> + "^bank@[0-9a-z]+$":
>>>> + $ref: amlogic,meson-pinctrl-common.yaml#/$defs/meson-gpio
>>>> +
>>>> + properties:
>>>> + reg:
>>>> + maxItems: 4
>>>> +
>>>> + reg-names:
>>>> + items:
>>>> + - const: mux
>>>> + - const: pull
>>>> + - const: pull-enable
>>>> + - const: gpio
>>>> +
>>>> + unevaluatedProperties: false
>>>
>>> Wrong placement. Rob asked you to put it after $ref and the review was
>>> conditional based on this. Don't add review-tag if you do not follow the
>>> comment.
>>>
>> I wasn't aware that this makes a difference, and in e.g. samsung,pinctrl.yaml
>> I found it at the end of the patternProperties block.
>> Thanks for the hint, then I will correct this and resubmit.
>
> But Rob asks for it, so regardless whether it makes difference or not,
> you ignore the comment?
>
I understood the comment as: It needs to be in the block, somewhere after the $ref.
My bad.
> Best regards,
> Krzysztof
>
Heiner
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2023-03-25 12:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 22:51 [PATCH v7] dt-bindings: pinctrl: Convert Amlogic Meson pinctrl binding Heiner Kallweit
2023-03-25 11:18 ` Krzysztof Kozlowski
2023-03-25 11:41 ` Heiner Kallweit
2023-03-25 11:50 ` Krzysztof Kozlowski
2023-03-25 12:17 ` Heiner Kallweit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73faa10f-c94a-759f-8407-49d64bd0f824@gmail.com \
--to=hkallweit1@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).