From: guillaume La Roque <glaroque@baylibre.com>
To: Rob Herring <robh@kernel.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
khilman@baylibre.com, linus.walleij@linaro.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v2 1/4] dt-bindings: pinctrl: add a 'drive-strength-uA' property
Date: Tue, 30 Apr 2019 17:24:16 +0200 [thread overview]
Message-ID: <7d1743ca-f45a-133f-6130-c77059d27de2@baylibre.com> (raw)
In-Reply-To: <20190430151243.GA6879@bogus>
Hi Rob,
On 4/30/19 5:12 PM, Rob Herring wrote:
> On Thu, Apr 18, 2019 at 02:47:55PM +0200, Guillaume La Roque wrote:
>> This property allow drive-strength parameter in uA instead of mA.
>>
>> Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
>> ---
>> Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
>> index cef2b5855d60..fc7018459aa2 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
>> +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
>> @@ -258,6 +258,7 @@ drive-push-pull - drive actively high and low
>> drive-open-drain - drive with open drain
>> drive-open-source - drive with open source
>> drive-strength - sink or source at most X mA
>> +drive-strength-uA - sink or source at most X uA
>> input-enable - enable input on pin (no effect on output, such as
>> enabling an input buffer)
>> input-disable - disable input on pin (no effect on output, such as
>> @@ -326,6 +327,8 @@ arguments are described below.
>>
>> - drive-strength takes as argument the target strength in mA.
>>
>> +- drive-strength-uA takes as argument the target strength in uA.
>> +
> We have standard unit suffixes defined in bindings/property-units.txt.
> Use them please.
thanks for your feedback and sorry i don't see this doc.
According to it i will update patch series with drive-strength-microamp
> Rob
Guillaume
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-04-30 15:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 12:47 [PATCH v2 0/4] Add drive-strength in Meson pinctrl driver Guillaume La Roque
2019-04-18 12:47 ` [PATCH v2 1/4] dt-bindings: pinctrl: add a 'drive-strength-uA' property Guillaume La Roque
2019-04-23 11:13 ` Linus Walleij
2019-04-27 19:19 ` Martin Blumenstingl
2019-04-29 19:19 ` Kevin Hilman
2019-04-30 15:12 ` Rob Herring
2019-04-30 15:24 ` guillaume La Roque [this message]
2019-04-18 12:47 ` [PATCH v2 2/4] pinctrl: generic: add new 'drive-strength-uA' property support Guillaume La Roque
2019-04-18 12:47 ` [PATCH v2 3/4] dt-bindings: pinctrl: meson: Add drive-strength-uA property Guillaume La Roque
2019-04-27 19:21 ` Martin Blumenstingl
2019-04-30 6:38 ` guillaume La Roque
2019-04-18 12:47 ` [PATCH v2 4/4] pinctrl: meson: add support of drive-strength-uA Guillaume La Roque
2019-04-27 19:44 ` Martin Blumenstingl
2019-04-30 7:20 ` guillaume La Roque
2019-04-30 20:28 ` Martin Blumenstingl
2019-05-06 13:16 ` guillaume La Roque
2019-04-23 11:13 ` [PATCH v2 0/4] Add drive-strength in Meson pinctrl driver Linus Walleij
2019-04-27 19:46 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d1743ca-f45a-133f-6130-c77059d27de2@baylibre.com \
--to=glaroque@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).