From: Kevin Hilman <khilman@baylibre.com>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH 1/2] arm64: dts: meson: sei510: consistently order nodes
Date: Fri, 10 May 2019 14:43:50 -0700 [thread overview]
Message-ID: <7h4l62dlyh.fsf@baylibre.com> (raw)
In-Reply-To: <20190510155327.5759-2-jbrunet@baylibre.com>
Jerome Brunet <jbrunet@baylibre.com> writes:
> Like order boards, order nodes by address then node names then aliases.
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> .../boot/dts/amlogic/meson-g12a-sei510.dts | 92 +++++++++----------
> 1 file changed, 46 insertions(+), 46 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
> index 34b40587e5ef..61fb30047d7f 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
> @@ -14,10 +14,6 @@
> compatible = "seirobotics,sei510", "amlogic,g12a";
> model = "SEI Robotics SEI510";
>
> - aliases {
> - serial0 = &uart_AO;
> - };
> -
> adc_keys {
> compatible = "adc-keys";
> io-channels = <&saradc 0>;
> @@ -31,13 +27,8 @@
> };
> };
>
> - ao_5v: regulator-ao_5v {
> - compatible = "regulator-fixed";
> - regulator-name = "AO_5V";
> - regulator-min-microvolt = <5000000>;
> - regulator-max-microvolt = <5000000>;
> - vin-supply = <&dc_in>;
> - regulator-always-on;
> + aliases {
> + serial0 = &uart_AO;
> };
minor nit: I kind of like "aliases" and "chosen" at the top since they
are kind of special nodes, but honestly, I can't think of a really good
reason other than personal preference, so keeping things sorted as
you've done here is probably better.
Kevin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-05-10 21:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 15:53 [PATCH 0/2] arm64: dts: meson: g12a board node order Jerome Brunet
2019-05-10 15:53 ` [PATCH 1/2] arm64: dts: meson: sei510: consistently order nodes Jerome Brunet
2019-05-10 21:43 ` Kevin Hilman [this message]
2019-05-11 15:52 ` Jerome Brunet
2019-05-13 7:41 ` Neil Armstrong
2019-05-13 23:40 ` Kevin Hilman
2019-05-10 15:53 ` [PATCH 2/2] arm64: dts: meson: u200: " Jerome Brunet
2019-05-10 21:46 ` [PATCH 0/2] arm64: dts: meson: g12a board node order Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7h4l62dlyh.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).