From: Kevin Hilman <khilman@baylibre.com>
To: Emiliano Ingrassia <ingrassia@epigenesys.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org, jianxin.pan@amlogic.com,
linus.luessing@c0d3.blue
Subject: Re: [PATCH v3 1/2] pinctrl: meson: meson8b: add the eth_rxd2 and eth_rxd3 pins
Date: Fri, 11 Jan 2019 10:06:54 -0800 [thread overview]
Message-ID: <7hbm4noypt.fsf@baylibre.com> (raw)
In-Reply-To: <20190111100915.GA1716@ingrassia.epigenesys.com>
Emiliano Ingrassia <ingrassia@epigenesys.com> writes:
> Hi Kevin,
>
> sorry to bother you.
No need to apologize.
> On Thu, Jan 10, 2019 at 05:08:39PM -0800, Kevin Hilman wrote:
>> Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:
>>
>> > Gigabit Ethernet requires the Ethernet TXD0..3 and RXD0..3 data lines.
>> > Add the missing eth_rxd2 and eth_rxd3 definitions so we don't have to
>> > rely on the bootloader to set them up correctly.
>> >
>> > The vendor u-boot sources for Odroid-C1 use the following Ethernet
>> > pinmux configuration:
>> > SET_CBUS_REG_MASK(PERIPHS_PIN_MUX_6, 0x3f4f);
>> > SET_CBUS_REG_MASK(PERIPHS_PIN_MUX_7, 0xf00000);
>> > This translates to the following pin groups in the mainline kernel:
>> > - register 6 bit 0: eth_rxd1 (DIF_0_P)
>> > - register 6 bit 1: eth_rxd0 (DIF_0_N)
>> > - register 6 bit 2: eth_rx_dv (DIF_1_P)
>> > - register 6 bit 3: eth_rx_clk (DIF_1_N)
>> > - register 6 bit 6: eth_tx_en (DIF_3_P)
>> > - register 6 bit 8: eth_ref_clk (DIF_3_N)
>> > - register 6 bit 9: eth_mdc (DIF_4_P)
>> > - register 6 bit 10: eth_mdio_en (DIF_4_N)
>> > - register 6 bit 11: eth_tx_clk (GPIOH_9)
>> > - register 6 bit 12: eth_txd2 (GPIOH_8)
>> > - register 6 bit 13: eth_txd3 (GPIOH_7)
>> > - register 7 bit 20: eth_txd0_0 (GPIOH_6)
>> > - register 7 bit 21: eth_txd1_0 (GPIOH_5)
>> > - register 7 bit 22: eth_rxd3 (DIF_2_P)
>> > - register 7 bit 23: eth_rxd2 (DIF_2_N)
>> >
>> > All functions except eth_rxd2 and eth_rxd3 are already supported by the
>> > pinctrl-meson8b driver.
>> >
>> > Suggested-by: Jianxin Pan <jianxin.pan@amlogic.com>
>> > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>>
>> Reviewed-by: Kevin Hilman <khilman@baylibre.com>
>
> For both patches of this series I gave:
> Tested-by: Emiliano Ingrassia <ingrassia@epigenesys.com>
> Reviewed-by: Emiliano Ingrassia <ingrassia@epigenesys.com>
>
> They were in the answer to the cover letter of this series.
> I note that they were not included in the commit message of the first patch.
>
> Did I miss something or did something wrong?
> Please, let me know.
You did everything fine, I just missed them.
I've started relying a bit more heavily on patchwork to collect
review/test tags, and right now it doesn't notice tags to the
cover-letter, only to individual patches, so I typically add those by
hand, but in this case I missed them.
Sorry about that, and thanks for the reminder. I'll add them and
repush.
And, while I'm thinking about it, I'll request that feature to patchwork
developers.
Kevin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-01-11 18:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-29 14:35 [PATCH v3 0/2] Meson8b RGMII Ethernet pin fixes Martin Blumenstingl
2018-12-29 14:35 ` [PATCH v3 1/2] pinctrl: meson: meson8b: add the eth_rxd2 and eth_rxd3 pins Martin Blumenstingl
2019-01-11 1:08 ` Kevin Hilman
2019-01-11 9:36 ` Emiliano Ingrassia
2019-01-11 10:09 ` Emiliano Ingrassia
2019-01-11 18:06 ` Kevin Hilman [this message]
2019-01-11 18:21 ` Emiliano Ingrassia
2019-01-11 19:52 ` Martin Blumenstingl
2019-01-11 22:42 ` Kevin Hilman
2018-12-29 14:35 ` [PATCH v3 2/2] ARM: dts: meson8b: fix the Ethernet data line signals in eth_rgmii_pins Martin Blumenstingl
2019-01-11 1:09 ` Kevin Hilman
2019-01-11 10:13 ` Emiliano Ingrassia
2019-02-04 14:26 ` Martin Blumenstingl
2019-02-07 3:04 ` Kevin Hilman
2019-02-08 19:38 ` Martin Blumenstingl
2018-12-30 18:15 ` [PATCH v3 0/2] Meson8b RGMII Ethernet pin fixes Emiliano Ingrassia
2018-12-31 10:59 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hbm4noypt.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=ingrassia@epigenesys.com \
--cc=jianxin.pan@amlogic.com \
--cc=linus.luessing@c0d3.blue \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).