From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@kernel.org>,
dri-devel@lists.freedesktop.org
Cc: linux-amlogic@lists.infradead.org
Subject: Re: [PATCH] drm/meson: enable runtime PM
Date: Mon, 30 Sep 2019 08:34:21 -0700 [thread overview]
Message-ID: <7ho8z1g5mq.fsf@baylibre.com> (raw)
In-Reply-To: <c0db12a0-66c3-7636-a7bd-b071d0820426@baylibre.com>
Neil Armstrong <narmstrong@baylibre.com> writes:
> Hi Kevin,
>
> On 25/09/2019 21:31, Kevin Hilman wrote:
>> From: Kevin Hilman <khilman@baylibre.com>
>>
>> On some SoCs, the VPU is in a power-domain and needs runtime PM
>> enabled and used in order to keep the power domain on.
>>
>> Signed-off-by: Kevin Hilman <khilman@baylibre.com>
>> ---
>> drivers/gpu/drm/meson/meson_drv.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c
>> index 2310c96fff46..256b6a0e9c6b 100644
>> --- a/drivers/gpu/drm/meson/meson_drv.c
>> +++ b/drivers/gpu/drm/meson/meson_drv.c
>> @@ -14,6 +14,7 @@
>> #include <linux/platform_device.h>
>> #include <linux/component.h>
>> #include <linux/of_graph.h>
>> +#include <linux/pm_runtime.h>
>>
>> #include <drm/drmP.h>
>> #include <drm/drm_atomic.h>
>> @@ -274,6 +275,7 @@ static int meson_drv_bind_master(struct device *dev, bool has_components)
>>
>> /* Hardware Initialization */
>>
>> + pm_runtime_get_sync(dev);
>> meson_vpu_init(priv);
>> meson_venc_init(priv);
>> meson_vpp_init(priv);
>> @@ -416,6 +418,7 @@ static int meson_drv_probe(struct platform_device *pdev)
>> struct device_node *ep, *remote;
>> int count = 0;
>>
>> + pm_runtime_enable(&pdev->dev);
>> for_each_endpoint_of_node(np, ep) {
>> remote = of_graph_get_remote_port_parent(ep);
>> if (!remote || !of_device_is_available(remote)) {
>> @@ -440,6 +443,7 @@ static int meson_drv_probe(struct platform_device *pdev)
>> }
>>
>> /* If no output endpoints were available, simply bail out */
>> + pm_runtime_disable(&pdev->dev);
>> return 0;
>> };
>>
>>
>
> I'll rather implement true runtime PM instead,
While this is a minimum implementation, can you explain what you mean by
"true" runtime PM?
Kevin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-09-30 15:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 19:31 [PATCH] drm/meson: enable runtime PM Kevin Hilman
2019-09-30 8:20 ` Neil Armstrong
2019-09-30 15:34 ` Kevin Hilman [this message]
2019-10-01 8:41 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ho8z1g5mq.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=khilman@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).