* [PATCH 22/44] serial: meson: Use uart_xmit_advance()
[not found] <20221019091151.6692-1-ilpo.jarvinen@linux.intel.com>
@ 2022-10-19 9:11 ` Ilpo Järvinen
2022-10-19 9:36 ` Neil Armstrong
2022-10-19 20:42 ` Martin Blumenstingl
0 siblings, 2 replies; 3+ messages in thread
From: Ilpo Järvinen @ 2022-10-19 9:11 UTC (permalink / raw)
To: linux-serial, Greg KH, Jiri Slaby, Neil Armstrong, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl, linux-arm-kernel,
linux-amlogic, linux-kernel
Cc: Andy Shevchenko, Ilpo Järvinen
Take advantage of the new uart_xmit_advance() helper.
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
drivers/tty/serial/meson_uart.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
index 056243c12836..74110017988a 100644
--- a/drivers/tty/serial/meson_uart.c
+++ b/drivers/tty/serial/meson_uart.c
@@ -162,8 +162,7 @@ static void meson_uart_start_tx(struct uart_port *port)
ch = xmit->buf[xmit->tail];
writel(ch, port->membase + AML_UART_WFIFO);
- xmit->tail = (xmit->tail + 1) & (UART_XMIT_SIZE - 1);
- port->icount.tx++;
+ uart_xmit_advance(port, 1);
}
if (!uart_circ_empty(xmit)) {
--
2.30.2
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 22/44] serial: meson: Use uart_xmit_advance()
2022-10-19 9:11 ` [PATCH 22/44] serial: meson: Use uart_xmit_advance() Ilpo Järvinen
@ 2022-10-19 9:36 ` Neil Armstrong
2022-10-19 20:42 ` Martin Blumenstingl
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2022-10-19 9:36 UTC (permalink / raw)
To: Ilpo Järvinen, linux-serial, Greg KH, Jiri Slaby,
Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Andy Shevchenko
On 19/10/2022 11:11, Ilpo Järvinen wrote:
> Take advantage of the new uart_xmit_advance() helper.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
> drivers/tty/serial/meson_uart.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
> index 056243c12836..74110017988a 100644
> --- a/drivers/tty/serial/meson_uart.c
> +++ b/drivers/tty/serial/meson_uart.c
> @@ -162,8 +162,7 @@ static void meson_uart_start_tx(struct uart_port *port)
>
> ch = xmit->buf[xmit->tail];
> writel(ch, port->membase + AML_UART_WFIFO);
> - xmit->tail = (xmit->tail + 1) & (UART_XMIT_SIZE - 1);
> - port->icount.tx++;
> + uart_xmit_advance(port, 1);
> }
>
> if (!uart_circ_empty(xmit)) {
Acked-by: Neil Armstrong <neil.armstrong@linaro.org>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 22/44] serial: meson: Use uart_xmit_advance()
2022-10-19 9:11 ` [PATCH 22/44] serial: meson: Use uart_xmit_advance() Ilpo Järvinen
2022-10-19 9:36 ` Neil Armstrong
@ 2022-10-19 20:42 ` Martin Blumenstingl
1 sibling, 0 replies; 3+ messages in thread
From: Martin Blumenstingl @ 2022-10-19 20:42 UTC (permalink / raw)
To: Ilpo Järvinen
Cc: linux-serial, Greg KH, Jiri Slaby, Neil Armstrong, Kevin Hilman,
Jerome Brunet, linux-arm-kernel, linux-amlogic, linux-kernel,
Andy Shevchenko
On Wed, Oct 19, 2022 at 11:13 AM Ilpo Järvinen
<ilpo.jarvinen@linux.intel.com> wrote:
>
> Take advantage of the new uart_xmit_advance() helper.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
That helper is a welcome improvement in my opinion. Thanks for working on this!
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-19 20:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20221019091151.6692-1-ilpo.jarvinen@linux.intel.com>
2022-10-19 9:11 ` [PATCH 22/44] serial: meson: Use uart_xmit_advance() Ilpo Järvinen
2022-10-19 9:36 ` Neil Armstrong
2022-10-19 20:42 ` Martin Blumenstingl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).