* [PATCH] iio: remove unneeded break
@ 2020-10-19 17:28 trix
2020-10-20 19:39 ` Martin Blumenstingl
0 siblings, 1 reply; 3+ messages in thread
From: trix @ 2020-10-19 17:28 UTC (permalink / raw)
To: jic23, lars, pmeerw, khilman, narmstrong, jbrunet,
martin.blumenstingl, andy.shevchenko, krzk, alexandru.ardelean,
jonathan.albrieux
Cc: linux-iio, linux-amlogic, linux-kernel, linux-arm-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
A break is not needed if it is preceded by a return
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/iio/adc/meson_saradc.c | 2 --
drivers/iio/imu/bmi160/bmi160_core.c | 1 -
2 files changed, 3 deletions(-)
diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
index e03988698755..66dc452d643a 100644
--- a/drivers/iio/adc/meson_saradc.c
+++ b/drivers/iio/adc/meson_saradc.c
@@ -593,13 +593,11 @@ static int meson_sar_adc_iio_info_read_raw(struct iio_dev *indio_dev,
case IIO_CHAN_INFO_RAW:
return meson_sar_adc_get_sample(indio_dev, chan, NO_AVERAGING,
ONE_SAMPLE, val);
- break;
case IIO_CHAN_INFO_AVERAGE_RAW:
return meson_sar_adc_get_sample(indio_dev, chan,
MEAN_AVERAGING, EIGHT_SAMPLES,
val);
- break;
case IIO_CHAN_INFO_SCALE:
if (chan->type == IIO_VOLTAGE) {
diff --git a/drivers/iio/imu/bmi160/bmi160_core.c b/drivers/iio/imu/bmi160/bmi160_core.c
index 222ebb26f013..431076dc0d2c 100644
--- a/drivers/iio/imu/bmi160/bmi160_core.c
+++ b/drivers/iio/imu/bmi160/bmi160_core.c
@@ -486,7 +486,6 @@ static int bmi160_write_raw(struct iio_dev *indio_dev,
case IIO_CHAN_INFO_SCALE:
return bmi160_set_scale(data,
bmi160_to_sensor(chan->type), val2);
- break;
case IIO_CHAN_INFO_SAMP_FREQ:
return bmi160_set_odr(data, bmi160_to_sensor(chan->type),
val, val2);
--
2.18.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: remove unneeded break
2020-10-19 17:28 [PATCH] iio: remove unneeded break trix
@ 2020-10-20 19:39 ` Martin Blumenstingl
2020-11-01 15:32 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Martin Blumenstingl @ 2020-10-20 19:39 UTC (permalink / raw)
To: trix
Cc: lars, Neil Armstrong, linux-iio, khilman, linux-kernel, krzk,
andy.shevchenko, linux-arm-kernel, pmeerw, linux-amlogic,
jonathan.albrieux, alexandru.ardelean, jic23, jbrunet
On Mon, Oct 19, 2020 at 7:28 PM <trix@redhat.com> wrote:
>
> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a return
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/iio/adc/meson_saradc.c | 2 --
for meson_saradc.c:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: remove unneeded break
2020-10-20 19:39 ` Martin Blumenstingl
@ 2020-11-01 15:32 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2020-11-01 15:32 UTC (permalink / raw)
To: Martin Blumenstingl
Cc: linux-amlogic, lars, Neil Armstrong, linux-iio, trix,
linux-kernel, krzk, andy.shevchenko, pmeerw, khilman,
jonathan.albrieux, alexandru.ardelean, linux-arm-kernel, jbrunet
On Tue, 20 Oct 2020 21:39:17 +0200
Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
> On Mon, Oct 19, 2020 at 7:28 PM <trix@redhat.com> wrote:
> >
> > From: Tom Rix <trix@redhat.com>
> >
> > A break is not needed if it is preceded by a return
> >
> > Signed-off-by: Tom Rix <trix@redhat.com>
> > ---
> > drivers/iio/adc/meson_saradc.c | 2 --
> for meson_saradc.c:
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Applied,
Thanks,
Jonathan
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-01 15:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-19 17:28 [PATCH] iio: remove unneeded break trix
2020-10-20 19:39 ` Martin Blumenstingl
2020-11-01 15:32 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).