archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH net] net: stmmac: dwmac-meson8b: Fix signedness bug in probe
       [not found] <20190925105822.GH3264@mwanda>
@ 2019-09-26 17:51 ` Martin Blumenstingl
  0 siblings, 0 replies; only message in thread
From: Martin Blumenstingl @ 2019-09-26 17:51 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Alexandre Torgue, Kevin Hilman, kernel-janitors, linux-stm32,
	Jose Abreu, Maxime Coquelin, netdev, Giuseppe Cavallaro,
	linux-amlogic, David S. Miller

+Cc linux-amlogic mailing list

On Wed, Sep 25, 2019 at 12:59 PM Dan Carpenter <> wrote:
> The "dwmac->phy_mode" is an enum and in this context GCC treats it as
> an unsigned int so the error handling is never triggered.
> Fixes: 566e82516253 ("net: stmmac: add a glue driver for the Amlogic Meson 8b / GXBB DWMAC")
> Signed-off-by: Dan Carpenter <>
Reviewed-by: Martin Blumenstingl <>

thank you for catching and fixing this!


linux-amlogic mailing list

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-09-26 17:51 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20190925105822.GH3264@mwanda>
2019-09-26 17:51 ` [PATCH net] net: stmmac: dwmac-meson8b: Fix signedness bug in probe Martin Blumenstingl

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).