* [RESEND PATCH] soc: amlogic: add missing of_node_put()
@ 2019-02-03 5:41 wen yang
2019-02-04 9:30 ` Neil Armstrong
0 siblings, 1 reply; 2+ messages in thread
From: wen yang @ 2019-02-03 5:41 UTC (permalink / raw)
To: khilman; +Cc: linux-amlogic, linux-kernel, linux-arm-kernel, wen yang
The call to of_parse_phandle returns a node pointer with refcount
incremented thus it must be explicitly decremented here after the last
usage.
Signed-off-by: Wen Yang <yellowriver2010@hotmail.com>
Cc: Kevin Hilman <khilman@baylibre.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-amlogic@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
drivers/soc/amlogic/meson-canvas.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/amlogic/meson-canvas.c b/drivers/soc/amlogic/meson-canvas.c
index fce33ca..87a6c6e 100644
--- a/drivers/soc/amlogic/meson-canvas.c
+++ b/drivers/soc/amlogic/meson-canvas.c
@@ -57,9 +57,12 @@ struct meson_canvas *meson_canvas_get(struct device *dev)
return ERR_PTR(-ENODEV);
canvas_pdev = of_find_device_by_node(canvas_node);
- if (!canvas_pdev)
+ if (!canvas_pdev) {
+ of_node_put(canvas_node);
return ERR_PTR(-EPROBE_DEFER);
+ }
+ of_node_put(canvas_node);
return dev_get_drvdata(&canvas_pdev->dev);
}
EXPORT_SYMBOL_GPL(meson_canvas_get);
--
2.7.4
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RESEND PATCH] soc: amlogic: add missing of_node_put()
2019-02-03 5:41 [RESEND PATCH] soc: amlogic: add missing of_node_put() wen yang
@ 2019-02-04 9:30 ` Neil Armstrong
0 siblings, 0 replies; 2+ messages in thread
From: Neil Armstrong @ 2019-02-04 9:30 UTC (permalink / raw)
To: wen yang, khilman; +Cc: linux-amlogic, linux-kernel, linux-arm-kernel
Hi,
On 03/02/2019 06:41, wen yang wrote:
> The call to of_parse_phandle returns a node pointer with refcount
> incremented thus it must be explicitly decremented here after the last
> usage.
>
Missing a Fixes tag.
> Signed-off-by: Wen Yang <yellowriver2010@hotmail.com>
> Cc: Kevin Hilman <khilman@baylibre.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-amlogic@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> ---
> drivers/soc/amlogic/meson-canvas.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/amlogic/meson-canvas.c b/drivers/soc/amlogic/meson-canvas.c
> index fce33ca..87a6c6e 100644
> --- a/drivers/soc/amlogic/meson-canvas.c
> +++ b/drivers/soc/amlogic/meson-canvas.c
> @@ -57,9 +57,12 @@ struct meson_canvas *meson_canvas_get(struct device *dev)
> return ERR_PTR(-ENODEV);
>
> canvas_pdev = of_find_device_by_node(canvas_node);
> - if (!canvas_pdev)
> + if (!canvas_pdev) {
> + of_node_put(canvas_node);
> return ERR_PTR(-EPROBE_DEFER);
> + }
>
> + of_node_put(canvas_node);
> return dev_get_drvdata(&canvas_pdev->dev);
> }
> EXPORT_SYMBOL_GPL(meson_canvas_get);
>
Apart the missing Fixes tag :
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Neil
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-04 9:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-03 5:41 [RESEND PATCH] soc: amlogic: add missing of_node_put() wen yang
2019-02-04 9:30 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).