* [PATCH] thermal: amlogic: Omit superfluous error message in amlogic_thermal_probe()
@ 2021-02-22 6:11 Tang Bin
2021-04-07 8:51 ` Neil Armstrong
0 siblings, 1 reply; 2+ messages in thread
From: Tang Bin @ 2021-02-22 6:11 UTC (permalink / raw)
To: glaroque, rui.zhang, daniel.lezcano, amitk
Cc: linux-amlogic, Tang Bin, linux-kernel, linux-pm
The function devm_platform_ioremap_resource has already contains error
message, so remove the redundant dev_err here.
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
drivers/thermal/amlogic_thermal.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/thermal/amlogic_thermal.c b/drivers/thermal/amlogic_thermal.c
index ccb1fe18e..bba9f3b14 100644
--- a/drivers/thermal/amlogic_thermal.c
+++ b/drivers/thermal/amlogic_thermal.c
@@ -253,10 +253,8 @@ static int amlogic_thermal_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, pdata);
base = devm_platform_ioremap_resource(pdev, 0);
- if (IS_ERR(base)) {
- dev_err(dev, "failed to get io address\n");
+ if (IS_ERR(base))
return PTR_ERR(base);
- }
pdata->regmap = devm_regmap_init_mmio(dev, base,
pdata->data->regmap_config);
--
2.20.1.windows.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] thermal: amlogic: Omit superfluous error message in amlogic_thermal_probe()
2021-02-22 6:11 [PATCH] thermal: amlogic: Omit superfluous error message in amlogic_thermal_probe() Tang Bin
@ 2021-04-07 8:51 ` Neil Armstrong
0 siblings, 0 replies; 2+ messages in thread
From: Neil Armstrong @ 2021-04-07 8:51 UTC (permalink / raw)
To: Tang Bin, glaroque, rui.zhang, daniel.lezcano, amitk
Cc: linux-amlogic, linux-kernel, linux-pm
On 22/02/2021 07:11, Tang Bin wrote:
> The function devm_platform_ioremap_resource has already contains error
> message, so remove the redundant dev_err here.
>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---
> drivers/thermal/amlogic_thermal.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/thermal/amlogic_thermal.c b/drivers/thermal/amlogic_thermal.c
> index ccb1fe18e..bba9f3b14 100644
> --- a/drivers/thermal/amlogic_thermal.c
> +++ b/drivers/thermal/amlogic_thermal.c
> @@ -253,10 +253,8 @@ static int amlogic_thermal_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, pdata);
>
> base = devm_platform_ioremap_resource(pdev, 0);
> - if (IS_ERR(base)) {
> - dev_err(dev, "failed to get io address\n");
> + if (IS_ERR(base))
> return PTR_ERR(base);
> - }
>
> pdata->regmap = devm_regmap_init_mmio(dev, base,
> pdata->data->regmap_config);
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-07 8:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-22 6:11 [PATCH] thermal: amlogic: Omit superfluous error message in amlogic_thermal_probe() Tang Bin
2021-04-07 8:51 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).