From: Simon Huelck <simonmail@gmx.de>
To: Jerome Brunet <jbrunet@baylibre.com>,
Jose Abreu <jose.abreu@synopsys.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-amlogic@lists.infradead.org, netdev@vger.kernel.org,
alexandre.torgue@st.com,
Emiliano Ingrassia <ingrassia@epigenesys.com>,
Gpeppe.cavallaro@st.com
Subject: Re: stmmac / meson8b-dwmac
Date: Thu, 21 Feb 2019 20:34:51 +0100 [thread overview]
Message-ID: <e009cbbb-e31d-2438-e454-2fa10ebec542@gmx.de> (raw)
In-Reply-To: <d7de65c614ee788152300f6d3799fd537b438496.camel@baylibre.com>
Am 21.02.2019 um 18:46 schrieb Jerome Brunet:
> On Thu, 2019-02-21 at 18:27 +0100, Simon Huelck wrote:
>> Hi,
>>
>>
>>
>> this was changed recently, with a patch for the EEE stuff , see here:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.0-rc7&id=e35e26b26e955c53e61c154ba26b9bb15da6b858
> Hu, I was not aware this finally went through. Good !
> As explained in the patch and by Jose, the GMAC should be using IRQ_LEVEL.
>
> The realtek PHY has EEE enabled by default. Having this enabled generates a
> lot of (Low Power) Interrupts.
>
> Previously, when the GMAC used IRQ_EDGE. Because it is wrong, we would
> eventually miss an IRQ and the interface would just die. Unfortunately, it was
> not that easy find out.
>
> 2 years ago, we just noticed that disabling EEE would make the failure go
> away. Forcing this EEE feature off through DT was merely a work around.
>
> Now that the real cause of the problem is known, there is no reason to keep
> this hack around.
>
> Whether EEE adds a performance penality and why, is another topic.
> As Jose pointed out, you can disable EEE at runtime, using ethtool.
>
> Jerome
>
Hi,
i disabled EEE via ethtool and via the .dtb , but the performance
penalty stays. Kernel 4.14 still gives me the former "good" performance.
regards,
Simon
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-02-21 19:35 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <a38e643c-ed9f-c306-cc95-84f70ebc1f10@gmx.de>
[not found] ` <CAFBinCDebPOsmrhSXecx48nGWHh7g_OGPbr1Y0M+n_v9Ht91ew@mail.gmail.com>
2019-01-17 21:23 ` stmmac / meson8b-dwmac Simon Huelck
2019-02-04 14:34 ` Martin Blumenstingl
2019-02-06 10:36 ` Emiliano Ingrassia
2019-02-06 18:04 ` Simon Huelck
2019-02-06 21:21 ` Simon Huelck
2019-02-07 19:30 ` Simon Huelck
2019-02-09 1:09 ` Martin Blumenstingl
2019-02-11 13:44 ` Jose Abreu
2019-02-14 7:21 ` Simon Huelck
2019-02-17 14:48 ` Martin Blumenstingl
2019-02-17 19:13 ` Simon Huelck
2019-02-18 8:42 ` Jose Abreu
2019-02-18 8:45 ` Jose Abreu
2019-02-18 12:33 ` Simon Huelck
2019-02-18 12:41 ` Jose Abreu
2019-02-18 13:02 ` Jose Abreu
2019-02-18 15:29 ` Simon Huelck
2019-02-18 15:31 ` Jose Abreu
2019-02-18 15:53 ` Simon Huelck
2019-02-18 16:26 ` Jose Abreu
2019-02-18 16:40 ` Simon Huelck
2019-02-18 16:43 ` Jose Abreu
2019-02-18 16:51 ` Simon Huelck
2019-02-18 17:05 ` Jose Abreu
2019-02-18 18:05 ` Simon Huelck
2019-02-19 8:47 ` Jose Abreu
2019-02-19 19:41 ` Simon Huelck
2019-02-21 14:21 ` Jerome Brunet
2019-02-21 17:27 ` Simon Huelck
2019-02-21 17:46 ` Jerome Brunet
2019-02-21 19:34 ` Simon Huelck [this message]
2019-02-22 17:21 ` Anand Moon
2019-02-24 15:00 ` Simon Huelck
2019-02-24 15:02 ` Simon Huelck
2019-02-24 19:42 ` Sebastian Gottschall
2019-02-24 20:34 ` Simon Huelck
2019-02-27 11:09 ` Jose Abreu
2019-02-27 19:02 ` Simon Huelck
2019-03-01 9:23 ` Jose Abreu
2019-03-05 9:55 ` Simon Huelck
2019-03-06 11:35 ` Simon Huelck
2019-03-06 11:45 ` Simon Huelck
2019-05-11 14:53 ` Simon Huelck
2019-05-13 9:07 ` Jose Abreu
2019-05-22 12:48 ` Simon Huelck
2019-05-22 14:02 ` Neil Armstrong
2019-02-27 21:03 ` Simon Huelck
2019-02-18 17:05 ` Simon Huelck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e009cbbb-e31d-2438-e454-2fa10ebec542@gmx.de \
--to=simonmail@gmx.de \
--cc=Gpeppe.cavallaro@st.com \
--cc=alexandre.torgue@st.com \
--cc=ingrassia@epigenesys.com \
--cc=jbrunet@baylibre.com \
--cc=jose.abreu@synopsys.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).