From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Alex Williamson <alex.williamson@redhat.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Jason Gunthorpe <jgg@nvidia.com>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, linux-api@vger.kernel.org
Subject: Re: remove the nvlink2 pci_vfio subdriver
Date: Mon, 22 Mar 2021 16:12:42 +0100 [thread overview]
Message-ID: <YFiz6sIJluL/u2Cu@kroah.com> (raw)
In-Reply-To: <20210322150155.797882-1-hch@lst.de>
On Mon, Mar 22, 2021 at 04:01:53PM +0100, Christoph Hellwig wrote:
> Hi all,
>
> the nvlink2 vfio subdriver is a weird beast. It supports a hardware
> feature without any open source component - what would normally be
> the normal open source userspace that we require for kernel drivers,
> although in this particular case user space could of course be a
> kernel driver in a VM. It also happens to be a complete mess that
> does not properly bind to PCI IDs, is hacked into the vfio_pci driver
> and also pulles in over 1000 lines of code always build into powerpc
> kernels that have Power NV support enabled. Because of all these
> issues and the lack of breaking userspace when it is removed I think
> the best idea is to simply kill.
>
> Diffstat:
> arch/powerpc/platforms/powernv/npu-dma.c | 705 ---------------------------
> b/arch/powerpc/include/asm/opal.h | 3
> b/arch/powerpc/include/asm/pci-bridge.h | 1
> b/arch/powerpc/include/asm/pci.h | 7
> b/arch/powerpc/platforms/powernv/Makefile | 2
> b/arch/powerpc/platforms/powernv/opal-call.c | 2
> b/arch/powerpc/platforms/powernv/pci-ioda.c | 185 -------
> b/arch/powerpc/platforms/powernv/pci.c | 11
> b/arch/powerpc/platforms/powernv/pci.h | 17
> b/arch/powerpc/platforms/pseries/pci.c | 23
> b/drivers/vfio/pci/Kconfig | 6
> b/drivers/vfio/pci/Makefile | 1
> b/drivers/vfio/pci/vfio_pci.c | 18
> b/drivers/vfio/pci/vfio_pci_private.h | 14
> b/include/uapi/linux/vfio.h | 40 -
> drivers/vfio/pci/vfio_pci_nvlink2.c | 490 ------------------
> 16 files changed, 8 insertions(+), 1517 deletions(-)
I thought this was supposed to be removed a few years ago!
Anyway, no objection from me:
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
prev parent reply other threads:[~2021-03-22 15:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 15:01 remove the nvlink2 pci_vfio subdriver Christoph Hellwig
2021-03-22 15:01 ` [PATCH 1/2] vfio/pci: remove vfio_pci_nvlink2 Christoph Hellwig
2021-03-22 17:46 ` Alex Williamson
2021-03-22 15:01 ` [PATCH 2/2] powerpc/powernv: remove the nvlink support Christoph Hellwig
2021-03-22 15:12 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFiz6sIJluL/u2Cu@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=airlied@linux.ie \
--cc=alex.williamson@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=jgg@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).