Linux-api Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] lightnvm: remove duplicate include in lightnvm.h
@ 2021-03-13 11:22 menglong8.dong
  2021-04-13 10:55 ` Matias Bjørling
  0 siblings, 1 reply; 2+ messages in thread
From: menglong8.dong @ 2021-03-13 11:22 UTC (permalink / raw)
  To: mb; +Cc: linux-block, linux-api, linux-kernel, Zhang Yunkai

From: Zhang Yunkai <zhang.yunkai@zte.com.cn>

'linux/ioctl.h' included in 'lightnvm.h' is duplicated.
It is also included in the 33th line.

Signed-off-by: Zhang Yunkai <zhang.yunkai@zte.com.cn>
---
 include/uapi/linux/lightnvm.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/uapi/linux/lightnvm.h b/include/uapi/linux/lightnvm.h
index ead2e72e5c88..2745afd9b8fa 100644
--- a/include/uapi/linux/lightnvm.h
+++ b/include/uapi/linux/lightnvm.h
@@ -22,7 +22,6 @@
 
 #ifdef __KERNEL__
 #include <linux/const.h>
-#include <linux/ioctl.h>
 #else /* __KERNEL__ */
 #include <stdio.h>
 #include <sys/ioctl.h>
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] lightnvm: remove duplicate include in lightnvm.h
  2021-03-13 11:22 [PATCH] lightnvm: remove duplicate include in lightnvm.h menglong8.dong
@ 2021-04-13 10:55 ` Matias Bjørling
  0 siblings, 0 replies; 2+ messages in thread
From: Matias Bjørling @ 2021-04-13 10:55 UTC (permalink / raw)
  To: menglong8.dong; +Cc: linux-block, linux-api, linux-kernel, Zhang Yunkai

On 13/03/2021 12.22, menglong8.dong@gmail.com wrote:
> From: Zhang Yunkai <zhang.yunkai@zte.com.cn>
>
> 'linux/ioctl.h' included in 'lightnvm.h' is duplicated.
> It is also included in the 33th line.
>
> Signed-off-by: Zhang Yunkai <zhang.yunkai@zte.com.cn>
> ---
>   include/uapi/linux/lightnvm.h | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/include/uapi/linux/lightnvm.h b/include/uapi/linux/lightnvm.h
> index ead2e72e5c88..2745afd9b8fa 100644
> --- a/include/uapi/linux/lightnvm.h
> +++ b/include/uapi/linux/lightnvm.h
> @@ -22,7 +22,6 @@
>   
>   #ifdef __KERNEL__
>   #include <linux/const.h>
> -#include <linux/ioctl.h>
>   #else /* __KERNEL__ */
>   #include <stdio.h>
>   #include <sys/ioctl.h>
Thanks, Yunkai. I've pulled it. Note that I've merged your two patches 
into one.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-13 11:22 [PATCH] lightnvm: remove duplicate include in lightnvm.h menglong8.dong
2021-04-13 10:55 ` Matias Bjørling

Linux-api Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-api/0 linux-api/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-api linux-api/ https://lore.kernel.org/linux-api \
		linux-api@vger.kernel.org
	public-inbox-index linux-api

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-api


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git