archive mirror
 help / color / mirror / Atom feed
* Re: Unchecked flags in statx(2) [Should be fixed before 4.11-final?]
       [not found] ` <>
@ 2017-04-21 12:28   ` Michael Kerrisk (man-pages)
  0 siblings, 0 replies; only message in thread
From: Michael Kerrisk (man-pages) @ 2017-04-21 12:28 UTC (permalink / raw)
  To: David Howells
  Cc: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w, lkml, linux-fsdevel,
	hch-wEGCiKHe2LqWVfeAwA7xHQ, Eric Biggers, Linux API,
	Alexander Viro

[Adding a few people to CC, and correcting myself on one piece] 

On 04/21/2017 02:14 PM, Michael Kerrisk (man-pages) wrote:
> Hello David,
>  I was reading your statx(2) man page, and noticed this text:
>        Do not simply set mask to UINT_MAX as one or more bits may, in the
>        future, be used to specify an extension to the buffer.
> (Here' 'mask' is the fourth argument to statx())
> What is going on here? Why is there  not a check in the code to
> give EINVAL if any flag other than those in STATX_ALL (0x00000fffU)
> is specified? (There is a check that gives EINVAL flags in 
> Similarly, there appears to be no check for invalid flags in the
> 'flags' argument of statx(). Why is there also not such a check
> there?
> The failure to do these sorts of checks has been the source of grief 
> in the past with other system calls.

So, it looks like the checks are there for 'flags' (I missed that 
they were one level deeper in the call sequence), but my question 
re 'mask' still stands.



Michael Kerrisk
Linux man-pages maintainer;
Linux/UNIX System Programming Training:

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-04-21 12:28 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <>
     [not found] ` <>
2017-04-21 12:28   ` Unchecked flags in statx(2) [Should be fixed before 4.11-final?] Michael Kerrisk (man-pages)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).