From: Jonas Bonn <jonas@southpole.se>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arch@vger.kernel.org, Grant Likely <grant@secretlab.ca>,
linux-alpha@vger.kernel.org, linux-ia64@vger.kernel.org,
Linus Walleij <linus.walleij@stericsson.com>,
Chris Zankel <chris@zankel.net>,
microblaze-uclinux@itee.uq.edu.au,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
linux-kernel@vger.kernel.org, linux@lists.openrisc.net,
sparclinux@vger.kernel.org,
"linuxppc-dev@lists.ozlabs.org list"
<linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] gpiolib/arches: Centralise bolierplate asm/gpio.h
Date: Mon, 16 Apr 2012 09:53:42 +0200 [thread overview]
Message-ID: <1334562822.2953.45.camel@crucifix> (raw)
In-Reply-To: <CACRpkdZ8yH1ZSG-nQ9dLm0TipHS-jZDuxwqohUC=LGH9V-5q4w@mail.gmail.com>
Acked-by: Jonas Bonn <jonas@southpole.se> (for OpenRISC)
On Mon, 2012-04-16 at 09:21 +0200, Linus Walleij wrote:
> On Sun, Apr 15, 2012 at 11:52 AM, Mark Brown
> <broonie@opensource.wolfsonmicro.com> wrote:
>
> > Rather than requiring architectures that use gpiolib but don't have any
> > need to define anything custom to copy an asm/gpio.h provide a Kconfig
> > symbol which architectures must select in order to include gpio.h and
> > for other architectures just provide the trivial implementation directly.
> >
> > This makes it much easier to do gpiolib updates and is also a step towards
> > making gpiolib APIs available on every architecture.
> >
> > For architectures with existing boilerplate code leave a stub header in
> > place which warns on direct inclusion of asm/gpio.h and includes
> > linux/gpio.h to catch code that's doing this. Direct inclusion of
> > asm/gpio.h has long been deprecated.
> >
> > Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> > ---
> > arch/alpha/include/asm/gpio.h | 59 ++----------------------------
> > arch/arm/Kconfig | 1 +
> > arch/avr32/Kconfig | 1 +
> > arch/blackfin/Kconfig | 1 +
> > arch/ia64/include/asm/gpio.h | 59 ++----------------------------
> > arch/m68k/Kconfig.cpu | 1 +
> > arch/microblaze/include/asm/gpio.h | 57 ++---------------------------
> > arch/mips/Kconfig | 1 +
> > arch/openrisc/include/asm/gpio.h | 69 ++---------------------------------
> > arch/powerpc/include/asm/gpio.h | 57 ++---------------------------
> > arch/sh/Kconfig | 1 +
> > arch/sparc/include/asm/gpio.h | 40 ++-------------------
> > arch/unicore32/Kconfig | 1 +
> > arch/x86/include/asm/gpio.h | 57 ++---------------------------
> > arch/xtensa/include/asm/gpio.h | 60 ++-----------------------------
> > drivers/gpio/Kconfig | 8 ++++
> > include/linux/gpio.h | 34 +++++++++++++++++
> > 17 files changed, 81 insertions(+), 426 deletions(-)
>
> This looks good but I think we need to page the alpha, ia64, m68k, microblaze,
> openrisc etc subarch maintainers on this patch so they have their say.
>
> Yours,
> Linus Walleij
> _______________________________________________
> Linux mailing list
> Linux@lists.openrisc.net
> http://lists.openrisc.net/listinfo/linux
WARNING: multiple messages have this Message-ID (diff)
From: Jonas Bonn <jonas@southpole.se>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
linux-arch@vger.kernel.org, Grant Likely <grant@secretlab.ca>,
linux-ia64@vger.kernel.org,
Linus Walleij <linus.walleij@stericsson.com>,
Chris Zankel <chris@zankel.net>,
microblaze-uclinux@itee.uq.edu.au, linux@lists.openrisc.net,
linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org,
sparclinux@vger.kernel.org,
"linuxppc-dev@lists.ozlabs.org list"
<linuxppc-dev@lists.ozlabs.org>
Subject: Re: [ORLinux] [PATCH] gpiolib/arches: Centralise bolierplate asm/gpio.h
Date: Mon, 16 Apr 2012 09:53:42 +0200 [thread overview]
Message-ID: <1334562822.2953.45.camel@crucifix> (raw)
Message-ID: <20120416075342.mBcUsTQKMNFYr-EoKCgp_CTExmKdLYnr60ibVPfdZbg@z> (raw)
In-Reply-To: <CACRpkdZ8yH1ZSG-nQ9dLm0TipHS-jZDuxwqohUC=LGH9V-5q4w@mail.gmail.com>
Acked-by: Jonas Bonn <jonas@southpole.se> (for OpenRISC)
On Mon, 2012-04-16 at 09:21 +0200, Linus Walleij wrote:
> On Sun, Apr 15, 2012 at 11:52 AM, Mark Brown
> <broonie@opensource.wolfsonmicro.com> wrote:
>
> > Rather than requiring architectures that use gpiolib but don't have any
> > need to define anything custom to copy an asm/gpio.h provide a Kconfig
> > symbol which architectures must select in order to include gpio.h and
> > for other architectures just provide the trivial implementation directly.
> >
> > This makes it much easier to do gpiolib updates and is also a step towards
> > making gpiolib APIs available on every architecture.
> >
> > For architectures with existing boilerplate code leave a stub header in
> > place which warns on direct inclusion of asm/gpio.h and includes
> > linux/gpio.h to catch code that's doing this. Direct inclusion of
> > asm/gpio.h has long been deprecated.
> >
> > Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> > ---
> > arch/alpha/include/asm/gpio.h | 59 ++----------------------------
> > arch/arm/Kconfig | 1 +
> > arch/avr32/Kconfig | 1 +
> > arch/blackfin/Kconfig | 1 +
> > arch/ia64/include/asm/gpio.h | 59 ++----------------------------
> > arch/m68k/Kconfig.cpu | 1 +
> > arch/microblaze/include/asm/gpio.h | 57 ++---------------------------
> > arch/mips/Kconfig | 1 +
> > arch/openrisc/include/asm/gpio.h | 69 ++---------------------------------
> > arch/powerpc/include/asm/gpio.h | 57 ++---------------------------
> > arch/sh/Kconfig | 1 +
> > arch/sparc/include/asm/gpio.h | 40 ++-------------------
> > arch/unicore32/Kconfig | 1 +
> > arch/x86/include/asm/gpio.h | 57 ++---------------------------
> > arch/xtensa/include/asm/gpio.h | 60 ++-----------------------------
> > drivers/gpio/Kconfig | 8 ++++
> > include/linux/gpio.h | 34 +++++++++++++++++
> > 17 files changed, 81 insertions(+), 426 deletions(-)
>
> This looks good but I think we need to page the alpha, ia64, m68k, microblaze,
> openrisc etc subarch maintainers on this patch so they have their say.
>
> Yours,
> Linus Walleij
> _______________________________________________
> Linux mailing list
> Linux@lists.openrisc.net
> http://lists.openrisc.net/listinfo/linux
next prev parent reply other threads:[~2012-04-16 7:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-15 9:52 [PATCH] gpiolib/arches: Centralise bolierplate asm/gpio.h Mark Brown
2012-04-16 7:21 ` Linus Walleij
2012-04-16 7:21 ` Linus Walleij
2012-04-16 7:53 ` Jonas Bonn [this message]
2012-04-16 7:53 ` [ORLinux] " Jonas Bonn
2012-04-16 8:15 ` Mark Brown
2012-04-16 8:15 ` Mark Brown
2012-04-16 8:26 ` Linus Walleij
2012-04-16 8:26 ` Linus Walleij
2012-05-12 0:08 ` Grant Likely
2012-05-12 0:08 ` Grant Likely
2012-04-17 18:49 ` Tony Luck
2012-04-17 18:49 ` Tony Luck
-- strict thread matches above, loose matches on Subject: below --
2012-02-04 15:54 Mark Brown
2012-02-04 15:54 ` Mark Brown
2012-02-04 17:06 ` Sam Ravnborg
2012-02-04 17:06 ` Sam Ravnborg
2012-02-04 17:21 ` Mark Brown
2012-02-04 17:21 ` Mark Brown
2012-02-04 17:41 ` Russell King - ARM Linux
2012-02-06 11:37 ` Mark Brown
2012-02-06 11:37 ` Mark Brown
2011-10-25 7:33 Mark Brown
2011-10-25 7:33 ` Mark Brown
2011-10-25 8:33 ` Grant Likely
2011-10-25 8:39 ` Mark Brown
2011-10-25 23:44 ` Mike Frysinger
2011-10-25 23:44 ` Mike Frysinger
2011-10-26 7:33 ` Mark Brown
2011-10-26 7:33 ` Mark Brown
2012-02-03 23:16 ` Grant Likely
2012-02-03 23:16 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334562822.2953.45.camel@crucifix \
--to=jonas@southpole.se \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=chris@zankel.net \
--cc=grant@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@lists.openrisc.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=microblaze-uclinux@itee.uq.edu.au \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).