From: Peter Zijlstra <peterz@infradead.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: davem@davemloft.net, arnd@arndb.de, manfred@colorfullife.com,
riel@redhat.com, hpa@zytor.com, ebiggers3@gmail.com,
elena.reshetova@intel.com, keescook@chromium.org,
dwindsor@gmail.com, mingo@kernel.org, jannh@google.com,
serge@hallyn.com, gregkh@linuxfoundation.org,
ebiederm@xmission.com, ishkamiel@gmail.com, tglx@linutronix.de,
hch@infradead.org, jpoimboe@redhat.com,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
akpm@linux-foundation.org, dave@stgolabs.net,
linux-arch@vger.kernel.org,
James.Bottomley@hansenpartnership.com,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:locking/core] locking/refcount: Create unchecked atomic_t implementation
Date: Mon, 4 Sep 2017 21:36:43 +0200 [thread overview]
Message-ID: <20170904193643.GC17526@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <20170904173444.GA7233@avx2>
On Mon, Sep 04, 2017 at 08:34:44PM +0300, Alexey Dobriyan wrote:
> On Mon, Sep 04, 2017 at 02:37:24PM +0200, Peter Zijlstra wrote:
> > - once.o refcount.o usercopy.o errseq.o
> > -obj-y += string_helpers.o
> > + once.o usercopy.o errseq.o string_helpers.o hexdump.o kstrtox.o
> > +
> > +obj-$(CONFIG_REFCOUNT_FULL) += refcount.o
> > obj-$(CONFIG_TEST_STRING_HELPERS) += test-string_helpers.o
> > -obj-y += hexdump.o
> > obj-$(CONFIG_TEST_HEXDUMP) += test_hexdump.o
> > -obj-y += kstrtox.o
>
> File per line so everything is not lumped together even if it is obj-y.
If that is policy mass convert everything and be done with it. Otherwise
I'll continue to use the predominant pattern, which in this case is a
giant obj-y +=. But mixed stuff is terribly annoying.
next prev parent reply other threads:[~2017-09-04 19:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 20:00 [PATCH v3] refcount: Create unchecked atomic_t implementation Kees Cook
2017-06-21 20:00 ` Kees Cook
2017-06-22 11:07 ` [tip:locking/core] locking/refcount: " tip-bot for Kees Cook
2017-06-28 16:58 ` tip-bot for Kees Cook
2017-09-04 12:37 ` Peter Zijlstra
2017-09-04 12:37 ` Peter Zijlstra
2017-09-04 17:11 ` Kees Cook
2017-09-04 17:11 ` Kees Cook
2017-09-04 19:35 ` Peter Zijlstra
2017-09-04 19:35 ` Peter Zijlstra
2017-09-04 17:34 ` Alexey Dobriyan
2017-09-04 17:34 ` Alexey Dobriyan
2017-09-04 19:36 ` Peter Zijlstra [this message]
2017-09-05 18:15 ` Alexey Dobriyan
2017-09-06 8:17 ` Peter Zijlstra
2017-09-06 8:17 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170904193643.GC17526@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dave@stgolabs.net \
--cc=davem@davemloft.net \
--cc=dwindsor@gmail.com \
--cc=ebiederm@xmission.com \
--cc=ebiggers3@gmail.com \
--cc=elena.reshetova@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=ishkamiel@gmail.com \
--cc=jannh@google.com \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=mingo@kernel.org \
--cc=riel@redhat.com \
--cc=serge@hallyn.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).