From: Peter Zijlstra <peterz@infradead.org>
To: Kees Cook <keescook@chromium.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Arnd Bergmann <arnd@arndb.de>,
Manfred Spraul <manfred@colorfullife.com>,
Rik van Riel <riel@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Eric Biggers <ebiggers3@gmail.com>,
"Reshetova, Elena" <elena.reshetova@intel.com>,
David Windsor <dwindsor@gmail.com>,
Ingo Molnar <mingo@kernel.org>, Jann Horn <jannh@google.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Hans Liljestrand <ishkamiel@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Christoph Hellwig <hch@infradead.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Davidlohr Bueso <dave@stgolabs.net>,
linux-arch <linux-arch@vger.kernel.org>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
"linux-tip-commits@vger.kernel.org"
<linux-tip-commits@vger.kernel.org>
Subject: Re: [tip:locking/core] locking/refcount: Create unchecked atomic_t implementation
Date: Mon, 4 Sep 2017 21:35:27 +0200 [thread overview]
Message-ID: <20170904193527.GB17526@worktop.programming.kicks-ass.net> (raw)
Message-ID: <20170904193527.XnjLrseF1CiNcaOFbLQE-cwRd4XrssbcTihtS6c3dHE@z> (raw)
In-Reply-To: <CAGXu5jJdpFk0GNWiw6sswthf3=gAptmLi6xmQqMvUigUYDFsQg@mail.gmail.com>
On Mon, Sep 04, 2017 at 10:11:37AM -0700, Kees Cook wrote:
> On Mon, Sep 4, 2017 at 5:37 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> > On Wed, Jun 28, 2017 at 09:58:15AM -0700, tip-bot for Kees Cook wrote:
> >> locking/refcount: Create unchecked atomic_t implementation
> >
> > This seems to do only half the job. Here's the rest.
> >
> > ---
> > Subject: locking/refcount: Finish unchecked atomic_t implementation
> >
> > For some reason the unchecked atomic_t implementation stopped half-way
> > through, complete it it.
>
> Hmm? The reason is that the implementation of the remaining functions
> is unchanged between full, unchecked, and x86.
But they're wasted code if !arch because the existing atomic functions
are adequate (and I would argue better in case of atomic_add_unless).
And arch implementations would certainly want to reimplement dec_not_one.
Plus, you completely failed mention any of this.
next prev parent reply other threads:[~2017-09-04 19:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 20:00 [PATCH v3] refcount: Create unchecked atomic_t implementation Kees Cook
2017-06-21 20:00 ` Kees Cook
2017-06-22 11:07 ` [tip:locking/core] locking/refcount: " tip-bot for Kees Cook
2017-06-28 16:58 ` tip-bot for Kees Cook
2017-09-04 12:37 ` Peter Zijlstra
2017-09-04 12:37 ` Peter Zijlstra
2017-09-04 17:11 ` Kees Cook
2017-09-04 17:11 ` Kees Cook
2017-09-04 19:35 ` Peter Zijlstra [this message]
2017-09-04 19:35 ` Peter Zijlstra
2017-09-04 17:34 ` Alexey Dobriyan
2017-09-04 17:34 ` Alexey Dobriyan
2017-09-04 19:36 ` Peter Zijlstra
2017-09-05 18:15 ` Alexey Dobriyan
2017-09-06 8:17 ` Peter Zijlstra
2017-09-06 8:17 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170904193527.GB17526@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dave@stgolabs.net \
--cc=davem@davemloft.net \
--cc=dwindsor@gmail.com \
--cc=ebiederm@xmission.com \
--cc=ebiggers3@gmail.com \
--cc=elena.reshetova@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=ishkamiel@gmail.com \
--cc=jannh@google.com \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=mingo@kernel.org \
--cc=riel@redhat.com \
--cc=serge@hallyn.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).