linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guo Ren <ren_guo@c-sky.com>
To: Rob Herring <robh@kernel.org>
Cc: akpm@linux-foundation.org, arnd@arndb.de,
	daniel.lezcano@linaro.org, davem@davemloft.net,
	gregkh@linuxfoundation.org, hch@infradead.org,
	marc.zyngier@arm.com, mark.rutland@arm.com, peterz@infradead.org,
	tglx@linutronix.de, linux-kernel@vger.kernel.org,
	linux-arch@vger.kernel.org, devicetree@vger.kernel.org,
	c-sky_gcc_upstream@c-sky.com
Subject: Re: [PATCH V8 18/21] dt-bindings: csky CPU Bindings
Date: Fri, 12 Oct 2018 20:18:21 +0800	[thread overview]
Message-ID: <20181012121821.GA12182@guoren-Inspiron-7460> (raw)
Message-ID: <20181012121821.6RqJGRuJQBO1uKgZ81GODXi5pxw0AuxnKx8IB5lHCus@z> (raw)
In-Reply-To: <20181012113551.GA17917@bogus>

On Fri, Oct 12, 2018 at 06:35:51AM -0500, Rob Herring wrote:
> On Fri, Oct 12, 2018 at 12:42:53PM +0800, Guo Ren wrote:
> > This patch adds the documentation to describe that how to add cpu nodes in
> > dts for SMP.
> > 
> > Signed-off-by: Guo Ren <ren_guo@c-sky.com>
> > Cc: Rob Herring <robh@kernel.org>
> > ---
> >  Documentation/devicetree/bindings/csky/cpus.txt | 70 +++++++++++++++++++++++++
> >  1 file changed, 70 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/csky/cpus.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/csky/cpus.txt b/Documentation/devicetree/bindings/csky/cpus.txt
> > new file mode 100644
> > index 0000000..ee3901d
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/csky/cpus.txt
> > @@ -0,0 +1,70 @@
> > +==================
> > +C-SKY CPU Bindings
> > +==================
> > +
> > +The device tree allows to describe the layout of CPUs in a system through
> > +the "cpus" node, which in turn contains a number of subnodes (ie "cpu")
> > +defining properties for every cpu.
> > +
> > +Only SMP system need to care about the cpus node and single processor
> > +needn't define cpus node at all.
> > +
> > +=====================================
> > +cpus and cpu node bindings definition
> > +=====================================
> > +
> > +- cpus node
> > +
> > +        Description: Container of cpu nodes
> > +
> > +        The node name must be "cpus".
> > +
> > +        A cpus node must define the following properties:
> > +
> > +        - #address-cells
> > +                Usage: required
> > +                Value type: <u32>
> > +                Definition: must be set to 1
> > +        - #size-cells
> > +                Usage: required
> > +                Value type: <u32>
> > +                Definition: must be set to 0
> > +
> > +- cpu node
> > +
> > +        Description: Describes one of SMP cores
> > +
> > +        PROPERTIES
> > +
> 
> What happened to compatible?
Opps ... I forgot it.

	- compatible:
		Usage: required
		Value type: <string>
		Definition: must contain "csky", eg:
			    "csky,610"
			    "csky,807"
			    "csky,810"
			    "csky,860"

> 
> > +        - device_type
> > +                Usage: required
> > +                Value type: <string>
> > +                Definition: must be "cpu"
> > +        - reg
> > +                Usage: required
> > +                Value type: <u32>
> > +                Definition: CPU index
> > +        - status:
> 
> Drop this. It is implied.
Ok, remove status.

Best Regards
 Guo Ren

  parent reply	other threads:[~2018-10-12 19:50 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-12  4:42 [PATCH V8 00/21] C-SKY(csky) Linux Kernel Port Guo Ren
2018-10-12  4:42 ` Guo Ren
2018-10-12  4:42 ` [PATCH V8 01/21] csky: Build infrastructure Guo Ren
2018-10-12  4:42   ` Guo Ren
2018-10-12  4:42 ` [PATCH V8 02/21] csky: defconfig Guo Ren
2018-10-12  4:42   ` Guo Ren
2018-10-12  4:42 ` [PATCH V8 03/21] csky: Kernel booting Guo Ren
2018-10-12  4:42   ` Guo Ren
2018-10-12  4:42 ` [PATCH V8 04/21] csky: Exception handling and mm-fault Guo Ren
2018-10-12  4:42   ` Guo Ren
2018-10-12  4:42 ` [PATCH V8 05/21] csky: System Call Guo Ren
2018-10-12  4:42   ` Guo Ren
2018-10-12  4:42 ` [PATCH V8 06/21] csky: Cache and TLB routines Guo Ren
2018-10-12  4:42   ` Guo Ren
2018-10-12  4:42 ` [PATCH V8 07/21] csky: MMU and page table management Guo Ren
2018-10-12  4:42   ` Guo Ren
2018-10-12  4:42 ` [PATCH V8 08/21] csky: Process management and Signal Guo Ren
2018-10-12  4:42   ` Guo Ren
2018-10-12  4:42 ` [PATCH V8 09/21] csky: VDSO and rt_sigreturn Guo Ren
2018-10-12  4:42   ` Guo Ren
2018-10-12  4:42 ` [PATCH V8 10/21] csky: IRQ handling Guo Ren
2018-10-12  4:42   ` Guo Ren
2018-10-12  4:42 ` [PATCH V8 11/21] csky: Atomic operations Guo Ren
2018-10-12  4:42   ` Guo Ren
2018-10-12  4:42 ` [PATCH V8 12/21] csky: ELF and module probe Guo Ren
2018-10-12  4:42   ` Guo Ren
2018-10-12  4:42 ` [PATCH V8 13/21] csky: Library functions Guo Ren
2018-10-12  4:42   ` Guo Ren
2018-10-12  4:42 ` [PATCH V8 14/21] csky: User access Guo Ren
2018-10-12  4:42   ` Guo Ren
2018-10-12  4:42 ` [PATCH V8 15/21] csky: Debug and Ptrace GDB Guo Ren
2018-10-12  4:42   ` Guo Ren
2018-10-12  4:42 ` [PATCH V8 16/21] csky: SMP support Guo Ren
2018-10-12  4:42   ` Guo Ren
2018-10-12 11:09   ` Marc Zyngier
2018-10-12 11:09     ` Marc Zyngier
2018-10-13  6:10     ` Guo Ren
2018-10-13  6:10       ` Guo Ren
2018-10-12  4:42 ` [PATCH V8 17/21] csky: Misc headers Guo Ren
2018-10-12  4:42   ` Guo Ren
2018-10-12  4:42 ` [PATCH V8 18/21] dt-bindings: csky CPU Bindings Guo Ren
2018-10-12  4:42   ` Guo Ren
2018-10-12 11:35   ` Rob Herring
2018-10-12 11:35     ` Rob Herring
2018-10-12 12:18     ` Guo Ren [this message]
2018-10-12 12:18       ` Guo Ren
2018-10-12  4:42 ` [PATCH V8 19/21] dt-bindings: Add vendor prefix for csky Guo Ren
2018-10-12  4:42   ` Guo Ren
2018-10-12  4:42 ` [PATCH V8 20/21] MAINTAINERS: Add csky Guo Ren
2018-10-12  4:42   ` Guo Ren
2018-10-12  4:42 ` [PATCH V8 21/21] csky: add support get_user_size access dword Guo Ren
2018-10-12  4:42   ` Guo Ren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181012121821.GA12182@guoren-Inspiron-7460 \
    --to=ren_guo@c-sky.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=c-sky_gcc_upstream@c-sky.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@infradead.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=peterz@infradead.org \
    --cc=robh@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).