From: Christoph Hellwig <hch@lst.de> To: Robin Murphy <robin.murphy@arm.com> Cc: Christoph Hellwig <hch@lst.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Maxime Chevallier <maxime.chevallier@bootlin.com>, linux-arch@vger.kernel.org, Olav Kongas <ok@artecdesign.ee>, Gavin Li <git@thegavinli.com>, linuxppc-dev@lists.ozlabs.org, Mathias Nyman <mathias.nyman@intel.com>, Geoff Levand <geoff@infradead.org>, Fabio Estevam <festevam@gmail.com>, Sascha Hauer <s.hauer@pengutronix.de>, linux-usb@vger.kernel.org, Michal Simek <michal.simek@xilinx.com>, linux-kernel@vger.kernel.org, Tony Prisk <linux@prisktech.co.nz>, iommu@lists.linux-foundation.org, Alan Stern <stern@rowland.harvard.edu>, NXP Linux Team <linux-imx@nxp.com>, Pengutronix Kernel Team <kernel@pengutronix.de>, Minas Harutyunyan <hminas@synopsys.com>, Shawn Guo <shawnguo@kernel.o> Subject: Re: [PATCH 6/6] driver core: initialize a default DMA mask for platform device Date: Thu, 15 Aug 2019 15:32:04 +0200 [thread overview] Message-ID: <20190815133204.GD12036@lst.de> (raw) In-Reply-To: <fbea6e6d-7721-b51d-0501-582e8446e9c9@arm.com> On Wed, Aug 14, 2019 at 04:49:13PM +0100, Robin Murphy wrote: >> because we have to support platform_device structures that are >> statically allocated. > > This would be a good point to also get rid of the long-standing bodge in > platform_device_register_full(). platform_device_register_full looks odd to start with, especially as the coumentation is rather lacking.. >> +static void setup_pdev_archdata(struct platform_device *pdev) > > Bikeshed: painting the generic DMA API properties as "archdata" feels a bit > off-target :/ > >> +{ >> + if (!pdev->dev.coherent_dma_mask) >> + pdev->dev.coherent_dma_mask = DMA_BIT_MASK(32); >> + if (!pdev->dma_mask) >> + pdev->dma_mask = DMA_BIT_MASK(32); >> + if (!pdev->dev.dma_mask) >> + pdev->dev.dma_mask = &pdev->dma_mask; >> + arch_setup_pdev_archdata(pdev); > > AFAICS m68k's implementation of that arch hook becomes entirely redundant > after this change, so may as well go. That would just leave powerpc's > actual archdata, which at a glance looks like it could probably be cleaned > up with not *too* much trouble. Actually I think we can just kill both off. At the point archdata is indeed entirely misnamed.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de> To: Robin Murphy <robin.murphy@arm.com> Cc: Christoph Hellwig <hch@lst.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Maxime Chevallier <maxime.chevallier@bootlin.com>, linux-arch@vger.kernel.org, Olav Kongas <ok@artecdesign.ee>, Gavin Li <git@thegavinli.com>, linuxppc-dev@lists.ozlabs.org, Mathias Nyman <mathias.nyman@intel.com>, Geoff Levand <geoff@infradead.org>, Fabio Estevam <festevam@gmail.com>, Sascha Hauer <s.hauer@pengutronix.de>, linux-usb@vger.kernel.org, Michal Simek <michal.simek@xilinx.com>, linux-kernel@vger.kernel.org, Tony Prisk <linux@prisktech.co.nz>, iommu@lists.linux-foundation.org, Alan Stern <stern@rowland.harvard.edu>, NXP Linux Team <linux-imx@nxp.com>, Pengutronix Kernel Team <kernel@pengutronix.de>, Minas Harutyunyan <hminas@synopsys.com>, Shawn Guo <shawnguo@kernel.org>, Bin Liu <b-liu@ti.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 6/6] driver core: initialize a default DMA mask for platform device Date: Thu, 15 Aug 2019 15:32:04 +0200 [thread overview] Message-ID: <20190815133204.GD12036@lst.de> (raw) Message-ID: <20190815133204.adzxp-eWiZFz3Xv4F88JHlw4xAc2hNQWU_Qmg7t9tyg@z> (raw) In-Reply-To: <fbea6e6d-7721-b51d-0501-582e8446e9c9@arm.com> On Wed, Aug 14, 2019 at 04:49:13PM +0100, Robin Murphy wrote: >> because we have to support platform_device structures that are >> statically allocated. > > This would be a good point to also get rid of the long-standing bodge in > platform_device_register_full(). platform_device_register_full looks odd to start with, especially as the coumentation is rather lacking.. >> +static void setup_pdev_archdata(struct platform_device *pdev) > > Bikeshed: painting the generic DMA API properties as "archdata" feels a bit > off-target :/ > >> +{ >> + if (!pdev->dev.coherent_dma_mask) >> + pdev->dev.coherent_dma_mask = DMA_BIT_MASK(32); >> + if (!pdev->dma_mask) >> + pdev->dma_mask = DMA_BIT_MASK(32); >> + if (!pdev->dev.dma_mask) >> + pdev->dev.dma_mask = &pdev->dma_mask; >> + arch_setup_pdev_archdata(pdev); > > AFAICS m68k's implementation of that arch hook becomes entirely redundant > after this change, so may as well go. That would just leave powerpc's > actual archdata, which at a glance looks like it could probably be cleaned > up with not *too* much trouble. Actually I think we can just kill both off. At the point archdata is indeed entirely misnamed.
next prev parent reply other threads:[~2019-08-15 13:32 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-11 8:05 next take at setting up a dma mask by default for platform devices Christoph Hellwig 2019-08-11 8:05 ` Christoph Hellwig 2019-08-11 8:05 ` [PATCH 1/6] usb: don't create dma pools for HCDs with a localmem_pool Christoph Hellwig 2019-08-11 8:05 ` Christoph Hellwig 2019-08-11 8:05 ` [PATCH 2/6] usb: add a hcd_uses_dma helper Christoph Hellwig 2019-08-11 8:05 ` Christoph Hellwig 2019-08-11 8:05 ` [PATCH 3/6] usb: add a HCD_DMA flag instead of guestimating DMA capabilities Christoph Hellwig 2019-08-11 8:05 ` Christoph Hellwig [not found] ` <20190811080520.21712-4-hch-jcswGhMUV9g@public.gmane.org> 2019-08-12 11:57 ` Christoph Hellwig 2019-08-12 11:57 ` Christoph Hellwig 2019-08-11 8:05 ` [PATCH 4/6] usb/max3421: remove the dummy {un,}map_urb_for_dma methods Christoph Hellwig 2019-08-11 8:05 ` Christoph Hellwig 2019-08-11 8:05 ` [PATCH 5/6] dma-mapping: remove is_device_dma_capable Christoph Hellwig 2019-08-11 8:05 ` Christoph Hellwig 2019-08-11 8:05 ` [PATCH 6/6] driver core: initialize a default DMA mask for platform device Christoph Hellwig 2019-08-11 8:05 ` Christoph Hellwig 2019-08-14 15:49 ` Robin Murphy 2019-08-14 15:49 ` Robin Murphy 2019-08-15 13:32 ` Christoph Hellwig [this message] 2019-08-15 13:32 ` Christoph Hellwig 2019-08-15 13:03 ` Greg Kroah-Hartman 2019-08-15 13:03 ` Greg Kroah-Hartman 2019-08-15 13:38 ` Christoph Hellwig 2019-08-15 13:38 ` Christoph Hellwig 2019-08-15 14:05 ` Greg Kroah-Hartman 2019-08-15 14:05 ` Greg Kroah-Hartman 2019-08-15 13:23 ` next take at setting up a dma mask by default for platform devices Greg Kroah-Hartman 2019-08-15 13:23 ` Greg Kroah-Hartman 2019-08-15 13:25 ` Christoph Hellwig 2019-08-15 13:25 ` Christoph Hellwig 2019-08-15 14:05 ` Greg Kroah-Hartman 2019-08-15 14:05 ` Greg Kroah-Hartman 2019-08-15 14:39 ` Alan Stern 2019-08-15 14:39 ` Alan Stern 2019-08-16 6:24 next take at setting up a dma mask by default for platform devices v2 Christoph Hellwig 2019-08-16 6:24 ` [PATCH 6/6] driver core: initialize a default DMA mask for platform device Christoph Hellwig 2019-08-16 6:24 ` Christoph Hellwig 2019-08-16 7:39 ` Geert Uytterhoeven 2019-08-16 7:39 ` Geert Uytterhoeven
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190815133204.GD12036@lst.de \ --to=hch@lst.de \ --cc=festevam@gmail.com \ --cc=geoff@infradead.org \ --cc=git@thegavinli.com \ --cc=gregkh@linuxfoundation.org \ --cc=hminas@synopsys.com \ --cc=iommu@lists.linux-foundation.org \ --cc=kernel@pengutronix.de \ --cc=linux-arch@vger.kernel.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=linux@prisktech.co.nz \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mathias.nyman@intel.com \ --cc=maxime.chevallier@bootlin.com \ --cc=michal.simek@xilinx.com \ --cc=ok@artecdesign.ee \ --cc=robin.murphy@arm.com \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.o \ --cc=stern@rowland.harvard.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).