* [PATCH] powerpc: ensure that swiotlb buffer is allocated from low memory
@ 2019-12-04 12:35 Mike Rapoport
2019-12-04 12:35 ` Mike Rapoport
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: Mike Rapoport @ 2019-12-04 12:35 UTC (permalink / raw)
To: linux-kernel
Cc: linuxppc-dev, linux-arch, linux-mm, iommu, Mike Rapoport,
Christian Zigotzky, Benjamin Herrenschmidt, Christoph Hellwig,
Darren Stevens, mad skateman, Michael Ellerman,
Nicolas Saenz Julienne, Paul Mackerras, Robin Murphy,
Rob Herring
From: Mike Rapoport <rppt@linux.ibm.com>
Some powerpc platforms (e.g. 85xx) limit DMA-able memory way below 4G. If a
system has more physical memory than this limit, the swiotlb buffer is not
addressable because it is allocated from memblock using top-down mode.
Force memblock to bottom-up mode before calling swiotlb_init() to ensure
that the swiotlb buffer is DMA-able.
Link: https://lkml.kernel.org/r/F1EBB706-73DF-430E-9020-C214EC8ED5DA@xenosoft.de
Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de>
Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Darren Stevens <darren@stevens-zone.net>
Cc: mad skateman <madskateman@gmail.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Robin Murphy <robin.murphy@arm.com>
Cc: Rob Herring <robh+dt@kernel.org>
---
arch/powerpc/mm/mem.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c
index be941d382c8d..14c2c53e3f9e 100644
--- a/arch/powerpc/mm/mem.c
+++ b/arch/powerpc/mm/mem.c
@@ -260,6 +260,14 @@ void __init mem_init(void)
BUILD_BUG_ON(MMU_PAGE_COUNT > 16);
#ifdef CONFIG_SWIOTLB
+ /*
+ * Some platforms (e.g. 85xx) limit DMA-able memory way below
+ * 4G. We force memblock to bottom-up mode to ensure that the
+ * memory allocated in swiotlb_init() is DMA-able.
+ * As it's the last memblock allocation, no need to reset it
+ * back to to-down.
+ */
+ memblock_set_bottom_up(true);
swiotlb_init(0);
#endif
--
2.24.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] powerpc: ensure that swiotlb buffer is allocated from low memory
2019-12-04 12:35 [PATCH] powerpc: ensure that swiotlb buffer is allocated from low memory Mike Rapoport
@ 2019-12-04 12:35 ` Mike Rapoport
[not found] ` <20191204123524.22919-1-rppt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
` (2 subsequent siblings)
3 siblings, 0 replies; 10+ messages in thread
From: Mike Rapoport @ 2019-12-04 12:35 UTC (permalink / raw)
To: linux-kernel
Cc: linuxppc-dev, linux-arch, linux-mm, iommu, Mike Rapoport,
Christian Zigotzky, Benjamin Herrenschmidt, Christoph Hellwig,
Darren Stevens, mad skateman, Michael Ellerman,
Nicolas Saenz Julienne, Paul Mackerras, Robin Murphy,
Rob Herring
From: Mike Rapoport <rppt@linux.ibm.com>
Some powerpc platforms (e.g. 85xx) limit DMA-able memory way below 4G. If a
system has more physical memory than this limit, the swiotlb buffer is not
addressable because it is allocated from memblock using top-down mode.
Force memblock to bottom-up mode before calling swiotlb_init() to ensure
that the swiotlb buffer is DMA-able.
Link: https://lkml.kernel.org/r/F1EBB706-73DF-430E-9020-C214EC8ED5DA@xenosoft.de
Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de>
Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Darren Stevens <darren@stevens-zone.net>
Cc: mad skateman <madskateman@gmail.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Robin Murphy <robin.murphy@arm.com>
Cc: Rob Herring <robh+dt@kernel.org>
---
arch/powerpc/mm/mem.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c
index be941d382c8d..14c2c53e3f9e 100644
--- a/arch/powerpc/mm/mem.c
+++ b/arch/powerpc/mm/mem.c
@@ -260,6 +260,14 @@ void __init mem_init(void)
BUILD_BUG_ON(MMU_PAGE_COUNT > 16);
#ifdef CONFIG_SWIOTLB
+ /*
+ * Some platforms (e.g. 85xx) limit DMA-able memory way below
+ * 4G. We force memblock to bottom-up mode to ensure that the
+ * memory allocated in swiotlb_init() is DMA-able.
+ * As it's the last memblock allocation, no need to reset it
+ * back to to-down.
+ */
+ memblock_set_bottom_up(true);
swiotlb_init(0);
#endif
--
2.24.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
[parent not found: <20191204123524.22919-1-rppt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]
* Re: [PATCH] powerpc: ensure that swiotlb buffer is allocated from low memory
[not found] ` <20191204123524.22919-1-rppt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
@ 2019-12-04 13:56 ` Christoph Hellwig
2019-12-04 13:56 ` Christoph Hellwig
0 siblings, 1 reply; 10+ messages in thread
From: Christoph Hellwig @ 2019-12-04 13:56 UTC (permalink / raw)
To: Mike Rapoport
Cc: linux-arch-u79uwXL29TY76Z2rM5mHXA, Darren Stevens,
Benjamin Herrenschmidt, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
Mike Rapoport, linux-mm-Bw31MaZKKs3YtjvyW6yDsg,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA, Rob Herring,
Paul Mackerras, Michael Ellerman, mad skateman,
Christian Zigotzky, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ,
Christoph Hellwig, Nicolas Saenz Julienne, Robin Murphy
On Wed, Dec 04, 2019 at 02:35:24PM +0200, Mike Rapoport wrote:
> From: Mike Rapoport <rppt-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org>
>
> Some powerpc platforms (e.g. 85xx) limit DMA-able memory way below 4G. If a
> system has more physical memory than this limit, the swiotlb buffer is not
> addressable because it is allocated from memblock using top-down mode.
>
> Force memblock to bottom-up mode before calling swiotlb_init() to ensure
> that the swiotlb buffer is DMA-able.
>
> Link: https://lkml.kernel.org/r/F1EBB706-73DF-430E-9020-C214EC8ED5DA-KCoaydhb8eAb1SvskN2V4Q@public.gmane.org
> Reported-by: Christian Zigotzky <chzigotzky-KCoaydhb8eAb1SvskN2V4Q@public.gmane.org>
> Signed-off-by: Mike Rapoport <rppt-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org>
Looks good:
Reviewed-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc: ensure that swiotlb buffer is allocated from low memory
2019-12-04 13:56 ` Christoph Hellwig
@ 2019-12-04 13:56 ` Christoph Hellwig
0 siblings, 0 replies; 10+ messages in thread
From: Christoph Hellwig @ 2019-12-04 13:56 UTC (permalink / raw)
To: Mike Rapoport
Cc: linux-kernel, linuxppc-dev, linux-arch, linux-mm, iommu,
Mike Rapoport, Christian Zigotzky, Benjamin Herrenschmidt,
Christoph Hellwig, Darren Stevens, mad skateman,
Michael Ellerman, Nicolas Saenz Julienne, Paul Mackerras,
Robin Murphy, Rob Herring
On Wed, Dec 04, 2019 at 02:35:24PM +0200, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@linux.ibm.com>
>
> Some powerpc platforms (e.g. 85xx) limit DMA-able memory way below 4G. If a
> system has more physical memory than this limit, the swiotlb buffer is not
> addressable because it is allocated from memblock using top-down mode.
>
> Force memblock to bottom-up mode before calling swiotlb_init() to ensure
> that the swiotlb buffer is DMA-able.
>
> Link: https://lkml.kernel.org/r/F1EBB706-73DF-430E-9020-C214EC8ED5DA@xenosoft.de
> Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de>
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc: ensure that swiotlb buffer is allocated from low memory
2019-12-04 12:35 [PATCH] powerpc: ensure that swiotlb buffer is allocated from low memory Mike Rapoport
2019-12-04 12:35 ` Mike Rapoport
[not found] ` <20191204123524.22919-1-rppt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
@ 2019-12-09 5:43 ` Michael Ellerman
2019-12-09 5:43 ` Michael Ellerman
2019-12-09 7:54 ` Mike Rapoport
2019-12-18 4:05 ` Michael Ellerman
3 siblings, 2 replies; 10+ messages in thread
From: Michael Ellerman @ 2019-12-09 5:43 UTC (permalink / raw)
To: Mike Rapoport, linux-kernel
Cc: linuxppc-dev, linux-arch, linux-mm, iommu, Mike Rapoport,
Christian Zigotzky, Benjamin Herrenschmidt, Christoph Hellwig,
Darren Stevens, mad skateman, Nicolas Saenz Julienne,
Paul Mackerras, Robin Murphy, Rob Herring
Mike Rapoport <rppt@kernel.org> writes:
> From: Mike Rapoport <rppt@linux.ibm.com>
>
> Some powerpc platforms (e.g. 85xx) limit DMA-able memory way below 4G. If a
> system has more physical memory than this limit, the swiotlb buffer is not
> addressable because it is allocated from memblock using top-down mode.
>
> Force memblock to bottom-up mode before calling swiotlb_init() to ensure
> that the swiotlb buffer is DMA-able.
>
> Link: https://lkml.kernel.org/r/F1EBB706-73DF-430E-9020-C214EC8ED5DA@xenosoft.de
This wasn't bisected, but I thought it was a regression. Do we know what
commit caused it?
Was it 25078dc1f74b ("powerpc: use mm zones more sensibly") ?
Or was that a red herring?
cheers
> Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de>
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Darren Stevens <darren@stevens-zone.net>
> Cc: mad skateman <madskateman@gmail.com>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Robin Murphy <robin.murphy@arm.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> ---
> arch/powerpc/mm/mem.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c
> index be941d382c8d..14c2c53e3f9e 100644
> --- a/arch/powerpc/mm/mem.c
> +++ b/arch/powerpc/mm/mem.c
> @@ -260,6 +260,14 @@ void __init mem_init(void)
> BUILD_BUG_ON(MMU_PAGE_COUNT > 16);
>
> #ifdef CONFIG_SWIOTLB
> + /*
> + * Some platforms (e.g. 85xx) limit DMA-able memory way below
> + * 4G. We force memblock to bottom-up mode to ensure that the
> + * memory allocated in swiotlb_init() is DMA-able.
> + * As it's the last memblock allocation, no need to reset it
> + * back to to-down.
> + */
> + memblock_set_bottom_up(true);
> swiotlb_init(0);
> #endif
>
> --
> 2.24.0
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc: ensure that swiotlb buffer is allocated from low memory
2019-12-09 5:43 ` Michael Ellerman
@ 2019-12-09 5:43 ` Michael Ellerman
2019-12-09 7:54 ` Mike Rapoport
1 sibling, 0 replies; 10+ messages in thread
From: Michael Ellerman @ 2019-12-09 5:43 UTC (permalink / raw)
To: Mike Rapoport, linux-kernel
Cc: linuxppc-dev, linux-arch, linux-mm, iommu, Mike Rapoport,
Christian Zigotzky, Benjamin Herrenschmidt, Christoph Hellwig,
Darren Stevens, mad skateman, Nicolas Saenz Julienne,
Paul Mackerras, Robin Murphy, Rob Herring
Mike Rapoport <rppt@kernel.org> writes:
> From: Mike Rapoport <rppt@linux.ibm.com>
>
> Some powerpc platforms (e.g. 85xx) limit DMA-able memory way below 4G. If a
> system has more physical memory than this limit, the swiotlb buffer is not
> addressable because it is allocated from memblock using top-down mode.
>
> Force memblock to bottom-up mode before calling swiotlb_init() to ensure
> that the swiotlb buffer is DMA-able.
>
> Link: https://lkml.kernel.org/r/F1EBB706-73DF-430E-9020-C214EC8ED5DA@xenosoft.de
This wasn't bisected, but I thought it was a regression. Do we know what
commit caused it?
Was it 25078dc1f74b ("powerpc: use mm zones more sensibly") ?
Or was that a red herring?
cheers
> Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de>
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Darren Stevens <darren@stevens-zone.net>
> Cc: mad skateman <madskateman@gmail.com>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Robin Murphy <robin.murphy@arm.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> ---
> arch/powerpc/mm/mem.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c
> index be941d382c8d..14c2c53e3f9e 100644
> --- a/arch/powerpc/mm/mem.c
> +++ b/arch/powerpc/mm/mem.c
> @@ -260,6 +260,14 @@ void __init mem_init(void)
> BUILD_BUG_ON(MMU_PAGE_COUNT > 16);
>
> #ifdef CONFIG_SWIOTLB
> + /*
> + * Some platforms (e.g. 85xx) limit DMA-able memory way below
> + * 4G. We force memblock to bottom-up mode to ensure that the
> + * memory allocated in swiotlb_init() is DMA-able.
> + * As it's the last memblock allocation, no need to reset it
> + * back to to-down.
> + */
> + memblock_set_bottom_up(true);
> swiotlb_init(0);
> #endif
>
> --
> 2.24.0
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc: ensure that swiotlb buffer is allocated from low memory
2019-12-09 5:43 ` Michael Ellerman
2019-12-09 5:43 ` Michael Ellerman
@ 2019-12-09 7:54 ` Mike Rapoport
2019-12-09 7:54 ` Mike Rapoport
1 sibling, 1 reply; 10+ messages in thread
From: Mike Rapoport @ 2019-12-09 7:54 UTC (permalink / raw)
To: Michael Ellerman
Cc: linux-kernel, linuxppc-dev, linux-arch, linux-mm, iommu,
Mike Rapoport, Christian Zigotzky, Benjamin Herrenschmidt,
Christoph Hellwig, Darren Stevens, mad skateman,
Nicolas Saenz Julienne, Paul Mackerras, Robin Murphy,
Rob Herring
On Mon, Dec 09, 2019 at 04:43:17PM +1100, Michael Ellerman wrote:
> Mike Rapoport <rppt@kernel.org> writes:
> > From: Mike Rapoport <rppt@linux.ibm.com>
> >
> > Some powerpc platforms (e.g. 85xx) limit DMA-able memory way below 4G. If a
> > system has more physical memory than this limit, the swiotlb buffer is not
> > addressable because it is allocated from memblock using top-down mode.
> >
> > Force memblock to bottom-up mode before calling swiotlb_init() to ensure
> > that the swiotlb buffer is DMA-able.
> >
> > Link: https://lkml.kernel.org/r/F1EBB706-73DF-430E-9020-C214EC8ED5DA@xenosoft.de
>
> This wasn't bisected, but I thought it was a regression. Do we know what
> commit caused it?
>
> Was it 25078dc1f74b ("powerpc: use mm zones more sensibly") ?
swiotlb buffer is initialized before zones are actually used, so probably
not :)
> Or was that a red herring?
>
> cheers
>
> > Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de>
> > Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > Cc: Christoph Hellwig <hch@lst.de>
> > Cc: Darren Stevens <darren@stevens-zone.net>
> > Cc: mad skateman <madskateman@gmail.com>
> > Cc: Michael Ellerman <mpe@ellerman.id.au>
> > Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> > Cc: Paul Mackerras <paulus@samba.org>
> > Cc: Robin Murphy <robin.murphy@arm.com>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > ---
> > arch/powerpc/mm/mem.c | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c
> > index be941d382c8d..14c2c53e3f9e 100644
> > --- a/arch/powerpc/mm/mem.c
> > +++ b/arch/powerpc/mm/mem.c
> > @@ -260,6 +260,14 @@ void __init mem_init(void)
> > BUILD_BUG_ON(MMU_PAGE_COUNT > 16);
> >
> > #ifdef CONFIG_SWIOTLB
> > + /*
> > + * Some platforms (e.g. 85xx) limit DMA-able memory way below
> > + * 4G. We force memblock to bottom-up mode to ensure that the
> > + * memory allocated in swiotlb_init() is DMA-able.
> > + * As it's the last memblock allocation, no need to reset it
> > + * back to to-down.
> > + */
> > + memblock_set_bottom_up(true);
> > swiotlb_init(0);
> > #endif
> >
> > --
> > 2.24.0
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc: ensure that swiotlb buffer is allocated from low memory
2019-12-09 7:54 ` Mike Rapoport
@ 2019-12-09 7:54 ` Mike Rapoport
0 siblings, 0 replies; 10+ messages in thread
From: Mike Rapoport @ 2019-12-09 7:54 UTC (permalink / raw)
To: Michael Ellerman
Cc: linux-kernel, linuxppc-dev, linux-arch, linux-mm, iommu,
Mike Rapoport, Christian Zigotzky, Benjamin Herrenschmidt,
Christoph Hellwig, Darren Stevens, mad skateman,
Nicolas Saenz Julienne, Paul Mackerras, Robin Murphy,
Rob Herring
On Mon, Dec 09, 2019 at 04:43:17PM +1100, Michael Ellerman wrote:
> Mike Rapoport <rppt@kernel.org> writes:
> > From: Mike Rapoport <rppt@linux.ibm.com>
> >
> > Some powerpc platforms (e.g. 85xx) limit DMA-able memory way below 4G. If a
> > system has more physical memory than this limit, the swiotlb buffer is not
> > addressable because it is allocated from memblock using top-down mode.
> >
> > Force memblock to bottom-up mode before calling swiotlb_init() to ensure
> > that the swiotlb buffer is DMA-able.
> >
> > Link: https://lkml.kernel.org/r/F1EBB706-73DF-430E-9020-C214EC8ED5DA@xenosoft.de
>
> This wasn't bisected, but I thought it was a regression. Do we know what
> commit caused it?
>
> Was it 25078dc1f74b ("powerpc: use mm zones more sensibly") ?
swiotlb buffer is initialized before zones are actually used, so probably
not :)
> Or was that a red herring?
>
> cheers
>
> > Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de>
> > Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > Cc: Christoph Hellwig <hch@lst.de>
> > Cc: Darren Stevens <darren@stevens-zone.net>
> > Cc: mad skateman <madskateman@gmail.com>
> > Cc: Michael Ellerman <mpe@ellerman.id.au>
> > Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> > Cc: Paul Mackerras <paulus@samba.org>
> > Cc: Robin Murphy <robin.murphy@arm.com>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > ---
> > arch/powerpc/mm/mem.c | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c
> > index be941d382c8d..14c2c53e3f9e 100644
> > --- a/arch/powerpc/mm/mem.c
> > +++ b/arch/powerpc/mm/mem.c
> > @@ -260,6 +260,14 @@ void __init mem_init(void)
> > BUILD_BUG_ON(MMU_PAGE_COUNT > 16);
> >
> > #ifdef CONFIG_SWIOTLB
> > + /*
> > + * Some platforms (e.g. 85xx) limit DMA-able memory way below
> > + * 4G. We force memblock to bottom-up mode to ensure that the
> > + * memory allocated in swiotlb_init() is DMA-able.
> > + * As it's the last memblock allocation, no need to reset it
> > + * back to to-down.
> > + */
> > + memblock_set_bottom_up(true);
> > swiotlb_init(0);
> > #endif
> >
> > --
> > 2.24.0
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc: ensure that swiotlb buffer is allocated from low memory
2019-12-04 12:35 [PATCH] powerpc: ensure that swiotlb buffer is allocated from low memory Mike Rapoport
` (2 preceding siblings ...)
2019-12-09 5:43 ` Michael Ellerman
@ 2019-12-18 4:05 ` Michael Ellerman
2019-12-18 4:05 ` Michael Ellerman
3 siblings, 1 reply; 10+ messages in thread
From: Michael Ellerman @ 2019-12-18 4:05 UTC (permalink / raw)
To: Mike Rapoport, linux-kernel
Cc: linux-arch, Darren Stevens, Robin Murphy, Mike Rapoport,
linux-mm, iommu, Rob Herring, Paul Mackerras, mad skateman,
Christian Zigotzky, linuxppc-dev, Christoph Hellwig,
Nicolas Saenz Julienne
On Wed, 2019-12-04 at 12:35:24 UTC, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@linux.ibm.com>
>
> Some powerpc platforms (e.g. 85xx) limit DMA-able memory way below 4G. If a
> system has more physical memory than this limit, the swiotlb buffer is not
> addressable because it is allocated from memblock using top-down mode.
>
> Force memblock to bottom-up mode before calling swiotlb_init() to ensure
> that the swiotlb buffer is DMA-able.
>
> Link: https://lkml.kernel.org/r/F1EBB706-73DF-430E-9020-C214EC8ED5DA@xenosoft.de
> Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de>
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/8fabc623238e68b3ac63c0dd1657bf86c1fa33af
cheers
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc: ensure that swiotlb buffer is allocated from low memory
2019-12-18 4:05 ` Michael Ellerman
@ 2019-12-18 4:05 ` Michael Ellerman
0 siblings, 0 replies; 10+ messages in thread
From: Michael Ellerman @ 2019-12-18 4:05 UTC (permalink / raw)
To: Mike Rapoport, linux-kernel
Cc: linux-arch, Darren Stevens, Robin Murphy, Mike Rapoport,
linux-mm, iommu, Rob Herring, Paul Mackerras, mad skateman,
Christian Zigotzky, linuxppc-dev, Christoph Hellwig,
Nicolas Saenz Julienne
On Wed, 2019-12-04 at 12:35:24 UTC, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@linux.ibm.com>
>
> Some powerpc platforms (e.g. 85xx) limit DMA-able memory way below 4G. If a
> system has more physical memory than this limit, the swiotlb buffer is not
> addressable because it is allocated from memblock using top-down mode.
>
> Force memblock to bottom-up mode before calling swiotlb_init() to ensure
> that the swiotlb buffer is DMA-able.
>
> Link: https://lkml.kernel.org/r/F1EBB706-73DF-430E-9020-C214EC8ED5DA@xenosoft.de
> Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de>
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/8fabc623238e68b3ac63c0dd1657bf86c1fa33af
cheers
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-12-18 4:05 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-04 12:35 [PATCH] powerpc: ensure that swiotlb buffer is allocated from low memory Mike Rapoport
2019-12-04 12:35 ` Mike Rapoport
[not found] ` <20191204123524.22919-1-rppt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2019-12-04 13:56 ` Christoph Hellwig
2019-12-04 13:56 ` Christoph Hellwig
2019-12-09 5:43 ` Michael Ellerman
2019-12-09 5:43 ` Michael Ellerman
2019-12-09 7:54 ` Mike Rapoport
2019-12-09 7:54 ` Mike Rapoport
2019-12-18 4:05 ` Michael Ellerman
2019-12-18 4:05 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).