linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH mips-fixes] vmlinux.lds.h: catch even more instrumentation symbols into .data
@ 2021-02-23 11:36 Alexander Lobakin
  2021-02-23 11:36 ` Alexander Lobakin
  2021-02-23 12:26 ` Thomas Bogendoerfer
  0 siblings, 2 replies; 5+ messages in thread
From: Alexander Lobakin @ 2021-02-23 11:36 UTC (permalink / raw)
  To: Thomas Bogendoerfer
  Cc: Arnd Bergmann, Nathan Chancellor, Nick Desaulniers,
	Sami Tolvanen, Huacai Chen, Pei Huang, Kees Cook,
	Alexander Lobakin, Fangrui Song, Jiaxun Yang, Corey Minyard,
	kernel test robot, linux-mips, linux-kernel, linux-arch

LKP caught another bunch of orphaned instrumentation symbols [0]:

mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
`init/main.o' being placed in section `.data.$LPBX1'
mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
`init/main.o' being placed in section `.data.$LPBX0'
mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
`init/do_mounts.o' being placed in section `.data.$LPBX1'
mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
`init/do_mounts.o' being placed in section `.data.$LPBX0'
mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
`init/do_mounts_initrd.o' being placed in section `.data.$LPBX1'
mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
`init/do_mounts_initrd.o' being placed in section `.data.$LPBX0'
mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
`init/initramfs.o' being placed in section `.data.$LPBX1'
mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
`init/initramfs.o' being placed in section `.data.$LPBX0'
mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
`init/calibrate.o' being placed in section `.data.$LPBX1'
mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
`init/calibrate.o' being placed in section `.data.$LPBX0'

[...]

Soften the wildcard to .data.$L* to grab these ones into .data too.

[0] https://lore.kernel.org/lkml/202102231519.lWPLPveV-lkp@intel.com

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Alexander Lobakin <alobakin@pm.me>
---
 include/asm-generic/vmlinux.lds.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
index 01a3fd6a64d2..c887ac36c1b4 100644
--- a/include/asm-generic/vmlinux.lds.h
+++ b/include/asm-generic/vmlinux.lds.h
@@ -95,7 +95,7 @@
  */
 #ifdef CONFIG_LD_DEAD_CODE_DATA_ELIMINATION
 #define TEXT_MAIN .text .text.[0-9a-zA-Z_]*
-#define DATA_MAIN .data .data.[0-9a-zA-Z_]* .data..L* .data..compoundliteral* .data.$__unnamed_* .data.$Lubsan_*
+#define DATA_MAIN .data .data.[0-9a-zA-Z_]* .data..L* .data..compoundliteral* .data.$__unnamed_* .data.$L*
 #define SDATA_MAIN .sdata .sdata.[0-9a-zA-Z_]*
 #define RODATA_MAIN .rodata .rodata.[0-9a-zA-Z_]* .rodata..L*
 #define BSS_MAIN .bss .bss.[0-9a-zA-Z_]* .bss..compoundliteral*
--
2.30.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH mips-fixes] vmlinux.lds.h: catch even more instrumentation symbols into .data
  2021-02-23 11:36 [PATCH mips-fixes] vmlinux.lds.h: catch even more instrumentation symbols into .data Alexander Lobakin
@ 2021-02-23 11:36 ` Alexander Lobakin
  2021-02-23 12:21   ` Thomas Bogendoerfer
  2021-02-23 12:26 ` Thomas Bogendoerfer
  1 sibling, 1 reply; 5+ messages in thread
From: Alexander Lobakin @ 2021-02-23 11:36 UTC (permalink / raw)
  To: Thomas Bogendoerfer
  Cc: Arnd Bergmann, Nathan Chancellor, Nick Desaulniers,
	Sami Tolvanen, Huacai Chen, Pei Huang, Kees Cook,
	Alexander Lobakin, Fangrui Song, Jiaxun Yang, Corey Minyard,
	kernel test robot, linux-mips, linux-kernel, linux-arch

> LKP caught another bunch of orphaned instrumentation symbols [0]:
>
> mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
> `init/main.o' being placed in section `.data.$LPBX1'
> mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
> `init/main.o' being placed in section `.data.$LPBX0'
> mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
> `init/do_mounts.o' being placed in section `.data.$LPBX1'
> mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
> `init/do_mounts.o' being placed in section `.data.$LPBX0'
> mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
> `init/do_mounts_initrd.o' being placed in section `.data.$LPBX1'
> mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
> `init/do_mounts_initrd.o' being placed in section `.data.$LPBX0'
> mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
> `init/initramfs.o' being placed in section `.data.$LPBX1'
> mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
> `init/initramfs.o' being placed in section `.data.$LPBX0'
> mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
> `init/calibrate.o' being placed in section `.data.$LPBX1'
> mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
> `init/calibrate.o' being placed in section `.data.$LPBX0'
>
> [...]
>
> Soften the wildcard to .data.$L* to grab these ones into .data too.
>
> [0] https://lore.kernel.org/lkml/202102231519.lWPLPveV-lkp@intel.com
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Alexander Lobakin <alobakin@pm.me>
> ---
>  include/asm-generic/vmlinux.lds.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Hi Thomas,

This applies on top of mips-next or Linus' tree, so you may need to
rebase mips-fixes before taking it.
It's not for mips-next as it should go into this cycle as a [hot]fix.
I haven't added any "Fixes:" tag since these warnings is a result
of merging several sets and of certain build configurations that
almost couldn't be tested separately.

> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
> index 01a3fd6a64d2..c887ac36c1b4 100644
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
> @@ -95,7 +95,7 @@
>   */
>  #ifdef CONFIG_LD_DEAD_CODE_DATA_ELIMINATION
>  #define TEXT_MAIN .text .text.[0-9a-zA-Z_]*
> -#define DATA_MAIN .data .data.[0-9a-zA-Z_]* .data..L* .data..compoundliteral* .data.$__unnamed_* .data.$Lubsan_*
> +#define DATA_MAIN .data .data.[0-9a-zA-Z_]* .data..L* .data..compoundliteral* .data.$__unnamed_* .data.$L*
>  #define SDATA_MAIN .sdata .sdata.[0-9a-zA-Z_]*
>  #define RODATA_MAIN .rodata .rodata.[0-9a-zA-Z_]* .rodata..L*
>  #define BSS_MAIN .bss .bss.[0-9a-zA-Z_]* .bss..compoundliteral*
> --
> 2.30.1

Thanks,
Al


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH mips-fixes] vmlinux.lds.h: catch even more instrumentation symbols into .data
  2021-02-23 11:36 ` Alexander Lobakin
@ 2021-02-23 12:21   ` Thomas Bogendoerfer
  2021-02-23 13:13     ` Alexander Lobakin
  0 siblings, 1 reply; 5+ messages in thread
From: Thomas Bogendoerfer @ 2021-02-23 12:21 UTC (permalink / raw)
  To: Alexander Lobakin
  Cc: Arnd Bergmann, Nathan Chancellor, Nick Desaulniers,
	Sami Tolvanen, Huacai Chen, Pei Huang, Kees Cook, Fangrui Song,
	Jiaxun Yang, Corey Minyard, kernel test robot, linux-mips,
	linux-kernel, linux-arch

On Tue, Feb 23, 2021 at 11:36:41AM +0000, Alexander Lobakin wrote:
> > LKP caught another bunch of orphaned instrumentation symbols [0]:
> >
> > mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
> > `init/main.o' being placed in section `.data.$LPBX1'
> > mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
> > `init/main.o' being placed in section `.data.$LPBX0'
> > mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
> > `init/do_mounts.o' being placed in section `.data.$LPBX1'
> > mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
> > `init/do_mounts.o' being placed in section `.data.$LPBX0'
> > mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
> > `init/do_mounts_initrd.o' being placed in section `.data.$LPBX1'
> > mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
> > `init/do_mounts_initrd.o' being placed in section `.data.$LPBX0'
> > mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
> > `init/initramfs.o' being placed in section `.data.$LPBX1'
> > mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
> > `init/initramfs.o' being placed in section `.data.$LPBX0'
> > mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
> > `init/calibrate.o' being placed in section `.data.$LPBX1'
> > mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
> > `init/calibrate.o' being placed in section `.data.$LPBX0'
> >
> > [...]
> >
> > Soften the wildcard to .data.$L* to grab these ones into .data too.
> >
> > [0] https://lore.kernel.org/lkml/202102231519.lWPLPveV-lkp@intel.com
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Alexander Lobakin <alobakin@pm.me>
> > ---
> >  include/asm-generic/vmlinux.lds.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Hi Thomas,
> 
> This applies on top of mips-next or Linus' tree, so you may need to
> rebase mips-fixes before taking it.
> It's not for mips-next as it should go into this cycle as a [hot]fix.
> I haven't added any "Fixes:" tag since these warnings is a result
> of merging several sets and of certain build configurations that
> almost couldn't be tested separately.

no worries, mips-fixes is defunct during merge windows. I'll send another
pull request to Linus and will add this patch to it.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH mips-fixes] vmlinux.lds.h: catch even more instrumentation symbols into .data
  2021-02-23 11:36 [PATCH mips-fixes] vmlinux.lds.h: catch even more instrumentation symbols into .data Alexander Lobakin
  2021-02-23 11:36 ` Alexander Lobakin
@ 2021-02-23 12:26 ` Thomas Bogendoerfer
  1 sibling, 0 replies; 5+ messages in thread
From: Thomas Bogendoerfer @ 2021-02-23 12:26 UTC (permalink / raw)
  To: Alexander Lobakin
  Cc: Arnd Bergmann, Nathan Chancellor, Nick Desaulniers,
	Sami Tolvanen, Huacai Chen, Pei Huang, Kees Cook, Fangrui Song,
	Jiaxun Yang, Corey Minyard, kernel test robot, linux-mips,
	linux-kernel, linux-arch

On Tue, Feb 23, 2021 at 11:36:21AM +0000, Alexander Lobakin wrote:
> LKP caught another bunch of orphaned instrumentation symbols [0]:
> 
> mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
> `init/main.o' being placed in section `.data.$LPBX1'
> mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
> `init/main.o' being placed in section `.data.$LPBX0'
> mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
> `init/do_mounts.o' being placed in section `.data.$LPBX1'
> mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
> `init/do_mounts.o' being placed in section `.data.$LPBX0'
> mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
> `init/do_mounts_initrd.o' being placed in section `.data.$LPBX1'
> mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
> `init/do_mounts_initrd.o' being placed in section `.data.$LPBX0'
> mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
> `init/initramfs.o' being placed in section `.data.$LPBX1'
> mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
> `init/initramfs.o' being placed in section `.data.$LPBX0'
> mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
> `init/calibrate.o' being placed in section `.data.$LPBX1'
> mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
> `init/calibrate.o' being placed in section `.data.$LPBX0'
> 
> [...]
> 
> Soften the wildcard to .data.$L* to grab these ones into .data too.
> 
> [0] https://lore.kernel.org/lkml/202102231519.lWPLPveV-lkp@intel.com
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Alexander Lobakin <alobakin@pm.me>
> ---
>  include/asm-generic/vmlinux.lds.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH mips-fixes] vmlinux.lds.h: catch even more instrumentation symbols into .data
  2021-02-23 12:21   ` Thomas Bogendoerfer
@ 2021-02-23 13:13     ` Alexander Lobakin
  0 siblings, 0 replies; 5+ messages in thread
From: Alexander Lobakin @ 2021-02-23 13:13 UTC (permalink / raw)
  To: Thomas Bogendoerfer
  Cc: Alexander Lobakin, Arnd Bergmann, Nathan Chancellor,
	Nick Desaulniers, Sami Tolvanen, Huacai Chen, Pei Huang,
	Kees Cook, Fangrui Song, Jiaxun Yang, Corey Minyard,
	kernel test robot, linux-mips, linux-kernel, linux-arch

From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Date: Tue, 23 Feb 2021 13:21:44 +0100

> On Tue, Feb 23, 2021 at 11:36:41AM +0000, Alexander Lobakin wrote:
> > > LKP caught another bunch of orphaned instrumentation symbols [0]:
> > >
> > > mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
> > > `init/main.o' being placed in section `.data.$LPBX1'
> > > mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
> > > `init/main.o' being placed in section `.data.$LPBX0'
> > > mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
> > > `init/do_mounts.o' being placed in section `.data.$LPBX1'
> > > mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
> > > `init/do_mounts.o' being placed in section `.data.$LPBX0'
> > > mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
> > > `init/do_mounts_initrd.o' being placed in section `.data.$LPBX1'
> > > mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
> > > `init/do_mounts_initrd.o' being placed in section `.data.$LPBX0'
> > > mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
> > > `init/initramfs.o' being placed in section `.data.$LPBX1'
> > > mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
> > > `init/initramfs.o' being placed in section `.data.$LPBX0'
> > > mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
> > > `init/calibrate.o' being placed in section `.data.$LPBX1'
> > > mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
> > > `init/calibrate.o' being placed in section `.data.$LPBX0'
> > >
> > > [...]
> > >
> > > Soften the wildcard to .data.$L* to grab these ones into .data too.
> > >
> > > [0] https://lore.kernel.org/lkml/202102231519.lWPLPveV-lkp@intel.com
> > >
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Signed-off-by: Alexander Lobakin <alobakin@pm.me>
> > > ---
> > >  include/asm-generic/vmlinux.lds.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Hi Thomas,
> >
> > This applies on top of mips-next or Linus' tree, so you may need to
> > rebase mips-fixes before taking it.
> > It's not for mips-next as it should go into this cycle as a [hot]fix.
> > I haven't added any "Fixes:" tag since these warnings is a result
> > of merging several sets and of certain build configurations that
> > almost couldn't be tested separately.
>
> no worries, mips-fixes is defunct during merge windows. I'll send another
> pull request to Linus and will add this patch to it.

Ah, thank you!

> Thomas.

Al

> --
> Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
> good idea.                                                [ RFC1925, 2.3 ]


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-02-23 13:14 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-23 11:36 [PATCH mips-fixes] vmlinux.lds.h: catch even more instrumentation symbols into .data Alexander Lobakin
2021-02-23 11:36 ` Alexander Lobakin
2021-02-23 12:21   ` Thomas Bogendoerfer
2021-02-23 13:13     ` Alexander Lobakin
2021-02-23 12:26 ` Thomas Bogendoerfer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).