* [PATCH] tools/memory-model: Fix smp_mb__after_spinlock() spelling
@ 2021-03-05 10:28 Björn Töpel
2021-03-05 14:50 ` Paul E. McKenney
2021-03-05 15:36 ` Alan Stern
0 siblings, 2 replies; 7+ messages in thread
From: Björn Töpel @ 2021-03-05 10:28 UTC (permalink / raw)
To: linux-kernel, linux-arch
Cc: Björn Töpel, Alan Stern, Andrea Parri, Will Deacon,
Peter Zijlstra, Boqun Feng, Nicholas Piggin, David Howells,
Jade Alglave, Luc Maranget, Paul E. McKenney, Akira Yokosawa,
Daniel Lustig, Joel Fernandes
From: Björn Töpel <bjorn.topel@intel.com>
A misspelled invokation of git-grep, revealed that
smp_mb__after_spinlock() was misspelled in explaination.txt.
Add missing "_" to smp_mb__after_spinlock().
Fixes: 1c27b644c0fd ("Automate memory-barriers.txt; provide Linux-kernel memory model")
Signed-off-by: Björn Töpel <bjorn.topel@intel.com>
---
tools/memory-model/Documentation/explanation.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/memory-model/Documentation/explanation.txt b/tools/memory-model/Documentation/explanation.txt
index f9d610d5a1a4..5d72f3112e56 100644
--- a/tools/memory-model/Documentation/explanation.txt
+++ b/tools/memory-model/Documentation/explanation.txt
@@ -2510,7 +2510,7 @@ they behave as follows:
smp_mb__after_atomic() orders po-earlier atomic updates and
the events preceding them against all po-later events;
- smp_mb_after_spinlock() orders po-earlier lock acquisition
+ smp_mb__after_spinlock() orders po-earlier lock acquisition
events and the events preceding them against all po-later
events.
base-commit: 7f58c0fb9238abaa3997185ceec319201b6f5a94
--
2.27.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] tools/memory-model: Fix smp_mb__after_spinlock() spelling
2021-03-05 10:28 [PATCH] tools/memory-model: Fix smp_mb__after_spinlock() spelling Björn Töpel
@ 2021-03-05 14:50 ` Paul E. McKenney
2021-03-05 15:36 ` Alan Stern
1 sibling, 0 replies; 7+ messages in thread
From: Paul E. McKenney @ 2021-03-05 14:50 UTC (permalink / raw)
To: Björn Töpel
Cc: linux-kernel, linux-arch, Björn Töpel, Alan Stern,
Andrea Parri, Will Deacon, Peter Zijlstra, Boqun Feng,
Nicholas Piggin, David Howells, Jade Alglave, Luc Maranget,
Akira Yokosawa, Daniel Lustig, Joel Fernandes
On Fri, Mar 05, 2021 at 11:28:23AM +0100, Björn Töpel wrote:
> From: Björn Töpel <bjorn.topel@intel.com>
>
> A misspelled invokation of git-grep, revealed that
> smp_mb__after_spinlock() was misspelled in explaination.txt.
>
> Add missing "_" to smp_mb__after_spinlock().
>
> Fixes: 1c27b644c0fd ("Automate memory-barriers.txt; provide Linux-kernel memory model")
> Signed-off-by: Björn Töpel <bjorn.topel@intel.com>
Good catch! Applied, thank you!
Thanx, Paul
> ---
> tools/memory-model/Documentation/explanation.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/memory-model/Documentation/explanation.txt b/tools/memory-model/Documentation/explanation.txt
> index f9d610d5a1a4..5d72f3112e56 100644
> --- a/tools/memory-model/Documentation/explanation.txt
> +++ b/tools/memory-model/Documentation/explanation.txt
> @@ -2510,7 +2510,7 @@ they behave as follows:
> smp_mb__after_atomic() orders po-earlier atomic updates and
> the events preceding them against all po-later events;
>
> - smp_mb_after_spinlock() orders po-earlier lock acquisition
> + smp_mb__after_spinlock() orders po-earlier lock acquisition
> events and the events preceding them against all po-later
> events.
>
>
> base-commit: 7f58c0fb9238abaa3997185ceec319201b6f5a94
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] tools/memory-model: Fix smp_mb__after_spinlock() spelling
2021-03-05 10:28 [PATCH] tools/memory-model: Fix smp_mb__after_spinlock() spelling Björn Töpel
2021-03-05 14:50 ` Paul E. McKenney
@ 2021-03-05 15:36 ` Alan Stern
2021-03-05 15:41 ` Björn Töpel
1 sibling, 1 reply; 7+ messages in thread
From: Alan Stern @ 2021-03-05 15:36 UTC (permalink / raw)
To: Björn Töpel
Cc: linux-kernel, linux-arch, Björn Töpel, Andrea Parri,
Will Deacon, Peter Zijlstra, Boqun Feng, Nicholas Piggin,
David Howells, Jade Alglave, Luc Maranget, Paul E. McKenney,
Akira Yokosawa, Daniel Lustig, Joel Fernandes
On Fri, Mar 05, 2021 at 11:28:23AM +0100, Björn Töpel wrote:
> From: Björn Töpel <bjorn.topel@intel.com>
>
> A misspelled invokation of git-grep, revealed that
-------------------^
Smetimes my brain is a little slow... Do you confirm that this is a
joke?
Alan
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] tools/memory-model: Fix smp_mb__after_spinlock() spelling
2021-03-05 15:36 ` Alan Stern
@ 2021-03-05 15:41 ` Björn Töpel
2021-03-05 18:26 ` Paul E. McKenney
0 siblings, 1 reply; 7+ messages in thread
From: Björn Töpel @ 2021-03-05 15:41 UTC (permalink / raw)
To: Alan Stern, Björn Töpel
Cc: linux-kernel, linux-arch, Andrea Parri, Will Deacon,
Peter Zijlstra, Boqun Feng, Nicholas Piggin, David Howells,
Jade Alglave, Luc Maranget, Paul E. McKenney, Akira Yokosawa,
Daniel Lustig, Joel Fernandes
On 2021-03-05 16:36, Alan Stern wrote:
> On Fri, Mar 05, 2021 at 11:28:23AM +0100, Björn Töpel wrote:
>> From: Björn Töpel <bjorn.topel@intel.com>
>>
>> A misspelled invokation of git-grep, revealed that
> -------------------^
>
> Smetimes my brain is a little slow... Do you confirm that this is a
> joke?
>
I wish, Alan. I wish.
Looks like I can only spel function names correctly.
Have a nice weekend!
Björn
> Alan
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] tools/memory-model: Fix smp_mb__after_spinlock() spelling
2021-03-05 15:41 ` Björn Töpel
@ 2021-03-05 18:26 ` Paul E. McKenney
2021-03-05 18:59 ` Alan Stern
0 siblings, 1 reply; 7+ messages in thread
From: Paul E. McKenney @ 2021-03-05 18:26 UTC (permalink / raw)
To: Björn Töpel
Cc: Alan Stern, Björn Töpel, linux-kernel, linux-arch,
Andrea Parri, Will Deacon, Peter Zijlstra, Boqun Feng,
Nicholas Piggin, David Howells, Jade Alglave, Luc Maranget,
Akira Yokosawa, Daniel Lustig, Joel Fernandes
On Fri, Mar 05, 2021 at 04:41:49PM +0100, Björn Töpel wrote:
> On 2021-03-05 16:36, Alan Stern wrote:
> > On Fri, Mar 05, 2021 at 11:28:23AM +0100, Björn Töpel wrote:
> > > From: Björn Töpel <bjorn.topel@intel.com>
> > >
> > > A misspelled invokation of git-grep, revealed that
> > -------------------^
> >
> > Smetimes my brain is a little slow... Do you confirm that this is a
> > joke?
> >
>
> I wish, Alan. I wish.
>
> Looks like I can only spel function names correctly.
Heh! I missed that one completely. Please see below for a wortschmied
commit.
Thanx, Paul
------------------------------------------------------------------------
commit 1c737ce34715db9431f6b034f92dbf09d954126d
Author: Björn Töpel <bjorn.topel@intel.com>
Date: Fri Mar 5 11:28:23 2021 +0100
tools/memory-model: Fix smp_mb__after_spinlock() spelling
A misspelled git-grep regex revealed that smp_mb__after_spinlock()
was misspelled in explanation.txt.
This commit adds the missing "_" to smp_mb__after_spinlock().
Fixes: 1c27b644c0fd ("Automate memory-barriers.txt; provide Linux-kernel memory model")
[ paulmck: Apply Alan Stern commit-log feedback. ]
Signed-off-by: Björn Töpel <bjorn.topel@intel.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
diff --git a/tools/memory-model/Documentation/explanation.txt b/tools/memory-model/Documentation/explanation.txt
index f9d610d..5d72f31 100644
--- a/tools/memory-model/Documentation/explanation.txt
+++ b/tools/memory-model/Documentation/explanation.txt
@@ -2510,7 +2510,7 @@ they behave as follows:
smp_mb__after_atomic() orders po-earlier atomic updates and
the events preceding them against all po-later events;
- smp_mb_after_spinlock() orders po-earlier lock acquisition
+ smp_mb__after_spinlock() orders po-earlier lock acquisition
events and the events preceding them against all po-later
events.
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] tools/memory-model: Fix smp_mb__after_spinlock() spelling
2021-03-05 18:26 ` Paul E. McKenney
@ 2021-03-05 18:59 ` Alan Stern
2021-03-05 19:09 ` Paul E. McKenney
0 siblings, 1 reply; 7+ messages in thread
From: Alan Stern @ 2021-03-05 18:59 UTC (permalink / raw)
To: Paul E. McKenney
Cc: Björn Töpel, Björn Töpel, linux-kernel,
linux-arch, Andrea Parri, Will Deacon, Peter Zijlstra,
Boqun Feng, Nicholas Piggin, David Howells, Jade Alglave,
Luc Maranget, Akira Yokosawa, Daniel Lustig, Joel Fernandes
On Fri, Mar 05, 2021 at 10:26:50AM -0800, Paul E. McKenney wrote:
> On Fri, Mar 05, 2021 at 04:41:49PM +0100, Björn Töpel wrote:
> > On 2021-03-05 16:36, Alan Stern wrote:
> > > On Fri, Mar 05, 2021 at 11:28:23AM +0100, Björn Töpel wrote:
> > > > From: Björn Töpel <bjorn.topel@intel.com>
> > > >
> > > > A misspelled invokation of git-grep, revealed that
> > > -------------------^
> > >
> > > Smetimes my brain is a little slow... Do you confirm that this is a
> > > joke?
> > >
> >
> > I wish, Alan. I wish.
> >
> > Looks like I can only spel function names correctly.
>
> Heh! I missed that one completely. Please see below for a wortschmied
> commit.
>
> Thanx, Paul
>
> ------------------------------------------------------------------------
>
> commit 1c737ce34715db9431f6b034f92dbf09d954126d
> Author: Björn Töpel <bjorn.topel@intel.com>
> Date: Fri Mar 5 11:28:23 2021 +0100
>
> tools/memory-model: Fix smp_mb__after_spinlock() spelling
>
> A misspelled git-grep regex revealed that smp_mb__after_spinlock()
> was misspelled in explanation.txt.
>
> This commit adds the missing "_" to smp_mb__after_spinlock().
Strictly speaking, the commit adds a missing "_" to
smp_mb_after_spinlock(). If it added anything to
smp_mb__after_spinlock(), the result would be incorrect.
How about just:
A misspelled git-grep regex revealed that smp_mb__after_spinlock()
was misspelled in explanation.txt. This commit adds the missing "_".
Alan
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] tools/memory-model: Fix smp_mb__after_spinlock() spelling
2021-03-05 18:59 ` Alan Stern
@ 2021-03-05 19:09 ` Paul E. McKenney
0 siblings, 0 replies; 7+ messages in thread
From: Paul E. McKenney @ 2021-03-05 19:09 UTC (permalink / raw)
To: Alan Stern
Cc: Björn Töpel, Björn Töpel, linux-kernel,
linux-arch, Andrea Parri, Will Deacon, Peter Zijlstra,
Boqun Feng, Nicholas Piggin, David Howells, Jade Alglave,
Luc Maranget, Akira Yokosawa, Daniel Lustig, Joel Fernandes
On Fri, Mar 05, 2021 at 01:59:24PM -0500, Alan Stern wrote:
> On Fri, Mar 05, 2021 at 10:26:50AM -0800, Paul E. McKenney wrote:
> > On Fri, Mar 05, 2021 at 04:41:49PM +0100, Björn Töpel wrote:
> > > On 2021-03-05 16:36, Alan Stern wrote:
> > > > On Fri, Mar 05, 2021 at 11:28:23AM +0100, Björn Töpel wrote:
> > > > > From: Björn Töpel <bjorn.topel@intel.com>
> > > > >
> > > > > A misspelled invokation of git-grep, revealed that
> > > > -------------------^
> > > >
> > > > Smetimes my brain is a little slow... Do you confirm that this is a
> > > > joke?
> > > >
> > >
> > > I wish, Alan. I wish.
> > >
> > > Looks like I can only spel function names correctly.
> >
> > Heh! I missed that one completely. Please see below for a wortschmied
> > commit.
> >
> > Thanx, Paul
> >
> > ------------------------------------------------------------------------
> >
> > commit 1c737ce34715db9431f6b034f92dbf09d954126d
> > Author: Björn Töpel <bjorn.topel@intel.com>
> > Date: Fri Mar 5 11:28:23 2021 +0100
> >
> > tools/memory-model: Fix smp_mb__after_spinlock() spelling
> >
> > A misspelled git-grep regex revealed that smp_mb__after_spinlock()
> > was misspelled in explanation.txt.
> >
> > This commit adds the missing "_" to smp_mb__after_spinlock().
>
> Strictly speaking, the commit adds a missing "_" to
> smp_mb_after_spinlock(). If it added anything to
> smp_mb__after_spinlock(), the result would be incorrect.
>
> How about just:
>
> A misspelled git-grep regex revealed that smp_mb__after_spinlock()
> was misspelled in explanation.txt. This commit adds the missing "_".
Very good, updated as you suggest, thank you!
Thanx, Paul
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-03-05 19:10 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-05 10:28 [PATCH] tools/memory-model: Fix smp_mb__after_spinlock() spelling Björn Töpel
2021-03-05 14:50 ` Paul E. McKenney
2021-03-05 15:36 ` Alan Stern
2021-03-05 15:41 ` Björn Töpel
2021-03-05 18:26 ` Paul E. McKenney
2021-03-05 18:59 ` Alan Stern
2021-03-05 19:09 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).