linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] MIPS: fix local_t operation on MIPS64
       [not found] <20210904151218.10167-1-huangpei@loongson.cn>
@ 2021-09-04 17:57 ` Maciej W. Rozycki
       [not found]   ` <20210905004810.5783639.10620.10055@loongson.cn>
  2021-09-04 18:50 ` kernel test robot
  1 sibling, 1 reply; 6+ messages in thread
From: Maciej W. Rozycki @ 2021-09-04 17:57 UTC (permalink / raw)
  To: Huang Pei
  Cc: Thomas Bogendoerfer, ambrosehua, Bibo Mao, linux-mips,
	linux-arch, linux-mm, Jiaxun Yang, Paul Burton, Li Xuefeng,
	Yang Tiezhu, Gao Juxin, Huacai Chen, Jinyang He, Steven Rostedt,
	Jisheng Zhang, Masami Hiramatsu

On Sat, 4 Sep 2021, Huang Pei wrote:

> diff --git a/arch/mips/include/asm/llsc.h b/arch/mips/include/asm/llsc.h
> index ec09fe5d6d6c..788e26ad7fca 100644
> --- a/arch/mips/include/asm/llsc.h
> +++ b/arch/mips/include/asm/llsc.h
> @@ -16,11 +16,15 @@
>  #define __SC		"sc	"
>  #define __INS		"ins	"
>  #define __EXT		"ext	"
> +#define __ADDU		"addu	"
> +#define __SUBU		"subu	"
>  #elif _MIPS_SZLONG == 64
>  #define __LL		"lld	"
>  #define __SC		"scd	"
>  #define __INS		"dins	"
>  #define __EXT		"dext	"
> +#define __ADDU		"daddu	"
> +#define __SUBU		"dsubu	"

 Why invent things instead of using standard macros (LONG_ADDU/LONG_SUBU)?

  Maciej

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] MIPS: fix local_t operation on MIPS64
       [not found] <20210904151218.10167-1-huangpei@loongson.cn>
  2021-09-04 17:57 ` [PATCH] MIPS: fix local_t operation on MIPS64 Maciej W. Rozycki
@ 2021-09-04 18:50 ` kernel test robot
  1 sibling, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-09-04 18:50 UTC (permalink / raw)
  To: Huang Pei, Thomas Bogendoerfer, ambrosehua
  Cc: llvm, kbuild-all, Bibo Mao, linux-mips, linux-arch, linux-mm,
	Jiaxun Yang, Paul Burton, Li Xuefeng, Yang Tiezhu

[-- Attachment #1: Type: text/plain, Size: 2744 bytes --]

Hi Huang,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.14 next-20210903]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Huang-Pei/MIPS-fix-local_t-operation-on-MIPS64/20210904-231410
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f1583cb1be35c23df60b1c39e3e7e6704d749d0b
config: mips-randconfig-r033-20210904 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 6fe2beba7d2a41964af658c8c59dd172683ef739)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install mips cross compiling tool for clang build
        # apt-get install binutils-mips-linux-gnu
        # https://github.com/0day-ci/linux/commit/4a1c6e12f6f078dfc5351925656b237f7e5fbb50
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Huang-Pei/MIPS-fix-local_t-operation-on-MIPS64/20210904-231410
        git checkout 4a1c6e12f6f078dfc5351925656b237f7e5fbb50
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/hamradio/mkiss.c:35:9: warning: 'END' macro redefined [-Wmacro-redefined]
   #define END             0300            /* indicates end of frame       */
           ^
   arch/mips/include/asm/asm.h:68:9: note: previous definition is here
   #define END(function)                                   \
           ^
   1 warning generated.


vim +/END +35 drivers/net/hamradio/mkiss.c

815f62bf742718 Ralf Baechle 2005-08-24  33  
815f62bf742718 Ralf Baechle 2005-08-24  34  /* SLIP/KISS protocol characters. */
815f62bf742718 Ralf Baechle 2005-08-24 @35  #define END             0300		/* indicates end of frame	*/
815f62bf742718 Ralf Baechle 2005-08-24  36  #define ESC             0333		/* indicates byte stuffing	*/
815f62bf742718 Ralf Baechle 2005-08-24  37  #define ESC_END         0334		/* ESC ESC_END means END 'data'	*/
815f62bf742718 Ralf Baechle 2005-08-24  38  #define ESC_ESC         0335		/* ESC ESC_ESC means ESC 'data'	*/
815f62bf742718 Ralf Baechle 2005-08-24  39  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34662 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] MIPS: fix local_t operation on MIPS64
       [not found]   ` <20210905004810.5783639.10620.10055@loongson.cn>
@ 2021-09-06 11:08     ` Maciej W. Rozycki
       [not found]       ` <20210906140307.cnj7iv567aibvhzr@ThinkPad-W520>
  0 siblings, 1 reply; 6+ messages in thread
From: Maciej W. Rozycki @ 2021-09-06 11:08 UTC (permalink / raw)
  To: 黄沛
  Cc: Thomas Bogendoerfer, ambrosehua, Bibo Mao, linux-mips,
	linux-arch, linux-mm, Jiaxun Yang, Paul Burton, Li Xuefeng,
	Yang Tiezhu, Gao Juxin, Huacai Chen, Jinyang He, Steven Rostedt,
	Jisheng Zhang, Masami Hiramatsu

On Sun, 5 Sep 2021, 黄沛 wrote:

> You mean including  asm/asm.h? 
> 
> or redefine LONG_ADDU as ** "addu " ** in asm/llsc.h?

 Use the existing macros, they're there for this purpose and widely used 
throughout the port already.

  Maciej

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] MIPS: fix local_t operation on MIPS64
       [not found]       ` <20210906140307.cnj7iv567aibvhzr@ThinkPad-W520>
@ 2021-09-06 16:29         ` Maciej W. Rozycki
       [not found]           ` <6113C299-3E26-4445-97FD-32690FD91C95@loongson.cn>
  0 siblings, 1 reply; 6+ messages in thread
From: Maciej W. Rozycki @ 2021-09-06 16:29 UTC (permalink / raw)
  To: Huang Pei
  Cc: Thomas Bogendoerfer, ambrosehua, Bibo Mao, linux-mips,
	linux-arch, linux-mm, Jiaxun Yang, Paul Burton, Li Xuefeng,
	Yang Tiezhu, Gao Juxin, Huacai Chen, Jinyang He, Steven Rostedt,
	Jisheng Zhang, Masami Hiramatsu

On Mon, 6 Sep 2021, Huang Pei wrote:

> || {standard input}: Assembler messages:
> {standard input}|11389| Error: unrecognized opcode `long_addu $6,$3,$2'
> {standard input}|11392| Error: unrecognized opcode `long_addu $6,$3,$2'
> {standard input}|11404| Error: unrecognized opcode `long_addu $5,$7,$2'
> {standard input}|11407| Error: unrecognized opcode `long_addu $5,$7,$2'
> {standard input}|12354| Error: unrecognized opcode `long_addu $20,$3,$2'
> {standard input}|12357| Error: unrecognized opcode `long_addu $20,$3,$2'

 Sheesh, you need to unquote the references to get them expanded.

  Maciej

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] MIPS: fix local_t operation on MIPS64
       [not found]           ` <6113C299-3E26-4445-97FD-32690FD91C95@loongson.cn>
@ 2021-09-07 10:00             ` Maciej W. Rozycki
  2021-09-08  8:15               ` 黄沛
  0 siblings, 1 reply; 6+ messages in thread
From: Maciej W. Rozycki @ 2021-09-07 10:00 UTC (permalink / raw)
  To: loongson
  Cc: Thomas Bogendoerfer, ambrosehua, Bibo Mao, linux-mips,
	linux-arch, linux-mm, Jiaxun Yang, Paul Burton, Li Xuefeng,
	Yang Tiezhu, Gao Juxin, Huacai Chen, Jinyang He, Steven Rostedt,
	Jisheng Zhang, Masami Hiramatsu

On Tue, 7 Sep 2021, loongson wrote:

> Please show me your code

 See commit e496453d3e15.  You may get inspiration from <asm/stacktrace.h> 
too.

> This email and its attachments contain confidential information from 
> Loongson Technology , which is intended only for the person or entity 
> whose address is listed above. Any use of the information contained 
> herein in any way (including, but not limited to, total or partial 
> disclosure, reproduction or dissemination) by persons other than the 
> intended recipient(s) is prohibited. If you receive this email in error, 
> please notify the sender by phone or email immediately and delete it.

 Your message has hit public mailing list archives already I'm afraid.

  Maciej

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] MIPS: fix local_t operation on MIPS64
  2021-09-07 10:00             ` Maciej W. Rozycki
@ 2021-09-08  8:15               ` 黄沛
  0 siblings, 0 replies; 6+ messages in thread
From: 黄沛 @ 2021-09-08  8:15 UTC (permalink / raw)
  To: Maciej W. Rozycki
  Cc: Thomas Bogendoerfer, ambrosehua, Bibo Mao, linux-mips,
	linux-arch, linux-mm, Jiaxun Yang, Paul Burton, Li Xuefeng,
	Yang Tiezhu, Gao Juxin, Huacai Chen, Jinyang He, Steven Rostedt,
	Jisheng Zhang, Masami Hiramatsu

Thank you, I got it.



本邮件及其附件含有龙芯中科的商业秘密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制或散发）本邮件及其附件中的信息。如果您错收本邮件，请您立即电话或邮件通知发件人并删除本邮件。 


This email and its attachments contain confidential information from Loongson Technology , which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this email in error, please notify the sender by phone or email immediately and delete it. 
  Original Message  
From: Maciej W. Rozycki
Sent: 2021年9月7日星期二 18:00
To: loongson
Cc: Thomas Bogendoerfer; ambrosehua@gmail.com; Bibo Mao; linux-mips@vger.kernel.org; linux-arch@vger.kernel.org; linux-mm@kvack.org; Jiaxun Yang; Paul Burton; Li Xuefeng; Yang Tiezhu; Gao Juxin; Huacai Chen; Jinyang He; Steven Rostedt; Jisheng Zhang; Masami Hiramatsu
Subject: Re: [PATCH] MIPS: fix local_t operation on MIPS64

On Tue, 7 Sep 2021, loongson wrote:

> Please show me your code

See commit e496453d3e15. You may get inspiration from <asm/stacktrace.h> 
too.

> This email and its attachments contain confidential information from 
> Loongson Technology , which is intended only for the person or entity 
> whose address is listed above. Any use of the information contained 
> herein in any way (including, but not limited to, total or partial 
> disclosure, reproduction or dissemination) by persons other than the 
> intended recipient(s) is prohibited. If you receive this email in error, 
> please notify the sender by phone or email immediately and delete it.

Your message has hit public mailing list archives already I'm afraid.

Maciej

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-09-08  8:15 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210904151218.10167-1-huangpei@loongson.cn>
2021-09-04 17:57 ` [PATCH] MIPS: fix local_t operation on MIPS64 Maciej W. Rozycki
     [not found]   ` <20210905004810.5783639.10620.10055@loongson.cn>
2021-09-06 11:08     ` Maciej W. Rozycki
     [not found]       ` <20210906140307.cnj7iv567aibvhzr@ThinkPad-W520>
2021-09-06 16:29         ` Maciej W. Rozycki
     [not found]           ` <6113C299-3E26-4445-97FD-32690FD91C95@loongson.cn>
2021-09-07 10:00             ` Maciej W. Rozycki
2021-09-08  8:15               ` 黄沛
2021-09-04 18:50 ` kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).