linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: libc-alpha@sourceware.org
Cc: Yury Norov <ynorov@caviumnetworks.com>,
	"Dr. Philipp Tomsich" <philipp.tomsich@theobroma-systems.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	linux-arch@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	szabolcs.nagy@arm.com, heiko.carstens@de.ibm.com,
	cmetcalf@ezchip.com, "Joseph S. Myers" <joseph@codesourcery.com>,
	zhouchengming1@huawei.com, "Kapoor,
	Prasun" <Prasun.Kapoor@caviumnetworks.com>,
	Alexander Graf <agraf@suse.de>,
	geert@linux-m68k.org, kilobyte@angband.pl,
	manuel.montezelo@gmail.com, Andrew Pinski <pinskia@gmail.com>,
	linyongting@huawei.com, Alexey Klimov <klimov.linux@gmail.com>,
	broonie@kernel.org,
	"Zhangjian (Bamvor)" <bamvor.zhangjian@huawei.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>
Subject: Re: [PATCH 3/3] mm: make pagoff_t type 64-bit
Date: Sun, 11 Dec 2016 15:59:01 +0100	[thread overview]
Message-ID: <2636242.RWRJivuddj@wuerfel> (raw)
In-Reply-To: <1481461003-14361-4-git-send-email-ynorov@caviumnetworks.com>

On Sunday, December 11, 2016 6:26:42 PM CET Yury Norov wrote:
> Also fix related interfaces
> 
> Signed-off-by: Yury Norov <ynorov@caviumnetworks.com>
> ---
>  fs/btrfs/extent_io.c       | 2 +-
>  fs/ext2/dir.c              | 4 ++--
>  include/linux/mm.h         | 9 +++++----
>  include/linux/radix-tree.h | 8 ++++----
>  include/linux/types.h      | 2 +-
>  lib/radix-tree.c           | 8 ++++----
>  mm/debug.c                 | 2 +-
>  mm/internal.h              | 2 +-
>  mm/memory.c                | 4 ++--
>  mm/mmap.c                  | 7 ++++---
>  mm/readahead.c             | 4 ++--
>  mm/util.c                  | 3 ++-
>  12 files changed, 29 insertions(+), 26 deletions(-)
> 

Thanks Yury for the demonstration. I think this would put the nail
in the coffin of the idea of mmap64 even for Pavel, who didn't
seem convinced already.

Changing all those interfaces and structure, struct page in particular,
is clearly too costly for any advantage we might have otherwise
gained.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: libc-alpha@sourceware.org
Cc: Yury Norov <ynorov@caviumnetworks.com>,
	"Dr. Philipp Tomsich" <philipp.tomsich@theobroma-systems.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	linux-arch@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	szabolcs.nagy@arm.com, heiko.carstens@de.ibm.com,
	cmetcalf@ezchip.com, "Joseph S. Myers" <joseph@codesourcery.com>,
	zhouchengming1@huawei.com, "Kapoor,
	Prasun" <Prasun.Kapoor@caviumnetworks.com>,
	Alexander Graf <agraf@suse.de>,
	geert@linux-m68k.org, kilobyte@angband.pl,
	manuel.montezelo@gmail.com, Andrew Pinski <pinskia@gmail.com>,
	linyongting@huawei.com, Alexey Klimov <klimov.linux@gmail.com>,
	broonie@kernel.org,
	"Zhangjian (Bamvor)" <bamvor.zhangjian@huawei.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>,
	Nathan Lynch <Nathan_Lynch@mentor.com>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	davem@davemloft.net, christoph.muellner@theobroma-systems.com
Subject: Re: [PATCH 3/3] mm: make pagoff_t type 64-bit
Date: Sun, 11 Dec 2016 15:59:01 +0100	[thread overview]
Message-ID: <2636242.RWRJivuddj@wuerfel> (raw)
Message-ID: <20161211145901.108-0bICxn_vopZVDNhXYZe_FOoe8JVqbUYx6r61-6Q@z> (raw)
In-Reply-To: <1481461003-14361-4-git-send-email-ynorov@caviumnetworks.com>

On Sunday, December 11, 2016 6:26:42 PM CET Yury Norov wrote:
> Also fix related interfaces
> 
> Signed-off-by: Yury Norov <ynorov@caviumnetworks.com>
> ---
>  fs/btrfs/extent_io.c       | 2 +-
>  fs/ext2/dir.c              | 4 ++--
>  include/linux/mm.h         | 9 +++++----
>  include/linux/radix-tree.h | 8 ++++----
>  include/linux/types.h      | 2 +-
>  lib/radix-tree.c           | 8 ++++----
>  mm/debug.c                 | 2 +-
>  mm/internal.h              | 2 +-
>  mm/memory.c                | 4 ++--
>  mm/mmap.c                  | 7 ++++---
>  mm/readahead.c             | 4 ++--
>  mm/util.c                  | 3 ++-
>  12 files changed, 29 insertions(+), 26 deletions(-)
> 

Thanks Yury for the demonstration. I think this would put the nail
in the coffin of the idea of mmap64 even for Pavel, who didn't
seem convinced already.

Changing all those interfaces and structure, struct page in particular,
is clearly too costly for any advantage we might have otherwise
gained.

	Arnd


  parent reply	other threads:[~2016-12-11 14:59 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-06 18:54 [Question] New mmap64 syscall? Yury Norov
2016-12-06 18:54 ` Yury Norov
2016-12-06 21:20 ` Arnd Bergmann
2016-12-07 10:34   ` Yury Norov
2016-12-07 10:34     ` Yury Norov
2016-12-07 11:07     ` Dr. Philipp Tomsich
2016-12-07 12:39       ` Yury Norov
2016-12-07 16:32         ` Catalin Marinas
2016-12-07 16:32           ` Catalin Marinas
2016-12-07 16:43           ` Dr. Philipp Tomsich
2016-12-07 16:43             ` Dr. Philipp Tomsich
2016-12-07 21:30             ` Arnd Bergmann
2016-12-07 21:30               ` Arnd Bergmann
2016-12-10  9:10               ` Pavel Machek
2016-12-10  9:10                 ` Pavel Machek
2016-12-10  9:21                 ` Pavel Machek
2016-12-10  9:21                   ` Pavel Machek
2016-12-11 12:56                   ` Yury Norov
2016-12-11 12:56                     ` Yury Norov
2016-12-11 12:56                     ` [PATCH 1/3] mm: move argument checkers of mmap_pgoff() to separated routine Yury Norov
2016-12-11 12:56                       ` Yury Norov
2016-12-11 12:56                     ` [PATCH 2/3] sys_mmap64() Yury Norov
2016-12-11 12:56                       ` Yury Norov
2016-12-11 14:48                       ` kbuild test robot
2016-12-11 14:48                         ` kbuild test robot
2016-12-11 14:56                       ` kbuild test robot
2016-12-11 14:56                         ` kbuild test robot
2016-12-11 12:56                     ` [PATCH 3/3] mm: make pagoff_t type 64-bit Yury Norov
2016-12-11 12:56                       ` Yury Norov
2016-12-11 13:31                       ` kbuild test robot
2016-12-11 13:31                         ` kbuild test robot
2016-12-11 13:41                       ` kbuild test robot
2016-12-11 13:41                         ` kbuild test robot
2016-12-11 14:59                       ` Arnd Bergmann [this message]
2016-12-11 14:59                         ` Arnd Bergmann
2016-12-16 10:55                         ` Yury Norov
2016-12-16 10:55                           ` Yury Norov
2016-12-16 11:02                           ` Arnd Bergmann
2016-12-16 11:02                             ` Arnd Bergmann
2016-12-18  9:23                           ` Christoph Hellwig
2016-12-18  9:23                             ` Christoph Hellwig
2016-12-07 13:23 ` [Question] New mmap64 syscall? Florian Weimer
2016-12-07 13:23   ` Florian Weimer
2016-12-07 15:48   ` Yury Norov
2016-12-07 15:48     ` Yury Norov
2016-12-08 15:47     ` Florian Weimer
2016-12-08 15:47       ` Florian Weimer
2017-01-03 20:54       ` Pavel Machek
2017-01-03 20:54         ` Pavel Machek
2017-01-12 16:13         ` Florian Weimer
2017-01-12 16:13           ` Florian Weimer
2017-01-12 21:51           ` Pavel Machek
2017-01-12 21:51             ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2636242.RWRJivuddj@wuerfel \
    --to=arnd@arndb.de \
    --cc=Prasun.Kapoor@caviumnetworks.com \
    --cc=agraf@suse.de \
    --cc=bamvor.zhangjian@huawei.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=cmetcalf@ezchip.com \
    --cc=geert@linux-m68k.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=joseph@codesourcery.com \
    --cc=kilobyte@angband.pl \
    --cc=klimov.linux@gmail.com \
    --cc=libc-alpha@sourceware.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linyongting@huawei.com \
    --cc=manuel.montezelo@gmail.com \
    --cc=maxim.kuvyrkov@linaro.org \
    --cc=philipp.tomsich@theobroma-systems.com \
    --cc=pinskia@gmail.com \
    --cc=szabolcs.nagy@arm.com \
    --cc=ynorov@caviumnetworks.com \
    --cc=zhouchengming1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).